Re: [PR] feat: Enable Multiple Input Ports on R UDF operators [texera]
Yicong-Huang merged PR #4174: URL: https://github.com/apache/texera/pull/4174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Enable Multiple Input Ports on R UDF operators [texera]
Ma77Ball commented on PR #4174: URL: https://github.com/apache/texera/pull/4174#issuecomment-3788116703 @kunwp1 I ran the code locally, and it worked as expected. I think we can add more human-readable error logs in a future PR. Overall, though the code, LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Enable Multiple Input Ports on R UDF operators [texera]
Yicong-Huang commented on PR #4174: URL: https://github.com/apache/texera/pull/4174#issuecomment-3787222684 > What should we change in the template? It already includes port as a parameter. Oh I didn't realize we already did that. Then I don't think we need other changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Enable Multiple Input Ports on R UDF operators [texera]
kunwp1 commented on PR #4174: URL: https://github.com/apache/texera/pull/4174#issuecomment-3787204749 > There must be some change on the Rudf template. Can we also add the changes in this PR? What should we change in the template? It already includes port as a parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Enable Multiple Input Ports on R UDF operators [texera]
Yicong-Huang commented on PR #4174: URL: https://github.com/apache/texera/pull/4174#issuecomment-3787168993 There must be some change on the Rudf template. Can we also add the changes in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Enable Multiple Input Ports on R UDF operators [texera]
Yicong-Huang commented on PR #4174: URL: https://github.com/apache/texera/pull/4174#issuecomment-3787164171 > I initially assigned this PR to @chenlica because @Ma77Ball isn’t a contributor and can’t be assigned as a reviewer. For those cases, just @ him in comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Enable Multiple Input Ports on R UDF operators [texera]
kunwp1 commented on PR #4174: URL: https://github.com/apache/texera/pull/4174#issuecomment-3786935412 I initially assigned this PR to @chenlica because @Ma77Ball isn’t a contributor and can’t be assigned as a reviewer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
