[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA
[ https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012473#comment-15012473 ] Sean Busbey commented on YETUS-171: --- Sounds good. Can we incorporate the ticket for pointing folks to naming guidelines in the same check? > patches that don't apply are not getting reported back to JIRA > -- > > Key: YETUS-171 > URL: https://issues.apache.org/jira/browse/YETUS-171 > Project: Yetus > Issue Type: Bug > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA
[ https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012625#comment-15012625 ] Allen Wittenauer commented on YETUS-171: Yeah. I was going to throw in rebasing too. But, some good news: the more I dig into this, it looks like a case of failing to catch an error thrown upstream in the JIRA code. So fixing this is easy. HOWEVER! I've discovered by accident that git 1.7.1 (at least that's what's on my centos 6 VM) always returns 0 during a git apply. Want to apply a PDF to your repo? git apply will happily report success. So... yeah. > patches that don't apply are not getting reported back to JIRA > -- > > Key: YETUS-171 > URL: https://issues.apache.org/jira/browse/YETUS-171 > Project: Yetus > Issue Type: Bug > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA
[ https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012434#comment-15012434 ] Allen Wittenauer commented on YETUS-171: I think what we can do is introduce the guess patch file thing back, but "reverse the polarity" a bit. If we are pretty sure it is a patch file and it doesn't apply, then fire off a message. That catches a *LOT* of patch files, so while it won't be 100%, something is better than nothing. > patches that don't apply are not getting reported back to JIRA > -- > > Key: YETUS-171 > URL: https://issues.apache.org/jira/browse/YETUS-171 > Project: Yetus > Issue Type: Bug > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA
[ https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012890#comment-15012890 ] Sean Busbey commented on YETUS-171: --- +1 fine to fix shellcheck false-positive with disable before commit. > patches that don't apply are not getting reported back to JIRA > -- > > Key: YETUS-171 > URL: https://issues.apache.org/jira/browse/YETUS-171 > Project: Yetus > Issue Type: Bug > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Attachments: YETUS-171.00.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA
[ https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012722#comment-15012722 ] Allen Wittenauer commented on YETUS-171: OK, [~sekikn] said we needed 1.7.3 as a minimum for something else (I forget what), and it appears that version properly gives a 1 exit code when trying to patch with a PDF file. So the docs already say 1.7.3 is the minimum, so we need to actually enforce that in code in order to prevent this weird edge case from happening and everyone (well, at least me) being confused. > patches that don't apply are not getting reported back to JIRA > -- > > Key: YETUS-171 > URL: https://issues.apache.org/jira/browse/YETUS-171 > Project: Yetus > Issue Type: Bug > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA
[ https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012748#comment-15012748 ] Kengo Seki commented on YETUS-171: -- bq. Kengo Seki said we needed 1.7.3 as a minimum for something else The reason is YETUS-16 ;) > patches that don't apply are not getting reported back to JIRA > -- > > Key: YETUS-171 > URL: https://issues.apache.org/jira/browse/YETUS-171 > Project: Yetus > Issue Type: Bug > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA
[
https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012812#comment-15012812
]
Yetus QA commented on YETUS-171:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 3s
{color} | {color:red} The applied patch generated 1 new shellcheck issues
(total was 4, now 5). {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
1s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 10s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12773170/YETUS-171.00.patch |
| JIRA Issue | YETUS-171 |
| Optional Tests | asflicense shellcheck |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 6326841 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider
upgrading.) |
| shellcheck |
https://builds.apache.org/job/PreCommit-YETUS-Build/112/artifact/patchprocess/diff-patch-shellcheck.txt
|
| modules | C: U: |
| Powered by | Apache Yetus http://yetus.apache.org |
| Console output |
https://builds.apache.org/job/PreCommit-YETUS-Build/112/console |
This message was automatically generated.
> patches that don't apply are not getting reported back to JIRA
> --
>
> Key: YETUS-171
> URL: https://issues.apache.org/jira/browse/YETUS-171
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: YETUS-171.00.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA
[ https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012811#comment-15012811 ] Yetus QA commented on YETUS-171: (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-YETUS-Build/112/console in case of problems. > patches that don't apply are not getting reported back to JIRA > -- > > Key: YETUS-171 > URL: https://issues.apache.org/jira/browse/YETUS-171 > Project: Yetus > Issue Type: Bug > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Attachments: YETUS-171.00.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA
[ https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010303#comment-15010303 ] Allen Wittenauer commented on YETUS-171: Yes, definitely. I just saw it today. > patches that don't apply are not getting reported back to JIRA > -- > > Key: YETUS-171 > URL: https://issues.apache.org/jira/browse/YETUS-171 > Project: Yetus > Issue Type: Bug > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
