[jira] [Updated] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-19 Thread Peter Vary (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Vary updated YETUS-471:
-
Attachment: YETUS-471.03.patch

Attaching the agreed upon solution:
- Add a flag to skip the source folder check

> Add possibility to configure Findbugs source folders
> 
>
> Key: YETUS-471
> URL: https://issues.apache.org/jira/browse/YETUS-471
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Affects Versions: 0.3.0
>Reporter: Peter Vary
>Assignee: Peter Vary
> Attachments: YETUS-471.00.patch, YETUS-471.01.patch, 
> YETUS-471.02.patch, YETUS-471.03.patch
>
>
> Trying to add yetus as a pre-commit test for Hive (see HIVE-15051)
> Findbugs plugin currently expects the project structure to be the standard 
> maven one (/src/main/java, /src/test/java). In Hive some of the modules have 
> a different file layout. It would be good to have a parameter introduced to 
> enable changes in checking directories.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Vary updated YETUS-471:
-
Attachment: YETUS-471.02.patch

Attached a patch addressing [~sekikn]'s points. All of which are valid.

Still, depending on the follow up conversation we might chose another way to 
address the problem which might align better with the Yetus goals.

> Add possibility to configure Findbugs source folders
> 
>
> Key: YETUS-471
> URL: https://issues.apache.org/jira/browse/YETUS-471
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Affects Versions: 0.3.0
>Reporter: Peter Vary
>Assignee: Peter Vary
> Attachments: YETUS-471.00.patch, YETUS-471.01.patch, 
> YETUS-471.02.patch
>
>
> Trying to add yetus as a pre-commit test for Hive (see HIVE-15051)
> Findbugs plugin currently expects the project structure to be the standard 
> maven one (/src/main/java, /src/test/java). In Hive some of the modules have 
> a different file layout. It would be good to have a parameter introduced to 
> enable changes in checking directories.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Kengo Seki (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kengo Seki updated YETUS-471:
-
Assignee: Peter Vary

> Add possibility to configure Findbugs source folders
> 
>
> Key: YETUS-471
> URL: https://issues.apache.org/jira/browse/YETUS-471
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Affects Versions: 0.3.0
>Reporter: Peter Vary
>Assignee: Peter Vary
> Attachments: YETUS-471.00.patch, YETUS-471.01.patch
>
>
> Trying to add yetus as a pre-commit test for Hive (see HIVE-15051)
> Findbugs plugin currently expects the project structure to be the standard 
> maven one (/src/main/java, /src/test/java). In Hive some of the modules have 
> a different file layout. It would be good to have a parameter introduced to 
> enable changes in checking directories.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Vary updated YETUS-471:
-
Attachment: YETUS-471.01.patch

Addressed issues found by precommit tests

> Add possibility to configure Findbugs source folders
> 
>
> Key: YETUS-471
> URL: https://issues.apache.org/jira/browse/YETUS-471
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Affects Versions: 0.3.0
>Reporter: Peter Vary
> Attachments: YETUS-471.00.patch, YETUS-471.01.patch
>
>
> Trying to add yetus as a pre-commit test for Hive (see HIVE-15051)
> Findbugs plugin currently expects the project structure to be the standard 
> maven one (/src/main/java, /src/test/java). In Hive some of the modules have 
> a different file layout. It would be good to have a parameter introduced to 
> enable changes in checking directories.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Vary updated YETUS-471:
-
Attachment: YETUS-471.00.patch

Proposed patch.

Please feel free to point out any minor mistakes as well, since this is my 
first attempt to contribute to this project.

Thanks,
Peter

> Add possibility to configure Findbugs source folders
> 
>
> Key: YETUS-471
> URL: https://issues.apache.org/jira/browse/YETUS-471
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Affects Versions: 0.3.0
>Reporter: Peter Vary
> Attachments: YETUS-471.00.patch
>
>
> Trying to add yetus as a pre-commit test for Hive (see HIVE-15051)
> Findbugs plugin currently expects the project structure to be the standard 
> maven one (/src/main/java, /src/test/java). In Hive some of the modules have 
> a different file layout. It would be good to have a parameter introduced to 
> enable changes in checking directories.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-471) Add possibility to configure Findbugs source folders

2016-12-01 Thread Peter Vary (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Vary updated YETUS-471:
-
Summary: Add possibility to configure Findbugs source folders  (was: Add 
possibility to configure Findbug source folders)

> Add possibility to configure Findbugs source folders
> 
>
> Key: YETUS-471
> URL: https://issues.apache.org/jira/browse/YETUS-471
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Affects Versions: 0.3.0
>Reporter: Peter Vary
>
> Trying to add yetus as a pre-commit test for Hive (see HIVE-15051)
> Findbugs plugin currently expects the project structure to be the standard 
> maven one (/src/main/java, /src/test/java). In Hive some of the modules have 
> a different file layout. It would be good to have a parameter introduced to 
> enable changes in checking directories.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)