[GitHub] [zookeeper] symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network

2019-08-14 Thread GitBox
symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/1048#discussion_r313739495 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java ## @@

[GitHub] [zookeeper] symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network

2019-08-14 Thread GitBox
symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/1048#discussion_r313738065 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java ## @@

[GitHub] [zookeeper] symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network

2019-08-14 Thread GitBox
symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/1048#discussion_r313774702 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java ## @@

[GitHub] [zookeeper] hanm commented on a change in pull request #1051: ZOOKEEPER-3503: Add server side large request throttling

2019-08-14 Thread GitBox
hanm commented on a change in pull request #1051: ZOOKEEPER-3503: Add server side large request throttling URL: https://github.com/apache/zookeeper/pull/1051#discussion_r314092183 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java

[GitHub] [zookeeper] hanm commented on a change in pull request #1051: ZOOKEEPER-3503: Add server side large request throttling

2019-08-14 Thread GitBox
hanm commented on a change in pull request #1051: ZOOKEEPER-3503: Add server side large request throttling URL: https://github.com/apache/zookeeper/pull/1051#discussion_r314089685 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java

[GitHub] [zookeeper] hanm commented on a change in pull request #1051: ZOOKEEPER-3503: Add server side large request throttling

2019-08-14 Thread GitBox
hanm commented on a change in pull request #1051: ZOOKEEPER-3503: Add server side large request throttling URL: https://github.com/apache/zookeeper/pull/1051#discussion_r314089330 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java

[GitHub] [zookeeper] symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network

2019-08-14 Thread GitBox
symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/1048#discussion_r313774702 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java ## @@

[GitHub] [zookeeper] symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network

2019-08-14 Thread GitBox
symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/1048#discussion_r313776919 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java ## @@

[GitHub] [zookeeper] symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network

2019-08-14 Thread GitBox
symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/1048#discussion_r313820217 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java

[GitHub] [zookeeper] symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network

2019-08-14 Thread GitBox
symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/1048#discussion_r313738065 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java ## @@

[GitHub] [zookeeper] symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network

2019-08-14 Thread GitBox
symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/1048#discussion_r313774702 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java ## @@

[GitHub] [zookeeper] eolivelli commented on issue #984: ZOOKEEPER-3427: Introduce SnapshotComparer that assists debugging with snapshots.

2019-08-14 Thread GitBox
eolivelli commented on issue #984: ZOOKEEPER-3427: Introduce SnapshotComparer that assists debugging with snapshots. URL: https://github.com/apache/zookeeper/pull/984#issuecomment-521236373 Just close this one and open a new one. As far as I know it is not possible to change ownership

[GitHub] [zookeeper] eolivelli commented on issue #1047: [ZOOKEEPER-3500] Improving the ZAB UPTODATE semantic to only issue it to learner when there is limited lagging

2019-08-14 Thread GitBox
eolivelli commented on issue #1047: [ZOOKEEPER-3500] Improving the ZAB UPTODATE semantic to only issue it to learner when there is limited lagging URL: https://github.com/apache/zookeeper/pull/1047#issuecomment-521234645 I am thinking about this idea. I don't have much time these days

[GitHub] [zookeeper] hanm commented on issue #984: ZOOKEEPER-3427: Introduce SnapshotComparer that assists debugging with snapshots.

2019-08-14 Thread GitBox
hanm commented on issue #984: ZOOKEEPER-3427: Introduce SnapshotComparer that assists debugging with snapshots. URL: https://github.com/apache/zookeeper/pull/984#issuecomment-521302446 >> Just close this one and open a new one. I wanted to preserve all comments in this PR. After

[GitHub] [zookeeper] TisonKun commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server

2019-08-14 Thread GitBox
TisonKun commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-521270729 retest this please This is an automated message

[GitHub] [zookeeper] TisonKun commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server

2019-08-14 Thread GitBox
TisonKun commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-521273094 I have redone the task enable checkstyle configuration and resolve conflict. Basically it focuses on whitespaces,

[GitHub] [zookeeper] symat commented on issue #1048: ZOOKEEPER-3188: Improve resilience to network

2019-08-14 Thread GitBox
symat commented on issue #1048: ZOOKEEPER-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/1048#issuecomment-521273603 retest maven build This is an automated message from the Apache Git

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1054: ZOOKEEPER-1112: Add support for C client for SASL authentication

2019-08-14 Thread GitBox
eolivelli commented on a change in pull request #1054: ZOOKEEPER-1112: Add support for C client for SASL authentication URL: https://github.com/apache/zookeeper/pull/1054#discussion_r314015476 ## File path: bin/zkServer.sh ## @@ -212,6 +212,7 @@ stop) else

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1054: ZOOKEEPER-1112: Add support for C client for SASL authentication

2019-08-14 Thread GitBox
eolivelli commented on a change in pull request #1054: ZOOKEEPER-1112: Add support for C client for SASL authentication URL: https://github.com/apache/zookeeper/pull/1054#discussion_r314026674 ## File path: