[GitHub] [zookeeper] eolivelli commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+

eolivelli commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+ URL: https://github.com/apache/zookeeper/pull/1056#discussion_r318972678 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+

eolivelli commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+ URL: https://github.com/apache/zookeeper/pull/1056#discussion_r318973475 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/DataTreeTest.java

[GitHub] [zookeeper] ztzg opened a new pull request #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions

ztzg opened a new pull request #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068 Some environments experience high DNS load because of the name resolutions introduced by

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton

eolivelli commented on a change in pull request #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#discussion_r319035410 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/Watcher.java ##

[GitHub] [zookeeper] TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton

TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#issuecomment-526169527 Thanks for your review @eolivelli. Address comments.

[GitHub] [zookeeper] TisonKun commented on a change in pull request #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton

TisonKun commented on a change in pull request #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#discussion_r319047261 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/Watcher.java ##

[GitHub] [zookeeper] TisonKun commented on a change in pull request #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton

TisonKun commented on a change in pull request #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#discussion_r319042725 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/Watcher.java ##

[GitHub] [zookeeper] hanm commented on a change in pull request #1047: [ZOOKEEPER-3500] Improving the ZAB UPTODATE semantic to only issue it to learner when there is limited lagging

hanm commented on a change in pull request #1047: [ZOOKEEPER-3500] Improving the ZAB UPTODATE semantic to only issue it to learner when there is limited lagging URL: https://github.com/apache/zookeeper/pull/1047#discussion_r319274979 ## File path:

[GitHub] [zookeeper] hanm commented on issue #1047: [ZOOKEEPER-3500] Improving the ZAB UPTODATE semantic to only issue it to learner when there is limited lagging

hanm commented on issue #1047: [ZOOKEEPER-3500] Improving the ZAB UPTODATE semantic to only issue it to learner when there is limited lagging URL: https://github.com/apache/zookeeper/pull/1047#issuecomment-526369321 +1 on the proposal.

[GitHub] [zookeeper] hanm commented on issue #1047: [ZOOKEEPER-3500] Improving the ZAB UPTODATE semantic to only issue it to learner when there is limited lagging

hanm commented on issue #1047: [ZOOKEEPER-3500] Improving the ZAB UPTODATE semantic to only issue it to learner when there is limited lagging URL: https://github.com/apache/zookeeper/pull/1047#issuecomment-526366986 >> Those are the txns queued on leader while learner took snapshot when

[GitHub] [zookeeper] symat commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+

symat commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+ URL: https://github.com/apache/zookeeper/pull/1056#discussion_r319197286 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/DataTreeTest.java

[GitHub] [zookeeper] lvfangmin commented on issue #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+

lvfangmin commented on issue #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+ URL: https://github.com/apache/zookeeper/pull/1056#issuecomment-526323567 This version with mockito.spy looks good to me, as long as we don't use things like setVersion. The only downside

[GitHub] [zookeeper] lvfangmin commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+

lvfangmin commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+ URL: https://github.com/apache/zookeeper/pull/1056#discussion_r319232082 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/DigestCalculator.java

[GitHub] [zookeeper] lvfangmin commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+

lvfangmin commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+ URL: https://github.com/apache/zookeeper/pull/1056#discussion_r319209584 ## File path: