[GitHub] [zookeeper] TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton

TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#issuecomment-529850468 Thanks for your review @eolivelli ! @lvfangmin @hanm could you please take a look at this pull request?

[GitHub] [zookeeper] lvfangmin opened a new pull request #1085: [ZOOKEEPER-3384] Add SO_LINGER socket option to avoid long quorum unavailable during close with full send buffer

lvfangmin opened a new pull request #1085: [ZOOKEEPER-3384] Add SO_LINGER socket option to avoid long quorum unavailable during close with full send buffer URL: https://github.com/apache/zookeeper/pull/1085 This is an

[GitHub] [zookeeper] mcfatealan commented on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe…

mcfatealan commented on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe… URL: https://github.com/apache/zookeeper/pull/1077#issuecomment-530112725 @lvfangmin @maoling deserialize is refactored following a similar approach (move I/O out of sync blocks),

[GitHub] [zookeeper] lvfangmin commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot

lvfangmin commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot URL: https://github.com/apache/zookeeper/pull/622#issuecomment-530077448 retest this please

[GitHub] [zookeeper] asfgit closed pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+

asfgit closed pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+ URL: https://github.com/apache/zookeeper/pull/1056 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] belugabehr commented on a change in pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs.

belugabehr commented on a change in pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs. URL: https://github.com/apache/zookeeper/pull/1084#discussion_r322761573 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/client/ZooKeeperSaslClient.java

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property

anmolnar commented on a change in pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property URL: https://github.com/apache/zookeeper/pull/1034#discussion_r322682677 ## File path:

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property

anmolnar commented on a change in pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property URL: https://github.com/apache/zookeeper/pull/1034#discussion_r322682677 ## File path:

[GitHub] [zookeeper] anmolnar commented on issue #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+

anmolnar commented on issue #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+ URL: https://github.com/apache/zookeeper/pull/1056#issuecomment-529932474 Merged to master. Thanks @symat ! This is an automated

[GitHub] [zookeeper] TisonKun commented on issue #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs.

TisonKun commented on issue #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs. URL: https://github.com/apache/zookeeper/pull/1084#issuecomment-530192952 Hi @ajingxian200! Thanks for your contribution! As @eolivelli said we can enrich this topic a bit to revisit the log format

[GitHub] [zookeeper] lvfangmin commented on issue #1047: [ZOOKEEPER-3500] Improving the ZAB UPTODATE semantic to only issue it to learner when there is limited lagging

lvfangmin commented on issue #1047: [ZOOKEEPER-3500] Improving the ZAB UPTODATE semantic to only issue it to learner when there is limited lagging URL: https://github.com/apache/zookeeper/pull/1047#issuecomment-530177202 @eolivelli it seems tricky to test 3.5 compatibility with 3.6.

[GitHub] [zookeeper] asfgit closed pull request #1083: [ZOOKEEPER-3540] Avoid client port unavailable by skip binding the same client port during reconfig

asfgit closed pull request #1083: [ZOOKEEPER-3540] Avoid client port unavailable by skip binding the same client port during reconfig URL: https://github.com/apache/zookeeper/pull/1083 This is an automated message from the

[GitHub] [zookeeper] vladimirivic commented on a change in pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property

vladimirivic commented on a change in pull request #1034: ZOOKEEPER-3491 Specify commitLogCount value using a system property URL: https://github.com/apache/zookeeper/pull/1034#discussion_r322836668 ## File path:

[GitHub] [zookeeper] TisonKun commented on a change in pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs.

TisonKun commented on a change in pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs. URL: https://github.com/apache/zookeeper/pull/1084#discussion_r322566400 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/client/ZooKeeperSaslClient.java

[GitHub] [zookeeper] TisonKun commented on a change in pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs.

TisonKun commented on a change in pull request #1084: ZOOKEEPER-3541: Wrong placeholder '{}' in logs. URL: https://github.com/apache/zookeeper/pull/1084#discussion_r322566400 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/client/ZooKeeperSaslClient.java

[GitHub] [zookeeper] nkalmar commented on issue #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid

nkalmar commented on issue #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid URL: https://github.com/apache/zookeeper/pull/610#issuecomment-529815520 Sure, I'll wait maven build, ant failing is fine from my point of view. On

[GitHub] [zookeeper] nkalmar commented on issue #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid

nkalmar commented on issue #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid URL: https://github.com/apache/zookeeper/pull/610#issuecomment-529818415 Pushed to master. Thanks @lvfangmin

[GitHub] [zookeeper] lvfangmin commented on issue #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid

lvfangmin commented on issue #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid URL: https://github.com/apache/zookeeper/pull/610#issuecomment-529807127 @nkalmar I've rebased the code onto latest master, mind to merge this?

[GitHub] [zookeeper] lvfangmin commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time

lvfangmin commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-529808127 @maoling we don't have an overall design doc for this, but you can find the incremental AdHash paper we're

[GitHub] [zookeeper] nkalmar edited a comment on issue #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid

nkalmar edited a comment on issue #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid URL: https://github.com/apache/zookeeper/pull/610#issuecomment-529815520 Sure, I'll wait maven build, ant failing is fine from my point of

[GitHub] [zookeeper] nkalmar edited a comment on issue #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid

nkalmar edited a comment on issue #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid URL: https://github.com/apache/zookeeper/pull/610#issuecomment-529815520 Sure, I'll wait maven build, ant failing is fine from my point of

[GitHub] [zookeeper] asfgit closed pull request #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid

asfgit closed pull request #610: [ZOOKEEPER-3124] Add the correct comment to show why we need the special logic to handle cversion and pzxid URL: https://github.com/apache/zookeeper/pull/610 This is an automated message