[GitHub] [zookeeper] asfgit closed pull request #1161: ZOOKEEPER-3633: AdminServer commands throw NPE when only secure client port is used

asfgit closed pull request #1161: ZOOKEEPER-3633: AdminServer commands throw NPE when only secure client port is used URL: https://github.com/apache/zookeeper/pull/1161 This is an automated message from the Apache Git

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases

eolivelli commented on a change in pull request #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases URL: https://github.com/apache/zookeeper/pull/1162#discussion_r353216797 ## File path: zookeeper-client/zookeeper-client-c/src/cli.c ##

[GitHub] [zookeeper] eolivelli commented on issue #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases

eolivelli commented on issue #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases URL: https://github.com/apache/zookeeper/pull/1162#issuecomment-561194381 @nkalmar the patch is now ready to go cc @anmolnar

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases

eolivelli commented on a change in pull request #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases URL: https://github.com/apache/zookeeper/pull/1162#discussion_r353217902 ## File path: zookeeper-client/zookeeper-client-c/src/cli.c ##

[GitHub] [zookeeper] nkalmar commented on a change in pull request #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases

nkalmar commented on a change in pull request #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases URL: https://github.com/apache/zookeeper/pull/1162#discussion_r353222010 ## File path: zookeeper-client/zookeeper-client-c/src/cli.c ## @@

[GitHub] [zookeeper] eolivelli commented on issue #1161: ZOOKEEPER-3633: AdminServer commands throw NPE when only secure client port is used

eolivelli commented on issue #1161: ZOOKEEPER-3633: AdminServer commands throw NPE when only secure client port is used URL: https://github.com/apache/zookeeper/pull/1161#issuecomment-561158359 @nkalmar we should cherry pick to 3.5 as well, do you agree?

[GitHub] [zookeeper] nkalmar commented on issue #1161: ZOOKEEPER-3633: AdminServer commands throw NPE when only secure client port is used

nkalmar commented on issue #1161: ZOOKEEPER-3633: AdminServer commands throw NPE when only secure client port is used URL: https://github.com/apache/zookeeper/pull/1161#issuecomment-561200496 @eolivelli sure, it just didn't rebase clean to 3.5, and saw in the jira it was meant to be fixed

[GitHub] [zookeeper] nkalmar commented on a change in pull request #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases

nkalmar commented on a change in pull request #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases URL: https://github.com/apache/zookeeper/pull/1162#discussion_r353216209 ## File path: zookeeper-client/zookeeper-client-c/src/cli.c ## @@

[GitHub] [zookeeper] asf-ci commented on issue #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases

asf-ci commented on issue #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases URL: https://github.com/apache/zookeeper/pull/1162#issuecomment-561252485 Refer to this link for build results (access rights to CI server needed):

[GitHub] [zookeeper] symat commented on issue #1161: ZOOKEEPER-3633: AdminServer commands throw NPE when only secure client port is used

symat commented on issue #1161: ZOOKEEPER-3633: AdminServer commands throw NPE when only secure client port is used URL: https://github.com/apache/zookeeper/pull/1161#issuecomment-561205072 I am also happy to rebase it, let me know if you don't have time

[GitHub] [zookeeper] symat commented on issue #1161: ZOOKEEPER-3633: AdminServer commands throw NPE when only secure client port is used

symat commented on issue #1161: ZOOKEEPER-3633: AdminServer commands throw NPE when only secure client port is used URL: https://github.com/apache/zookeeper/pull/1161#issuecomment-561242716 oh, never mind... I see you did it :) thanks!

[GitHub] [zookeeper] KimRasak opened a new pull request #1164: Fix haveDelivered wrong implementation.

KimRasak opened a new pull request #1164: Fix haveDelivered wrong implementation. URL: https://github.com/apache/zookeeper/pull/1164 # Original implementation and mine - The original implementation of `QuorumCnxManager::haveDelivered` returns true once it finds a queue is empty, and

[GitHub] [zookeeper] asf-ci commented on issue #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases

asf-ci commented on issue #1162: ZOOKEEPER-3635 Use Docker and Maven Release Plugin to prepare ZooKeeper releases URL: https://github.com/apache/zookeeper/pull/1162#issuecomment-561231361 Refer to this link for build results (access rights to CI server needed):

[GitHub] [zookeeper] lvfangmin commented on issue #1158: ZOOKEEPER-3546 - fix missed change, default should be 0 not Long.MAX_VALUE

lvfangmin commented on issue #1158: ZOOKEEPER-3546 - fix missed change, default should be 0 not Long.MAX_VALUE URL: https://github.com/apache/zookeeper/pull/1158#issuecomment-561299544 Merged, thanks @Randgalt! This is an

[GitHub] [zookeeper] lvfangmin commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time

lvfangmin commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time URL: https://github.com/apache/zookeeper/pull/1059#discussion_r353373264 ## File path:

[GitHub] [zookeeper] lvfangmin commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time

lvfangmin commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-561345119 Addressed comments, rebased onto latest master, added detailed documents about digest feature and the

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time

eolivelli commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time URL: https://github.com/apache/zookeeper/pull/1059#discussion_r353375603 ## File path:

[GitHub] [zookeeper] asfgit closed pull request #1146: ZOOKEEPER-3595: restore the handling of the fsync parameter

asfgit closed pull request #1146: ZOOKEEPER-3595: restore the handling of the fsync parameter URL: https://github.com/apache/zookeeper/pull/1146 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] asfgit closed pull request #1158: ZOOKEEPER-3546 - fix missed change, default should be 0 not Long.MAX_VALUE

asfgit closed pull request #1158: ZOOKEEPER-3546 - fix missed change, default should be 0 not Long.MAX_VALUE URL: https://github.com/apache/zookeeper/pull/1158 This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] asf-ci commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time

asf-ci commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-561365941 Refer to this link for build results (access rights to CI server needed):

[GitHub] [zookeeper] maoling commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time

maoling commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time URL: https://github.com/apache/zookeeper/pull/1059#discussion_r353517749 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md

[GitHub] [zookeeper] lvfangmin commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time

lvfangmin commented on issue #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time URL: https://github.com/apache/zookeeper/pull/1059#issuecomment-561436910 Have run the spotbugs check locally with command "mvn spotbugs:check -DskipTests", and haven't seen it's

[GitHub] [zookeeper] maoling commented on issue #1164: Fix haveDelivered wrong implementation.

maoling commented on issue #1164: Fix haveDelivered wrong implementation. URL: https://github.com/apache/zookeeper/pull/1164#issuecomment-561452629 retest maven build This is an automated message from the Apache Git Service.