[GitHub] [zookeeper] symat commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client

symat commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-604556116 I can take a look tomorrow... however, I haven't used much perl either. And also I am not a committer,

Jenkins build is still unstable: zookeeper-master-maven-jdk12 #433

See

[GitHub] [zookeeper] ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client

ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-604560318 @symat: Not asking you to do extra work! I just thought I'd make you aware of this PR, as I keep seeing

[GitHub] [zookeeper] ztzg edited a comment on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions

ztzg edited a comment on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#issuecomment-604582212 Cc: @suhasdantkale and @mjeelanimsft, as PRs #1259 and #579 indicate that you are interested in the C client

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #1115: ZOOKEEPER-3574: Close quorum socket asynchronously to avoid server sh…

jhuan31 commented on a change in pull request #1115: ZOOKEEPER-3574: Close quorum socket asynchronously to avoid server sh… URL: https://github.com/apache/zookeeper/pull/1115#discussion_r398790450 ## File path:

[GitHub] [zookeeper] blb93 commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…

blb93 commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i… URL: https://github.com/apache/zookeeper/pull/1271#issuecomment-604618353 @eolivelli Thank you for the clarification! I definitely thought maoling had write access. It makes sense now.

Build failed in Jenkins: zookeeper-branch36-java8 #108

See Changes: [nkalmar] ZOOKEEPER-3760: remove a useless throwing CliException -- [...truncated 529.34 KB...] [exec] ZooKeeper JMX enabled by default

[GitHub] [zookeeper] nkalmar commented on issue #1286: ZOOKEEPER-3760: remove a useless throwing CliException

nkalmar commented on issue #1286: ZOOKEEPER-3760: remove a useless throwing CliException URL: https://github.com/apache/zookeeper/pull/1286#issuecomment-604578133 Merged to master, 3.6 and 3.5 (had conflict, one extra formatting change here). Thanks @lingjinjiang

[GitHub] [zookeeper] ztzg commented on issue #1211: ZOOKEEPER-3683: Discard requests that are delayed longer than a confi…

ztzg commented on issue #1211: ZOOKEEPER-3683: Discard requests that are delayed longer than a confi… URL: https://github.com/apache/zookeeper/pull/1211#issuecomment-604577534 @hanm, re `requestThrottleQueueTime`: Nice catch!

Jenkins build is back to stable : zookeeper-master-maven-jdk12 #434

See

[GitHub] [zookeeper] ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client

ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-604549540 Now thinking that @symat may be also interested in looking into this.

[GitHub] [zookeeper] ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions

ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#issuecomment-604549738 Now thinking that @symat may be also interested in looking into this.

Build failed in Jenkins: PreCommit-ZOOKEEPER-github-pr-build-maven #1919

See Changes: [brittany.barnes] ZOOKEEPER-3728: move traceMask calculation logic into the trace log in -- [...truncated 1.17 MB...] Generating

[GitHub] [zookeeper] asfgit closed pull request #1286: ZOOKEEPER-3760: remove a useless throwing CliException

asfgit closed pull request #1286: ZOOKEEPER-3760: remove a useless throwing CliException URL: https://github.com/apache/zookeeper/pull/1286 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions

ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#issuecomment-604582212 Cc: @suhasdantkale, as PR #1259 indicates that you are interested in the C client library—and in DNS-related issues in

[GitHub] [zookeeper] nkalmar closed pull request #1293: ZOOKEEPER-3756: Members slow to rejoin quorum using Kubernetes

nkalmar closed pull request #1293: ZOOKEEPER-3756: Members slow to rejoin quorum using Kubernetes URL: https://github.com/apache/zookeeper/pull/1293 This is an automated message from the Apache Git Service. To respond to

[GitHub] [zookeeper] nkalmar commented on issue #1293: ZOOKEEPER-3756: Members slow to rejoin quorum using Kubernetes

nkalmar commented on issue #1293: ZOOKEEPER-3756: Members slow to rejoin quorum using Kubernetes URL: https://github.com/apache/zookeeper/pull/1293#issuecomment-604532914 Merged to branch-3.5, thanks @symat This is an

Build failed in Jenkins: zookeeper-master-maven-jdk13 #129

See Changes: -- [...truncated 638.40 KB...] [INFO] Building jar:

[GitHub] [zookeeper] eolivelli closed pull request #1291: ZOOKEEPER-3767: Fix several document invalid syntax

eolivelli closed pull request #1291: ZOOKEEPER-3767: Fix several document invalid syntax URL: https://github.com/apache/zookeeper/pull/1291 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] eolivelli commented on issue #1284: ZOOKEEPER-3755: Use maven to create fatjar

eolivelli commented on issue #1284: ZOOKEEPER-3755: Use maven to create fatjar URL: https://github.com/apache/zookeeper/pull/1284#issuecomment-604693890 thank you @sushantmane ! Committed to master and to 3.6. This feature will be delivered with 3.6.1, hopefully next week.

Jenkins build is back to normal : zookeeper-branch36-java8 #109

See

Jenkins build became unstable: zookeeper-master-maven #728

See

[GitHub] [zookeeper] eolivelli closed pull request #1284: ZOOKEEPER-3755: Use maven to create fatjar

eolivelli closed pull request #1284: ZOOKEEPER-3755: Use maven to create fatjar URL: https://github.com/apache/zookeeper/pull/1284 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zookeeper] eolivelli closed pull request #1285: ZOOKEEPER-3689: zkCli/ZooKeeperMain relies on system properties for TLS config

eolivelli closed pull request #1285: ZOOKEEPER-3689: zkCli/ZooKeeperMain relies on system properties for TLS config URL: https://github.com/apache/zookeeper/pull/1285 This is an automated message from the Apache Git

[GitHub] [zookeeper] phunt commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…

phunt commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i… URL: https://github.com/apache/zookeeper/pull/1271#issuecomment-604697966 +1 lgtm. This is an automated message from the

Jenkins build is back to stable : zookeeper-master-maven-jdk11 #435

See

[GitHub] [zookeeper] eolivelli closed pull request #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…

eolivelli closed pull request #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i… URL: https://github.com/apache/zookeeper/pull/1271 This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] TisonKun opened a new pull request #1295: ZOOKEEPER-3771: Update zk-merge-pr script to Python3

TisonKun opened a new pull request #1295: ZOOKEEPER-3771: Update zk-merge-pr script to Python3 URL: https://github.com/apache/zookeeper/pull/1295 @eolivelli generally I use `2to3` util and check the codepath that I can arrive, manually fix some lines. But it seems we can verify

Jenkins build is back to normal : zookeeper-master-maven-jdk13 #130

See

[GitHub] [zookeeper] eolivelli commented on issue #1295: ZOOKEEPER-3771: Update zk-merge-pr script to Python3

eolivelli commented on issue #1295: ZOOKEEPER-3771: Update zk-merge-pr script to Python3 URL: https://github.com/apache/zookeeper/pull/1295#issuecomment-604718122 I will be happy to try out this patch for my next use of the script thank you for your quick response !

ZooKeeper_branch34_jdk8 - Build # 2113 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/2113/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 43.46 KB...] [junit] Running

Jenkins build is back to stable : zookeeper-master-maven #729

See

[GitHub] [zookeeper] symat commented on issue #1293: ZOOKEEPER-3756: Members slow to rejoin quorum using Kubernetes

symat commented on issue #1293: ZOOKEEPER-3756: Members slow to rejoin quorum using Kubernetes URL: https://github.com/apache/zookeeper/pull/1293#issuecomment-604277486 @eolivelli can you please take a look? this is the same as #1289 just for branch 3.5...

[GitHub] [zookeeper] aoozdemir commented on issue #156: ZOOKEEPER-2044:CancelledKeyException in zookeeper 3.4.5.

aoozdemir commented on issue #156: ZOOKEEPER-2044:CancelledKeyException in zookeeper 3.4.5. URL: https://github.com/apache/zookeeper/pull/156#issuecomment-604373972 @maoling I'm guessing that it's not critical, but it's not ideal to have the error all the time. Below is the error log

[GitHub] [zookeeper] aoozdemir edited a comment on issue #156: ZOOKEEPER-2044:CancelledKeyException in zookeeper 3.4.5.

aoozdemir edited a comment on issue #156: ZOOKEEPER-2044:CancelledKeyException in zookeeper 3.4.5. URL: https://github.com/apache/zookeeper/pull/156#issuecomment-604373972 @maoling I'm guessing that it's not critical, but it's not ideal to have the error all the time. Below is the

Jenkins build is unstable: zookeeper-master-maven-jdk11 #434

See

ZooKeeper_branch35_jdk8 - Build # 1764 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1764/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 70.00 KB...] [junit] Tests run: 1, Failures:

[GitHub] [zookeeper] eolivelli commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…

eolivelli commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i… URL: https://github.com/apache/zookeeper/pull/1271#issuecomment-604484717 In order to commit a patch we are used to wait for at least two *binding* approvals. In this case my

[GitHub] [zookeeper] eolivelli commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…

eolivelli commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i… URL: https://github.com/apache/zookeeper/pull/1271#issuecomment-604485029 Btw the patch is quite straightforward so maybe I can commit anyway