[GitHub] [zookeeper] MuktiKrishnan opened a new pull request #1658: ZOOKEEPER-4263 : Provided an option to encrypt keystore password

2021-03-28 Thread GitBox
MuktiKrishnan opened a new pull request #1658: URL: https://github.com/apache/zookeeper/pull/1658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [zookeeper] maoling commented on pull request #1574: ZOOKEEPER-4054: Make prometheus listen host can configure

2021-03-28 Thread GitBox
maoling commented on pull request #1574: URL: https://github.com/apache/zookeeper/pull/1574#issuecomment-808911418 @Shoothzj I retry the CI, it became green. But when I run the UT(`testInvalidAddr`) in my local mac: ``` org.junit.ComparisonFailure: Expected

[GitHub] [zookeeper] arshadmohammad commented on pull request #1653: ZOOKEEPER-4260: Backport ZOOKEEPER-3575 to branch-3.6

2021-03-28 Thread GitBox
arshadmohammad commented on pull request #1653: URL: https://github.com/apache/zookeeper/pull/1653#issuecomment-808922810 Please include the latest changes done in PR https://github.com/apache/zookeeper/pull/1645. Also add the documentation for learner.asyncSending property -- This

[GitHub] [zookeeper] arshadmohammad opened a new pull request #1660: ZOOKEEPER-4266: Correct ZooKeeper version in documentation header

2021-03-28 Thread GitBox
arshadmohammad opened a new pull request #1660: URL: https://github.com/apache/zookeeper/pull/1660 Changed version from 3.6 to 3.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zookeeper] arshadmohammad opened a new pull request #1659: ZOOKEEPER-4266: Correct ZooKeeper version in documentation header

2021-03-28 Thread GitBox
arshadmohammad opened a new pull request #1659: URL: https://github.com/apache/zookeeper/pull/1659 Changed version from 3.6 to 3.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1658: ZOOKEEPER-4263 : Provided an option to encrypt keystore password

2021-03-28 Thread GitBox
anmolnar commented on a change in pull request #1658: URL: https://github.com/apache/zookeeper/pull/1658#discussion_r602930897 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/SSLUtil.java ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software

[GitHub] [zookeeper] functioner commented on pull request #1653: ZOOKEEPER-4260: Backport ZOOKEEPER-3575 to branch-3.6

2021-03-28 Thread GitBox
functioner commented on pull request #1653: URL: https://github.com/apache/zookeeper/pull/1653#issuecomment-809038276 @arshadmohammad I cherry-pick #1645. Some configurations are not available in branch-3.6 so I do not include them. -- This is an automated message from the Apache Git

[GitHub] [zookeeper] Shoothzj edited a comment on pull request #1574: ZOOKEEPER-4054: Make prometheus listen host can configure

2021-03-28 Thread GitBox
Shoothzj edited a comment on pull request #1574: URL: https://github.com/apache/zookeeper/pull/1574#issuecomment-809014582 > @Shoothzj I retry the CI, it became green. But when I run the UT(`testInvalidAddr`) in my local mac: > > ``` > org.junit.ComparisonFailure: > Expected

[GitHub] [zookeeper] Winbobob opened a new pull request #1661: ZOOKEEPER-3764: Add High Availability Guarantee Into Docs

2021-03-28 Thread GitBox
Winbobob opened a new pull request #1661: URL: https://github.com/apache/zookeeper/pull/1661 Include the formula for calculating the maximum number of server failures in the ZK doc. > https://issues.apache.org/jira/browse/ZOOKEEPER-3764 -- This is an automated message from the Apache

[GitHub] [zookeeper] maoling closed pull request #1574: ZOOKEEPER-4054: Make prometheus listen host can configure

2021-03-28 Thread GitBox
maoling closed pull request #1574: URL: https://github.com/apache/zookeeper/pull/1574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [zookeeper] maoling commented on pull request #1638: ZOOKEEPER-4246: Resource leaks in org.apache.zookeeper.server.persistence.SnapStream#getInputStream and #getOutputStream

2021-03-28 Thread GitBox
maoling commented on pull request #1638: URL: https://github.com/apache/zookeeper/pull/1638#issuecomment-808859314 @kelloggm Looks reasonable. > I noticed the first because of the use of the error-prone `GZIPOutputStream`, and the other two after looking at the surrounding code.