[GitHub] [zookeeper] GavinAlison commented on issue #966: Branch 3.5.5 running zookeeper can't start on linux_64 system

2019-06-04 Thread GitBox
GavinAlison commented on issue #966: Branch 3.5.5running zookeeper can't start on linux_64 system URL: https://github.com/apache/zookeeper/pull/966#issuecomment-498602892 @maoling , 谢了, 没仔细看readme , 据说要编译 才可以启动 This is

[GitHub] [zookeeper] maoling commented on issue #833: ZOOKEEPER-3288:add a new doc:ZookeeperCLI.md

2019-06-02 Thread GitBox
maoling commented on issue #833: ZOOKEEPER-3288:add a new doc:ZookeeperCLI.md URL: https://github.com/apache/zookeeper/pull/833#issuecomment-498120397 ping @anmolnar @eolivelli @nkalmar Could you plz take a look? The preview is

[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider

2019-06-02 Thread GitBox
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-498065598 Thank you @nkalmar ! It would be great to have your final approval

[GitHub] [zookeeper] eolivelli removed a comment on issue #965: MN-19012 Compile Java code with -Xdoclint

2019-06-02 Thread GitBox
eolivelli removed a comment on issue #965: MN-19012 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-497759739 This is still a draft This is an automated message from the Apache

[GitHub] [zookeeper] eolivelli opened a new pull request #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-02 Thread GitBox
eolivelli opened a new pull request #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965 Add -Xdoclint option and clean up Javadocs This is an automated message from the

[GitHub] [zookeeper] eolivelli commented on issue #965: MN-19012 Compile Java code with -Xdoclint

2019-06-02 Thread GitBox
eolivelli commented on issue #965: MN-19012 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498066927 @nkalmar @anmolnar Please take a look I would like to commit it very soon. It will invalidate many pending pull requests: after

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-02 Thread GitBox
eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498068024 I am investigating about this impossible error: ``` [ERROR] Failed to execute goal

[GitHub] [zookeeper] kabike commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document

2019-06-02 Thread GitBox
kabike commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document URL: https://github.com/apache/zookeeper/pull/931#issuecomment-498082733 @hanm "A client will see the same view of the service regardless of the server that it connects

[GitHub] [zookeeper] eolivelli commented on a change in pull request #833: ZOOKEEPER-3288:add a new doc:ZookeeperCLI.md

2019-06-03 Thread GitBox
eolivelli commented on a change in pull request #833: ZOOKEEPER-3288:add a new doc:ZookeeperCLI.md URL: https://github.com/apache/zookeeper/pull/833#discussion_r289702767 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperCLI.md ## @@ -0,0 +1,542 @@ + + +#

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498188536 Why not just remove the > sing and use "smaller" on the line "If both flushDelay and maxMaxBatchSize are set (> 0)" ?

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498192940 I had an old version of "master" locally. Thank you very much @nkalmar for your support. I have pushed the fix. Maybe I

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498190929 @nkalmar this is weird here on github I can see the line, but I can't see that line on my local copy

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498191055 ``` /** * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498191594 Oh, maybe I have to rebase :-( This is an automated message from the

[GitHub] [zookeeper] nkalmar edited a comment on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
nkalmar edited a comment on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498188536 Why not just remove the > sign and use "bigger" on the line "If both flushDelay and maxMaxBatchSize are set (> 0)" ?

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498191954 That's strange indeed. I can see it and it causes build failure. I checked out master and applied your patch (although it doesn't even

[GitHub] [zookeeper] grgrzybek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-06-03 Thread GitBox
grgrzybek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-498168041 Excuse me for being late to the party. Let me introduce myself - I'm OSGi

[GitHub] [zookeeper] maoling commented on a change in pull request #833: ZOOKEEPER-3288:add a new doc:ZookeeperCLI.md

2019-06-03 Thread GitBox
maoling commented on a change in pull request #833: ZOOKEEPER-3288:add a new doc:ZookeeperCLI.md URL: https://github.com/apache/zookeeper/pull/833#discussion_r289740854 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperCLI.md ## @@ -0,0 +1,542 @@ + + +#

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498190223 > Why not just remove the > sign and use "bigger" on the line > "If both flushDelay and maxMaxBatchSize are set (> 0)" ?

[GitHub] [zookeeper] nkalmar edited a comment on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
nkalmar edited a comment on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498188536 Why not just remove the > sign and use "bigger" on the line "If both flushDelay and maxMaxBatchSize are set (> 0)" ?

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498194477 Actually, I do have some javadoc warnings left :( `[WARNING] Javadoc Warnings [WARNING]

[GitHub] [zookeeper] enixon commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

2019-06-04 Thread GitBox
enixon commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted … URL: https://github.com/apache/zookeeper/pull/944#issuecomment-498769384 Thanks, @hanm , I've incorporated your suggestions.

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498239868 I'm not sure why the maven build failed the last run? This is an

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498282034 @nkalmar the error seems not related to this patch ``` java.lang.AssertionError at

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498282085 retest maven build This is an automated message from the Apache Git

[GitHub] [zookeeper] asfgit closed pull request #939: ZOOKEEPER-3385: Add admin command to display leader

2019-06-04 Thread GitBox
asfgit closed pull request #939: ZOOKEEPER-3385: Add admin command to display leader URL: https://github.com/apache/zookeeper/pull/939 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] asfgit closed pull request #850: ZOOKEEPER-3309: Add sync processor metrics

2019-06-04 Thread GitBox
asfgit closed pull request #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zookeeper] enixon commented on issue #967: ZOOKEEPER-3385: fix build break.

2019-06-04 Thread GitBox
enixon commented on issue #967: ZOOKEEPER-3385: fix build break. URL: https://github.com/apache/zookeeper/pull/967#issuecomment-498909577 lgtm - thanks for addressing This is an automated message from the Apache Git Service.

[GitHub] [zookeeper] enixon commented on issue #967: ZOOKEEPER-3385: fix build break.

2019-06-04 Thread GitBox
enixon commented on issue #967: ZOOKEEPER-3385: fix build break. URL: https://github.com/apache/zookeeper/pull/967#issuecomment-498909611 retest ant build This is an automated message from the Apache Git Service. To respond

[GitHub] [zookeeper] hanm commented on issue #967: ZOOKEEPER-3385: fix build break.

2019-06-04 Thread GitBox
hanm commented on issue #967: ZOOKEEPER-3385: fix build break. URL: https://github.com/apache/zookeeper/pull/967#issuecomment-498898016 I had no idea how that was not caught by pre commit checks - everything was green before I merged the commit. Anyway, this PR should fix the build.

[GitHub] [zookeeper] hanm opened a new pull request #967: ZOOKEEPER-3385: fix build break.

2019-06-04 Thread GitBox
hanm opened a new pull request #967: ZOOKEEPER-3385: fix build break. URL: https://github.com/apache/zookeeper/pull/967 PR https://github.com/apache/zookeeper/pull/939 that merged in master caused build break due to two missing imports. Fix the build break by adding the missing imports.

[GitHub] [zookeeper] asfgit closed pull request #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

2019-06-04 Thread GitBox
asfgit closed pull request #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted … URL: https://github.com/apache/zookeeper/pull/944 This is an automated message from the Apache Git Service. To respond

[GitHub] [zookeeper] enixon commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing

2019-06-04 Thread GitBox
enixon commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing URL: https://github.com/apache/zookeeper/pull/958#issuecomment-498894644 retest maven build This is an automated message from the

[GitHub] [zookeeper] eolivelli commented on issue #967: ZOOKEEPER-3385: fix build break.

2019-06-05 Thread GitBox
eolivelli commented on issue #967: ZOOKEEPER-3385: fix build break. URL: https://github.com/apache/zookeeper/pull/967#issuecomment-498954587 this is the change that dropped those lines https://github.com/apache/zookeeper/commit/6af151a7e44760c33165e58d3b33a4d2760283a4

[GitHub] [zookeeper] eolivelli commented on issue #967: ZOOKEEPER-3385: fix build break.

2019-06-05 Thread GitBox
eolivelli commented on issue #967: ZOOKEEPER-3385: fix build break. URL: https://github.com/apache/zookeeper/pull/967#issuecomment-498952500 retest ant build This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] eolivelli commented on issue #967: ZOOKEEPER-3385: fix build break.

2019-06-05 Thread GitBox
eolivelli commented on issue #967: ZOOKEEPER-3385: fix build break. URL: https://github.com/apache/zookeeper/pull/967#issuecomment-498954366 @hanm In order to be sure that a patch won't break the codebase, ideally, we should re run the precommit before merging. This sort of problems

[GitHub] [zookeeper] nkalmar commented on issue #967: ZOOKEEPER-3385: fix build break.

2019-06-05 Thread GitBox
nkalmar commented on issue #967: ZOOKEEPER-3385: fix build break. URL: https://github.com/apache/zookeeper/pull/967#issuecomment-499003572 retest ant build This is an automated message from the Apache Git Service. To respond

[GitHub] [zookeeper] maoling commented on issue #968: ZKUtil deleteRecursive check LOG Level before calculate the parameter

2019-06-05 Thread GitBox
maoling commented on issue #968: ZKUtil deleteRecursive check LOG Level before calculate the parameter URL: https://github.com/apache/zookeeper/pull/968#issuecomment-499028792 @Geker You're right. - But using the formatting anchors is more succinct。 e.g: `LOG.debug("Deleting {}

[GitHub] [zookeeper] nkalmar commented on a change in pull request #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor

2019-06-05 Thread GitBox
nkalmar commented on a change in pull request #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor URL: https://github.com/apache/zookeeper/pull/905#discussion_r290656383 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -1358,6

[GitHub] [zookeeper] nkalmar commented on a change in pull request #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor

2019-06-05 Thread GitBox
nkalmar commented on a change in pull request #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor URL: https://github.com/apache/zookeeper/pull/905#discussion_r290656215 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -1358,6

[GitHub] [zookeeper] Geker opened a new pull request #968: ZKUtil deleteRecursive check LOG Level before calculate the parameter

2019-06-05 Thread GitBox
Geker opened a new pull request #968: ZKUtil deleteRecursive check LOG Level before calculate the parameter URL: https://github.com/apache/zookeeper/pull/968 LOG.debug("Deleting " + tree); will be calculate tree.toString() even if the log level is higher than debug. this pull

[GitHub] [zookeeper] asfgit closed pull request #967: ZOOKEEPER-3385: fix build break.

2019-06-05 Thread GitBox
asfgit closed pull request #967: ZOOKEEPER-3385: fix build break. URL: https://github.com/apache/zookeeper/pull/967 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [zookeeper] nkalmar commented on issue #967: ZOOKEEPER-3385: fix build break.

2019-06-05 Thread GitBox
nkalmar commented on issue #967: ZOOKEEPER-3385: fix build break. URL: https://github.com/apache/zookeeper/pull/967#issuecomment-499013788 retest ant build This is an automated message from the Apache Git Service. To respond

[GitHub] [zookeeper] nkalmar commented on issue #967: ZOOKEEPER-3385: fix build break.

2019-06-05 Thread GitBox
nkalmar commented on issue #967: ZOOKEEPER-3385: fix build break. URL: https://github.com/apache/zookeeper/pull/967#issuecomment-499025060 Merged to master, thanks @hanm This is an automated message from the Apache Git

[GitHub] [zookeeper] eolivelli commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

2019-05-31 Thread GitBox
eolivelli commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted … URL: https://github.com/apache/zookeeper/pull/944#issuecomment-497588095 @anmolnar I think we should keep this implementation as it is production ready and it also eases the backport

[GitHub] [zookeeper] anmolnar commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists

2019-05-30 Thread GitBox
anmolnar commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists URL: https://github.com/apache/zookeeper/pull/963#issuecomment-497498101 @lfrancke @eolivelli PR against website is good, but a committer has to update the asf-site branch once the patch is

[GitHub] [zookeeper] enixon commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

2019-05-30 Thread GitBox
enixon commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted … URL: https://github.com/apache/zookeeper/pull/944#issuecomment-497509348 @anmolnar that is correct, Netty gives us OptionalSSLHandler which does almost exactly what we want. Since Netty

[GitHub] [zookeeper] lfrancke commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists

2019-05-30 Thread GitBox
lfrancke commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists URL: https://github.com/apache/zookeeper/pull/963#issuecomment-497502838 _Not_ sending a PR is something I'm very good at ;-) btw. if someone could assign the Jira ticket to me that'd be great

[GitHub] [zookeeper] anmolnar commented on issue #964: ZOOKEEPER-3407: Update POM file

2019-05-31 Thread GitBox
anmolnar commented on issue #964: ZOOKEEPER-3407: Update POM file URL: https://github.com/apache/zookeeper/pull/964#issuecomment-497675085 @lfrancke We already have a view of ZooKeeper ant jobs: https://builds.apache.org/view/S-Z/view/ZooKeeper/ Your one seems to be a little bit

[GitHub] [zookeeper] anmolnar commented on issue #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-31 Thread GitBox
anmolnar commented on issue #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#issuecomment-497676066 retest ant build This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] anmolnar commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-31 Thread GitBox
anmolnar commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#discussion_r289354799 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/MultiTransactionRecord.java ## @@ -88,40

[GitHub] [zookeeper] anmolnar commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-31 Thread GitBox
anmolnar commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#discussion_r289360089 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/MultiTransactionTest.java ## @@

[GitHub] [zookeeper] anmolnar commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-31 Thread GitBox
anmolnar commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#discussion_r289357787 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java ## @@

[GitHub] [zookeeper] anmolnar commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-31 Thread GitBox
anmolnar commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-497685167 @eolivelli PTAL. This is an automated message from the

[GitHub] [zookeeper] anmolnar commented on issue #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-31 Thread GitBox
anmolnar commented on issue #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#issuecomment-497683452 @lvfangmin PTAL. This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] anmolnar commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists

2019-05-31 Thread GitBox
anmolnar commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists URL: https://github.com/apache/zookeeper/pull/963#issuecomment-497670442 We got 2 approvals, I'll commit and update the website soon.

[GitHub] [zookeeper] anmolnar commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists

2019-05-31 Thread GitBox
anmolnar commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists URL: https://github.com/apache/zookeeper/pull/963#issuecomment-497669475 @lfrancke I added you to the contributors list. You can assign the Jira to yourself.

[GitHub] [zookeeper] anmolnar commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists

2019-05-31 Thread GitBox
anmolnar commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists URL: https://github.com/apache/zookeeper/pull/963#issuecomment-497674494 Committed and website has been updated. Thanks @lfrancke ! This

[GitHub] [zookeeper] anmolnar closed pull request #963: ZOOKEEPER-3406: Update website for new mailing lists

2019-05-31 Thread GitBox
anmolnar closed pull request #963: ZOOKEEPER-3406: Update website for new mailing lists URL: https://github.com/apache/zookeeper/pull/963 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] eolivelli commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-31 Thread GitBox
eolivelli commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#discussion_r289464258 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -1895,23 +1897,33

[GitHub] [zookeeper] eolivelli commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-31 Thread GitBox
eolivelli commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#discussion_r289463802 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -1895,23 +1897,33

[GitHub] [zookeeper] eolivelli commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation

2019-05-31 Thread GitBox
eolivelli commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#discussion_r289463991 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -1895,23 +1897,33

[GitHub] [zookeeper] eolivelli opened a new pull request #965: MN-19012 Compile Java code with -Xdoclint

2019-05-31 Thread GitBox
eolivelli opened a new pull request #965: MN-19012 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965 Add -Xdoclint option and clean up Javadocs This is an automated message from the Apache

[GitHub] [zookeeper] eolivelli commented on issue #965: MN-19012 Compile Java code with -Xdoclint

2019-05-31 Thread GitBox
eolivelli commented on issue #965: MN-19012 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-497759739 This is still a draft This is an automated message from the Apache Git

[GitHub] [zookeeper] asfgit closed pull request #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-31 Thread GitBox
asfgit closed pull request #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] anmolnar commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-31 Thread GitBox
anmolnar commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-497846672 Committed to master branch. Thanks @szepet ! Please assign the Jira to yourself, otherwise you'll lose the credit. ;)

[GitHub] [zookeeper] enixon opened a new pull request #972: ZOOKEEPER-2418: txnlog diff sync can skip sending some transactions t…

2019-06-06 Thread GitBox
enixon opened a new pull request #972: ZOOKEEPER-2418: txnlog diff sync can skip sending some transactions t… URL: https://github.com/apache/zookeeper/pull/972 …o followers This is an automated message from the Apache Git

[GitHub] [zookeeper] BELUGABEHR commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements

2019-06-06 Thread GitBox
BELUGABEHR commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements URL: https://github.com/apache/zookeeper/pull/878#issuecomment-499724386 @lvfangmin Just fixed the merge and pushed again. Thanks!

[GitHub] [zookeeper] asfgit closed pull request #969: ZOOKEEPER-3416: Remove redundant ServerCnxnFactoryAccessor.

2019-06-07 Thread GitBox
asfgit closed pull request #969: ZOOKEEPER-3416: Remove redundant ServerCnxnFactoryAccessor. URL: https://github.com/apache/zookeeper/pull/969 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] nkalmar commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor

2019-06-07 Thread GitBox
nkalmar commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor URL: https://github.com/apache/zookeeper/pull/905#issuecomment-499867500 retest ant build This is an automated message from the Apache

[GitHub] [zookeeper] Geker commented on issue #968: ZKUtil deleteRecursive check LOG Level before calculate the parameter

2019-06-05 Thread GitBox
Geker commented on issue #968: ZKUtil deleteRecursive check LOG Level before calculate the parameter URL: https://github.com/apache/zookeeper/pull/968#issuecomment-499141367 @maoling according to the logging guidelines,I modify it

[GitHub] [zookeeper] eolivelli commented on issue #968: ZKUtil deleteRecursive check LOG Level before calculate the parameter

2019-06-05 Thread GitBox
eolivelli commented on issue #968: ZKUtil deleteRecursive check LOG Level before calculate the parameter URL: https://github.com/apache/zookeeper/pull/968#issuecomment-499142757 Should we cherry pick to 3.5? This is an

[GitHub] [zookeeper] hanm opened a new pull request #969: ZOOKEEPER-3416: Remove redundant ServerCnxnFactoryAccessor.

2019-06-05 Thread GitBox
hanm opened a new pull request #969: ZOOKEEPER-3416: Remove redundant ServerCnxnFactoryAccessor. URL: https://github.com/apache/zookeeper/pull/969 We have two ways to access the private zkServer inside ServerCnxnFactory, and there is really no need to keep maintaining both. We could

[GitHub] [zookeeper] eolivelli commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-06-07 Thread GitBox
eolivelli commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r291733345 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md

[GitHub] [zookeeper] eolivelli commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-06-07 Thread GitBox
eolivelli commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#issuecomment-500047290 @hanm @lvfangmim Does this patch look good to you now?

[GitHub] [zookeeper] vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-06-07 Thread GitBox
vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r291758431 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md

[GitHub] [zookeeper] vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-06-07 Thread GitBox
vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r291758431 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md

[GitHub] [zookeeper] suhasdantkale opened a new pull request #973: ZOOKEEPER-3420

2019-06-07 Thread GitBox
suhasdantkale opened a new pull request #973: ZOOKEEPER-3420 URL: https://github.com/apache/zookeeper/pull/973 With newer ZK C Client and older ZK server, recv_buffer() could potentially return 0 continuously on non-blocking socket. Fixing the issue by correctly finding how many

[GitHub] [zookeeper] lvfangmin commented on a change in pull request #712: Maintain the configuration will be used by server stabilizer.It can be overridden based on the server type and the server sys

2019-06-07 Thread GitBox
lvfangmin commented on a change in pull request #712: Maintain the configuration will be used by server stabilizer.It can be overridden based on the server type and the server system internals. URL: https://github.com/apache/zookeeper/pull/712#discussion_r291765165 ## File path:

[GitHub] [zookeeper] normanmaurer commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK

2019-06-07 Thread GitBox
normanmaurer commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK URL: https://github.com/apache/zookeeper/pull/919#discussion_r291781673 ## File path:

[GitHub] [zookeeper] normanmaurer commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK

2019-06-07 Thread GitBox
normanmaurer commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK URL: https://github.com/apache/zookeeper/pull/919#discussion_r291781559 ## File path:

[GitHub] [zookeeper] maoling opened a new pull request #974: ZOOKEEPER-3344:write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and doc the usage

2019-06-07 Thread GitBox
maoling opened a new pull request #974: ZOOKEEPER-3344:write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and doc the usage URL: https://github.com/apache/zookeeper/pull/974 - A test case about `zkSnapShotToolkit.cmd` in the `Windows` os was included in the

[GitHub] [zookeeper] hanm commented on issue #971: ZOOKEEPER-3418: Improve quorum throughput through eager ACL checks of requests on local servers.

2019-06-06 Thread GitBox
hanm commented on issue #971: ZOOKEEPER-3418: Improve quorum throughput through eager ACL checks of requests on local servers. URL: https://github.com/apache/zookeeper/pull/971#issuecomment-499687356 retest maven build This

[GitHub] [zookeeper] hanm removed a comment on issue #971: ZOOKEEPER-3418: Improve quorum throughput through eager ACL checks of requests on local servers.

2019-06-06 Thread GitBox
hanm removed a comment on issue #971: ZOOKEEPER-3418: Improve quorum throughput through eager ACL checks of requests on local servers. URL: https://github.com/apache/zookeeper/pull/971#issuecomment-499687356 retest maven build

[GitHub] [zookeeper] asfgit closed pull request #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE

2019-05-30 Thread GitBox
asfgit closed pull request #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE URL: https://github.com/apache/zookeeper/pull/962 This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] nkalmar commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory

2019-05-30 Thread GitBox
nkalmar commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/912#issuecomment-497335051 retest maven build This is an automated

[GitHub] [zookeeper] nkalmar commented on issue #960: Fix typos and grammar in zookeeper docs

2019-05-30 Thread GitBox
nkalmar commented on issue #960: Fix typos and grammar in zookeeper docs URL: https://github.com/apache/zookeeper/pull/960#issuecomment-497338858 retest ant build This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] nkalmar commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE

2019-05-30 Thread GitBox
nkalmar commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE URL: https://github.com/apache/zookeeper/pull/962#issuecomment-497338561 Thanks Patrick, committed to 3.5 and master.

[GitHub] [zookeeper] nkalmar commented on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator)

2019-05-30 Thread GitBox
nkalmar commented on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator) URL: https://github.com/apache/zookeeper/pull/946#issuecomment-497361500 Can you backport the maven part from master @JiriOndrusek ? I think it should work the same

[GitHub] [zookeeper] JiriOndrusek commented on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator)

2019-05-30 Thread GitBox
JiriOndrusek commented on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator) URL: https://github.com/apache/zookeeper/pull/946#issuecomment-497373054 @nkalmar would it be possible to merge ant part - this PR (for purposes of 3.4.x) and merge

[GitHub] [zookeeper] anmolnar commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2019-05-30 Thread GitBox
anmolnar commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch URL: https://github.com/apache/zookeeper/pull/136#issuecomment-497382576 @eolivelli Not yet unfortunately. I'm going to have a new baby boy next week, so not sure how much spare time I'll have for code reviews,

[GitHub] [zookeeper] ashashwat commented on issue #960: Fix typos and grammar in zookeeper docs

2019-05-30 Thread GitBox
ashashwat commented on issue #960: Fix typos and grammar in zookeeper docs URL: https://github.com/apache/zookeeper/pull/960#issuecomment-497369647 @nkalmar Done. The Jenkins green has been eluding this pull request though.

[GitHub] [zookeeper] JiriOndrusek commented on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator)

2019-05-30 Thread GitBox
JiriOndrusek commented on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator) URL: https://github.com/apache/zookeeper/pull/946#issuecomment-497372439 hi, @nkalmar problem with master branch is, that it is not finished: There has to be made a

[GitHub] [zookeeper] Randgalt commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2019-05-30 Thread GitBox
Randgalt commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch URL: https://github.com/apache/zookeeper/pull/136#issuecomment-497384296 I'm still around. If it's worth my effort I can rebase. This is an

[GitHub] [zookeeper] anmolnar commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2019-05-30 Thread GitBox
anmolnar commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch URL: https://github.com/apache/zookeeper/pull/136#issuecomment-497383103 I recommend not cutting `3.6.0` until these big feature candidates are reviewed. We should start a discussion on the dev list soon.

[GitHub] [zookeeper] asfgit closed pull request #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
asfgit closed pull request #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zookeeper] vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-06-03 Thread GitBox
vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r289949284 ## File path: conf/zoo_sample.cfg ## @@ -6,6 +6,9 @@ initLimit=10 #

[GitHub] [zookeeper] eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
eolivelli commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498341300 retest maven build This is an automated message from the Apache Git

[GitHub] [zookeeper] enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader

2019-06-03 Thread GitBox
enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader URL: https://github.com/apache/zookeeper/pull/939#issuecomment-498457960 retest maven build This is an automated message from the Apache Git

[GitHub] [zookeeper] maoling commented on issue #960: Fix typos and grammar in zookeeper docs

2019-06-03 Thread GitBox
maoling commented on issue #960: Fix typos and grammar in zookeeper docs URL: https://github.com/apache/zookeeper/pull/960#issuecomment-498483418 retest this please This is an automated message from the Apache Git Service. To

  1   2   3   4   5   6   7   8   9   10   >