[GitHub] [zookeeper] arshadmohammad commented on issue #1105: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-11 Thread GitBox
arshadmohammad commented on issue #1105: ZOOKEEPER-1260:Audit logging in 
ZooKeeper servers.
URL: https://github.com/apache/zookeeper/pull/1105#issuecomment-552758818
 
 
   Feature is merged in PR https://github.com/apache/zookeeper/pull/1133


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] arshadmohammad commented on issue #1105: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-05 Thread GitBox
arshadmohammad commented on issue #1105: ZOOKEEPER-1260:Audit logging in 
ZooKeeper servers.
URL: https://github.com/apache/zookeeper/pull/1105#issuecomment-549922014
 
 
   Addressed all the comments and created PR for master branch.
   https://github.com/apache/zookeeper/pull/1133


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] arshadmohammad commented on issue #1105: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-04 Thread GitBox
arshadmohammad commented on issue #1105: ZOOKEEPER-1260:Audit logging in 
ZooKeeper servers.
URL: https://github.com/apache/zookeeper/pull/1105#issuecomment-549404116
 
 
   @anmolnar, I will update the patch soon, hopefully by tomorrow. Will try to 
wind up this work by this weekend


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] arshadmohammad commented on issue #1105: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-10-11 Thread GitBox
arshadmohammad commented on issue #1105: ZOOKEEPER-1260:Audit logging in 
ZooKeeper servers.
URL: https://github.com/apache/zookeeper/pull/1105#issuecomment-540943266
 
 
   > In terms of the implementation: would you please make the `ZKAuditLogger` 
implementation pluggable similarly to `zookeeper.clientCnxnSocket`. Later we 
might start to work on Ranger integration and a pluggable audit logger would be 
very useful.
   
   Sure, I will make it configurable.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] arshadmohammad commented on issue #1105: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-10-11 Thread GitBox
arshadmohammad commented on issue #1105: ZOOKEEPER-1260:Audit logging in 
ZooKeeper servers.
URL: https://github.com/apache/zookeeper/pull/1105#issuecomment-540942744
 
 
   > ... because 3.5 is already locked down for new features and release 
process of 3.6 has already been started.
   I think it is locked for backward incompatible features, not for all 
features and this feature is not backward incompatible.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services