[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1357: ZOOKEEPER-3835: Deprecate IOUtils copyBytes

[GitBox]

ctubbsii commented on a change in pull request #1357:
URL: https://github.com/apache/zookeeper/pull/1357#discussion_r428644115



##
File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/common/IOUtils.java
##
@@ -68,6 +68,7 @@ public static void cleanup(Logger log, Closeable... 
closeables) {
 
 /**
  * Copies from one stream to another.
+ * Deprecated. No longer used in ZK.

Review comment:
   To get past the build problems, just suppress the warning wherever it 
must still be used internally... or replace internal calls with whatever is 
replacing this.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1357: ZOOKEEPER-3835: Deprecate IOUtils copyBytes

[GitBox]

ctubbsii commented on a change in pull request #1357:
URL: https://github.com/apache/zookeeper/pull/1357#discussion_r428643357



##
File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/common/IOUtils.java
##
@@ -68,6 +68,7 @@ public static void cleanup(Logger log, Closeable... 
closeables) {
 
 /**
  * Copies from one stream to another.
+ * Deprecated. No longer used in ZK.

Review comment:
   If it's deprecated, it should use the `@Deprecated` annotation, and have 
a useful `@deprecated` javadoc message for any current callers.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org