[GitHub] [zookeeper] eolivelli commented on a change in pull request #1114: ZOOKEEPER-3572: correctly handle zooinspector resources

2019-10-11 Thread GitBox
eolivelli commented on a change in pull request #1114: ZOOKEEPER-3572: 
correctly handle zooinspector resources
URL: https://github.com/apache/zookeeper/pull/1114#discussion_r334012332
 
 

 ##
 File path: zookeeper-contrib/zookeeper-contrib-zooinspector/pom.xml
 ##
 @@ -96,4 +96,15 @@
 
   
 
+  
+
+  
+${project.basedir}/src/main/resources
+
 
 Review comment:
   is this really needed ? isn't it the default ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] eolivelli commented on a change in pull request #1114: ZOOKEEPER-3572: correctly handle zooinspector resources

2019-10-11 Thread GitBox
eolivelli commented on a change in pull request #1114: ZOOKEEPER-3572: 
correctly handle zooinspector resources
URL: https://github.com/apache/zookeeper/pull/1114#discussion_r334012332
 
 

 ##
 File path: zookeeper-contrib/zookeeper-contrib-zooinspector/pom.xml
 ##
 @@ -96,4 +96,15 @@
 
   
 
+  
+
+  
+${project.basedir}/src/main/resources
+
 
 Review comment:
   is this really needded ? isn't it the default ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services