[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498239868 I'm not sure why the maven build failed the last run? This is an

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498194477 Actually, I do have some javadoc warnings left :( `[WARNING] Javadoc Warnings [WARNING]

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498191954 That's strange indeed. I can see it and it causes build failure. I checked out master and applied your patch (although it doesn't even

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox
nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498188536 Why not just remove the > sing and use "smaller" on the line "If both flushDelay and maxMaxBatchSize are set (> 0)" ?