[GitHub] [zookeeper] ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions
ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#issuecomment-607177872 `zkperl`: Well, I can tell you that we are using that one :) (I'll take advantage of this to ping @nkalmar about https://github.com/apache/zookeeper/pull/1243#issuecomment-602653743, as he so nicely suggested :) In general, I agree with your comment—and will ask—but I am at the same time wondering how many of the actual users actively follow the mailing list(s). I don't suppose we have something akin to the Debian Popularity Contest, do we? While I wouldn't be opposed to moving "unpopular" bindings to their own repository, it would probably only make sense to do so if merge rules are somewhat relaxed—as I suspect it would otherwise be even more difficult to meet the "two PMC approvals" threshold. In any case: I am willing to be automatically marked as a reviewer for (at least) the `zkperl` and `zkpython` "contribs." Do we have such a mechanism? I see that GitHub implements some such mechanisms ([1](https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners), [2](https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/managing-code-review-assignment-for-your-team)), but I'm not sure how applicable they are to our case. Never hesitate to ping me manually! (Cc: @eolivelli.) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions
ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#issuecomment-607126132 @symat: Thank you for the review, and the "vote of confidence"! Re `zkpython`: Noted. (As well as `zkperl`, for good measure.) FYI, I have unrelated minor cleanups planned for `zkpython`—but everyone I know seems to be using Kazoo right now. Are you actually using `zkpython`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions
ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#issuecomment-604582212 Cc: @suhasdantkale, as PR #1259 indicates that you are interested in the C client library—and in DNS-related issues in particular. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions
ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#issuecomment-604549738 Now thinking that @symat may be also interested in looking into this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions
ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#issuecomment-602477725 Dear @eolivelli, @anmolnar, @eolivelli, @hanm, @enixon, This has been lingering for a while. How can we give it some momentum? Cheers, -D This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions
ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#issuecomment-550455737 @enixon: I have refreshed the PR, using `finish` rather than `done` as the goto label, as 1/ there is a precedent 2/ it seems to capture "the sense of an early finish" :) The code has also been "stress-tested" in more situations (but not "continuously in production"), with me noticing 1/ no negative side-effects and 2/ reduced operation latencies. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions
ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#issuecomment-544375523 Hi @enixon, Thank you for the review, and sorry for my sluggishness. > The code looks good to me. Have you tested it in any production setting? No. (A much simpler workaround has been used by the team which encountered the issue.) I'll try and see if I can get some more coverage, but it's always a bit of a chicken-and-egg situation. >> @@ -1037,13 +1071,13 @@ int update_addrs(zhandle_t *zh) > zh->state = ZOO_NOTCONNECTED_STATE; > } > > -fail: > +done: > > naming nit - "done" is technically accurate but doesn't capture the > sense of an early finish. Alternatives? Here is what I currently see in zookeeper.c master: 6 abort X 6 done 3 error X 13 failX 1 finish 1 nextX 2 out So: 'finish' or 'out'? Cheers, -D This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions
ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#issuecomment-537511065 Hi @anmolnar, @eolivelli, @hanm, As I saw Andor's "Releasing 3.6.0 - Pending Patches" thread on the ML: what do you think about the attached patch? Does the proposed solution look reasonable to you? And if it does, is that something you would like to have in an early 3.6? Thanks, Damien Diederen This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
