[RFC] reordering and cleanup of thread authors

2010-04-06 Thread Dirk Hohndel
This is based in part on some discussion on IRC today. When a thread is displayed in the search results, previously the authors were always displayed in chronological order. But if only part of the thread matches the query, that may or may not be the intuitive thing to do. Imagine the default "+in

[RFC] reordering and cleanup of thread authors

2010-04-06 Thread Dirk Hohndel
This is based in part on some discussion on IRC today. When a thread is displayed in the search results, previously the authors were always displayed in chronological order. But if only part of the thread matches the query, that may or may not be the intuitive thing to do. Imagine the default "+in

Re: [notmuch] [Sebastian Spaeth] Pull requests

2010-04-06 Thread micah anderson
On 2010-03-27, micah anderson wrote: > On Thu, 25 Mar 2010 22:50:52 -0400, micah anderson wrote: > > On Mon, 01 Mar 2010 15:57:00 +0100, "Sebastian Spaeth" > > wrote: > > > > > From git repository git://github.com/spaetz/notmuch-all-feature.git I > > > would like to advocate the following branc

[PATCH] Remove dangling opening curly bracket.

2010-04-06 Thread Servilio Afre Puentes
Signed-off-by: Servilio Afre Puentes --- notmuch-reply.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index 3798d60..8eb4754 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -383,7 +383,7 @@ notmuch_reply_format_default(void *ctx

[PATCH] test-lib.sh: Add explicit license detail, with change from GPLv2 to GPLv2+.

2010-04-06 Thread Michal Sojka
On Sat, 20 Feb 2010, Carl Worth wrote: > This file has had no explicit license information noted in it, but > has clearly been created and modified according to the terms of GPLv2 > as with the rest of the git code base. > > The purpose of relicensing is to allow other GPLv3+ projects (in > partic

Re: [PATCH] fix obvious cut and paste error

2010-04-06 Thread Carl Worth
On Tue, 06 Apr 2010 15:36:25 -0700, Dirk Hohndel wrote: > -if (unlikely (thread_id_query == NULL)) > +if (unlikely (matched_query == NULL)) Good catch. This is pushed now. -Carl pgpFaQcfNN0Tl.pgp Description: PGP signature ___ notmuch mailing

[PATCH] fix obvious cut and paste error

2010-04-06 Thread Carl Worth
e Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100406/4167da47/attachment.pgp>

Re: [PATCH 2/2] guess From address from Received headers

2010-04-06 Thread Carl Worth
On Tue, 06 Apr 2010 12:45:57 -0700, Dirk Hohndel wrote: > When replying to a message notmuch tries to pick the correct From > address by looking which one of a user's configured email addresses > were included in To or Cc headers of the email that is being replied to. > If none of the users em

[PATCH 2/2] guess From address from Received headers

2010-04-06 Thread Carl Worth
on-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100406/d3fc8675/attachment.pgp>

[PATCH] json: Avoid calling strlen(NULL)

2010-04-06 Thread Anthony Towns
On Tue, Apr 6, 2010 at 17:25, David Edmondson wrote: > ? ?json: Avoid calling strlen(NULL) > ? ?MIME parts may have no filename, which previously resulted in calling > ? ?strlen(NULL). > ?char * > ?json_quote_str(const void *ctx, const char *str) > ?{ > + ? ?if (str == NULL) > + ? ? ? return (char

[PATCH] Derive version numbers from git

2010-04-06 Thread Michal Sojka
On Tue, 06 Apr 2010, Sebastian Spaeth wrote: > On 2010-04-06, Michal Sojka wrote: > > I often have several versions of notmuch compiled and it would be very > > helpful to be able to distinguish between them. Git has a very nice > > feature to make intermediate numbering automatic and unambigu

Re: [notmuch] Message parsing issue?

2010-04-06 Thread Jason White
David Bremner wrote: > One thing I noticed was that the message you sent (at least, if I got > the correct attachment), had X-Spam headers _before_ the "From " > line. If I remove those headers then the message displays Ok. It is > probably not worth putting too much effort into that display co

[PATCH] fix obvious cut and paste error

2010-04-06 Thread Dirk Hohndel
the wrong variable is checked for success of an allocation Signed-off-by: Dirk Hohndel --- lib/thread.cc |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/thread.cc b/lib/thread.cc index 1c8b39d..48c070e 100644 --- a/lib/thread.cc +++ b/lib/thread.cc @@ -236,7 +236,7

[PATCH] fix obvious cut and paste error

2010-04-06 Thread Dirk Hohndel
the wrong variable is checked for success of an allocation Signed-off-by: Dirk Hohndel --- lib/thread.cc |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/thread.cc b/lib/thread.cc index 1c8b39d..48c070e 100644 --- a/lib/thread.cc +++ b/lib/thread.cc @@ -236,7 +236,7

[PATCH] Derive version numbers from git

2010-04-06 Thread Sebastian Spaeth
On 2010-04-06, Michal Sojka wrote: > I often have several versions of notmuch compiled and it would be very > helpful to be able to distinguish between them. Git has a very nice > feature to make intermediate numbering automatic and unambiguous so > let's use it here. But, there are people without

[notmuch] Bulk message tagging

2010-04-06 Thread Mark Anderson
On Mon, 5 Apr 2010 01:15:39 -0500, Xavier Maillard wrote: > On Sun, 04 Apr 2010 07:38:03 -0400, Jesse Rosenthal > wrote: > > On Sun, 04 Apr 2010 06:37:53 +0200, Xavier Maillard wrote: > > > Is there an easy way to mark a whole bunch of message (restricted > > > in a region, result of a search,

Re: [notmuch] Bulk message tagging

2010-04-06 Thread Mark Anderson
On Mon, 5 Apr 2010 01:15:39 -0500, Xavier Maillard wrote: > On Sun, 04 Apr 2010 07:38:03 -0400, Jesse Rosenthal > wrote: > > On Sun, 04 Apr 2010 06:37:53 +0200, Xavier Maillard wrote: > > > Is there an easy way to mark a whole bunch of message (restricted > > > in a region, result of a search,

[PATCH 2/2] guess From address from Received headers

2010-04-06 Thread Dirk Hohndel
When replying to a message notmuch tries to pick the correct From address by looking which one of a user's configured email addresses were included in To or Cc headers of the email that is being replied to. If none of the users email addresses are in the To or Cc headers we now try to guess f

[PATCH 2/2] guess From address from Received headers

2010-04-06 Thread Dirk Hohndel
When replying to a message notmuch tries to pick the correct From address by looking which one of a user's configured email addresses were included in To or Cc headers of the email that is being replied to. If none of the users email addresses are in the To or Cc headers we now try to guess f

[PATCH 1/2] fix notmuch_message_file_get_header

2010-04-06 Thread Dirk Hohndel
fix notmuch_message_file_get_header to always return the first instance of the header you are looking for Signed-off-by: Dirk Hohndel --- lib/message-file.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/message-file.c b/lib/message-file.c index 3a1a6

[PATCH 1/2] fix notmuch_message_file_get_header

2010-04-06 Thread Dirk Hohndel
fix notmuch_message_file_get_header to always return the first instance of the header you are looking for Signed-off-by: Dirk Hohndel --- lib/message-file.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/message-file.c b/lib/message-file.c index 3a1a6

[notmuch] vala, this is notmuch. notmuch, this is vala

2010-04-06 Thread Sebastian Spaeth
On Mon, 5 Apr 2010 14:50:04 +0100, Enrico Zini wrote: > Now I use "lbdb", which gets very slow as time goes. You idea creates a > most definitely superior system. You can actually use both :): Do check out the patch on the mailing list to combine the notmuch address lookup with bbdb via EUDC. It

[PATCH] Derive version numbers from git

2010-04-06 Thread Michal Sojka
On Tue, 06 Apr 2010, Carl Worth wrote: > In trying to get notmuch to grow up a little bit, I've just added a > version number (0.1 initially) and have started doing releases. My idea > for now is to have 2-part versions for releases, and 3-part versions to > indicate intermediate states within git.

Re: [PATCH] test-lib.sh: Add explicit license detail, with change from GPLv2 to GPLv2+.

2010-04-06 Thread Michal Sojka
On Sat, 20 Feb 2010, Carl Worth wrote: > This file has had no explicit license information noted in it, but > has clearly been created and modified according to the terms of GPLv2 > as with the rest of the git code base. > > The purpose of relicensing is to allow other GPLv3+ projects (in > partic

[PATCH] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)

2010-04-06 Thread Sebastian Spaeth
From: Jesse Rosenthal Change the buffer name to a uniquified subject of the thread (i.e. the subject of the first message in the thread) instead of the thread-id. This is more meaningful to the user, and will make it easier to scroll through numerous open buffers. Note that this patch adds an op

[notmuch] [PATCH V4] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)

2010-04-06 Thread Sebastian Spaeth
On Sat, 06 Mar 2010 09:20:21 -0500, Jesse Rosenthal wrote: > Change the buffer name to a uniquified subject of the thread (i.e. the > subject of the first message in the thread) instead of the thread-id. This > is more meaningful to the user, and will make it easier to scroll through > numerous o

[PATCH 2/2] notmuch.el: Colour cited regions and signatures with message-cited-text-face

2010-04-06 Thread Sebastian Spaeth
From: David Edmondson Patch from mail id:1266226909-19360-1-git-send-email-dme at dme.org with a fix in id:873a12hl3f.fsf at aw.hh.sledj.net Signed-off-by: Sebastian Spaeth --- emacs/notmuch-show.el | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/ema

[PATCH 1/2] notmuch.el: Allow citation suffixes to be shown as well as prefixes.

2010-04-06 Thread Sebastian Spaeth
From: David Edmondson In many conversations the last few lines of a citation are more interesting than the first few lines, hence allow those to be shown if desired. Modify the face used for the citation button to distinguish it from the surrounding citation. Signed-off-by: Sebastian Spaeth --

[notmuch] [PATCH] notmuch.el: Allow citation suffixes to be shown as well as prefixes.

2010-04-06 Thread Sebastian Spaeth
On Wed, 17 Feb 2010 10:51:51 +, David Edmondson wrote: > In many conversations the last few lines of a citation are more > interesting than the first few lines, hence allow those to be shown if > desired. > > Modify the face used for the citation button to distinguish it from > the surroundin

[PATCH] json: Avoid calling strlen(NULL)

2010-04-06 Thread David Edmondson
On Tue, 6 Apr 2010 18:17:44 +1000, Anthony Towns wrote: > OTOH, the code in json_quote_array to deal with that does the same > thing (returns a literal string containing two quote marks), which > seems wrong -- the normal code path is to talloc to get a newly > allocated, editable string, that mig

[PATCH 2/2] notmuch.el: Add support for reply-to sender

2010-04-06 Thread Sebastian Spaeth
From: Aneesh Kumar K.V Add key binding to do a reply-to sender. This is mapped to 'R' Signed-off-by: Aneesh Kumar K.V Signed-off-by: Sebastian Spaeth --- emacs/notmuch-show.el | 21 - 1 files changed, 20 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b

[PATCH 1/2] notmuch-reply: Add support for replying only to sender

2010-04-06 Thread Sebastian Spaeth
From: Aneesh Kumar K.V This patch add --recipient=all|sender option Signed-off-by: Aneesh Kumar K.V --- notmuch-client.h |2 + notmuch-reply.c | 55 - 2 files changed, 43 insertions(+), 14 deletions(-) diff --git a/notmuch-client.h b/

Re: [PATCH] Derive version numbers from git

2010-04-06 Thread Michal Sojka
On Tue, 06 Apr 2010, Sebastian Spaeth wrote: > On 2010-04-06, Michal Sojka wrote: > > I often have several versions of notmuch compiled and it would be very > > helpful to be able to distinguish between them. Git has a very nice > > feature to make intermediate numbering automatic and unambigu

[notmuch] [PATCH -V2 1/2] notmuch-reply: Add support for replying only to sender

2010-04-06 Thread Sebastian Spaeth
I just rebased these two patches as the files have been moved around. I use those patches and they work fine for me, by the way. Patches will arrive in a second as reply to this message. Sebastian

[notmuch] Message parsing issue?

2010-04-06 Thread David Bremner
On Sat, 3 Apr 2010 18:25:40 +1100, Jason White wrote: > The problem is that for certain messages, notmuch show treats the entire > message, including, significantly, all of the headers, as the message body. > > An example is attached, with "notmuch show" output as the first file and the > origin

[PATCH] json: Avoid calling strlen(NULL)

2010-04-06 Thread David Edmondson
commit b65817262b3a275ecd0ef1898d92ec5508a9f810 Author: David Edmondson Date: Tue Apr 6 08:24:00 2010 +0100 json: Avoid calling strlen(NULL) MIME parts may have no filename, which previously resulted in calling strlen(NULL). Modified json.c diff --git a/json.c b/json.c ind

Re: [PATCH] Derive version numbers from git

2010-04-06 Thread Sebastian Spaeth
On 2010-04-06, Michal Sojka wrote: > I often have several versions of notmuch compiled and it would be very > helpful to be able to distinguish between them. Git has a very nice > feature to make intermediate numbering automatic and unambiguous so > let's use it here. But, there are people without

Re: [notmuch] Message parsing issue?

2010-04-06 Thread David Bremner
On Sat, 3 Apr 2010 18:25:40 +1100, Jason White wrote: > The problem is that for certain messages, notmuch show treats the entire > message, including, significantly, all of the headers, as the message body. > > An example is attached, with "notmuch show" output as the first file and the > origin

Re: [notmuch] vala, this is notmuch. notmuch, this is vala

2010-04-06 Thread Sebastian Spaeth
On Mon, 5 Apr 2010 14:50:04 +0100, Enrico Zini wrote: > Now I use "lbdb", which gets very slow as time goes. You idea creates a > most definitely superior system. You can actually use both :): Do check out the patch on the mailing list to combine the notmuch address lookup with bbdb via EUDC. It

Re: [PATCH] json: Avoid calling strlen(NULL)

2010-04-06 Thread David Edmondson
On Tue, 6 Apr 2010 18:17:44 +1000, Anthony Towns wrote: > OTOH, the code in json_quote_array to deal with that does the same > thing (returns a literal string containing two quote marks), which > seems wrong -- the normal code path is to talloc to get a newly > allocated, editable string, that mig

Re: [PATCH] json: Avoid calling strlen(NULL)

2010-04-06 Thread Anthony Towns
On Tue, Apr 6, 2010 at 17:25, David Edmondson wrote: >    json: Avoid calling strlen(NULL) >    MIME parts may have no filename, which previously resulted in calling >    strlen(NULL). >  char * >  json_quote_str(const void *ctx, const char *str) >  { > +    if (str == NULL) > +       return (char

[PATCH] Derive version numbers from git

2010-04-06 Thread Michal Sojka
On Tue, 06 Apr 2010, Carl Worth wrote: > In trying to get notmuch to grow up a little bit, I've just added a > version number (0.1 initially) and have started doing releases. My idea > for now is to have 2-part versions for releases, and 3-part versions to > indicate intermediate states within git.

[PATCH] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)

2010-04-06 Thread Sebastian Spaeth
From: Jesse Rosenthal Change the buffer name to a uniquified subject of the thread (i.e. the subject of the first message in the thread) instead of the thread-id. This is more meaningful to the user, and will make it easier to scroll through numerous open buffers. Note that this patch adds an op

Re: [notmuch] [PATCH V4] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)

2010-04-06 Thread Sebastian Spaeth
On Sat, 06 Mar 2010 09:20:21 -0500, Jesse Rosenthal wrote: > Change the buffer name to a uniquified subject of the thread (i.e. the > subject of the first message in the thread) instead of the thread-id. This > is more meaningful to the user, and will make it easier to scroll through > numerous op

[PATCH 2/2] notmuch.el: Colour cited regions and signatures with message-cited-text-face

2010-04-06 Thread Sebastian Spaeth
From: David Edmondson Patch from mail id:1266226909-19360-1-git-send-email-...@dme.org with a fix in id:873a12hl3f@aw.hh.sledj.net Signed-off-by: Sebastian Spaeth --- emacs/notmuch-show.el | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/emacs/not

[PATCH 1/2] notmuch.el: Allow citation suffixes to be shown as well as prefixes.

2010-04-06 Thread Sebastian Spaeth
From: David Edmondson In many conversations the last few lines of a citation are more interesting than the first few lines, hence allow those to be shown if desired. Modify the face used for the citation button to distinguish it from the surrounding citation. Signed-off-by: Sebastian Spaeth --

Re: [notmuch] [PATCH] notmuch.el: Allow citation suffixes to be shown as well as prefixes.

2010-04-06 Thread Sebastian Spaeth
On Wed, 17 Feb 2010 10:51:51 +, David Edmondson wrote: > In many conversations the last few lines of a citation are more > interesting than the first few lines, hence allow those to be shown if > desired. > > Modify the face used for the citation button to distinguish it from > the surroundin

[PATCH] json: Avoid calling strlen(NULL)

2010-04-06 Thread David Edmondson
commit b65817262b3a275ecd0ef1898d92ec5508a9f810 Author: David Edmondson Date: Tue Apr 6 08:24:00 2010 +0100 json: Avoid calling strlen(NULL) MIME parts may have no filename, which previously resulted in calling strlen(NULL). Modified json.c diff --git a/json.c b/json.c

[PATCH 2/2] notmuch.el: Add support for reply-to sender

2010-04-06 Thread Sebastian Spaeth
From: Aneesh Kumar K.V Add key binding to do a reply-to sender. This is mapped to 'R' Signed-off-by: Aneesh Kumar K.V Signed-off-by: Sebastian Spaeth --- emacs/notmuch-show.el | 21 - 1 files changed, 20 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b

[PATCH 1/2] notmuch-reply: Add support for replying only to sender

2010-04-06 Thread Sebastian Spaeth
From: Aneesh Kumar K.V This patch add --recipient=all|sender option Signed-off-by: Aneesh Kumar K.V --- notmuch-client.h |2 + notmuch-reply.c | 55 - 2 files changed, 43 insertions(+), 14 deletions(-) diff --git a/notmuch-client.h b/

Re: [notmuch] [PATCH -V2 1/2] notmuch-reply: Add support for replying only to sender

2010-04-06 Thread Sebastian Spaeth
I just rebased these two patches as the files have been moved around. I use those patches and they work fine for me, by the way. Patches will arrive in a second as reply to this message. Sebastian ___ notmuch mailing list notmuch@notmuchmail.org http://n