[PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Michal Sojka
On Wed, 13 Oct 2010, Mike Kelly wrote: > On Wed, 13 Oct 2010 10:24:25 -0400 > Mike Kelly wrote: > > > Looks like this may also require a newer xapian than i have now > > (xapian-core 1.0.18), as notmuch new aborts with: > > > > terminate called after throwing an instance of > >

[PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Michal Sojka
On Wed, 13 Oct 2010, Servilio Afre Puentes wrote: > On 13 October 2010 08:13, Michal Sojka wrote: > [...] > > THERE IS CURRENTLY ONE KNOWN ISSUE: Viewing/storing of attachments of > > unread messages doesn't work. The reason is that when you view the > > message its unread tag is removed which

[PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Dirk Hohndel
On Wed, 13 Oct 2010 22:34:34 +0200, Michal Sojka wrote: > On Wed, 13 Oct 2010, Servilio Afre Puentes wrote: > > On 13 October 2010 08:13, Michal Sojka wrote: > > [...] > > > THERE IS CURRENTLY ONE KNOWN ISSUE: Viewing/storing of attachments of > > > unread messages doesn't work. The reason is

[PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Mike Kelly
tly, however > notmuch didn't used to have that dependency. -- Mike Kelly -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/a

[PATCH 2/4] Maildir synchronization

2010-10-13 Thread Sebastian Spaeth
ff. Sebastian -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20101013/4bc1b7d0/attachment-0001.pgp>

[PATCH v3 0/5] Git-based modularization of test suite

2010-10-13 Thread Michal Sojka
On Wed, 22 Sep 2010, Michal Sojka wrote: > On Mon, 20 Sep 2010, Carl Worth wrote: > > I've now pushed this out, along with some changes of my own on top of > > it. My changes make things in the test suite look more like they did > > before the git-based modularization, (both output from the test

notmuch setup: segfault in prompt macro

2010-10-13 Thread David Bremner
On Wed, 13 Oct 2010 09:43:40 -0400, Mike Kelly wrote: > Hi, > > While testing Michal Sojka's latest patches, I tried running notmuch > setup, only to find that it segfaults. It does this on a vanilla > branch, too, though: > > #0 0x286e3ba5 in memcpy () from /lib/libc.so.7 > No symbol

[PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread David Bremner
On Wed, 13 Oct 2010 10:50:36 -0400, Servilio Afre Puentes wrote: > > Wouldn't it be more efficient to query notmuch for the filename using > the message ID we store in the DB? When network usage is implemented, > tramp can give us transparent remote file access in emacs. > We can of course do

[PATCH 4/4] Tests for maildir synchronization

2010-10-13 Thread Michal Sojka
Signed-off-by: Michal Sojka --- test/maildir-sync | 216 + test/notmuch-test |2 +- test/test-lib.sh | 14 +++- 3 files changed, 229 insertions(+), 3 deletions(-) create mode 100755 test/maildir-sync diff --git a/test/maildir-sync

[PATCH 3/4] Make maildir synchronization configurable

2010-10-13 Thread Michal Sojka
This adds group [maildir] and key 'sync_level' to the configuration file. The value of sync_level is used to control how the synchronization happens. The default value is no synchronization. --- lib/database-private.h |2 +- lib/database.cc|9 + lib/message.cc |

[PATCH 2/4] Maildir synchronization

2010-10-13 Thread Michal Sojka
This patch allows bi-directional synchronization between maildir flags and certain tags. The flag-to-tag mapping is defined by flag2tag array. The synchronization works this way: 1) Whenever notmuch new is executed, the following happens: o New messages are tagged with configured new_tags.

[PATCH 1/4] lib: Return added message even if it already was in the database

2010-10-13 Thread Michal Sojka
--- lib/database.cc |3 ++- lib/notmuch.h |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index e4ac970..9a4f715 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -1671,7 +1671,8 @@ notmuch_database_add_message

[PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Michal Sojka
Hi, this is an updated version of patches sent in id:1273580061-22580-1-git-send-email-sojkam1 at fel.cvut.cz. Only the last patch (tests) was actually updated to work with new test suite. These patches has already been tested by several people and I think they are ready to be merged. They can be

notmuch setup: segfault in prompt macro

2010-10-13 Thread Mike Kelly
(sorry, forgot to reply to list) On Wed, 13 Oct 2010 14:26:56 -0300 David Bremner wrote: > On Wed, 13 Oct 2010 09:43:40 -0400, Mike Kelly > wrote: > > Hi, > > > > While testing Michal Sojka's latest patches, I tried running notmuch > > setup, only to find that it segfaults. It does this on a

[PATCH] Allow user to specify ignored directories

2010-10-13 Thread Michal Sojka
On Thu, 30 Sep 2010, Andreas Amann wrote: > Hi list, > > this is my first post. I found notmuch a couple of days ago and it works > great. However I wanted to be able to ignore certain directories (mostly > .git in my case) when "notmuch new" is running. > > With this patch the user can provide

[PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Servilio Afre Puentes
On 13 October 2010 08:13, Michal Sojka wrote: [...] > THERE IS CURRENTLY ONE KNOWN ISSUE: Viewing/storing of attachments of > unread messages doesn't work. The reason is that when you view the > message its unread tag is removed which causes the file to be renamed, > but Emacs still uses the

opening attachment

2010-10-13 Thread Daniel Goldin
Ah, thank you. Works like a charm. d. On Tue, 12 Oct 2010 10:53:09 +0200, Michal Sojka wrote: > On Sun, 10 Oct 2010, Daniel Goldin wrote: > > > > Setting my .mailcap doesn't seem to have any effect on how notmuch/emacs > > handles attachments. Hitting return saves no matter what. > > I use

[PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Mike Kelly
On Wed, 13 Oct 2010 10:24:25 -0400 Mike Kelly wrote: > Looks like this may also require a newer xapian than i have now > (xapian-core 1.0.18), as notmuch new aborts with: > > terminate called after throwing an instance of > 'Xapian::InvalidArgumentError' > > I'll see if I can track down

[PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Mike Kelly
On Wed, 13 Oct 2010 09:31:58 -0400 Mike Kelly wrote: > On Wed, 13 Oct 2010 14:13:54 +0200 > Michal Sojka wrote: > > > Hi, > > > > this is an updated version of patches sent in > > id:1273580061-22580-1-git-send-email-sojkam1 at fel.cvut.cz. Only the > > last patch (tests) was actually updated

notmuch setup: segfault in prompt macro

2010-10-13 Thread Mike Kelly
Hi, While testing Michal Sojka's latest patches, I tried running notmuch setup, only to find that it segfaults. It does this on a vanilla branch, too, though: #0 0x286e3ba5 in memcpy () from /lib/libc.so.7 No symbol table info available. #1 0x28620f6b in getline () from /lib/libc.so.7

notmuch-next branch

2010-10-13 Thread Sebastian Spaeth
> I'd be glad to host something on notmuchmail.org too. > > I suppose I should just set that up... +1 which would make it easier to find for new users. Who would have push rights? (not me). Sebastian

[PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Mike Kelly
On Wed, 13 Oct 2010 14:13:54 +0200 Michal Sojka wrote: > Hi, > > this is an updated version of patches sent in > id:1273580061-22580-1-git-send-email-sojkam1 at fel.cvut.cz. Only the > last patch (tests) was actually updated to work with new test suite. > These patches has already been tested

[PATCH v3 0/5] Git-based modularization of test suite

2010-10-13 Thread Carl Worth
example?), I'd be glad to hear it. -Carl -- carl.d.worth at intel.com -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20101013/4aca2474/attachment.pgp>

Re: notmuch-next branch

2010-10-13 Thread Sebastian Spaeth
I'd be glad to host something on notmuchmail.org too. I suppose I should just set that up... +1 which would make it easier to find for new users. Who would have push rights? (not me). Sebastian ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH 3/4] Make maildir synchronization configurable

2010-10-13 Thread Michal Sojka
This adds group [maildir] and key 'sync_level' to the configuration file. The value of sync_level is used to control how the synchronization happens. The default value is no synchronization. --- lib/database-private.h |2 +- lib/database.cc|9 + lib/message.cc |

[PATCH 4/4] Tests for maildir synchronization

2010-10-13 Thread Michal Sojka
Signed-off-by: Michal Sojka sojk...@fel.cvut.cz --- test/maildir-sync | 216 + test/notmuch-test |2 +- test/test-lib.sh | 14 +++- 3 files changed, 229 insertions(+), 3 deletions(-) create mode 100755 test/maildir-sync diff --git

Re: [PATCH v3 0/5] Git-based modularization of test suite

2010-10-13 Thread Michal Sojka
On Wed, 22 Sep 2010, Michal Sojka wrote: On Mon, 20 Sep 2010, Carl Worth wrote: I've now pushed this out, along with some changes of my own on top of it. My changes make things in the test suite look more like they did before the git-based modularization, (both output from the test suite

notmuch setup: segfault in prompt macro

2010-10-13 Thread Mike Kelly
Hi, While testing Michal Sojka's latest patches, I tried running notmuch setup, only to find that it segfaults. It does this on a vanilla branch, too, though: #0 0x286e3ba5 in memcpy () from /lib/libc.so.7 No symbol table info available. #1 0x28620f6b in getline () from /lib/libc.so.7

Re: [PATCH 2/4] Maildir synchronization

2010-10-13 Thread Sebastian Spaeth
+/* ASCII ordered table of Maildir flags and associated tags */ +struct maildir_flag_tag flag2tag[] = { +{ 'D', draft, false}, +{ 'F', flagged, false}, +{ 'P', passed, false}, +{ 'R', replied, false}, +{ 'S', unread, true }, +{ 'T', delete, false}, +}; for

Re: [PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Mike Kelly
On Wed, 13 Oct 2010 10:24:25 -0400 Mike Kelly pi...@pioto.org wrote: Looks like this may also require a newer xapian than i have now (xapian-core 1.0.18), as notmuch new aborts with: terminate called after throwing an instance of 'Xapian::InvalidArgumentError' I'll see if I can track

Re: [PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Servilio Afre Puentes
On 13 October 2010 08:13, Michal Sojka sojk...@fel.cvut.cz wrote: [...] THERE IS CURRENTLY ONE KNOWN ISSUE: Viewing/storing of attachments of unread messages doesn't work. The reason is that when you view the message its unread tag is removed which causes the file to be renamed, but Emacs

Re: [PATCH v3 0/5] Git-based modularization of test suite

2010-10-13 Thread Carl Worth
On Wed, 13 Oct 2010 14:44:23 +0200, Michal Sojka sojk...@fel.cvut.cz wrote: here is my experience with test_begin_subtest and test_expect_equal functions in test-lib.sh. I see there two significant differences from the git's test_expect_success and similar functions. First, when the test

Re: [PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread David Bremner
On Wed, 13 Oct 2010 10:50:36 -0400, Servilio Afre Puentes servi...@gmail.com wrote: Wouldn't it be more efficient to query notmuch for the filename using the message ID we store in the DB? When network usage is implemented, tramp can give us transparent remote file access in emacs. We can

Re: notmuch setup: segfault in prompt macro

2010-10-13 Thread David Bremner
On Wed, 13 Oct 2010 09:43:40 -0400, Mike Kelly pi...@pioto.org wrote: Hi, While testing Michal Sojka's latest patches, I tried running notmuch setup, only to find that it segfaults. It does this on a vanilla branch, too, though: #0 0x286e3ba5 in memcpy () from /lib/libc.so.7 No

Re: notmuch setup: segfault in prompt macro

2010-10-13 Thread Mike Kelly
(sorry, forgot to reply to list) On Wed, 13 Oct 2010 14:26:56 -0300 David Bremner brem...@unb.ca wrote: On Wed, 13 Oct 2010 09:43:40 -0400, Mike Kelly pi...@pioto.org wrote: Hi, While testing Michal Sojka's latest patches, I tried running notmuch setup, only to find that it segfaults.

Re: [PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Michal Sojka
On Wed, 13 Oct 2010, Mike Kelly wrote: On Wed, 13 Oct 2010 10:24:25 -0400 Mike Kelly pi...@pioto.org wrote: Looks like this may also require a newer xapian than i have now (xapian-core 1.0.18), as notmuch new aborts with: terminate called after throwing an instance of

Re: [PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Mike Kelly
On Wed, 13 Oct 2010 22:59:49 +0200 Michal Sojka sojk...@fel.cvut.cz wrote: So you were able to compile it? What was the problem? I mentioned at the bottom of a previous message: This is with gcc (GCC) 4.2.1 20070719 [FreeBSD] Switching to gcc44 seems to allow it to compile correctly,

Re: [PATCH 0/4] Maildir synchronization v2

2010-10-13 Thread Dirk Hohndel
On Wed, 13 Oct 2010 22:34:34 +0200, Michal Sojka sojk...@fel.cvut.cz wrote: On Wed, 13 Oct 2010, Servilio Afre Puentes wrote: On 13 October 2010 08:13, Michal Sojka sojk...@fel.cvut.cz wrote: [...] THERE IS CURRENTLY ONE KNOWN ISSUE: Viewing/storing of attachments of unread messages