Preventing the user shooting themself in the foot

On Thu, 30 Jun 2011 13:04:23 +1000, Brian May wrote: > On 30 June 2011 08:40, Carl Worth wrote: > > The 'a' keybinding, (in turn), was designed for cases when you *know* > > you don't want to read the rest of the thread. > > ... in which case it should also mark everything as read. IMHO. I

[PATCH 2/2] emacs: Tests for user-defined sections

--- test/emacs | 37 test/emacs.expected-output/notmuch-hello |3 +- .../notmuch-hello-new-section |4 ++ .../notmuch-hello-no-saved-searches|3 +-

[PATCH 0/2] emacs: User-defined sections in notmuch-hello

Unfortunately the customize-interface for more customized entries in notmuch-hello-sections looks a bit weird, but I couldn't figure out how to get rid of the empty lines produced by generating the lambda expression needed. To avoid unnecessary complexity in the code this patch removes aligning

[PATCH] test: revert non-intentional changes introduced in eb4cf465

eb4cf465 introduces changes which weren't part of the submitted patch (id:"87liwlip2j.fsf at gmail.com"), presumably made during resolving merge conflicts. The first one causes the title of a test to be printed a second time, in place of the correct title: PASS Message with .. in Message-Id:

[PATCH v3] test:Improve test behaviors when --root is used

On Tue, 28 Jun 2011 16:03:00 -0700, Carl Worth wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > On Tue, 28 Jun 2011 16:11:32 -0600, Mark Anderson > wrote: > > Change add_email_corpus, emacs_deliver_message and tests to use > > $TEST_DIRECTORY instead of '..'. > ... > >

[PATCH 3/4] emacs: Add pseudo saved search to match mail that no saved search matches

On Wed, 29 Jun 2011 13:49:18 -0700, Jameson Graef Rollins wrote: Non-text part: multipart/signed > On Wed, 29 Jun 2011 20:15:22 +, Jani Nikula wrote: > > So to clarify, do you prefer having on/off switches, or just enabling > > this without customization at all? Personally I'd shy away from

Preventing the user shooting themself in the foot

w mode). jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/4cb021bc/attachment.pgp>

Preventing the user shooting themself in the foot

It's really dangerous to use the 'a' key in notmuch-mode in an inbox thread which has multiple unread replies! Yes, the other unread replies will still be tagged unread, but the user might not immediately be aware of them. It would be really useful to have an optional warning ("More unread

[PATCH 3/4] emacs: Add pseudo saved search to match mail that no saved search matches

On Wed, 29 Jun 2011 12:14:05 -0700, Jameson Graef Rollins wrote: Non-text part: multipart/signed > On Tue, 28 Jun 2011 07:31:31 +, Jani Nikula wrote: > > Add a pseudo saved search that matches all the mail that no other saved > > search matches. Add new customization option

Preventing the user shooting themself in the foot

he actions, at least; I've never been too fond of the specific key choices). On Jun 29, 2011 6:40 PM, "Carl Worth" wrote: -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/45f1b984/attachment-0001.html>

[PATCH] new: Improved workaround for mistaken new directories

Currently, notmuch new assumes any directory with a database mtime of 0 is new, but we don't set the mtime until after processing messages and subdirectories in that directory. Hence, anything that prevents the mtime update (such as an interruption or the wall-clock logic introduced in 8c39e8d6)

notmuch Digest, Vol 20, Issue 57

On Wed, 29 Jun 2011 13:54:40 -0700, Jameson Graef Rollins wrote: > On Wed, 29 Jun 2011 14:21:11 -0600, Mark Anderson > wrote: > > I personally prefer --output=files remain as it was, with one file per > > mail (even though I submitted the patch to change it). I suggest that > > we could add

[PATCH 1/6] test: run emacs inside screen

Dmitry Kurochkin wrote: > Before the change, emacs run in daemon mode without any visible > buffers. Turns out that this affects emacs behavior in some > cases. In particular, `window-end' function returns `point-max' > instead of the last visible position. That makes it hard or > impossible to

[PATCH] new: Improved workaround for mistaken new directories

- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/76c34e16/attachment.pgp>

Preventing the user shooting themself in the foot

-Carl -- carl.d.worth at intel.com -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/ce84a857/attachment.pgp>

[PATCH] test: document test_expect_equal_file

. Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/bd90c076/attachment.pgp>

[PATCH] lib/Makefile.local: remove leftover debugging output.

as scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/255b9b38/attachment.pgp>

[PATCH 1/2] new: Don't update DB mtime if FS mtime equals wall-clock time.

e. -Carl -- carl.d.worth at intel.com -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/d46766a0/attachment.pgp>

[PATCH] test: revert non-intentional changes introduced in eb4cf465

e Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/5da48f05/attachment.pgp>

notmuch Digest, Vol 20, Issue 57

On Tue, 28 Jun 2011 16:53:30 -0700, Carl Worth wrote: > On Tue, 28 Jun 2011 16:38:30 -0600, Mark Anderson > wrote: > > I had briefly considered adding another output format "file", just to get a > > single file for each message in the db, but the file/files distinction > > feels a bit niggling.

[PATCH] Fix folder: coherence issue

- carl.d.worth at intel.com -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/a7a01a06/attachment.pgp>

[PATCH] Fix folder: coherence issue

Add removal of all ZXFOLDER terms to removal of all XFOLDER terms for each message filename removal. The existing filename-list reindexing will put all the needed terms back in. Test search-folder-coherence now passes. Signed-off-by:Mark Anderson --- Once I fixed the removal instead of the

notmuch Digest, Vol 20, Issue 57

ations where there really isn't a need. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/ee93de94/attachment.pgp>

Preventing the user shooting themself in the foot

--- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/fc70ca80/attachment.pgp>

[PATCH 3/4] emacs: Add pseudo saved search to match mail that no saved search matches

mie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/0c20cc13/attachment.pgp>

[PATCH] test: document test_expect_equal_file

This test was not properly documented when it was originally added (my bad). --- test/README |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/test/README b/test/README index 8fbf78d..f9ac607 100644 --- a/test/README +++ b/test/README @@ -156,6 +156,13 @@ library for

[PATCH 1/3] test: `notmuch-show-advance-and-archive' with invisible signature

On Wed, 29 Jun 2011 05:48:50 +0400, Dmitry Kurochkin wrote: > Add Emacs test to check that `notmuch-show-advance-and-archive' > works for the last message in thread with invisible signature. > --- > > This patch series fixes the bug reported by Sebastien in [1]. I > was able to reproduce it and

[PATCH] emacs: remove unused `point-invisible-p' function

`point-invisible-p' does not work correctly when `invisible' property is a list. There are standard `invisible-p' and related functions that should be used instead. --- emacs/notmuch-lib.el | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git

[PATCH 2/2] test/libnotmuch-abi: compare exported symbols, available symbols, and linker script.

From: David Bremner This uses objdump and awk to grab the available "notmuch_" symbols from the object files and all exported symbols from libnotmuch.so. The symbols from the linker script are grabbed using sed. All three of these sets of symbols should be equal. ---

[PATCH 1/2] test/symbol-hiding: rename to test/libnotmuch-abi, prepare to add more subtests

From: David Bremner Test descriptions changed to accomodate more subtests. The generic 'run_test' is renamed 'run_exception_test', symbol-test(.cc) is renamed exception-test(.cc). --- I'm not sure if it would be better to start a new test script rather than this fuss about

bug in emacs-ui ?

t; hiding a message while some citations are shown in notmuch-show view"). > > > Reverting that fixes the problem for me. (If you don't want to resolve > > > conflicts, also revert 432e091924c1d1d8950a44ca78bc5b9c5ade47e4 first.) I > > > don't > > > have the ti

[PATCH 1/3] test: `notmuch-show-advance-and-archive' with invisible signature

On Wed, 29 Jun 2011 09:10:19 +0400, Dmitry Kurochkin wrote: > On Wed, 29 Jun 2011 05:48:50 +0400, Dmitry Kurochkin gmail.com> wrote: > > This patch series fixes the bug reported by Sebastien in [1]. I > > was able to reproduce it and confirm that the second patch from > > this series fixes the

[PATCH] lib/Makefile.local: remove leftover debugging output.

From: David Bremner The removed "echo $(libnotmuch_modules)" was strictly for debugging. Thanks to Austin Clements for the hint. --- lib/Makefile.local |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/lib/Makefile.local b/lib/Makefile.local index

[PATCH 1/2] new: Don't update DB mtime if FS mtime equals wall-clock time.

p://notmuchmail.org/pipermail/notmuch/attachments/20110629/4f487e2a/attachment.pgp>

[PATCH 10/10] test: use emacsclient(1) for Emacs tests

anks! -Carl -- carl.d.worth at intel.com -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/1e9ff4e7/attachment.pgp>

[PATCH 1/2] new: Don't update DB mtime if FS mtime equals wall-clock time.

e fully). Other than that, I'm quite happy with the patch. -Carl -- carl.d.worth at intel.com -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.or

bug in emacs-ui ?

On Tue, 28 Jun 2011 21:38:17 +0400, Dmitry Kurochkin wrote: > Hi Jani. > > On Tue, 28 Jun 2011 10:35:48 + (UTC), Jani Nikula > wrote: > > Carl Worth writes: > > > > > > > > On Wed, 22 Jun 2011 08:50:23 +0200, Sebastien Binet > > > wrote: > > > > On Tue, 21 Jun 2011 15:09:20 -0700, Carl

[PATCH 3/3] emacs: remove no longer used functions from notmuch-show.el

Remove `notmuch-show-move-past-invisible-backward' and `notmuch-show-move-past-invisible-forward' functions which are unused. --- emacs/notmuch-show.el |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index

[PATCH 2/3] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive

Use `previous-single-char-property-change' instead of going through each character by hand and testing it's visibility. This fixes `notmuch-show-advance-and-archive' to work for the last message in thread with hidden signature. --- emacs/notmuch-show.el | 17 + 1 files changed,

[PATCH 10/10] test: use emacsclient(1) for Emacs tests

On Tue, Jun 28, 2011 at 8:15 PM, Carl Worth wrote: > That means that if the emacs_deliver_message code is fast enough, (less > than 1 second), and if the test suite is being run on a lame filesystem > without sub-second timestamp granularity (including ext3fs) that the > "notmuch new" invocation

[PATCH 2/2] test: Nix increment_mtime.

With the fix for the mtime race, this workaround is no longer necessary. --- test/maildir-sync |8 test/multipart|1 - test/new |9 - test/search-by-folder |2 -- test/test-lib.sh | 15 --- 5 files changed, 0

[PATCH 1/2] new: Don't update DB mtime if FS mtime equals wall-clock time.

This fixes a race where multiple message deliveries in the same second with an intervening notmuch new could result in messages being ignored by notmuch (at least, until a later delivery forced a rescan). Because mtimes only have second granularity, later deliveries in the same second won't change

[PATCH v6 00/17] Fix 'notmuch new' atomicity issues

Just found one more atomicity bug in notmuch-new. I would prefer to not update this patch series yet again, but rather to follow up with a separate fix for this. The full bug is described below, but the gist is that how add_files_recursive computes new_directory from the mtime isn't sound. The

[PATCH 10/10] test: use emacsclient(1) for Emacs tests

On Tue, 28 Jun 2011 15:14:04 -0700, Carl Worth wrote: > On Tue, 28 Jun 2011 08:45:11 +0400, Dmitry Kurochkin gmail.com> wrote: > > Before the change, every Emacs test ran in a separate Emacs > > instance. Starting Emacs many times wastes considerable time and > > it gets worse as the test suite

[PATCH 2/2] test: use emacsclient(1) for Emacs tests

On Tue, 28 Jun 2011 13:10:58 -0700, Carl Worth wrote: Non-text part: multipart/signed > On Tue, 28 Jun 2011 20:42:42 +0400, Dmitry Kurochkin gmail.com> wrote: > > I would like to hear what other (Carl in particular) think about this. > > If the consensus is for your approach, I would be happy to

[PATCH 2/2] test: use emacsclient(1) for Emacs tests

On Tue, 28 Jun 2011 13:10:58 -0700, Carl Worth wrote: > On Tue, 28 Jun 2011 20:42:42 +0400, Dmitry Kurochkin gmail.com> wrote: > > I would like to hear what other (Carl in particular) think about this. > > If the consensus is for your approach, I would be happy to implement > > it. > > In

notmuch Digest, Vol 20, Issue 57

Carl Worth writes:> [snip] > First, it's important to understand that any friction here comes from > Gmail exposing its tags as folders, (which in turn could be the lack of > availability of a more tag-aware protocol than imap). > I agree that this is the key issue here. I was hoping that

Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues

Just found one more atomicity bug in notmuch-new. I would prefer to not update this patch series yet again, but rather to follow up with a separate fix for this. The full bug is described below, but the gist is that how add_files_recursive computes new_directory from the mtime isn't sound. The

[PATCH 1/2] new: Don't update DB mtime if FS mtime equals wall-clock time.

This fixes a race where multiple message deliveries in the same second with an intervening notmuch new could result in messages being ignored by notmuch (at least, until a later delivery forced a rescan). Because mtimes only have second granularity, later deliveries in the same second won't change

[PATCH 2/2] test: Nix increment_mtime.

With the fix for the mtime race, this workaround is no longer necessary. --- test/maildir-sync |8 test/multipart|1 - test/new |9 - test/search-by-folder |2 -- test/test-lib.sh | 15 --- 5 files changed, 0

Re: [PATCH 10/10] test: use emacsclient(1) for Emacs tests

On Tue, Jun 28, 2011 at 8:15 PM, Carl Worth cwo...@cworth.org wrote: That means that if the emacs_deliver_message code is fast enough, (less than 1 second), and if the test suite is being run on a lame filesystem without sub-second timestamp granularity (including ext3fs) that the notmuch new

Re: [PATCH 1/3] test: `notmuch-show-advance-and-archive' with invisible signature

On Wed, 29 Jun 2011 09:10:19 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Wed, 29 Jun 2011 05:48:50 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: This patch series fixes the bug reported by Sebastien in [1]. I was able to reproduce it and confirm that the

[PATCH] lib/Makefile.local: remove leftover debugging output.

From: David Bremner brem...@debian.org The removed echo $(libnotmuch_modules) was strictly for debugging. Thanks to Austin Clements for the hint. --- lib/Makefile.local |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/lib/Makefile.local b/lib/Makefile.local index

[PATCH 1/2] test/symbol-hiding: rename to test/libnotmuch-abi, prepare to add more subtests

From: David Bremner brem...@debian.org Test descriptions changed to accomodate more subtests. The generic 'run_test' is renamed 'run_exception_test', symbol-test(.cc) is renamed exception-test(.cc). --- I'm not sure if it would be better to start a new test script rather than this fuss about

[PATCH 2/2] test/libnotmuch-abi: compare exported symbols, available symbols, and linker script.

From: David Bremner brem...@debian.org This uses objdump and awk to grab the available notmuch_ symbols from the object files and all exported symbols from libnotmuch.so. The symbols from the linker script are grabbed using sed. All three of these sets of symbols should be equal. ---

[PATCH] test: document test_expect_equal_file

This test was not properly documented when it was originally added (my bad). --- test/README |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/test/README b/test/README index 8fbf78d..f9ac607 100644 --- a/test/README +++ b/test/README @@ -156,6 +156,13 @@ library for

Re: [PATCH 3/4] emacs: Add pseudo saved search to match mail that no saved search matches

On Tue, 28 Jun 2011 07:31:31 +, Jani Nikula j...@nikula.org wrote: Add a pseudo saved search that matches all the mail that no other saved search matches. Add new customization option notmuch-saved-searches-nomatch to enable and name the pseudo saved search. Hi, Jani. I haven't looked too

Preventing the user shooting themself in the foot

It's really dangerous to use the 'a' key in notmuch-mode in an inbox thread which has multiple unread replies! Yes, the other unread replies will still be tagged unread, but the user might not immediately be aware of them. It would be really useful to have an optional warning (More unread messages

[PATCH 1/6] test: run emacs inside screen

Before the change, emacs run in daemon mode without any visible buffers. Turns out that this affects emacs behavior in some cases. In particular, `window-end' function returns `point-max' instead of the last visible position. That makes it hard or impossible to implement some tests. The patch

[PATCH 2/6] test: do not set frame width in emacs

No need for `set-frame-width' in emacs tests since it runs in screen now. --- test/test-lib.el |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/test/test-lib.el b/test/test-lib.el index a783936..97ae593 100644 --- a/test/test-lib.el +++ b/test/test-lib.el @@ -20,9 +20,6

[PATCH 3/6] test: `notmuch-show-advance-and-archive' with invisible signature

Add Emacs test to check that `notmuch-show-advance-and-archive' works for the last message in thread with invisible signature. --- test/emacs | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index e59de47..bad1122 100755 ---

[PATCH 4/6] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive

Use `previous-single-char-property-change' instead of going through each character by hand and testing it's visibility. This fixes `notmuch-show-advance-and-archive' to work for the last message in thread with hidden signature. --- emacs/notmuch-show.el | 17 + 1 files changed,

[PATCH 5/6] emacs: remove no longer used functions from notmuch-show.el

Remove `notmuch-show-move-past-invisible-backward' and `notmuch-show-move-past-invisible-forward' functions which are unused. --- emacs/notmuch-show.el |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index

[PATCH 6/6] emacs: remove unused `point-invisible-p' function

`point-invisible-p' does not work correctly when `invisible' property is a list. There are standard `invisible-p' and related functions that should be used instead. --- emacs/notmuch-lib.el | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git

Re: [PATCH 1/3] test: `notmuch-show-advance-and-archive' with invisible signature

On Wed, 29 Jun 2011 09:10:19 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Wed, 29 Jun 2011 05:48:50 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Add Emacs test to check that `notmuch-show-advance-and-archive' works for the last message in thread with invisible

Re: [PATCH 3/4] emacs: Add pseudo saved search to match mail that no saved search matches

On Wed, 29 Jun 2011 12:14:05 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: Non-text part: multipart/signed On Tue, 28 Jun 2011 07:31:31 +, Jani Nikula j...@nikula.org wrote: Add a pseudo saved search that matches all the mail that no other saved search matches. Add new

[PATCH] Fix folder: coherence issue

Add removal of all ZXFOLDER terms to removal of all XFOLDER terms for each message filename removal. The existing filename-list reindexing will put all the needed terms back in. Test search-folder-coherence now passes. Signed-off-by:Mark Anderson ma.sk...@gmail.com --- Once I fixed the removal

Re: [PATCH v3] test:Improve test behaviors when --root is used

On Tue, 28 Jun 2011 16:03:00 -0700, Carl Worth cwo...@cworth.org wrote: Non-text part: multipart/mixed Non-text part: multipart/signed On Tue, 28 Jun 2011 16:11:32 -0600, Mark Anderson ma.sk...@gmail.com wrote: Change add_email_corpus, emacs_deliver_message and tests to use $TEST_DIRECTORY

Re: notmuch Digest, Vol 20, Issue 57

On Tue, 28 Jun 2011 16:53:30 -0700, Carl Worth cwo...@cworth.org wrote: On Tue, 28 Jun 2011 16:38:30 -0600, Mark Anderson ma.sk...@gmail.com wrote: I had briefly considered adding another output format file, just to get a single file for each message in the db, but the file/files distinction

Re: [PATCH 1/6] test: run emacs inside screen

Dmitry Kurochkin wrote: Before the change, emacs run in daemon mode without any visible buffers. Turns out that this affects emacs behavior in some cases. In particular, `window-end' function returns `point-max' instead of the last visible position. That makes it hard or impossible to

[PATCH] test: revert non-intentional changes introduced in eb4cf465

eb4cf465 introduces changes which weren't part of the submitted patch (id:87liwlip2j@gmail.com), presumably made during resolving merge conflicts. The first one causes the title of a test to be printed a second time, in place of the correct title: PASS Message with .. in Message-Id:

[PATCH 0/2] emacs: User-defined sections in notmuch-hello

Unfortunately the customize-interface for more customized entries in notmuch-hello-sections looks a bit weird, but I couldn't figure out how to get rid of the empty lines produced by generating the lambda expression needed. To avoid unnecessary complexity in the code this patch removes aligning

[PATCH 2/2] emacs: Tests for user-defined sections

--- test/emacs | 37 test/emacs.expected-output/notmuch-hello |3 +- .../notmuch-hello-new-section |4 ++ .../notmuch-hello-no-saved-searches|3 +-

[PATCH 1/2] emacs: User-defined sections in notmuch-hello

This patch makes the notmuch-hello screen fully customizable by allowing the user to add and remove arbitrary sections. It also provides some convenience functions for constructing sections, e.g. showing the unread message count for each tag. This is done by specifying a list of functions that

Re: Preventing the user shooting themself in the foot

On Wed, 29 Jun 2011 20:42:01 +0100, Robin Green gree...@greenrd.org wrote: It's really dangerous to use the 'a' key in notmuch-mode in an inbox thread which has multiple unread replies! Yes, the other unread replies will still be tagged unread, but the user might not immediately be aware of

Re: [PATCH 3/4] emacs: Add pseudo saved search to match mail that no saved search matches

On Wed, 29 Jun 2011 20:15:22 +, Jani Nikula j...@nikula.org wrote: So to clarify, do you prefer having on/off switches, or just enabling this without customization at all? Personally I'd shy away from the latter, but I guess it depends on how useful vs. distracting people find this. My

[PATCH] test: avoid using screen(1) configuration files

Set SCREENRC and SYSSCREENRC environment variables to /dev/null as suggested by Jim Paris to avoid potential problems with screen(1) configuration files. --- test/test-lib.sh |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index

Re: [PATCH 1/6] test: run emacs inside screen

On Wed, 29 Jun 2011 16:16:40 -0400, Jim Paris j...@jtan.com wrote: Dmitry Kurochkin wrote: Before the change, emacs run in daemon mode without any visible buffers. Turns out that this affects emacs behavior in some cases. In particular, `window-end' function returns `point-max' instead

Re: [PATCH 3/4] emacs: Add pseudo saved search to match mail that no saved search matches

On Wed, 29 Jun 2011 13:49:18 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: Non-text part: multipart/signed On Wed, 29 Jun 2011 20:15:22 +, Jani Nikula j...@nikula.org wrote: So to clarify, do you prefer having on/off switches, or just enabling this without customization

Re: notmuch Digest, Vol 20, Issue 57

On Wed, 29 Jun 2011 13:54:40 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: On Wed, 29 Jun 2011 14:21:11 -0600, Mark Anderson ma.sk...@gmail.com wrote: I personally prefer --output=files remain as it was, with one file per mail (even though I submitted the patch to change

Re: [PATCH 1/2] new: Don't update DB mtime if FS mtime equals wall-clock time.

On Wed, 29 Jun 2011 03:10:54 -0400, Austin Clements amdra...@mit.edu wrote: This fixes a race where multiple message deliveries in the same second with an intervening notmuch new could result in messages being ignored by notmuch (at least, until a later delivery forced a rescan). Excellent

Re: [PATCH] lib/Makefile.local: remove leftover debugging output.

On Wed, 29 Jun 2011 07:42:02 -0300, da...@tethera.net wrote: From: David Bremner brem...@debian.org The removed echo $(libnotmuch_modules) was strictly for debugging. Merged, thanks. -Carl -- carl.d.wo...@intel.com pgpbjPw7WN56c.pgp Description: PGP signature

Re: [PATCH] test: document test_expect_equal_file

On Wed, 29 Jun 2011 10:06:32 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: This test was not properly documented when it was originally added (my bad). Thanks. Merged! -Carl -- carl.d.wo...@intel.com pgpbz7TFngMlS.pgp Description: PGP signature

Re: Preventing the user shooting themself in the foot

On Wed, 29 Jun 2011 20:42:01 +0100, Robin Green gree...@greenrd.org wrote: It's really dangerous to use the 'a' key in notmuch-mode in an inbox thread which has multiple unread replies! Yes, the other unread replies will still be tagged unread, but the user might not immediately be aware of

[PATCH] new: Improved workaround for mistaken new directories

Currently, notmuch new assumes any directory with a database mtime of 0 is new, but we don't set the mtime until after processing messages and subdirectories in that directory. Hence, anything that prevents the mtime update (such as an interruption or the wall-clock logic introduced in 8c39e8d6)

Re: [PATCH] new: Improved workaround for mistaken new directories

On Wed, 29 Jun 2011 19:00:01 -0400, Austin Clements amdra...@mit.edu wrote: We work around this by setting the new directory's database mtime to -1 before scanning anything in the new directory. This also obviates the need for the workaround used in 8c39e8d6. Thanks. This is pushed. +/*

Re: Preventing the user shooting themself in the foot

On 30 June 2011 08:40, Carl Worth cwo...@cworth.org wrote: The 'a' keybinding, (in turn), was designed for cases when you *know* you don't want to read the rest of the thread. ... in which case it should also mark everything as read. IMHO. Are there any keyboard bindings to go forwards to the