Preventing the user shooting themself in the foot

On Thu, 30 Jun 2011, Sebastian Spaeth wrote: > It works perfectly for me. Adding another key for "only archive this > message" would be fine. Do people actually use the "x" keybinding? I > know I don't. I use 'x' a lot when I read a high-traffic mailing list and only want to read threads with

[python] missing notmuch_database_needs_upgrade

): """Upgrades the current database cheers, /p -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments

[PROTO] possible solution for "Race condition for '*' command"

On Mon, 04 Jul 2011 13:56:26 -0400, Austin Clements wrote: Non-text part: multipart/alternative > Ah, this is subtler than I thought. You're right that, for the '*' > command, you want only the matched ID's. Tagging a region, however, > operates on entire threads. I think it's important to

Dangerous space bar key (was: Preventing the user shooting themself in the foot)

sage)) ))) Notice I also made it so that this does not exit the current thread view. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110704/37570c25/attachment-0001.pgp>

notmuch 0.6: notmuch new dies with std::terminate

On Mon, 04 Jul 2011 09:20:25 -0300, David Bremner wrote: > On Mon, 04 Jul 2011 11:58:24 +0100, Robin Green > wrote: > > Some time after upgrading to notmuch 0.6, notmuch new suddenly started > > failing, with this backtrace: (this is on DragonFly BSD) > > > > Program terminated with signal 6,

[PROTO] possible solution for "Race condition for '*' command"

-- Pieter -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110704/9ca75884/attachment.html>

[PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 04 Jul 2011 10:55:21 +0200, Pieter Praet wrote: > On Mon, 4 Jul 2011 12:27:04 +0400, Dmitry Kurochkin gmail.com> wrote: > > It is very convenient when C-e (bound to `widget-end-of-line') ignores > > trailing spaces inside the search widget. But it only does so if a > > widget is not

[PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

It is very convenient when C-e (bound to `widget-end-of-line') ignores trailing spaces inside the search widget. But it only does so if a widget is not followed by a newline (that is why it works in the saved search widgets). The patch just adds an insisible space after the search widget to get

[PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 04 Jul 2011 13:08:43 +0400, Dmitry Kurochkin wrote: > On Mon, 04 Jul 2011 10:55:21 +0200, Pieter Praet wrote: > > On Mon, 4 Jul 2011 12:27:04 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > It is very convenient when C-e (bound to `widget-end-of-line') ignores > > > trailing spaces

[PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 4 Jul 2011 12:27:04 +0400, Dmitry Kurochkin wrote: > It is very convenient when C-e (bound to `widget-end-of-line') ignores > trailing spaces inside the search widget. But it only does so if a > widget is not followed by a newline (that is why it works in the saved > search widgets).

[PATCH] emacs: add insisible space after the search widget field in notmuch-hello

It is very convenient when C-e (bound to `widget-end-of-line') ignores trailing spaces inside the search widget. But it only does so if a widget is not followed by a newline (that is why it works in the saved search widgets). The patch just adds an insisible space after the search widget to get

[PATCH 2/2] emacs: skip forward to visible text in notmuch-show-message-extent

On Sun, 3 Jul 2011 08:28:06 +0400, Dmitry Kurochkin wrote: > The patch rewrites `notmuch-show-message-extent' to be more > robust. The main goal is to make it work as expected if point is > invisible. Besides, there are no more point movements and > property search functions are used instead

[PATCH] emacs: add insisible space after the search widget field in notmuch-hello

> Besides, nobody commented on it except a noob like myself. > > Just by keeping half an eye on all that gets merged, imagining what > a maintainer's job must be like sends shivers down my spine. ^ The following was sent in true top-posting style, for your personal bewilderment. Please stand

[PATCH] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 04 Jul 2011 11:37:06 +0400, Dmitry Kurochkin wrote: > On Mon, 04 Jul 2011 09:24:17 +0200, Pieter Praet wrote: > > On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > It is very convenient when C-e (bound to `widget-end-of-line') ignores > > > trailing spaces

[PATCH] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin wrote: > It is very convenient when C-e (bound to `widget-end-of-line') ignores > trailing spaces inside the search widget. But it only does so if a > widget is not followed by a newline (that is why it works in the saved > search widgets).

notmuch 0.6: notmuch new dies with std::terminate

On Mon, 04 Jul 2011 11:58:24 +0100, Robin Green wrote: > Some time after upgrading to notmuch 0.6, notmuch new suddenly started > failing, with this backtrace: (this is on DragonFly BSD) > > Program terminated with signal 6, Aborted. [...] > #3 0x00080150c9c1 in

[PATCH 6/6] build-system: guard parts irrevokable parts of release target with REALLY_UPLOAD

From: David Bremner This supports both testing and use by non-upload privileged users. Along with previous commits in the series, this lets one do a dry run of the release process and created a tarball, signature file, and release announcement to inspect before uploading. ---

[PATCH 5/6] build-system: Use existing signed tag for release, if present.

From: David Bremner This is to support testing the release machinery without jumping through hoops to delete and restore a tag, or bumping the version number in both version and debian/changelog. --- Makefile.local |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 4/6] build-system: use signed tag to make tar file, if available.

From: David Bremner This as the advantage that "make VERSION=n.m dist" will work correctly even if the wrong branch happens to be checked out. --- Makefile.local |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local

[PATCH 3/6] build-system: tag earlier in the release process.

From: David Bremner If tagging fails, we really don't want to upload tarballs. --- Makefile.local |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local index dea813c..b6445e5 100644 --- a/Makefile.local +++ b/Makefile.local

[PATCH 2/6] build-system: remove calls to git-buildpackage and dput in release target.

From: David Bremner The removed code had the following issues: - It depends on the users git-buildpackage configuration to put the results in the correct place, so is fragile. - The tar file is overwritten in the next step, so copying it is not useful. - We should build

[PATCH 1/6] build-system: replace use of ssh with wget for checking the website

From: David Bremner The idea is to see if the version we are already releasing exists on the notmuch website. Using wget allows more people to run this target, and also allows people with ssh access to run it without access to their keys. --- Makefile.local | 15

[PATCH 5/5] emacs: make `notmuch-search-operate-all' use matched-msgids instead of the original query string

Signed-off-by: Pieter Praet --- emacs/notmuch.el |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 46e276a..0d040a2 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -869,7 +869,10 @@ Each character of the tag name may

[PATCH 4/5] test: emacs: add/remove tags from all matching messages with `notmuch-search-operate-all'

Signed-off-by: Pieter Praet --- test/emacs-search-operate-all | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) create mode 100755 test/emacs-search-operate-all diff --git a/test/emacs-search-operate-all b/test/emacs-search-operate-all new file mode 100755

[PATCH 3/5] emacs: stashing (a region of) matched-msgids

Signed-off-by: Pieter Praet --- emacs/notmuch.el | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 2338044..46e276a 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -226,6 +226,7 @@ For a mouse binding, return

[PATCH 2/5] emacs: add some functions to fetch the matched-msgids of a (region of) search result(s)

Signed-off-by: Pieter Praet --- emacs/notmuch.el |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 674deb7..2338044 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -402,6 +402,14 @@ Complete list of currently

[PATCH 1/5] emacs: add property "matched-msgids" to each search result

Signed-off-by: Pieter Praet --- emacs/notmuch.el |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index f11ec24..674deb7 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -801,13 +801,14 @@ non-authors is found, assume that all

[PROTO] possible solution for "Race condition for '*' command"

Thanks Austin! Unfortunately, your patch causes *all* Message-Id's in the thread to be appended, as opposed to only the ones matching the query: #+BEGIN_EXAMPLE $ notmuch search tag:inbox AND from:amdragon at mit.edu thread:2777 Yest. 19:17 [1/3] Austin Clements| Pieter Praet; [PATCH

[PATCH v2 2/3] test: improve known broken tests support

There is existing support for broken tests. But it is not convenient to use. The primary issue is that we have to maintain a set of test_expect_*_failure functions which are equivalent to the normal test_expect_* counterparts except for what functions are called for result reporting. The patch

[PATCH v2 1/3] test: update documentation for test_emacs in test/README

Update test_emacs documentation in test/README according to the latest changes in emacs tests. Move the note regarding setting variables from test/emacs to test/README. --- test/README | 10 +++--- test/emacs |5 - 2 files changed, 7 insertions(+), 8 deletions(-) diff --git

[PATCH v2 0/3] improved broken tests support and test for a bug

This version implements suggestions by Austin. Regards, Dmitry

[PATCH 2/3] test: improve known broken tests support

On Sun, 3 Jul 2011 23:42:13 -0400, Austin Clements wrote: > Great idea! > > Just a heads-up, this will conflict with the first two patches in the > atomicity series (though git may not detect the second conflict). > Both are trivial patches, though, so the merge should be easy. > Oh. I hope

[PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Human-friendly scenario: * open a thread where a message which ends with an HTML part is followed by another message * make the first message visible * goto the beginning of the second message (first line, first colon) * hit "RET" Result: nothing happens except for "No URL at point" message

[PATCH 2/3] test: improve known broken tests support

There is existing support for broken tests. But it is not convenient to use. The primary issue is that we have to maintain a set of test_expect_*_failure functions which are equivalent to the normal test_expect_* counterparts except for what functions are called for result reporting. The patch

[PATCH 1/3] test: update documentation for test_emacs in test/README

Update test_emacs documentation in test/README according to the latest changes in emacs tests. Move the note regarding setting variables from test/emacs to test/README. --- test/README | 10 +++--- test/emacs |5 - 2 files changed, 7 insertions(+), 8 deletions(-) diff --git

[PATCH 2/3] test: improve known broken tests support

Great idea! Just a heads-up, this will conflict with the first two patches in the atomicity series (though git may not detect the second conflict). Both are trivial patches, though, so the merge should be easy. Three minor comments below. On Sun, Jul 3, 2011 at 9:59 PM, Dmitry Kurochkin wrote:

[PROTO] possible solution for Race condition for '*' command

Thanks Austin! Unfortunately, your patch causes *all* Message-Id's in the thread to be appended, as opposed to only the ones matching the query: #+BEGIN_EXAMPLE $ notmuch search tag:inbox AND from:amdra...@mit.edu thread:2777 Yest. 19:17 [1/3] Austin Clements| Pieter Praet; [PATCH

[PATCH 1/5] emacs: add property matched-msgids to each search result

Signed-off-by: Pieter Praet pie...@praet.org --- emacs/notmuch.el |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index f11ec24..674deb7 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -801,13 +801,14 @@ non-authors is found,

[PATCH 3/5] emacs: stashing (a region of) matched-msgids

Signed-off-by: Pieter Praet pie...@praet.org --- emacs/notmuch.el | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 2338044..46e276a 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -226,6 +226,7 @@ For a mouse

[PATCH 4/5] test: emacs: add/remove tags from all matching messages with `notmuch-search-operate-all'

Signed-off-by: Pieter Praet pie...@praet.org --- test/emacs-search-operate-all | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) create mode 100755 test/emacs-search-operate-all diff --git a/test/emacs-search-operate-all b/test/emacs-search-operate-all new

[PATCH 5/5] emacs: make `notmuch-search-operate-all' use matched-msgids instead of the original query string

Signed-off-by: Pieter Praet pie...@praet.org --- emacs/notmuch.el |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 46e276a..0d040a2 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -869,7 +869,10 @@ Each character of

Re: [PATCH] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: It is very convenient when C-e (bound to `widget-end-of-line') ignores trailing spaces inside the search widget. But it only does so if a widget is not followed by a newline (that is why it works in the

Re: [PATCH] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 04 Jul 2011 09:24:17 +0200, Pieter Praet pie...@praet.org wrote: On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: It is very convenient when C-e (bound to `widget-end-of-line') ignores trailing spaces inside the search widget. But it only does

Re: [PATCH] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 04 Jul 2011 11:37:06 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Mon, 04 Jul 2011 09:24:17 +0200, Pieter Praet pie...@praet.org wrote: On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: It is very convenient when C-e (bound to

Re: [PATCH] emacs: add insisible space after the search widget field in notmuch-hello

Besides, nobody commented on it except a noob like myself. Just by keeping half an eye on all that gets merged, imagining what a maintainer's job must be like sends shivers down my spine. ^ The following was sent in true top-posting style, for your personal bewilderment. Please stand on

Re: [PATCH 2/2] emacs: skip forward to visible text in notmuch-show-message-extent

On Sun, 3 Jul 2011 08:28:06 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: The patch rewrites `notmuch-show-message-extent' to be more robust. The main goal is to make it work as expected if point is invisible. Besides, there are no more point movements and property search

[PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

It is very convenient when C-e (bound to `widget-end-of-line') ignores trailing spaces inside the search widget. But it only does so if a widget is not followed by a newline (that is why it works in the saved search widgets). The patch just adds an insisible space after the search widget to get

Re: [PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 04 Jul 2011 10:55:21 +0200, Pieter Praet pie...@praet.org wrote: On Mon, 4 Jul 2011 12:27:04 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: It is very convenient when C-e (bound to `widget-end-of-line') ignores trailing spaces inside the search widget. But it only does

Re: [PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 04 Jul 2011 13:08:43 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Mon, 04 Jul 2011 10:55:21 +0200, Pieter Praet pie...@praet.org wrote: On Mon, 4 Jul 2011 12:27:04 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: It is very convenient when C-e (bound to

notmuch 0.6: notmuch new dies with std::terminate

Some time after upgrading to notmuch 0.6, notmuch new suddenly started failing, with this backtrace: (this is on DragonFly BSD) Program terminated with signal 6, Aborted. #0 0x0008017bde18 in kill () from /usr/lib/libc.so.7 (gdb) bt #0 0x0008017bde18 in kill () from /usr/lib/libc.so.7

Proposed changes to release target

When pushing 0.6 out the door, I found the release target in Makefile daunting. This was partly lack of confidence/understanding on my part: I didn't really like the idea of starting a chain of events that I didn't fully understand that ended up copying files to the web site. Also, it didn't

[PATCH 1/6] build-system: replace use of ssh with wget for checking the website

From: David Bremner brem...@debian.org The idea is to see if the version we are already releasing exists on the notmuch website. Using wget allows more people to run this target, and also allows people with ssh access to run it without access to their keys. --- Makefile.local | 15

[PATCH 3/6] build-system: tag earlier in the release process.

From: David Bremner brem...@debian.org If tagging fails, we really don't want to upload tarballs. --- Makefile.local |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local index dea813c..b6445e5 100644 --- a/Makefile.local +++ b/Makefile.local

[PATCH 6/6] build-system: guard parts irrevokable parts of release target with REALLY_UPLOAD

From: David Bremner brem...@debian.org This supports both testing and use by non-upload privileged users. Along with previous commits in the series, this lets one do a dry run of the release process and created a tarball, signature file, and release announcement to inspect before uploading. ---

[PATCH 4/6] build-system: use signed tag to make tar file, if available.

From: David Bremner brem...@debian.org This as the advantage that make VERSION=n.m dist will work correctly even if the wrong branch happens to be checked out. --- Makefile.local |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local index

[PATCH 2/6] build-system: remove calls to git-buildpackage and dput in release target.

From: David Bremner brem...@debian.org The removed code had the following issues: - It depends on the users git-buildpackage configuration to put the results in the correct place, so is fragile. - The tar file is overwritten in the next step, so copying it is not useful. - We should build

Re: notmuch 0.6: notmuch new dies with std::terminate

On Mon, 04 Jul 2011 11:58:24 +0100, Robin Green gree...@greenrd.org wrote: Some time after upgrading to notmuch 0.6, notmuch new suddenly started failing, with this backtrace: (this is on DragonFly BSD) Program terminated with signal 6, Aborted. [...] #3 0x00080150c9c1 in

Re: notmuch 0.6: notmuch new dies with std::terminate

On Mon, 04 Jul 2011 09:20:25 -0300, David Bremner da...@tethera.net wrote: On Mon, 04 Jul 2011 11:58:24 +0100, Robin Green gree...@greenrd.org wrote: Some time after upgrading to notmuch 0.6, notmuch new suddenly started failing, with this backtrace: (this is on DragonFly BSD) Program

Re: [PROTO] possible solution for Race condition for '*' command

Ah, this is subtler than I thought. You're right that, for the '*' command, you want only the matched ID's. Tagging a region, however, operates on entire threads. I think it's important to retain this behavior because threads are what the user sees and selects in the search buffer (*, on the

Re: [PROTO] possible solution for Race condition for '*' command

On Mon, 04 Jul 2011 13:56:26 -0400, Austin Clements amdra...@mit.edu wrote: Non-text part: multipart/alternative Ah, this is subtler than I thought. You're right that, for the '*' command, you want only the matched ID's. Tagging a region, however, operates on entire threads. I think it's

Re: Preventing the user shooting themself in the foot

On Thu, 30 Jun 2011, Sebastian Spaeth wrote: It works perfectly for me. Adding another key for only archive this message would be fine. Do people actually use the x keybinding? I know I don't. I use 'x' a lot when I read a high-traffic mailing list and only want to read threads with

[python] missing notmuch_database_needs_upgrade

Hiya, As mentioned shortly on the irc channel, notmuch python bindings seem to be missing 'notmuch_database_needs_upgrade' as Database().needs_upgrade() confirms. This seems to be due to a typo.. index 5deb2a5..648f61a 100644 --- a/bindings/python/notmuch/database.py +++

Dangerous space bar key (was: Preventing the user shooting themself in the foot)

On Wed, 29 Jun 2011 20:42:01 +0100, Robin Green gree...@greenrd.org wrote: It's really dangerous to use the 'a' key in notmuch-mode in an inbox thread which has multiple unread replies! Yes, the other unread replies will still be tagged unread, but the user might not immediately be aware of

Re: [PATCH 0/2] emacs: User-defined sections in notmuch-hello

On Wed, 29 Jun 2011, Daniel Schoepe wrote: Unfortunately the customize-interface for more customized entries in notmuch-hello-sections looks a bit weird, but I couldn't figure out how to get rid of the empty lines produced by generating the lambda expression needed. Hi Daniel, this looks

Re: Dangerous space bar key (was: Preventing the user shooting themself in the foot)

On Mon, 04 Jul 2011 23:36:35 +0200, Matthieu Lemerre ra...@free.fr wrote: I like to use the space (and sometimes the backspace key) to read threads back and forth, but sometimes I might read stuff to quickly and archive a thread without wanting it. It is then complex to find it back