Memory management practices

2011-09-07 Thread Austin Clements
On Wed, Sep 7, 2011 at 10:48 PM, Austin Clements wrote: > *snip* > > I'm a bit confused by the reference tree you drew. ?The references in > the underlying libnotmuch objects are the other way around. > notmuch_query_t holds a talloc reference to every notmuch_messages_t > it produces, not the oth

Memory management practices

2011-09-07 Thread Austin Clements
On Wed, Sep 7, 2011 at 4:36 PM, Ben Gamari wrote: > On Mon, 29 Aug 2011 16:30:57 -0400, Ben Gamari > wrote: >> [SNIP] >> >> In general, it seems to me that memory management in notmuch bindings is >> a little bit harder than it needs to me due to the decision not to >> talloc_ref parent objects

Patch: Flush and Reopen

2011-09-07 Thread Martin Owens
h-and-reopen-methods-to-the-libnotmuch-and-t.patch Type: text/x-patch Size: 6898 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110907/da43f3a8/attachment-0001.bin>

Re: Memory management practices

2011-09-07 Thread Austin Clements
On Wed, Sep 7, 2011 at 10:48 PM, Austin Clements wrote: > *snip* > > I'm a bit confused by the reference tree you drew.  The references in > the underlying libnotmuch objects are the other way around. > notmuch_query_t holds a talloc reference to every notmuch_messages_t > it produces, not the oth

Re: Memory management practices

2011-09-07 Thread Austin Clements
On Wed, Sep 7, 2011 at 4:36 PM, Ben Gamari wrote: > On Mon, 29 Aug 2011 16:30:57 -0400, Ben Gamari wrote: >> [SNIP] >> >> In general, it seems to me that memory management in notmuch bindings is >> a little bit harder than it needs to me due to the decision not to >> talloc_ref parent objects whe

[PATCH] Do not attept to output part raw if part is not GMimePart.

2011-09-07 Thread David Bremner
On Tue, 06 Sep 2011 15:51:42 -0700, Jameson Graef Rollins wrote: > Everyone that I know of who has tried to reproduce this bug has been > able to. I vote that we include this patch in 0.8, so that we can get > it out of the way. I have pushed this to master. Sorry, I still don't plan to include

RFC/PATCH emacs attachment handling

2011-09-07 Thread Matthieu Lemerre
> Finally, I have also mapped the key "o" (other/open with) on a button to > open with user chosen program. This could be split out into a separate > patch if preferred. This is great! In particular many people send PDF attachments to me with mime-type attachment/octet-stream, and notmuch could n

RFC/PATCH emacs attachment handling

2011-09-07 Thread Xavier Maillard
Hello Tomi, On Wed, 07 Sep 2011 10:06:36 +0300, Tomi Ollila wrote: > On Wed 07 Sep 2011 04:20, Mark Walters writes: > > > Hello > > > > I have modified the emacs interface for handling attachments by adding > > a keymap to the attachment button. For example pressing v when on an > > attachment

SlackBuild package for notmuch 0.7

2011-09-07 Thread Xavier Maillard
Hi, On Sun, 04 Sep 2011 19:15:56 +0200, Jostein Berntsen wrote: > > I have made a SlackBuild package for notmuch version 0.7 that makes it > easy to install it the correct way in Slackware 13.37: Thank you very much Jostein ! -- X=M=A

Memory management practices

2011-09-07 Thread Ben Gamari
On Mon, 29 Aug 2011 16:30:57 -0400, Ben Gamari wrote: > [SNIP] > > In general, it seems to me that memory management in notmuch bindings is > a little bit harder than it needs to me due to the decision not to > talloc_ref parent objects when a new child object is created. This means > that a bin

Re: [PATCH] Do not attept to output part raw if part is not GMimePart.

2011-09-07 Thread Jameson Graef Rollins
On Wed, 07 Sep 2011 18:46:10 -0300, David Bremner wrote: > I have pushed this to master. Sorry, I still don't plan to include it in > 0.8. I think it is better to have a short strict freeze, than a long > friendly one. Ok, thanks. Just as long as I don't have to push to get this fix applied any

[PATCH] Do not attept to output part raw if part is not GMimePart.

2011-09-07 Thread Jameson Graef Rollins
On Wed, 07 Sep 2011 18:46:10 -0300, David Bremner wrote: > I have pushed this to master. Sorry, I still don't plan to include it in > 0.8. I think it is better to have a short strict freeze, than a long > friendly one. Ok, thanks. Just as long as I don't have to push to get this fix applied any

Re: [PATCH] Do not attept to output part raw if part is not GMimePart.

2011-09-07 Thread David Bremner
On Tue, 06 Sep 2011 15:51:42 -0700, Jameson Graef Rollins wrote: > Everyone that I know of who has tried to reproduce this bug has been > able to. I vote that we include this patch in 0.8, so that we can get > it out of the way. I have pushed this to master. Sorry, I still don't plan to includ

Re: RFC/PATCH emacs attachment handling

2011-09-07 Thread Xavier Maillard
Hello Tomi, On Wed, 07 Sep 2011 10:06:36 +0300, Tomi Ollila wrote: > On Wed 07 Sep 2011 04:20, Mark Walters writes: > > > Hello > > > > I have modified the emacs interface for handling attachments by adding > > a keymap to the attachment button. For example pressing v when on an > > attachment

Re: SlackBuild package for notmuch 0.7

2011-09-07 Thread Xavier Maillard
Hi, On Sun, 04 Sep 2011 19:15:56 +0200, Jostein Berntsen wrote: > > I have made a SlackBuild package for notmuch version 0.7 that makes it > easy to install it the correct way in Slackware 13.37: Thank you very much Jostein ! -- X=M=A ___ notmuch m

[PATCH v2 5/7] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive

2011-09-07 Thread Dmitry Kurochkin
On Wed, 07 Sep 2011 09:13:22 +, Jani Nikula wrote: > On Fri, 1 Jul 2011 08:55:20 +0400, Dmitry Kurochkin gmail.com> wrote: > > Use `previous-single-char-property-change' instead of going > > through each character by hand and testing it's visibility. This > > fixes `notmuch-show-advance-and

Re: Memory management practices

2011-09-07 Thread Ben Gamari
On Mon, 29 Aug 2011 16:30:57 -0400, Ben Gamari wrote: > [SNIP] > > In general, it seems to me that memory management in notmuch bindings is > a little bit harder than it needs to me due to the decision not to > talloc_ref parent objects when a new child object is created. This means > that a bind

RFC/PATCH emacs attachment handling

2011-09-07 Thread Tomi Ollila
On Wed 07 Sep 2011 04:20, Mark Walters writes: > Hello > > I have modified the emacs interface for handling attachments by adding > a keymap to the attachment button. For example pressing v when on an > attachment button views the attachment (using the mailcap method) and > pressing s saves the a

[PATCH v2 0/2] sort saved searches, again

2011-09-07 Thread Adam Wolfe Gordon
(Sorry if anyone gets this twice; I sent it to the list initially from the wrong email address.) On Wed, Sep 7, 2011 at 02:01, Jani Nikula wrote: > On Tue, 6 Sep 2011 08:23:43 -0700 (PDT), Adam Wolfe Gordon xvx.ca> wrote: >> I think having an option to sort the saved searches is a fine idea. >>

[PATCH v2 5/7] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive

2011-09-07 Thread Jani Nikula
On Fri, 1 Jul 2011 08:55:20 +0400, Dmitry Kurochkin wrote: > Use `previous-single-char-property-change' instead of going > through each character by hand and testing it's visibility. This > fixes `notmuch-show-advance-and-archive' to work for the last > message in thread with hidden signature.

Re: [PATCH v2 0/2] sort saved searches, again

2011-09-07 Thread Adam Wolfe Gordon
(Sorry if anyone gets this twice; I sent it to the list initially from the wrong email address.) On Wed, Sep 7, 2011 at 02:01, Jani Nikula wrote: > On Tue, 6 Sep 2011 08:23:43 -0700 (PDT), Adam Wolfe Gordon > wrote: >> I think having an option to sort the saved searches is a fine idea. >> The E

[PATCH 2/2] emacs: Fix notmuch-mua-user-agent defcustom

2011-09-07 Thread Jani Nikula
The :options keyword is not meaningful for function type. Also, it was not possible to enter nil value, contrary to the notmuch-mua-user-agent defcustom documentation. Specify the alternatives using choice type, taking nil into account. Signed-off-by: Jani Nikula --- emacs/notmuch-mua.el | 10

[PATCH 1/2] emacs: Fix notmuch-hello-tag-list-make-query defcustom

2011-09-07 Thread Jani Nikula
It was not possible to define custom filters or filter functions because the types were const. Remove const to allow editing. Signed-off-by: Jani Nikula --- emacs/notmuch-hello.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-h

[PATCH v2 2/2] emacs: Make saving new saved searches append, not prepend

2011-09-07 Thread Jani Nikula
Append new saved searches at the end of saved searches rather than insert in front. Signed-off-by: Jani Nikula --- emacs/notmuch-hello.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 6c8e265..dc34ebe 100644 ---

[PATCH v2 1/2] emacs: Add new customization option to sort saved searches

2011-09-07 Thread Jani Nikula
Add new customization option notmuch-saved-search-sort-function to sort saved searches in user-defined order. Provide a sort function to sort the saved searches in alphabetical order. Setting the search function to nil causes the saved searches not to be sorted, as before. This also remains the def

[PATCH v2 0/2] sort saved searches, again

2011-09-07 Thread Jani Nikula
Hi, and thanks for all the comments - [I took the liberty of reordering Adam's paragraphs in my reply.] On Tue, 6 Sep 2011 08:23:43 -0700 (PDT), Adam Wolfe Gordon wrote: > I think having an option to sort the saved searches is a fine idea. > The Emacs Way would probably be to have an option fo

Re: [PATCH v2 5/7] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive

2011-09-07 Thread Dmitry Kurochkin
On Wed, 07 Sep 2011 09:13:22 +, Jani Nikula wrote: > On Fri, 1 Jul 2011 08:55:20 +0400, Dmitry Kurochkin > wrote: > > Use `previous-single-char-property-change' instead of going > > through each character by hand and testing it's visibility. This > > fixes `notmuch-show-advance-and-archive

RFC/PATCH emacs attachment handling

2011-09-07 Thread Mark Walters
Hello I have modified the emacs interface for handling attachments by adding a keymap to the attachment button. For example pressing v when on an attachment button views the attachment (using the mailcap method) and pressing s saves the attachment. I find this makes it a lot easier when dealing w

Re: [PATCH v2 5/7] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive

2011-09-07 Thread Jani Nikula
On Fri, 1 Jul 2011 08:55:20 +0400, Dmitry Kurochkin wrote: > Use `previous-single-char-property-change' instead of going > through each character by hand and testing it's visibility. This > fixes `notmuch-show-advance-and-archive' to work for the last > message in thread with hidden signature.

[PATCH 2/2] emacs: Fix notmuch-mua-user-agent defcustom

2011-09-07 Thread Jani Nikula
The :options keyword is not meaningful for function type. Also, it was not possible to enter nil value, contrary to the notmuch-mua-user-agent defcustom documentation. Specify the alternatives using choice type, taking nil into account. Signed-off-by: Jani Nikula --- emacs/notmuch-mua.el | 10

[PATCH 1/2] emacs: Fix notmuch-hello-tag-list-make-query defcustom

2011-09-07 Thread Jani Nikula
It was not possible to define custom filters or filter functions because the types were const. Remove const to allow editing. Signed-off-by: Jani Nikula --- emacs/notmuch-hello.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-h

Not much database creation error

2011-09-07 Thread Martin Owens
Thanks Sebastian, I'll test it as soon as I can. As a further question, I have a program opening the database for READ_WRITE access (this process provides a simple write only dbus interface) and I want clients to connect to notmuch over a read only connection. A problem I'm having is that when I

[PATCH v2 2/2] emacs: Make saving new saved searches append, not prepend

2011-09-07 Thread Jani Nikula
Append new saved searches at the end of saved searches rather than insert in front. Signed-off-by: Jani Nikula --- emacs/notmuch-hello.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 6c8e265..dc34ebe 100644 ---

[PATCH v2 1/2] emacs: Add new customization option to sort saved searches

2011-09-07 Thread Jani Nikula
Add new customization option notmuch-saved-search-sort-function to sort saved searches in user-defined order. Provide a sort function to sort the saved searches in alphabetical order. Setting the search function to nil causes the saved searches not to be sorted, as before. This also remains the def

[PATCH v2 0/2] sort saved searches, again

2011-09-07 Thread Jani Nikula
Hi, and thanks for all the comments - [I took the liberty of reordering Adam's paragraphs in my reply.] On Tue, 6 Sep 2011 08:23:43 -0700 (PDT), Adam Wolfe Gordon wrote: > I think having an option to sort the saved searches is a fine idea. > The Emacs Way would probably be to have an option f

Re: RFC/PATCH emacs attachment handling

2011-09-07 Thread Tomi Ollila
On Wed 07 Sep 2011 04:20, Mark Walters writes: > Hello > > I have modified the emacs interface for handling attachments by adding > a keymap to the attachment button. For example pressing v when on an > attachment button views the attachment (using the mailcap method) and > pressing s saves the a