[PATCH] lib: make find_message{,by_filename) report errors

On Sat, 1 Oct 2011 11:12:23 +0300, Ali Polatel wrote: > From: Ali Polatel > > Looks like the patch did not make it correctly the first time. > Resending using git-send-email? > > You may also find the commit in my notmuch repository: > git://github.com/alip/notmuch.git branch: find_message

[PATCH v1 1/1] lib: make find_message{,by_filename) report errors

Previously, the functions notmuch_database_find_message() and notmuch_database_find_message_by_filename() functions did not properly report error condition to the library user. For more information, read the thread on the notmuch mailing list starting with my mail "id:871uv2unfd.fsf at gmail.com"

[PATCH v1 0/1] lib: make find_message{,by_filename) report errors

Here is an updated patch fixing style issues addressed by amdragon on IRC. I plan to submit a patch documenting how to configure VIM to code using notmuch's style guidelines as well. You may also find the commit in my notmuch repository: git://github.com/alip/notmuch.git branch: find_message-v1

[PATCH 13/13] test: make smtp-dummy work with Emacs 24

In Emacs 24, a space is expected after a SMTP response code. If we don't respect that, smtpmail-send-it will wait forever. --- test/smtp-dummy.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/smtp-dummy.c b/test/smtp-dummy.c index 9da8202..021af11 100644 ---

[PATCH 12/13] emacs: remove unused `point-invisible-p' function

From: Dmitry Kurochkin `point-invisible-p' does not work correctly when `invisible' property is a list. There are standard `invisible-p' and related functions that should be used instead. --- emacs/notmuch-lib.el | 15 --- 1 files changed, 0

[PATCH 11/13] emacs: remove no longer used functions from notmuch-show.el

From: Dmitry Kurochkin Remove `notmuch-show-move-past-invisible-backward' and `notmuch-show-move-past-invisible-forward' functions which are unused. --- emacs/notmuch-show.el |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git

[PATCH 10/13] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive

From: Dmitry Kurochkin Use `previous-single-char-property-change' instead of going through each character by hand and testing it's visibility. This fixes `notmuch-show-advance-and-archive' to work for the last message in thread with hidden signature. ---

[PATCH 09/13] test: `notmuch-show-advance-and-archive' with invisible signature

From: Dmitry Kurochkin Add Emacs test to check that `notmuch-show-advance-and-archive' works for the last message in thread with invisible signature. --- test/emacs | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/test/emacs

[PATCH 08/13] test: do not set frame width in emacs

From: Dmitry Kurochkin No need for `set-frame-width' in emacs tests since it runs in screen now. --- test/test-lib.el |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/test/test-lib.el b/test/test-lib.el index a783936..97ae593 100644 ---

[PATCH 07/13] test: avoid using screen(1) configuration files

From: Dmitry Kurochkin Set SCREENRC and SYSSCREENRC environment variables to "/dev/null" as suggested by Jim Paris to avoid potential problems with screen(1) configuration files. --- test/test-lib.sh |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

[PATCH 06/13] test: run emacs inside screen

From: Dmitry Kurochkin Before the change, emacs run in daemon mode without any visible buffers. Turns out that this affects emacs behavior in some cases. In particular, `window-end' function returns `point-max' instead of the last visible position. That makes it

[PATCH 05/13] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests

From: Pieter Praet Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet --- test/emacs-large-search-buffer |

[PATCH 04/13] test: add 'Emacs' prereq to dependent 'emacs' tests

From: Pieter Praet Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet --- test/emacs | 71

[PATCH 03/13] test: add 'Emacs' prereq to dependent 'crypto' tests

From: Pieter Praet Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Right now, all crypto tests do depend on Emacs, because it is used

[PATCH 02/13] test: add 'GnuPG' prereq to dependent 'crypto' tests

From: Pieter Praet Adds a new test that checks for the presence of 'gpg', and adds that test as a prereq to all subsequent tests that rely on GnuPG. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet --- test/crypto | 35

[PATCH 01/13] test: define a helper function for defining prereqs on executables

While test_expect_success could be used to define these prereqs, this is probably not a good idea: if a prereq is not available, using test_expect_success would result in a test being reported as FAILED at the end of the test suite (and its dependencies as skipped). On the contrary, when using

[PATCH 00/13] Test prereqs and screen-based Emacs tests

Here it is: a rebased version of Pieter's patch series adding prereqs for the emacs and crypto tests [1], and Dmitry's patches for running emacs inside screen in the test suite [2]. (Please note that this one also includes fixes to improve hidden signatures handling in

[PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Hi Thomas. On Mon, 03 Oct 2011 14:39:36 +0200, Thomas Jost wrote: > On Sun, 02 Oct 2011 05:45:53 +0400, Dmitry Kurochkin gmail.com> wrote: > > BTW there were patches to support tmux (or maybe it was dtach). IIRC > > the consensus was that supporting it does not worth complicating test > >

[PATCH v2 0/2] Better error handling

LGTM. Quoth Ali Polatel on Oct 03 at 11:40 pm: > From: Ali Polatel > > New set of patches addressing the issues in the mail > "id:20111003174308.GD17905 at mit.edu" > > Ali Polatel (2): > lib: destroy message object after message removal > lib: make find_message{,by_filename) report errors

[PATCH 3/3] test: add emacs test for hiding a message following an HTML part

tmuchmail.org/pipermail/notmuch/attachments/20111003/2cd90408/attachment-0001.pgp>

[PATCH 4/4] emacs: add notmuch-hello-hook

--- emacs/notmuch-hello.el |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 1cf95d7..00bb5ce 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -111,6 +111,11 @@ So: (integer :tag

[PATCH 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

In 123,456.78, "." is the decimal separator, but "," is the thousands separator. This commit also mentions the space being used as thousands separator in several European countries. --- emacs/notmuch-hello.el |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 2/4] emacs: Support a message-mode switch function in notmuch-mua

--- emacs/notmuch-mua.el | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index 8824b08..68c344e 100644 --- a/emacs/notmuch-mua.el +++ b/emacs/notmuch-mua.el @@ -31,6 +31,14 @@ :group 'notmuch :type 'hook)

[PATCH 1/4] emacs: Add a face for crypto parts headers

--- emacs/notmuch-crypto.el |5 + emacs/notmuch-show.el |4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el index f03266f..673ebb8 100644 --- a/emacs/notmuch-crypto.el +++ b/emacs/notmuch-crypto.el @@ -36,6 +36,11

[PATCH v1 1/1] lib: make find_message{,by_filename) report errors

All of the code looks good to me (and improving error handling is always a good thing). Some style nits are inline below. The changes to _resolve_message_id_to_thread_id and _notmuch_database_link_message_to_parents seem like just plain better error handling and unrelated to the find_message API

notmuch and git

I know that having an exclude option for notmuch has been discussed a number of times. I have wanted such a feature to be able to ignore the .git directroy, since I keep my mail in a git repository. I recently discovered a workaround. If you make .git a text file containing = .git

[PATCH 3/3] test: add emacs test for hiding a message following an HTML part

On Mon, 03 Oct 2011 14:39:36 +0200, Thomas Jost wrote: Non-text part: multipart/signed > > About adding prereqs to the test suite -- in my private branch I have a > rebased and fixed version of the patch series sent by Pieter Praet [1]. > It worked fine last time I tested it on a system without

[PATCH 4/4] emacs: add notmuch-hello-hook

--- emacs/notmuch-hello.el |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 1cf95d7..00bb5ce 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -111,6 +111,11 @@ So: (integer :tag

[PATCH 1/4] emacs: Add a face for crypto parts headers

--- emacs/notmuch-crypto.el |5 + emacs/notmuch-show.el |4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el index f03266f..673ebb8 100644 --- a/emacs/notmuch-crypto.el +++ b/emacs/notmuch-crypto.el @@ -36,6 +36,11

[PATCH 0/4] Several minor Emacs enhancements

Hello, This is a little series of 4 patches to the Emacs interfaces. They are quite small, independent from each other, and should be harmless. - The first one adds a face for crypto parts headers, because a hardcoded blue foreground looks quite ugly with my color theme. - The second one

[PATCH 2/4] emacs: Support a message-mode switch function in notmuch-mua

--- emacs/notmuch-mua.el | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index 8824b08..68c344e 100644 --- a/emacs/notmuch-mua.el +++ b/emacs/notmuch-mua.el @@ -31,6 +31,14 @@ :group 'notmuch :type 'hook)