From: David Bremner
Aaron Ecay points out in
id:"1324136185-4509-1-git-send-email-aaronecay at gmail.com" that the
mktemp in
debian-snapshot: TMPFILE := $(shell mktemp)
Is being evaluated for every target. As best I can tell, this is
because make is evaluating the
On Sat, 17 Dec 2011 10:36:25 -0500, Aaron Ecay wrote:
> On some systems (incl. OS X 10.6), mktemp expects an argument giving it
> the place to put the new temporary file.
> ---
>
> On my machine without this patch, make prints a message from mktemp
> about expecting an argument each time it is
Looks good to me.
Regards,
Tomi
On Sat, 17 Dec 2011 18:57:33 -0500, Austin Clements wrote:
> Not knowing anything about uncrustify, would it be possible to set up
> a pre-commit hook that at least rejects newly added code that doesn't
> fit the style?
I think that would be possible. It might take a little slightly fancy
LGTM.
Quoth Dmitry Kurochkin on Dec 18 at 4:21 am:
> Changes:
>
> v4:
>
> * explain why we need to properly delete editable widget fields
>
> v3:
>
> * remove useless let with `widget-field-list', thanks Austin
>
> v2:
>
> * actually use `all' variable in `mapc' call, thanks Tomi
Looks good to me.
Regards,
Dmitry
This series looks good to me. Just one nit below.
Quoth Dmitry Kurochkin on Dec 18 at 3:39 am:
> `notmuch-hello' should call `notmuch-hello-mode' function only when
> run for the first time. But before the change, `notmuch-hello' used
> `kill-all-local-variables' to remove editable widgets
Quoth David Bremner on Dec 17 at 6:50 pm:
> On Sat, 17 Dec 2011 11:28:15 -0400, David Bremner
> wrote:
> > +#
> > +# sample usage:
> > +#uncrustify --replace -c uncrustify.cfg foo.c
>
> There are several different possible workflows, here is what I have
> found convenient. To simplify
LGTM. Too bad it requires so much re-indenting, but such is the
nature of Lisp.
Quoth Aaron Ecay on Dec 17 at 10:47 am:
> This generates byte-compiler warnings on (at least) current trunk
> versions of Emacs. The quote is not necessary; lambda forms are
> self-quoting.
> ---
>
On Sat, 17 Dec 2011 11:28:15 -0400, David Bremner wrote:
> +#
> +# sample usage:
> +#uncrustify --replace -c uncrustify.cfg foo.c
There are several different possible workflows, here is what I have
found convenient. To simplify the example, suppose we have a single
patch, and no
On Sat, 17 Dec 2011 05:41:28 -0500, Aaron Ecay wrote:
> From the emacs changelog:
>
> ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and
> passes it to the mail user agent function. This argument specifies an
> action for returning to the caller after finishing with the
On Sat, 17 Dec 2011 13:20:41 -0800, Jameson Graef Rollins wrote:
> Not that I'm saying we shouldn't fix this issue, but just out of
> curiosity, under what circumstances would someone want to call the
> debian-snapshot target from a non-debian based system?
That part of the makefile is called
On Tue, 13 Dec 2011 15:56:47 -0400, David Bremner wrote:
> From: David Bremner
>
> The idea is that $test_count could be used in tests to label
> intermediate files. The output enabled by this patch (and --debug)
> helps figure out which OUTPUT.nn file belongs to which test in case
> several
On Sat, 17 Dec 2011 05:41:28 -0500, Aaron Ecay wrote:
> >From the emacs changelog:
>
> ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and
> passes it to the mail user agent function. This argument specifies an
> action for returning to the caller after finishing with
tachments/20111217/aeefe295/attachment.pgp>
On Fri, 16 Dec 2011 15:23:31 +0400, Dmitry Kurochkin wrote:
>
> Perhaps we can change `notmuch-mua-mail' to accept ( to subject
> other-headers rest) and pass it all to `message-mail'. That
> should be compatible with both Emacs 23 and 24, and is future-proof.
+1 for this approach.
btw: do I
On Fri, 16 Dec 2011 12:01:42 -0400, David Bremner wrote:
>
> Hi All;
>
> Currently help strings are compiled into the notmuch binary. This is a
> bit a of pain, since we have the same help text in two places.
> What do you think about having "notmuch help foo" invoke "man
> notmuch-foo" and
From: David Bremner
Uncrustify is a free (as in GPL2+) tool that indents and beautifies
C/C++ code. It is similar to GNU indent in functionality although
probably more configurable (in fairness, indent has better
documentation). Uncrustify does not have the indent
This generates byte-compiler warnings on (at least) current trunk
versions of Emacs. The quote is not necessary; lambda forms are
self-quoting.
---
emacs/notmuch-crypto.el |4 +-
emacs/notmuch-hello.el | 64 +-
emacs/notmuch-maildir-fcc.el
Parallel to ignoring .so for linux.
---
.gitignore |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index 9468e30..d64ec9f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -9,6 +9,7 @@ notmuch.sym
notmuch-shared
notmuch.1.gz
libnotmuch.so*
On some systems (incl. OS X 10.6), mktemp expects an argument giving it
the place to put the new temporary file.
---
On my machine without this patch, make prints a message from mktemp
about expecting an argument each time it is run. At some point, make
got into a situation where it would print
>From the emacs changelog:
** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and
passes it to the mail user agent function. This argument specifies an
action for returning to the caller after finishing with the mail.
This is currently used by Rmail to delete a mail
`notmuch-hello' should call `notmuch-hello-mode' function only when
run for the first time. But before the change, `notmuch-hello' used
`kill-all-local-variables' to remove editable widgets fields. This
caused the major mode to be reset, and `notmuch-hello-mode' to be
called every time.
The
Test that `notmuch-hello-mode-hook' is not called during
`notmuch-hello' buffer updates. The test is currently broken.
---
test/emacs | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index a864ffa..b4c2444 100755
--- a/test/emacs
+++
Test that `notmuch-hello-mode-hook' is called once when
`notmuch-hello' function is called.
---
test/emacs |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index 6e922de..a864ffa 100755
--- a/test/emacs
+++ b/test/emacs
@@ -476,4 +476,13 @@
Add `notmuch-hello-mode-hook-counter' hook to count how many times
`notmuch-hello-mode-hook' was called. The counter function increments
`notmuch-hello-mode-hook-counter' variable value if it is bount,
otherwise it does nothing.
---
test/test-lib.el |9 +
1 files changed, 9
>From the emacs changelog:
** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and
passes it to the mail user agent function. This argument specifies an
action for returning to the caller after finishing with the mail.
This is currently used by Rmail to delete a mail
From: Daniel Schoepe
---
test/emacs |7 +++
.../notmuch-show-thread-outline|7 +++
2 files changed, 14 insertions(+), 0 deletions(-)
create mode 100644
From: Daniel Schoepe
This patch adds some functionality to display the outline for threads
displayed by notmuch-show. The entries in the outline buffer are
links to the corresponding message in the notmuch-show buffer.
---
emacs/notmuch-lib.el | 12 +++
Fixed whitespace error reported by Jameson.
From: Daniel Schoepe
---
test/emacs |7 +++
.../notmuch-show-thread-outline|7 +++
2 files changed, 14 insertions(+), 0 deletions(-)
create mode 100644
From: Daniel Schoepe
This patch adds some functionality to display the outline for threads
displayed by notmuch-show. The entries in the outline buffer are
links to the corresponding message in the notmuch-show buffer.
---
emacs/notmuch-lib.el | 12 +++
I somehow managed to forget the actual test file in the previous version...
From: Daniel Schoepe
---
test/emacs |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index 6e922de..e706909 100755
--- a/test/emacs
+++ b/test/emacs
@@ -71,6 +71,13 @@ test_emacs "(let
From: Daniel Schoepe
This patch adds some functionality to display the outline for threads
displayed by notmuch-show. The entries in the outline buffer are
links to the corresponding message in the notmuch-show buffer.
---
emacs/notmuch-lib.el | 12 +++
Rebased to master, only one trivial conflict anyway.
On Fri, 16 Dec 2011 12:01:42 -0400, David Bremner brem...@unb.ca wrote:
Hi All;
Currently help strings are compiled into the notmuch binary. This is a
bit a of pain, since we have the same help text in two places.
What do you think about having notmuch help foo invoke man
notmuch-foo and
On Fri, 16 Dec 2011 15:23:31 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
Perhaps we can change `notmuch-mua-mail' to accept (optional to subject
other-headers rest rest) and pass it all to `message-mail'. That
should be compatible with both Emacs 23 and 24, and is
From the emacs changelog:
** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and
passes it to the mail user agent function. This argument specifies an
action for returning to the caller after finishing with the mail.
This is currently used by Rmail to delete a mail window.
On Tue, 13 Dec 2011 15:56:47 -0400, David Bremner da...@tethera.net wrote:
From: David Bremner brem...@debian.org
The idea is that $test_count could be used in tests to label
intermediate files. The output enabled by this patch (and --debug)
helps figure out which OUTPUT.nn file belongs to
On Sat, 17 Dec 2011 05:41:28 -0500, Aaron Ecay aarone...@gmail.com wrote:
From the emacs changelog:
** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and
passes it to the mail user agent function. This argument specifies an
action for returning to the caller after
From the emacs changelog:
** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and
passes it to the mail user agent function. This argument specifies an
action for returning to the caller after finishing with the mail.
This is currently used by Rmail to delete a mail window.
From: David Bremner brem...@debian.org
Uncrustify is a free (as in GPL2+) tool that indents and beautifies
C/C++ code. It is similar to GNU indent in functionality although
probably more configurable (in fairness, indent has better
documentation). Uncrustify does not have the indent mis-feature
Looks good to me.
Regards,
Dmitry
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
On some systems (incl. OS X 10.6), mktemp expects an argument giving it
the place to put the new temporary file.
---
On my machine without this patch, make prints a message from mktemp
about expecting an argument each time it is run. At some point, make
got into a situation where it would print
Parallel to ignoring .so for linux.
---
.gitignore |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index 9468e30..d64ec9f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -9,6 +9,7 @@ notmuch.sym
notmuch-shared
notmuch.1.gz
libnotmuch.so*
On Sat, 17 Dec 2011 10:36:25 -0500, Aaron Ecay aarone...@gmail.com wrote:
On some systems (incl. OS X 10.6), mktemp expects an argument giving it
the place to put the new temporary file.
---
On my machine without this patch, make prints a message from mktemp
about expecting an argument each
Changes in v2 since v1:
* actually use `all' variable in `mapc' call, thanks Tomi
Regards,
Dmitry
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Add `notmuch-hello-mode-hook-counter' hook to count how many times
`notmuch-hello-mode-hook' was called. The counter function increments
`notmuch-hello-mode-hook-counter' variable value if it is bount,
otherwise it does nothing.
---
test/test-lib.el |9 +
1 files changed, 9
Test that `notmuch-hello-mode-hook' is called once when
`notmuch-hello' function is called.
---
test/emacs |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index 6e922de..a864ffa 100755
--- a/test/emacs
+++ b/test/emacs
@@ -476,4 +476,13 @@
Test that `notmuch-hello-mode-hook' is not called during
`notmuch-hello' buffer updates. The test is currently broken.
---
test/emacs | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index a864ffa..b4c2444 100755
--- a/test/emacs
+++
`notmuch-hello' should call `notmuch-hello-mode' function only when
run for the first time. But before the change, `notmuch-hello' used
`kill-all-local-variables' to remove editable widgets fields. This
caused the major mode to be reset, and `notmuch-hello-mode' to be
called every time.
The
On Sat, 17 Dec 2011 10:36:25 -0500, Aaron Ecay aarone...@gmail.com wrote:
On some systems (incl. OS X 10.6), mktemp expects an argument giving it
the place to put the new temporary file.
Not that I'm saying we shouldn't fix this issue, but just out of
curiosity, under what circumstances would
On Sat, 17 Dec 2011 11:28:15 -0400, David Bremner da...@tethera.net wrote:
+#
+# sample usage:
+#uncrustify --replace -c uncrustify.cfg foo.c
There are several different possible workflows, here is what I have
found convenient. To simplify the example, suppose we have a single
patch,
On Sat, 17 Dec 2011 13:20:41 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
Not that I'm saying we shouldn't fix this issue, but just out of
curiosity, under what circumstances would someone want to call the
debian-snapshot target from a non-debian based system?
That part of
Test that `notmuch-hello-mode-hook' is not called during
`notmuch-hello' buffer updates. The test is currently broken.
---
test/emacs | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index a864ffa..b4c2444 100755
--- a/test/emacs
+++
`notmuch-hello' should call `notmuch-hello-mode' function only when
run for the first time. But before the change, `notmuch-hello' used
`kill-all-local-variables' to remove editable widgets fields. This
caused the major mode to be reset, and `notmuch-hello-mode' to be
called every time.
The
LGTM. Too bad it requires so much re-indenting, but such is the
nature of Lisp.
Quoth Aaron Ecay on Dec 17 at 10:47 am:
This generates byte-compiler warnings on (at least) current trunk
versions of Emacs. The quote is not necessary; lambda forms are
self-quoting.
---
Quoth David Bremner on Dec 17 at 6:50 pm:
On Sat, 17 Dec 2011 11:28:15 -0400, David Bremner da...@tethera.net wrote:
+#
+# sample usage:
+#uncrustify --replace -c uncrustify.cfg foo.c
There are several different possible workflows, here is what I have
found convenient. To
This series looks good to me. Just one nit below.
Quoth Dmitry Kurochkin on Dec 18 at 3:39 am:
`notmuch-hello' should call `notmuch-hello-mode' function only when
run for the first time. But before the change, `notmuch-hello' used
`kill-all-local-variables' to remove editable widgets
Changes:
v4:
* explain why we need to properly delete editable widget fields
v3:
* remove useless let with `widget-field-list', thanks Austin
v2:
* actually use `all' variable in `mapc' call, thanks Tomi
___
notmuch mailing list
Add `notmuch-hello-mode-hook-counter' hook to count how many times
`notmuch-hello-mode-hook' was called. The counter function increments
`notmuch-hello-mode-hook-counter' variable value if it is bount,
otherwise it does nothing.
---
test/test-lib.el |9 +
1 files changed, 9
Test that `notmuch-hello-mode-hook' is called once when
`notmuch-hello' function is called.
---
test/emacs |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index 6e922de..a864ffa 100755
--- a/test/emacs
+++ b/test/emacs
@@ -476,4 +476,13 @@
Test that `notmuch-hello-mode-hook' is not called during
`notmuch-hello' buffer updates. The test is currently broken.
---
test/emacs | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index a864ffa..b4c2444 100755
--- a/test/emacs
+++
`notmuch-hello' should call `notmuch-hello-mode' function only when
run for the first time. But before the change, `notmuch-hello' used
`kill-all-local-variables' to remove editable widgets fields. This
caused the major mode to be reset, and `notmuch-hello-mode' to be
called every time.
The
LGTM.
Quoth Dmitry Kurochkin on Dec 18 at 4:21 am:
Changes:
v4:
* explain why we need to properly delete editable widget fields
v3:
* remove useless let with `widget-field-list', thanks Austin
v2:
* actually use `all' variable in `mapc' call, thanks Tomi
On Sat, 17 Dec 2011 18:57:33 -0500, Austin Clements amdra...@mit.edu wrote:
Not knowing anything about uncrustify, would it be possible to set up
a pre-commit hook that at least rejects newly added code that doesn't
fit the style?
I think that would be possible. It might take a little
From: David Bremner brem...@debian.org
Aaron Ecay points out in
id:1324136185-4509-1-git-send-email-aarone...@gmail.com that the
mktemp in
debian-snapshot: TMPFILE := $(shell mktemp)
Is being evaluated for every target. As best I can tell, this is
because make is evaluating the right hand
Hi,
Bower is yet another curses frontend for the Notmuch email system.
I wrote it for me, but you might like it, too. Mutt users would
probably find it most familiar.
https://github.com/wangp/bower
bower is written in Mercury. There are screenshots if you just want to
see what it
69 matches
Mail list logo