[PATCH v2 1/3] mime node: Record depth-first part numbers

On Sun, 22 Jan 2012 21:31:11 -0500, Austin Clements wrote: > This makes the part numbers readily accessible to formatters. > Hierarchical part numbering would be a more natural and efficient fit > for MIME and may be the way to go in the future, but depth-first > numbering maintains compatibility

[PATCH v2 3/3] show: Introduce mime_node formatter callback

On Sun, 22 Jan 2012 21:31:13 -0500, Austin Clements wrote: > This callback is the gateway to the new mime_node_t-based formatters. > This maintains backwards compatibility so the formatters can be > transitioned one at a time. Once all formatters are converted, the > formatter structure can be

[PATCH 6/6] emacs: modify the default show-mode key bindings for archiving

This is also +1 for me. /Xavier

[RFC PATCH 3/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

Quoth Mark Walters on Jan 24 at 1:18 am: > Add the actual NOTMUCH_MESSAGE_FLAG_EXCLUDED flag. > > --- > lib/notmuch-private.h |1 + > lib/notmuch.h |3 ++- > lib/query.cc | 11 +++ > lib/thread.cc | 14 ++ > 4 files changed, 20

[RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

The overall structure of this series looks great. There's obviously a lot of clean up to do, but I'll reply with a few high-level comments. Quoth Mark Walters on Jan 24 at 1:18 am: > Form excluded doc_ids set and use that to exclude messages. > Should be no functional change. > > --- >

[PATCH 3/3] test: Add address cleaning tests.

On Thu, 19 Jan 2012 12:54:03 +, David Edmondson wrote: > Including some more test framework in test-lib.el. IMO test-lib.el changes should be in a separate patch. > --- > test/emacs-address-cleaning.el | 29 + > test/emacs-address-cleaning.sh | 12

[PATCH 2/3] test: Add `test_emacs_expect_t'.

On Thu, 19 Jan 2012 12:54:02 +, David Edmondson wrote: > Add a new test function to allow simpler testing of emacs > functionality. > > `test_emacs_expect_t' takes one argument - a list expression to > evaluate. The test passes if the expression returns `t', otherwise it > fails and the

[PATCH 1/3] test: Don't return the result of checking for running emacs to the tester.

LGTM. Regards, Dmitry

[PATCH] Automatically exclude tags in notmuch-show

Quoth Mark Walters on Jan 24 at 1:05 am: > > On Sun, 22 Jan 2012 20:52:22 -0500, Austin Clements > wrote: > > Quoth Mark Walters on Jan 23 at 1:13 am: > > > On Sun, 22 Jan 2012 13:16:09 -0500, Austin Clements > > > wrote: > > > > Quoth myself on Jan 20 at 12:18 pm: > > > > > Quoth Mark

[PATCH 10/10] test: use emacsclient(1) for Emacs tests

On Tue, 28 Jun 2011 08:45:11 +0400, Dmitry Kurochkin wrote: > Before the change, every Emacs test ran in a separate Emacs > instance. Starting Emacs many times wastes considerable time and > it gets worse as the test suite grows. The patch solves this by > using a single Emacs server and

[PATCH v2 1/3] mime node: Record depth-first part numbers

On Sun, 22 Jan 2012 21:31:11 -0500, Austin Clements wrote: > This makes the part numbers readily accessible to formatters. > Hierarchical part numbering would be a more natural and efficient fit > for MIME and may be the way to go in the future, but depth-first > numbering maintains compatibility

[PATCH 08/10] test: set variables using `let' instead of `setq' in Emacs tests

On Tue, 28 Jun 2011 08:45:09 +0400, Dmitry Kurochkin wrote: > Using `setq' for setting variables in Emacs tests affect other > tests that may run in the same Emacs environment. Currently it > works because each test is run in a separate Emacs instance. But > in the future multiple tests will

[PATCH v2 1/6] search: rename auto_exclude_tags to {search, }exclude_tags

On Mon, 23 Jan 2012 05:22:32 +0100, Pieter Praet wrote: > All other config-related functions and args include the section > title in their name, so for the sake of consistency, mirror that. > All six pushed, d

[PATCH v5 2/2] show: Introduce mime_node formatter callback

This callback is the gateway to the new mime_node_t-based formatters. This maintains backwards compatibility so the formatters can be transitioned one at a time. Once all formatters are converted, the formatter structure can be reduced to only message_set_{start,sep,end} and part, most of

[PATCH v5 1/2] mime node: Record depth-first part numbers

This makes the part numbers readily accessible to formatters. Hierarchical part numbering would be a more natural and efficient fit for MIME and may be the way to go in the future, but depth-first numbering maintains compatibility with what we currently do. --- mime-node.c | 38

[PATCH v5 0/2] Second step of 'show' rewrite

Arrg, sorry for the spam. I grabbed the wrong commit ID when sending v4.

[PATCH v4 2/3] show: Use consistent header ordering in the text format

Previously, top-level message headers were printed as Subject, From, To, Date, while embedded message headers were printed From, To, Subject, Date. This makes both cases use the former order and updates the tests accordingly. Strangely, the raw format also uses this function, so this also fixes

[PATCH v4 1/3] mime node: Record depth-first part numbers

This makes the part numbers readily accessible to formatters. Hierarchical part numbering would be a more natural and efficient fit for MIME and may be the way to go in the future, but depth-first numbering maintains compatibility with what we currently do. --- mime-node.c | 37

[PATCH v4 0/3] Second step of 'show' rewrite

This version addresses Dmitry's review.

[PATCH v2 3/3] show: Introduce mime_node formatter callback

Thanks for the review. New version coming shortly (v4, since the list ate v3 while everyone was still reading v2). Quoth Dmitry Kurochkin on Jan 24 at 2:37 am: > On Sun, 22 Jan 2012 21:31:13 -0500, Austin Clements > wrote: > > This callback is the gateway to the new mime_node_t-based

[PATCH v2 1/3] mime node: Record depth-first part numbers

Quoth Dmitry Kurochkin on Jan 24 at 2:19 am: > On Sun, 22 Jan 2012 21:31:11 -0500, Austin Clements > wrote: > > This makes the part numbers readily accessible to formatters. > > Hierarchical part numbering would be a more natural and efficient fit > > for MIME and may be the way to go in the

[PATCH 4/4 v42] test: Add address cleaning tests.

--- Anticipate the failure of test 3. test/emacs-address-cleaning.el | 29 + test/emacs-address-cleaning.sh | 19 +++ test/notmuch-test |1 + 3 files changed, 49 insertions(+), 0 deletions(-) create mode 100644

[PATCH 3/4 v42] test: Add more helpers for emacs tests.

--- Split out from the tests and re-factored. test/test-lib.el | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/test/test-lib.el b/test/test-lib.el index 96752f0..c4a5db4 100644 --- a/test/test-lib.el +++ b/test/test-lib.el @@ -20,6 +20,8 @@ ;; ;;

[PATCH 2/4 v42] test: Add `test_emacs_expect_t'.

Add a new test function to allow simpler testing of emacs functionality. `test_emacs_expect_t' takes one argument - a lisp expression to evaluate. The test passes if the expression returns `t', otherwise it fails and the output is reported to the tester. --- As per Dmitry: - don't call

[PATCH 1/4 v42] test: Don't return the result of checking for running emacs to the tester.

When checking for a running emacs, test_emacs evaluates the empty list '()'. This returns 'nil' when emacs is running, which is then prepended to the actual test result. Given that it is not part of the actual test output the test harness can incorrectly report test failure (or success). ---

[PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/e6d41843/attachment-0001.pgp>

[RFC][PATCH] emacs: Provide scaffolding so that the new `shr' HTML renderer can run.

On Mon, 19 Dec 2011 23:38:36 -0700, Chris Gray wrote: > > +;; Nonsense required to have the new gnus `shr' HTML display code > > +;; work. > > +(defvar gnus-summary-buffer) > > +(defvar gnus-inhibit-images) > > I believe that gnus-inhibit-images is defined in gnus-art.el. Perhaps > that file

Infinite loop in emacs interface

On Mon, 23 Jan 2012 15:26:20 +0100, Florian Friesdorf wrote: > On Tue, 17 Jan 2012 23:44:40 +0100, Rodney Lorrimar > wrote: > > > > Debugger entered--Lisp error: (void-variable gnus-inhibit-images) > > mm-shr((# ("text/html") nil nil nil nil nil nil)) > > mm-inline-text-html((#

[PATCH v3 2/2] show: Introduce mime_node formatter callback

This callback is the gateway to the new mime_node_t-based formatters. This maintains backwards compatibility so the formatters can be transitioned one at a time. Once all formatters are converted, the formatter structure can be reduced to only message_set_{start,sep,end} and part, most of

[PATCH v3 1/2] mime node: Record depth-first part numbers

This makes the part numbers readily accessible to formatters. Hierarchical part numbering would be a more natural and efficient fit for MIME and may be the way to go in the future, but depth-first numbering maintains compatibility with what we currently do. --- mime-node.c | 36

[PATCH v3 0/2] Second step of 'show' rewrite

Fix a silly comment mistake pointed out by Jani

[PATCH] python: fix error handling

On Sun, 22 Jan 2012 14:09:35 +0100, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > Before 3434d1940 the return values of libnotmuch functions were > declared as c_void_p and the code checking for errors compared the > returned value to None, which is the ctypes equivalent of a NULL

[PATCH 2/3] test: Add `test_emacs_expect_t'.

s scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/b7bcf596/attachment.pgp>

[PATCH 1/3 v2] emacs: Don't return the button from `notmuch-show-insert-part-header'.

/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/2115e78c/attachment.pgp>

[PATCH 6/6] emacs: modify the default show-mode key bindings for archiving

+1. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/eb85c7b1/attachment.pgp>

[PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/00a2e2c9/attachment-0001.pgp>

[PATCH 3/6] emacs: add message archiving functions

+1. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/ec84c3b6/attachment.pgp>

[PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread

+1. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/c68d3110/attachment.pgp>

[PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions

ignature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/2a65fda1/attachment.pgp>

[PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

seems to be on an uncrustify kick recently, so... jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/245d8309/attachment-0001.pgp>

[PATCH 3/3 v2] emacs: Don't insert a part header if it's the first part and text/*.

Previously this logic applied only to text/plain. Allow it for other text/* parts as well. --- This was not included in version 1 of the patch set. emacs/notmuch-show.el |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/emacs/notmuch-show.el

[PATCH 1/3 v2] emacs: Don't return the button from `notmuch-show-insert-part-header'.

Instead, allow the caller to specify some parameters for the button. Rework `notmuch-show-insert-part-multipart/signed' and `notmuch-show-insert-part-multipart/encrypted' accordingly. --- Removed the merge of multipart/signed and multipart/encrypted. emacs/notmuch-show.el | 84

[RFC][PATCH] emacs: Provide scaffolding so that the new `shr' HTML renderer can run.

On Mon, 23 Jan 2012 15:43:08 +0100, Florian Friesdorf wrote: > With notmuch-0.11 (require 'gnus-art') "fixes" the void > gnus-inhibit-images error. This is true, though as Aaron Ecay pointed out in the discussion of this patch, it does bring in all of gnus. My current workaround to the bug of

[PATCH v3 6/6] NEWS: update "Tag exclusion" section

Series LGTM. Quoth Pieter Praet on Jan 23 at 6:41 am: > --- > > Added note re new configurations, as suggested by Austin: > id:"20120123044108.GS16740 at mit.edu" > > NEWS | 19 +++ > 1 files changed, 15 insertions(+), 4 deletions(-) > > diff --git a/NEWS b/NEWS > index

[PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

ng to resend, but noted for next time. Thanks. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/da5ed563/attachment-0001.pgp>

[PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

my opinion, enough special casing would be required that it wouldn't be > worth it, and it would make the code less clear. Okay. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http

[PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup

On Mon, 23 Jan 2012 07:22:25 +, Jani Nikula wrote: > On Mon, 23 Jan 2012 06:05:27 +0100, Pieter Praet wrote: > > On Sun, 22 Jan 2012 14:53:41 -0800, Jameson Graef Rollins > finestructure.net> wrote: > > > On Sun, 22 Jan 2012 23:14:13 +0100, Xavier Maillard > > maillard.im> wrote: > > > >

[PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup

On Sun, 22 Jan 2012 21:34:00 -0800, Jameson Graef Rollins wrote: > On Mon, 23 Jan 2012 06:05:27 +0100, Pieter Praet wrote: > > You definitely have a point, but then again, who are we to assume that > > the terms "deleted" and "spam" have the *exact* same meaning for > > everyone? (also see

[PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup

On Mon, 23 Jan 2012 09:03:42 +0100, Pieter Praet wrote: > On Mon, 23 Jan 2012 07:22:25 +, Jani Nikula wrote: > > On Mon, 23 Jan 2012 06:05:27 +0100, Pieter Praet > > wrote: > > > On Sun, 22 Jan 2012 14:53:41 -0800, Jameson Graef Rollins > > finestructure.net> wrote: > > > > On Sun, 22 Jan

[PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup

On Sun, 22 Jan 2012 23:38:40 -0800, Jameson Graef Rollins wrote: > On Mon, 23 Jan 2012 07:22:25 +, Jani Nikula wrote: > > There really should be a definitive list of tags that are special to > > lib/cli/emacs (like "inbox", "unread", "deleted", ...), or are > > recommended for specific

[PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

--- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/417cb6eb/attachment.pgp>

[PATCH] emacs: Make the part content available to `mm-inlinable-p'.

ated ('cid:' images), - images in HTML which are referenced using HTTP (or FTP or ... I suppose). ? -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://no

[PATCH v2] emacs: Make the part content available to the mm-inline* checks.

le URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/c6322f92/attachment.pgp>

[PATCH] test/emacs-large-search-buffer: correct typo (EXPEXTED -> EXPECTED)

On Mon, 23 Jan 2012 05:26:10 +0100, Pieter Praet wrote: > introduced in commit 3b24b396 > --- > test/emacs-large-search-buffer | 12 ++-- > 1 files changed, 6 insertions(+), 6 deletions(-) pushed d

[PATCH] python: fix error handling

On Sun, 22 Jan 2012 14:09:35 +0100, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > Before 3434d1940 the return values of libnotmuch functions were > declared as c_void_p and the code checking for errors compared the > returned value to None, which is the ctypes equivalent of a NULL

[PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup

On Mon, 23 Jan 2012 06:05:27 +0100, Pieter Praet wrote: > On Sun, 22 Jan 2012 14:53:41 -0800, Jameson Graef Rollins finestructure.net> wrote: > > On Sun, 22 Jan 2012 23:14:13 +0100, Xavier Maillard > > wrote: > > > > > > On Thu, 19 Jan 2012 20:19:03 +0100, Pieter Praet > > > wrote: > > > >

[PATCH v3 4/6] setup: Create functions for tag list printing and parsing

From: Austin Clements This refactors the tag list printing and parsing currently used for new.tags so that both can be reused for the new search.exclude_tags option. --- notmuch-setup.c | 55 ++- 1 files changed, 34

[PATCH v3 6/6] NEWS: update "Tag exclusion" section

--- Added note re new configurations, as suggested by Austin: id:"20120123044108.GS16740 at mit.edu" NEWS | 19 +++ 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 2c2d9e9..2acdce5 100644 --- a/NEWS +++ b/NEWS @@ -13,10 +13,21 @@ Reply to

[PATCH v3 5/6] setup: prompt user for search.exclude_tags value

Allow users to customize the search.exclude_tags option during setup. --- v2: - less copy-paste coding... :) v3: Austin's corrections [1] - @ `print_tag_list': add space before paren. - @ `notmuch_config_set_search_exclude_tags': remove \n between type cast and value. [1]

[PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup

On Sun, 22 Jan 2012 14:53:41 -0800, Jameson Graef Rollins wrote: > On Sun, 22 Jan 2012 23:14:13 +0100, Xavier Maillard > wrote: > > > > On Thu, 19 Jan 2012 20:19:03 +0100, Pieter Praet > > wrote: > > > If the 'search.exclude_tags' option is missing from the config file, > > > its value is

[PATCH] test/emacs-large-search-buffer: correct typo (EXPEXTED -> EXPECTED)

introduced in commit 3b24b396 --- test/emacs-large-search-buffer | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/emacs-large-search-buffer b/test/emacs-large-search-buffer index 6095e9d..4351e33 100755 --- a/test/emacs-large-search-buffer +++

[PATCH v2 6/6] NEWS: update "Tag exclusion" section

--- NEWS | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 2c2d9e9..a0b7929 100644 --- a/NEWS +++ b/NEWS @@ -13,10 +13,16 @@ Reply to sender Tag exclusion - Tags can be automatically excluded from search results unless they - appear

[PATCH v2 5/6] setup: prompt user for search.exclude_tags value

Allow users to customize the search.exclude_tags option during setup. --- notmuch-setup.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/notmuch-setup.c b/notmuch-setup.c index dcfa607..0d75adc 100644 --- a/notmuch-setup.c +++ b/notmuch-setup.c @@

[PATCH v2 4/6] setup: move tag printing and parsing into separate functions

From: Austin Clements * notmuch-setup.c (notmuch_setup_command): Break tag printing and response parsing out into separate functions called `print_tag_list' respectively `parse_tag_list', for reuse with the 'search.exclude_tags' option. --- notmuch-setup.c | 55

[PATCH v2 3/6] config: only exclude messages if 'search.exclude_tags' is explicitly set

Currently, the 'search.exclude_tags' option is automatically set to "deleted;spam;" if it's missing from the config file. This violates the Principle of Least Surprise, so *only* set 'search.exclude_tags' to "deleted;spam;" if we didn't find a configuration file at all. This patch is actually

[PATCH v2 2/6] test: only exclude "deleted" messages from search if explicitly configured

Currently, the 'search.exclude_tags' option is automatically set to "deleted;spam;" if it's missing from the config file. This violates the Principle of Least Surprise, so update the tests to *only* expect the exclusion of messages which are tagged "deleted" if the 'search.exclude_tags' option is

[PATCH v2 1/6] search: rename auto_exclude_tags to {search, }exclude_tags

All other config-related functions and args include the section title in their name, so for the sake of consistency, mirror that. Also, the "auto"matic part is a given, so that was dropped. --- notmuch-client.h |4 ++-- notmuch-config.c | 28 ++-- notmuch-count.c |

[PATCH 4/4] setup: prompt user for search.exclude_tags value

On Sun, 22 Jan 2012 12:08:15 -0500, Austin Clements wrote: > Quoth Pieter Praet on Jan 22 at 7:55 am: > > On Thu, 19 Jan 2012 23:19:02 -0500, Austin Clements > > wrote: > > > [...] > > > Hah, okay. How about this as an initial minor refactoring of the code > > > for new.tags? > > > [...] > >

[PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup

On Sun, 22 Jan 2012 23:14:13 +0100, Xavier Maillard wrote: > > On Thu, 19 Jan 2012 20:19:03 +0100, Pieter Praet wrote: > > If the 'search.exclude_tags' option is missing from the config file, > > its value is automatically set to "deleted;spam;". Taking PoLS/DWIM > > into account, this should

[PATCH v3 2/2] search: Support automatic tag exclusions

On Sun, 22 Jan 2012 23:09:30 +0100, Xavier Maillard wrote: > Hey Pieter, > Hi! > On Thu, 19 Jan 2012 20:19:00 +0100, Pieter Praet wrote: > > Nice feature! I won't be using it myself, but I can imagine it being > > *very* useful for those who still feel the need to "delete" email :). > >

ignore folders patch?

Hi, On 2012-01-22T13:32:12 EET, Fabio Zanini wrote: > Hi! > > This is my first message to the list. In 2010 a patch was developed that > enabled notmuch new to ignore certain subdirectories of the mail folder: > > http://notmuchmail.org/pipermail/notmuch/2010/003170.html > > However, I

[PATCH] Automatically exclude tags in notmuch-show

On Sun, 22 Jan 2012 13:16:09 -0500, Austin Clements wrote: > Quoth myself on Jan 20 at 12:18 pm: > > Quoth Mark Walters on Jan 20 at 12:10 am: > > > > > > Ok Having said this is trivial I have found a problem. What should > > > notmuch do if you do something like > > > > > > notmuch show id: >

[PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/167021ca/attachment.pgp>

[PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup

permail/notmuch/attachments/20120123/9242aa06/attachment.pgp>

[PATCH 6/6] emacs: modify the default show-mode key bindings for archiving

This changes the default key bindings for the 'a' key in notmuch-show mode. Instead of archiving the entire thread, it now just archives the current message, and then advance to the next open message (archive-message-then-next). 'A' is now bound to the previous archive-thread-then-next function.

[PATCH 5/6] emacs: use pop-at-end functionality in show-archive-message-then-next function

This provides a smoother message processing flow by reducing the number of key presses needed for these common operations. --- emacs/notmuch-show.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index fe7ec6a..8c71d03

[PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

This will allow for keybindings that achieve a smoother message processing flow by reducing the number of key presses needed for most common operations. --- emacs/notmuch-show.el | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/emacs/notmuch-show.el

[PATCH 3/6] emacs: add message archiving functions

This adds two new message archiving functions that parallel the thread archiving functions: notmuch-show-archive-message{,-then-next}. The former also takes a prefix argument to unarchive the message (ie. put back in inbox). --- emacs/notmuch-show.el | 17 + 1 files changed, 17

[PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread

This function is now just for archiving the current thread. A new function is created to archive-then-next. The 'a' key binding is updated accordingly. This will allow people to bind to the simple thread archiving function without the extra navigation. The archive-thread function now also

[PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions

Brake up notmuch-show-archive-thread-internal into two new functions: notmuch-show-tag-thread-internal: applies a tag to all messages in thread. If option remove flag is t, tags will be removed instead of added. notmuch-show-next-thread: moves to the next thread in the search result. If given

show-mode message/thread archiving improvements

e: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120123/fe9d42be/attachment.pgp>

[PATCH v2 4/6] setup: move tag printing and parsing into separate functions

Quoth Pieter Praet on Jan 23 at 5:22 am: > From: Austin Clements > > * notmuch-setup.c (notmuch_setup_command): > Break tag printing and response parsing out into separate functions > called `print_tag_list' respectively `parse_tag_list', for reuse > with the 'search.exclude_tags' option.

Re: [PATCH v2] emacs: Make the part content available to the mm-inline* checks.

On Fri, 20 Jan 2012 12:13:49 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Wed, 18 Jan 2012 14:35:01 -0500, Austin Clements amdra...@mit.edu wrote: Shouldn't we only be doing this for parts with inline (or not attachment) content-disposition? That's cheap to check. Or

Re: [PATCH] emacs: Make the part content available to `mm-inlinable-p'.

On Fri, 20 Jan 2012 12:04:27 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Thu, 19 Jan 2012 09:34:07 +, David Edmondson d...@dme.org wrote: The `mm-inlinable-p' function works better if it has access to the data of the relevant part, so load that content before

Re: [PATCH 3/4] config: only set search.exclude_tags to deleted; spam; during setup

On Mon, 23 Jan 2012 07:22:25 +, Jani Nikula j...@nikula.org wrote: On Mon, 23 Jan 2012 06:05:27 +0100, Pieter Praet pie...@praet.org wrote: On Sun, 22 Jan 2012 14:53:41 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Sun, 22 Jan 2012 23:14:13 +0100, Xavier Maillard

Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

On Sun, 22 Jan 2012 13:38:09 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: This patch seems to include multiple distinct changes. There is a change to notmuch-show-insert-part-header, but a seemingly unrelated change to the insertion of signed/encrypted part buttons. They

Re: [PATCH 3/4] config: only set search.exclude_tags to deleted; spam; during setup

On Sun, 22 Jan 2012 23:38:40 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Mon, 23 Jan 2012 07:22:25 +, Jani Nikula j...@nikula.org wrote: There really should be a definitive list of tags that are special to lib/cli/emacs (like inbox, unread, deleted, ...), or are

Re: [PATCH 3/4] config: only set search.exclude_tags to deleted; spam; during setup

On Mon, 23 Jan 2012 09:03:42 +0100, Pieter Praet pie...@praet.org wrote: On Mon, 23 Jan 2012 07:22:25 +, Jani Nikula j...@nikula.org wrote: On Mon, 23 Jan 2012 06:05:27 +0100, Pieter Praet pie...@praet.org wrote: On Sun, 22 Jan 2012 14:53:41 -0800, Jameson Graef Rollins

Re: show-mode message/thread archiving improvements

v2 of this series to follow, based on some good feedback from David and Aaron. Reminder: The last patch changes the default keybind for the 'a' key to archive just the current message, and not the entire thread. In my opinion this is a *much* more sensible binding for this key. I actually

[PATCH 3/6] emacs: add message archiving functions

This adds two new message archiving functions that parallel the thread archiving functions: notmuch-show-archive-message{,-then-next}. The former also takes a prefix argument to unarchive the message (ie. put back in inbox). --- emacs/notmuch-show.el | 17 + 1 files changed, 17

[PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions

Brake up notmuch-show-archive-thread-internal into two new functions: notmuch-show-tag-thread-internal: applies a tag to all messages in thread. If option remove flag is t, tags will be removed instead of added. notmuch-show-next-thread: moves to the next thread in the search result. If given

[PATCH 5/6] emacs: use pop-at-end functionality in show-archive-message-then-next function

This provides a smoother message processing flow by reducing the number of key presses needed for these common operations. --- emacs/notmuch-show.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index fe7ec6a..8c71d03

[PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

This will allow for keybindings that achieve a smoother message processing flow by reducing the number of key presses needed for most common operations. --- emacs/notmuch-show.el | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/emacs/notmuch-show.el

[PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread

This function is now just for archiving the current thread. A new function is created to archive-then-next. The 'a' key binding is updated accordingly. This will allow people to bind to the simple thread archiving function without the extra navigation. The archive-thread function now also

[PATCH 6/6] emacs: modify the default show-mode key bindings for archiving

This changes the default key bindings for the 'a' key in notmuch-show mode. Instead of archiving the entire thread, it now just archives the current message, and then advance to the next open message (archive-message-then-next). 'A' is now bound to the previous archive-thread-then-next function.

Re: [PATCH 3/4] config: only set search.exclude_tags to deleted; spam; during setup

On Mon, 23 Jan 2012 08:24:44 +, Jani Nikula j...@nikula.org wrote: The lib *does* assign special meaning to the tags it syncs to maildir flags: draft, flagged, passed, replied, unread. (deleted used to be part of the list.) The cli does have to request the syncing, but the mapping is in

Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

On Mon, 23 Jan 2012 08:16:03 +, David Edmondson d...@dme.org wrote: There was no problem with the logic. The code in the two functions was almost identical, so I'd like to make any future changes in just one place. You didn't actually answer my question - is the logic in the new function

Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

On Mon, 23 Jan 2012 00:52:26 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Mon, 23 Jan 2012 08:16:03 +, David Edmondson d...@dme.org wrote: There was no problem with the logic. The code in the two functions was almost identical, so I'd like to make any future changes

Re: [PATCH] python: fix error handling

On Sun, 22 Jan 2012 14:09:35 +0100, Justus Winter 4win...@informatik.uni-hamburg.de wrote: Before 3434d1940 the return values of libnotmuch functions were declared as c_void_p and the code checking for errors compared the returned value to None, which is the ctypes equivalent of a NULL

[PATCH 1/3 v2] emacs: Don't return the button from `notmuch-show-insert-part-header'.

Instead, allow the caller to specify some parameters for the button. Rework `notmuch-show-insert-part-multipart/signed' and `notmuch-show-insert-part-multipart/encrypted' accordingly. --- Removed the merge of multipart/signed and multipart/encrypted. emacs/notmuch-show.el | 84

  1   2   >