notmuch-show-tag-all, in the first line of the commit message.
As in the previous patch, if the previous patch comes earlier in the
series, notmuch-show-tag-all could be written this way initially.
Quoth Dmitry Kurochkin on Jan 30 at 6:26 am:
> Use `notmuch-show-mapc' function instead of a
Quoth Dmitry Kurochkin on Jan 30 at 6:26 am:
> Before the change, `notmuch-show-operate-all' used thread id for
notmuch-show-tag-all?
> "notmuch tag" search. This could result in tagging unexpected
> messages that were added to the thread after the notmuch-show buffer
> was created. The patch
Looking good. Just a few small points below.
Quoth Dmitry Kurochkin on Jan 30 at 6:26 am:
> Before the change, "+" and "-" tagging operations in notmuch-search
> view accepted only a single tag. The patch makes them use the
> recently added `notmuch-read-tag-changes' function (renamed
>
Hello
I have been experimenting with notmuch-always-prompt-for-sender on my
debian stable setup (emacs 23.2.1) and it doesn't like
ido-completing-read. It goes to the minibuffer and then it seems to be
impossible to exit the minibuffer.
I can find an emacs bug report #3274 and some discussion
Show mode will recognize the exclude flag by not opening excluding
messages by default, and will start at the first matching non-excluded
message. If there are no matching non-excluded messages it will go to
the first matching (necessarily excluded) message.
---
emacs/notmuch-show.el | 18
In all cases of notmuch count/search/show where the results returned
cannot reflect the exclude flag return just the matched not-excluded
results. If the caller wishes to have all the matched results (i.e.,
including the excluded ones) they should call with the
--do-not-exclude option.
The
This adds the excludes to notmuch-show.c. We do not exclude when only
a single message (or part) is requested. notmuch-show will output the
exclude information when either text or json format is requested. As
this changes the output from notmuch-show it breaks many tests (in a
trivial and expected
Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to
notmuch_query_search_threads. Implemented by inspecting the tags
directly in _notmuch_thread_create/_thread_add_message rather than as
a Xapian query for speed reasons.
---
lib/notmuch-private.h | 16 ++--
lib/query.cc |1 +
Slightly refactor the exclude code to give the callers access to the
exclude query itself. There should be no functional change.
---
lib/query.cc | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/lib/query.cc b/lib/query.cc
index
This option turns off the exclusion so all matching messages are
returned. We do not need to add this to show as notmuch-show does not
(yet) exclude.
---
notmuch-count.c | 12
notmuch-search.c | 12
2 files changed, 16 insertions(+), 8 deletions(-)
diff --git
Ok I now have a patch set which might be complete enough to be worth
reviewing. It is essentially complete and appears to work.
Things that still need doing:
updating the test suite. The series changes notmuch-show to
output the exclude flag so several tests need updating. Of
Quoth Dmitry Kurochkin on Jan 30 at 2:54 am:
> Hi Austin.
>
> On Sun, 29 Jan 2012 16:34:27 -0500, Austin Clements
> wrote:
> > One philosophical nit below, but not enough to hold this up.
> >
> > Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:
> > > Before the change, tag format validation was
Eighth in the increasingly inaccurately named six patch series...
Quoth Dmitry Kurochkin on Jan 28 at 9:59 am:
> Before the change, `notmuch-show-operate-all' used thread id for
> "notmuch tag" search. This could result in tagging unexpected
> messages that were added to the thread after the
Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de>
---
NEWS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/NEWS b/NEWS
index 71644ff..132efe8 100644
--- a/NEWS
+++ b/NEWS
@@ -61,6 +61,12 @@ Python 3.2 compatibility
The python bindings are now
Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de>
---
NEWS |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/NEWS b/NEWS
index bee6f2e..71644ff 100644
--- a/NEWS
+++ b/NEWS
@@ -57,6 +57,10 @@ Fix error handling in python bindings.
exceptions to
Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de>
---
NEWS | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/NEWS b/NEWS
index 2acdce5..bee6f2e 100644
--- a/NEWS
+++ b/NEWS
@@ -47,6 +47,16 @@ New functions
notmuch_query_add_tag_exclude
This patch series adds a section for the python binding changes to the
NEWS file.
Cheers,
Justus
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:
> Some tag-related operations accept a single tag without prefix
> (`notmuch-select-tag-with-completion'), others accept multiple tags
> prefixed with '+' or '-' (`notmuch-select-tags-with-completion').
> Before the change, both functions used a single
Hi notmuch developers,
currently there is no way to determine why opening a database using
notmuch_database_open fails. I suppose that this is a problem for all
functions returning a pointer, but it is especially problematic for
this function since one cannot distinguish between a temporary
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:
> After the recent tagging operations changes, functions bound to "+"
> and "-" in notmuch-search and notmuch-show views always read input
> from the minibuffer. Use kbd macros instead of calling them directly.
Should this be folded into the previous
I'm looking forward to having this. I think it'll streamline tagging
operations.
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:
> Before the change, "+" and "-" tagging operations in notmuch-search
> and notmuch-show views accepted only a single tag. The patch makes
> them use the recently added
Hey David,
Quoting David Bremner (2012-01-22 13:30:35)
>On Sun, 22 Jan 2012 06:01:41 -, Justus Winter <4winter at
>informatik.uni-hamburg.de> wrote:
>>
>> I feel kind of bad since I severely broke the error handling for all
>> pythonic notmuch users out there, is there any chance of a
One philosophical nit below, but not enough to hold this up.
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:
> Before the change, tag format validation was done in
> `notmuch-search-operate-all' function only. The patch moves it down
> to `notmuch-tag', so that all users of that function get input
en there for a while.
jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120129/e55fff04/attachment.pgp>
This adds a test for proposed rfc6068 "mailto:; URI handling. The
proposed function would be called 'notmuch-mua-mailto'. The test
provides an example mailto: string that should test some subset of the
rfc6068 specification: http://tools.ietf.org/html/rfc6068
---
test/emacs | 29
> The cli stuff needs thought (about what it should do rather than
> how to do it).
Ok I have thought about the cli interface. My thoughts are as follows:
count/search/show should all have a --do-not-exclude option.
notmuch count:
messages: just output count of matching not-excluded
The function notmuch_database_find_message_by_filename now requires a
notmuch_message_t and returns a notmuch_status_t. This
change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2,
version 0.9.
---
lib/notmuch.h | 21 +++--
1 files changed, 11 insertions(+), 10
> * notmuch_tags_t object. (For consistency, we do provide a
> * notmuch_tags_destroy function, but there's no good reason to call
> --
> 1.7.2.5
>
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
-- next part --
An HTML attachment was scrubbed...
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120129/efaed20e/attachment.html>
It is no longer needed, since elisp tests files are auto loaded now.
---
test/emacs-address-cleaning |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/test/emacs-address-cleaning b/test/emacs-address-cleaning
index 51018fe..6ddde5c 100755
---
This allows us to simplify shell part of tests written in elisp.
---
test/test-lib.sh |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 8158328..0174e93 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -943,6 +943,12 @@
Hi Daniel.
On Sat, 28 Jan 2012 22:30:57 +0100, Daniel Schoepe
wrote:
> Hi Dmitry,
>
> On Tue, 24 Jan 2012 03:07, Dmitry Kurochkin
> wrote:
> > There are some trailing whitespaces in the tests.
>
> those are also produced by the various notmuch-hello functions, and are
> also in the existing
Emacs message-mode uses certain text strings to indicate how to attach
files to outgoing mail. If these are present in the text of an email,
and a user is tricked into replying to the message, the user?s files
could be exposed.
---
NEWS | 18 ++
Previously, we manually "free"d various pointers in
notmuch_database_open. Use a local talloc context instead to simplify
cleanup and eliminate various NULL pointer initializations and
conditionals.
---
lib/database.cc | 14 +-
1 files changed, 5 insertions(+), 9 deletions(-)
diff
Previously, if a Xapian exception occurred in notmuch_database_open,
we failed to clean up the allocated notmuch_database_t object.
---
lib/database.cc |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/database.cc b/lib/database.cc
index a6d15a1..94022d7 100644
---
In the error-handling paths of notmuch_database_open, we call
notmuch_database_close, which "delete"s several objects referenced by
the notmuch_database_t object. However, some of these pointers may be
uninitialized, resulting in undefined behavior. Hence, allocate the
notmuch_database_t with
Make notmuch-show.c respect the EXCLUDE flag.
---
notmuch-show.c | 20 +---
1 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/notmuch-show.c b/notmuch-show.c
index dec799c..b55d2ba 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -193,10 +193,12 @@
Add the exclude flag to notmuch_query_search_threads
---
lib/notmuch-private.h | 17 +++--
lib/query.cc |1 +
lib/thread.cc | 18 +++---
3 files changed, 27 insertions(+), 9 deletions(-)
diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
Make notmuch_query_search_messages set the exclude flag
Exclude flag will be added to notmuch_query_search threads later.
---
lib/notmuch.h |3 ++-
lib/query.cc | 34 +++---
2 files changed, 33 insertions(+), 4 deletions(-)
diff --git a/lib/notmuch.h
Slightly refactor the exclude code to give the callers access to the
exclude query itself. There should be no functional change.
---
lib/query.cc | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/lib/query.cc b/lib/query.cc
index
Signed-off-by: Justus Winter 4win...@informatik.uni-hamburg.de
---
NEWS | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/NEWS b/NEWS
index 2acdce5..bee6f2e 100644
--- a/NEWS
+++ b/NEWS
@@ -47,6 +47,16 @@ New functions
notmuch_query_add_tag_exclude supports the
Signed-off-by: Justus Winter 4win...@informatik.uni-hamburg.de
---
NEWS |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/NEWS b/NEWS
index bee6f2e..71644ff 100644
--- a/NEWS
+++ b/NEWS
@@ -57,6 +57,10 @@ Fix error handling in python bindings.
exceptions to indicate
Hi notmuch developers,
currently there is no way to determine why opening a database using
notmuch_database_open fails. I suppose that this is a problem for all
functions returning a pointer, but it is especially problematic for
this function since one cannot distinguish between a temporary
This option turns off the exclusion so all matching messages are
returned. We do not need to add this to show as notmuch-show does not
(yet) exclude.
---
notmuch-count.c | 12
notmuch-search.c | 12
2 files changed, 16 insertions(+), 8 deletions(-)
diff --git
Slightly refactor the exclude code to give the callers access to the
exclude query itself. There should be no functional change.
---
lib/query.cc | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/lib/query.cc b/lib/query.cc
index
Add a flag NOTMUCH_MESSAGE_FLAG_EXCLUDED which is set by
notmuch_query_search_messages for excluded messages. Also add an
option omit_excluded_messages to the search that we do not want the
excludes at all.
This exclude flag will be added to notmuch_query_search threads in the
next patch.
---
Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to
notmuch_query_search_threads. Implemented by inspecting the tags
directly in _notmuch_thread_create/_thread_add_message rather than as
a Xapian query for speed reasons.
---
lib/notmuch-private.h | 16 ++--
lib/query.cc |1 +
This adds the excludes to notmuch-show.c. We do not exclude when only
a single message (or part) is requested. notmuch-show will output the
exclude information when either text or json format is requested. As
this changes the output from notmuch-show it breaks many tests (in a
trivial and expected
In all cases of notmuch count/search/show where the results returned
cannot reflect the exclude flag return just the matched not-excluded
results. If the caller wishes to have all the matched results (i.e.,
including the excluded ones) they should call with the
--do-not-exclude option.
The
Show mode will recognize the exclude flag by not opening excluding
messages by default, and will start at the first matching non-excluded
message. If there are no matching non-excluded messages it will go to
the first matching (necessarily excluded) message.
---
emacs/notmuch-show.el | 18
This adds a test for proposed rfc6068 mailto:; URI handling. The
proposed function would be called 'notmuch-mua-mailto'. The test
provides an example mailto: string that should test some subset of the
rfc6068 specification: http://tools.ietf.org/html/rfc6068
---
test/emacs | 29
The new function 'notmuch-mua-mailto' provides an interactive handler
for rfc6068 mailto:; URIs. It attempts to implement the rfc6068
specification: http://tools.ietf.org/html/rfc6068
More decoding of the mailto string needs to be done, as is evident by
the fact that the mailto test remains
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:
After the recent tagging operations changes, functions bound to +
and - in notmuch-search and notmuch-show views always read input
from the minibuffer. Use kbd macros instead of calling them directly.
Should this be folded into the previous patch
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:
Some tag-related operations accept a single tag without prefix
(`notmuch-select-tag-with-completion'), others accept multiple tags
prefixed with '+' or '-' (`notmuch-select-tags-with-completion').
Before the change, both functions used a single
On Sun, 29 Jan 2012 17:58:41 -0500, Austin Clements amdra...@mit.edu wrote:
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:
After the recent tagging operations changes, functions bound to +
and - in notmuch-search and notmuch-show views always read input
from the minibuffer. Use kbd macros
Eighth in the increasingly inaccurately named six patch series...
Quoth Dmitry Kurochkin on Jan 28 at 9:59 am:
Before the change, `notmuch-show-operate-all' used thread id for
notmuch tag search. This could result in tagging unexpected
messages that were added to the thread after the
Hello
I have been experimenting with notmuch-always-prompt-for-sender on my
debian stable setup (emacs 23.2.1) and it doesn't like
ido-completing-read. It goes to the minibuffer and then it seems to be
impossible to exit the minibuffer.
I can find an emacs bug report #3274 and some discussion
Quoth Dmitry Kurochkin on Jan 30 at 2:54 am:
Hi Austin.
On Sun, 29 Jan 2012 16:34:27 -0500, Austin Clements amdra...@mit.edu wrote:
One philosophical nit below, but not enough to hold this up.
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:
Before the change, tag format validation was
On Sun, 29 Jan 2012 18:16:50 -0500, Austin Clements amdra...@mit.edu wrote:
Quoth Dmitry Kurochkin on Jan 30 at 2:54 am:
Hi Austin.
On Sun, 29 Jan 2012 16:34:27 -0500, Austin Clements amdra...@mit.edu
wrote:
One philosophical nit below, but not enough to hold this up.
Quoth
Hi Jani, notmuch developers,
executive summary: notmuch almangamates several e-mail threads
into one notmuch-thread, I consider this a bug:
* Jani Nikula j...@nikula.org [26. Jan. 2012]:
On Thu, 26 Jan 2012 13:44:50 +0100, Gregor Zattler telegr...@gmx.net wrote:
* Jameson Graef Rollins
Hi Austin.
The below changes will be send as v2 soon.
On Sun, 29 Jan 2012 17:57:10 -0500, Austin Clements amdra...@mit.edu wrote:
I'm looking forward to having this. I think it'll streamline tagging
operations.
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:
Before the change, + and -
On Sun, 29 Jan 2012 18:02:29 -0500, Austin Clements amdra...@mit.edu wrote:
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:
Some tag-related operations accept a single tag without prefix
(`notmuch-select-tag-with-completion'), others accept multiple tags
prefixed with '+' or '-'
EOn Sun, 29 Jan 2012 18:11:20 -0500, Austin Clements amdra...@mit.edu wrote:
Eighth in the increasingly inaccurately named six patch series...
Quoth Dmitry Kurochkin on Jan 28 at 9:59 am:
Before the change, `notmuch-show-operate-all' used thread id for
notmuch tag search. This could
Changes in v2:
* add patch to remove No tags given error from `notmuch-tag' as
suggested by Austin in [1]
* split patch 3 in two (search and show) for easier review
* add patch with NEWS entry
* rename `notmuch-{search,show}-operate-all' to
`notmuch-{search,show}-tag-all'
* fix other
---
emacs/notmuch.el |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 84d7d0a..ff46617 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -577,7 +577,7 @@ the messages that were tagged
(let ((beg (+ (point) 1)))
After the recent tagging operations changes, functions bound to +
and - in notmuch-search and notmuch-show views always read input
from the minibuffer. Use kbd macros instead of calling them directly.
---
test/emacs | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
The patch adds `notmuch-show-tag-all' function bound to * in
notmuch-show view. The function is similar to the
`notmuch-search-tag-all' function for the notmuch-search view: it
changes tags for all messages in the current thread.
---
emacs/notmuch-show.el | 15 +++
1 files changed,
The tag syntax check in `notmuch-tag' function was too strict and did
not allow nmbug tags with ::. Since the check is done for all
tagging operations in Emacs UI, this basically means that no nmbug
tags can be changed. The patch relaxes the tag syntax check to allow
any tag names that do not
Before the change, `notmuch-show-operate-all' used thread id for
notmuch tag search. This could result in tagging unexpected
messages that were added to the thread after the notmuch-show buffer
was created. The patch changes `notmuch-show-operate-all' to use ids
of shown messages to fix this.
Since `notmuch-tag' is a non-interactive function and hence is meant
to be invoked programmatically, it should accept zero tags. Also, the
tagging operations (bound to *, +, -) would accept empty input
without an error.
---
emacs/notmuch.el | 10 +-
1 files changed, 5 insertions(+), 5
Quoth Dmitry Kurochkin on Jan 30 at 6:26 am:
Before the change, `notmuch-show-operate-all' used thread id for
notmuch-show-tag-all?
notmuch tag search. This could result in tagging unexpected
messages that were added to the thread after the notmuch-show buffer
was created. The patch
notmuch-show-tag-all, in the first line of the commit message.
As in the previous patch, if the previous patch comes earlier in the
series, notmuch-show-tag-all could be written this way initially.
Quoth Dmitry Kurochkin on Jan 30 at 6:26 am:
Use `notmuch-show-mapc' function instead of a
Quoth Dmitry Kurochkin on Jan 30 at 6:26 am:
---
NEWS | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/NEWS b/NEWS
index 2acdce5..dc3acc4 100644
--- a/NEWS
+++ b/NEWS
@@ -39,6 +39,24 @@ Reply to sender
and search modes, 'r' has been bound to
On Mon, 30 Jan 2012 00:04:02 -0500, Austin Clements amdra...@mit.edu wrote:
Quoth Dmitry Kurochkin on Jan 30 at 6:26 am:
---
NEWS | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/NEWS b/NEWS
index 2acdce5..dc3acc4 100644
--- a/NEWS
+++
Before the change, + and - tagging operations in notmuch-show view
accepted only a single tag. The patch makes them use the recently
added `notmuch-read-tag-changes' function, which allows to enter
multiple tags with + and - prefixes. So after the change, + and
- bindings in notmuch-show view
* emacs/notmuch-show.el
(notmuch-show-stash-mlarchive-link-alist):
New defcustom of type `alist' (key = name, value = URI),
containing Mailing List Archive URI's for searching by Message-Id.
(notmuch-show-stash-mlarchive-link-default):
New defcustom, default MLA to use when
On Fri, 27 Jan 2012 20:36:40 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
On Fri, 27 Jan 2012 09:42:23 +0100, Pieter Praet pie...@praet.org wrote:
On Thu, 26 Jan 2012 14:40:26 +, David Edmondson d...@dme.org wrote:
In general, I like this.
- I think that the stash
76 matches
Mail list logo