[PATCH v2 11/13] emacs: code cleanup in `notmuch-show-operate-all', no functional changes

2012-01-29 Thread Austin Clements
notmuch-show-tag-all, in the first line of the commit message. As in the previous patch, if the previous patch comes earlier in the series, notmuch-show-tag-all could be written this way initially. Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: > Use `notmuch-show-mapc' function instead of a

[PATCH v2 10/13] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

2012-01-29 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: > Before the change, `notmuch-show-operate-all' used thread id for notmuch-show-tag-all? > "notmuch tag" search. This could result in tagging unexpected > messages that were added to the thread after the notmuch-show buffer > was created. The patch

[PATCH v2 03/13] emacs: make "+" and "-" tagging operations in notmuch-search more robust

2012-01-29 Thread Austin Clements
Looking good. Just a few small points below. Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: > Before the change, "+" and "-" tagging operations in notmuch-search > view accepted only a single tag. The patch makes them use the > recently added `notmuch-read-tag-changes' function (renamed >

Bug: emacs 23.2 doesn't like ido-completing-read

2012-01-29 Thread Mark Walters
Hello I have been experimenting with notmuch-always-prompt-for-sender on my debian stable setup (emacs 23.2.1) and it doesn't like ido-completing-read. It goes to the minibuffer and then it seems to be impossible to exit the minibuffer. I can find an emacs bug report #3274 and some discussion

[PATCH 7/7] emacs: show: recognize the exclude flag.

2012-01-29 Thread Mark Walters
Show mode will recognize the exclude flag by not opening excluding messages by default, and will start at the first matching non-excluded message. If there are no matching non-excluded messages it will go to the first matching (necessarily excluded) message. --- emacs/notmuch-show.el | 18

[PATCH 6/7] cli: omit excluded messages in results where appropriate.

2012-01-29 Thread Mark Walters
In all cases of notmuch count/search/show where the results returned cannot reflect the exclude flag return just the matched not-excluded results. If the caller wishes to have all the matched results (i.e., including the excluded ones) they should call with the --do-not-exclude option. The

[PATCH 5/7] cli: Make notmuch-show respect excludes.

2012-01-29 Thread Mark Walters
This adds the excludes to notmuch-show.c. We do not exclude when only a single message (or part) is requested. notmuch-show will output the exclude information when either text or json format is requested. As this changes the output from notmuch-show it breaks many tests (in a trivial and expected

[PATCH 4/7] lib: Add the exclude flag to notmuch_query_search_threads

2012-01-29 Thread Mark Walters
Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to notmuch_query_search_threads. Implemented by inspecting the tags directly in _notmuch_thread_create/_thread_add_message rather than as a Xapian query for speed reasons. --- lib/notmuch-private.h | 16 ++-- lib/query.cc |1 +

[PATCH 2/7] lib: Rearrange the exclude code in query.cc

2012-01-29 Thread Mark Walters
Slightly refactor the exclude code to give the callers access to the exclude query itself. There should be no functional change. --- lib/query.cc | 29 +++-- 1 files changed, 19 insertions(+), 10 deletions(-) diff --git a/lib/query.cc b/lib/query.cc index

[PATCH 1/7] cli: add --do-not-exclude option to count and search.

2012-01-29 Thread Mark Walters
This option turns off the exclusion so all matching messages are returned. We do not need to add this to show as notmuch-show does not (yet) exclude. --- notmuch-count.c | 12 notmuch-search.c | 12 2 files changed, 16 insertions(+), 8 deletions(-) diff --git

[RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-01-29 Thread Mark Walters
Ok I now have a patch set which might be complete enough to be worth reviewing. It is essentially complete and appears to work. Things that still need doing: updating the test suite. The series changes notmuch-show to output the exclude flag so several tests need updating. Of

[PATCH 1/6] emacs: move tag format validation to `notmuch-tag' function

2012-01-29 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 30 at 2:54 am: > Hi Austin. > > On Sun, 29 Jan 2012 16:34:27 -0500, Austin Clements > wrote: > > One philosophical nit below, but not enough to hold this up. > > > > Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: > > > Before the change, tag format validation was

[PATCH 8/6] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

2012-01-29 Thread Austin Clements
Eighth in the increasingly inaccurately named six patch series... Quoth Dmitry Kurochkin on Jan 28 at 9:59 am: > Before the change, `notmuch-show-operate-all' used thread id for > "notmuch tag" search. This could result in tagging unexpected > messages that were added to the thread after the

[PATCH 3/3] NEWS: add entry for the improved unicode handling in the python bindings

2012-01-29 Thread Justus Winter
Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> --- NEWS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 71644ff..132efe8 100644 --- a/NEWS +++ b/NEWS @@ -61,6 +61,12 @@ Python 3.2 compatibility The python bindings are now

[PATCH 2/3] NEWS: add entry for python 3.2 compatibility

2012-01-29 Thread Justus Winter
Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> --- NEWS |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index bee6f2e..71644ff 100644 --- a/NEWS +++ b/NEWS @@ -57,6 +57,10 @@ Fix error handling in python bindings. exceptions to

[PATCH 1/3] NEWS: add entry for python error handling fix

2012-01-29 Thread Justus Winter
Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> --- NEWS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 2acdce5..bee6f2e 100644 --- a/NEWS +++ b/NEWS @@ -47,6 +47,16 @@ New functions notmuch_query_add_tag_exclude

NEWS: add entries for the changes in the python bindings

2012-01-29 Thread Justus Winter
This patch series adds a section for the python binding changes to the NEWS file. Cheers, Justus

[PATCH 6/6] emacs: separate history for operations which accept single and multiple tags

2012-01-29 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: > Some tag-related operations accept a single tag without prefix > (`notmuch-select-tag-with-completion'), others accept multiple tags > prefixed with '+' or '-' (`notmuch-select-tags-with-completion'). > Before the change, both functions used a single

error handling and stderr

2012-01-29 Thread Justus Winter
Hi notmuch developers, currently there is no way to determine why opening a database using notmuch_database_open fails. I suppose that this is a problem for all functions returning a pointer, but it is especially problematic for this function since one cannot distinguish between a temporary

[PATCH 4/6] test: fix emacs tests after tagging operations changes

2012-01-29 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: > After the recent tagging operations changes, functions bound to "+" > and "-" in notmuch-search and notmuch-show views always read input > from the minibuffer. Use kbd macros instead of calling them directly. Should this be folded into the previous

[PATCH 3/6] emacs: make "+" and "-" tagging operations more robust

2012-01-29 Thread Austin Clements
I'm looking forward to having this. I think it'll streamline tagging operations. Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: > Before the change, "+" and "-" tagging operations in notmuch-search > and notmuch-show views accepted only a single tag. The patch makes > them use the recently added

bugfix release (was: heads up from the python front)

2012-01-29 Thread Justus Winter
Hey David, Quoting David Bremner (2012-01-22 13:30:35) >On Sun, 22 Jan 2012 06:01:41 -, Justus Winter <4winter at >informatik.uni-hamburg.de> wrote: >> >> I feel kind of bad since I severely broke the error handling for all >> pythonic notmuch users out there, is there any chance of a

[PATCH 1/6] emacs: move tag format validation to `notmuch-tag' function

2012-01-29 Thread Austin Clements
One philosophical nit below, but not enough to hold this up. Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: > Before the change, tag format validation was done in > `notmuch-search-operate-all' function only. The patch moves it down > to `notmuch-tag', so that all users of that function get input

[PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

2012-01-29 Thread Jameson Graef Rollins
en there for a while. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120129/e55fff04/attachment.pgp>

[PATCH 1/2] test: emacs mailto: URI handling

2012-01-29 Thread Jameson Graef Rollins
This adds a test for proposed rfc6068 "mailto:; URI handling. The proposed function would be called 'notmuch-mua-mailto'. The test provides an example mailto: string that should test some subset of the rfc6068 specification: http://tools.ietf.org/html/rfc6068 --- test/emacs | 29

[RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-01-29 Thread Mark Walters
> The cli stuff needs thought (about what it should do rather than > how to do it). Ok I have thought about the cli interface. My thoughts are as follows: count/search/show should all have a --do-not-exclude option. notmuch count: messages: just output count of matching not-excluded

[PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-29 Thread Allan Wind
The function notmuch_database_find_message_by_filename now requires a notmuch_message_t and returns a notmuch_status_t. This change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, version 0.9. --- lib/notmuch.h | 21 +++-- 1 files changed, 11 insertions(+), 10

[PATCH] lib: notmuch_tags_get example was not updated to reflect api change

2012-01-29 Thread Jani Nikula
> * notmuch_tags_t object. (For consistency, we do provide a > * notmuch_tags_destroy function, but there's no good reason to call > -- > 1.7.2.5 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120129/efaed20e/attachment.html>

[PATCH 2/2] test: remove explicit loading of elisp tests in emacs-address-cleaning

2012-01-29 Thread Dmitry Kurochkin
It is no longer needed, since elisp tests files are auto loaded now. --- test/emacs-address-cleaning |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/test/emacs-address-cleaning b/test/emacs-address-cleaning index 51018fe..6ddde5c 100755 ---

[PATCH 1/2] test: auto load elisp tests file in test_emacs if available

2012-01-29 Thread Dmitry Kurochkin
This allows us to simplify shell part of tests written in elisp. --- test/test-lib.sh |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 8158328..0174e93 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -943,6 +943,12 @@

[PATCH v7 2/2] emacs: Tests for user-defined sections

2012-01-29 Thread Dmitry Kurochkin
Hi Daniel. On Sat, 28 Jan 2012 22:30:57 +0100, Daniel Schoepe wrote: > Hi Dmitry, > > On Tue, 24 Jan 2012 03:07, Dmitry Kurochkin > wrote: > > There are some trailing whitespaces in the tests. > > those are also produced by the various notmuch-hello functions, and are > also in the existing

[PATCH 2/2] emacs: Quote MML tags in replies

2012-01-29 Thread Aaron Ecay
Emacs message-mode uses certain text strings to indicate how to attach files to outgoing mail. If these are present in the text of an email, and a user is tricked into replying to the message, the user?s files could be exposed. --- NEWS | 18 ++

[PATCH 3/3] lib: Use talloc to simplify cleanup in notmuch_database_open

2012-01-29 Thread Austin Clements
Previously, we manually "free"d various pointers in notmuch_database_open. Use a local talloc context instead to simplify cleanup and eliminate various NULL pointer initializations and conditionals. --- lib/database.cc | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff

[PATCH 2/3] lib: Release resources if notmuch_database_open fails

2012-01-29 Thread Austin Clements
Previously, if a Xapian exception occurred in notmuch_database_open, we failed to clean up the allocated notmuch_database_t object. --- lib/database.cc |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index a6d15a1..94022d7 100644 ---

[PATCH 1/3] lib: Don't delete uninitialized pointers

2012-01-29 Thread Austin Clements
In the error-handling paths of notmuch_database_open, we call notmuch_database_close, which "delete"s several objects referenced by the notmuch_database_t object. However, some of these pointers may be uninitialized, resulting in undefined behavior. Hence, allocate the notmuch_database_t with

[PATCH 4/4] Add exclude flag

2012-01-29 Thread Mark Walters
Make notmuch-show.c respect the EXCLUDE flag. --- notmuch-show.c | 20 +--- 1 files changed, 17 insertions(+), 3 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index dec799c..b55d2ba 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -193,10 +193,12 @@

[PATCH 3/4] Add exclude flag

2012-01-29 Thread Mark Walters
Add the exclude flag to notmuch_query_search_threads --- lib/notmuch-private.h | 17 +++-- lib/query.cc |1 + lib/thread.cc | 18 +++--- 3 files changed, 27 insertions(+), 9 deletions(-) diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h

[PATCH 2/4] Add exclude flag

2012-01-29 Thread Mark Walters
Make notmuch_query_search_messages set the exclude flag Exclude flag will be added to notmuch_query_search threads later. --- lib/notmuch.h |3 ++- lib/query.cc | 34 +++--- 2 files changed, 33 insertions(+), 4 deletions(-) diff --git a/lib/notmuch.h

[PATCH 1/4] Add exclude flag

2012-01-29 Thread Mark Walters
Slightly refactor the exclude code to give the callers access to the exclude query itself. There should be no functional change. --- lib/query.cc | 29 +++-- 1 files changed, 19 insertions(+), 10 deletions(-) diff --git a/lib/query.cc b/lib/query.cc index

[PATCH 1/3] NEWS: add entry for python error handling fix

2012-01-29 Thread Justus Winter
Signed-off-by: Justus Winter 4win...@informatik.uni-hamburg.de --- NEWS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 2acdce5..bee6f2e 100644 --- a/NEWS +++ b/NEWS @@ -47,6 +47,16 @@ New functions notmuch_query_add_tag_exclude supports the

[PATCH 2/3] NEWS: add entry for python 3.2 compatibility

2012-01-29 Thread Justus Winter
Signed-off-by: Justus Winter 4win...@informatik.uni-hamburg.de --- NEWS |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index bee6f2e..71644ff 100644 --- a/NEWS +++ b/NEWS @@ -57,6 +57,10 @@ Fix error handling in python bindings. exceptions to indicate

error handling and stderr

2012-01-29 Thread Justus Winter
Hi notmuch developers, currently there is no way to determine why opening a database using notmuch_database_open fails. I suppose that this is a problem for all functions returning a pointer, but it is especially problematic for this function since one cannot distinguish between a temporary

[PATCH 1/7] cli: add --do-not-exclude option to count and search.

2012-01-29 Thread Mark Walters
This option turns off the exclusion so all matching messages are returned. We do not need to add this to show as notmuch-show does not (yet) exclude. --- notmuch-count.c | 12 notmuch-search.c | 12 2 files changed, 16 insertions(+), 8 deletions(-) diff --git

[PATCH 2/7] lib: Rearrange the exclude code in query.cc

2012-01-29 Thread Mark Walters
Slightly refactor the exclude code to give the callers access to the exclude query itself. There should be no functional change. --- lib/query.cc | 29 +++-- 1 files changed, 19 insertions(+), 10 deletions(-) diff --git a/lib/query.cc b/lib/query.cc index

[PATCH 3/7] lib: Make notmuch_query_search_messages set the exclude flag

2012-01-29 Thread Mark Walters
Add a flag NOTMUCH_MESSAGE_FLAG_EXCLUDED which is set by notmuch_query_search_messages for excluded messages. Also add an option omit_excluded_messages to the search that we do not want the excludes at all. This exclude flag will be added to notmuch_query_search threads in the next patch. ---

[PATCH 4/7] lib: Add the exclude flag to notmuch_query_search_threads

2012-01-29 Thread Mark Walters
Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to notmuch_query_search_threads. Implemented by inspecting the tags directly in _notmuch_thread_create/_thread_add_message rather than as a Xapian query for speed reasons. --- lib/notmuch-private.h | 16 ++-- lib/query.cc |1 +

[PATCH 5/7] cli: Make notmuch-show respect excludes.

2012-01-29 Thread Mark Walters
This adds the excludes to notmuch-show.c. We do not exclude when only a single message (or part) is requested. notmuch-show will output the exclude information when either text or json format is requested. As this changes the output from notmuch-show it breaks many tests (in a trivial and expected

[PATCH 6/7] cli: omit excluded messages in results where appropriate.

2012-01-29 Thread Mark Walters
In all cases of notmuch count/search/show where the results returned cannot reflect the exclude flag return just the matched not-excluded results. If the caller wishes to have all the matched results (i.e., including the excluded ones) they should call with the --do-not-exclude option. The

[PATCH 7/7] emacs: show: recognize the exclude flag.

2012-01-29 Thread Mark Walters
Show mode will recognize the exclude flag by not opening excluding messages by default, and will start at the first matching non-excluded message. If there are no matching non-excluded messages it will go to the first matching (necessarily excluded) message. --- emacs/notmuch-show.el | 18

[PATCH 1/2] test: emacs mailto: URI handling

2012-01-29 Thread Jameson Graef Rollins
This adds a test for proposed rfc6068 mailto:; URI handling. The proposed function would be called 'notmuch-mua-mailto'. The test provides an example mailto: string that should test some subset of the rfc6068 specification: http://tools.ietf.org/html/rfc6068 --- test/emacs | 29

[PATCH 2/2] emacs: new mua mailto: URI handler

2012-01-29 Thread Jameson Graef Rollins
The new function 'notmuch-mua-mailto' provides an interactive handler for rfc6068 mailto:; URIs. It attempts to implement the rfc6068 specification: http://tools.ietf.org/html/rfc6068 More decoding of the mailto string needs to be done, as is evident by the fact that the mailto test remains

Re: [PATCH 4/6] test: fix emacs tests after tagging operations changes

2012-01-29 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: After the recent tagging operations changes, functions bound to + and - in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly. Should this be folded into the previous patch

Re: [PATCH 6/6] emacs: separate history for operations which accept single and multiple tags

2012-01-29 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: Some tag-related operations accept a single tag without prefix (`notmuch-select-tag-with-completion'), others accept multiple tags prefixed with '+' or '-' (`notmuch-select-tags-with-completion'). Before the change, both functions used a single

Re: [PATCH 4/6] test: fix emacs tests after tagging operations changes

2012-01-29 Thread Dmitry Kurochkin
On Sun, 29 Jan 2012 17:58:41 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: After the recent tagging operations changes, functions bound to + and - in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros

Re: [PATCH 8/6] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

2012-01-29 Thread Austin Clements
Eighth in the increasingly inaccurately named six patch series... Quoth Dmitry Kurochkin on Jan 28 at 9:59 am: Before the change, `notmuch-show-operate-all' used thread id for notmuch tag search. This could result in tagging unexpected messages that were added to the thread after the

Bug: emacs 23.2 doesn't like ido-completing-read

2012-01-29 Thread Mark Walters
Hello I have been experimenting with notmuch-always-prompt-for-sender on my debian stable setup (emacs 23.2.1) and it doesn't like ido-completing-read. It goes to the minibuffer and then it seems to be impossible to exit the minibuffer. I can find an emacs bug report #3274 and some discussion

Re: [PATCH 1/6] emacs: move tag format validation to `notmuch-tag' function

2012-01-29 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 30 at 2:54 am: Hi Austin. On Sun, 29 Jan 2012 16:34:27 -0500, Austin Clements amdra...@mit.edu wrote: One philosophical nit below, but not enough to hold this up. Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: Before the change, tag format validation was

Re: [PATCH 1/6] emacs: move tag format validation to `notmuch-tag' function

2012-01-29 Thread Dmitry Kurochkin
On Sun, 29 Jan 2012 18:16:50 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Dmitry Kurochkin on Jan 30 at 2:54 am: Hi Austin. On Sun, 29 Jan 2012 16:34:27 -0500, Austin Clements amdra...@mit.edu wrote: One philosophical nit below, but not enough to hold this up. Quoth

Re: Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

2012-01-29 Thread Gregor Zattler
Hi Jani, notmuch developers, executive summary: notmuch almangamates several e-mail threads into one notmuch-thread, I consider this a bug: * Jani Nikula j...@nikula.org [26. Jan. 2012]: On Thu, 26 Jan 2012 13:44:50 +0100, Gregor Zattler telegr...@gmx.net wrote: * Jameson Graef Rollins

Re: [PATCH 3/6] emacs: make + and - tagging operations more robust

2012-01-29 Thread Dmitry Kurochkin
Hi Austin. The below changes will be send as v2 soon. On Sun, 29 Jan 2012 17:57:10 -0500, Austin Clements amdra...@mit.edu wrote: I'm looking forward to having this. I think it'll streamline tagging operations. Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: Before the change, + and -

Re: [PATCH 6/6] emacs: separate history for operations which accept single and multiple tags

2012-01-29 Thread Dmitry Kurochkin
On Sun, 29 Jan 2012 18:02:29 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: Some tag-related operations accept a single tag without prefix (`notmuch-select-tag-with-completion'), others accept multiple tags prefixed with '+' or '-'

Re: [PATCH 8/6] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

2012-01-29 Thread Dmitry Kurochkin
EOn Sun, 29 Jan 2012 18:11:20 -0500, Austin Clements amdra...@mit.edu wrote: Eighth in the increasingly inaccurately named six patch series... Quoth Dmitry Kurochkin on Jan 28 at 9:59 am: Before the change, `notmuch-show-operate-all' used thread id for notmuch tag search. This could

[PATCH v2 00/13] emacs: more robust and consistent tagging operations

2012-01-29 Thread Dmitry Kurochkin
Changes in v2: * add patch to remove No tags given error from `notmuch-tag' as suggested by Austin in [1] * split patch 3 in two (search and show) for easier review * add patch with NEWS entry * rename `notmuch-{search,show}-operate-all' to `notmuch-{search,show}-tag-all' * fix other

[PATCH v2 02/13] emacs: remove text properties from `notmuch-search-get-tags' result

2012-01-29 Thread Dmitry Kurochkin
--- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 84d7d0a..ff46617 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -577,7 +577,7 @@ the messages that were tagged (let ((beg (+ (point) 1)))

[PATCH v2 05/13] test: fix emacs tests after tagging operations changes

2012-01-29 Thread Dmitry Kurochkin
After the recent tagging operations changes, functions bound to + and - in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly. --- test/emacs | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-)

[PATCH v2 07/13] emacs: add * binding for notmuch-show view

2012-01-29 Thread Dmitry Kurochkin
The patch adds `notmuch-show-tag-all' function bound to * in notmuch-show view. The function is similar to the `notmuch-search-tag-all' function for the notmuch-search view: it changes tags for all messages in the current thread. --- emacs/notmuch-show.el | 15 +++ 1 files changed,

[PATCH v2 09/13] emacs: relax tag syntax check in `notmuch-tag' function

2012-01-29 Thread Dmitry Kurochkin
The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with ::. Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not

[PATCH v2 10/13] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

2012-01-29 Thread Dmitry Kurochkin
Before the change, `notmuch-show-operate-all' used thread id for notmuch tag search. This could result in tagging unexpected messages that were added to the thread after the notmuch-show buffer was created. The patch changes `notmuch-show-operate-all' to use ids of shown messages to fix this.

[PATCH v2 12/13] emacs: accept empty tag list in `notmuch-tag'

2012-01-29 Thread Dmitry Kurochkin
Since `notmuch-tag' is a non-interactive function and hence is meant to be invoked programmatically, it should accept zero tags. Also, the tagging operations (bound to *, +, -) would accept empty input without an error. --- emacs/notmuch.el | 10 +- 1 files changed, 5 insertions(+), 5

Re: [PATCH v2 10/13] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

2012-01-29 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: Before the change, `notmuch-show-operate-all' used thread id for notmuch-show-tag-all? notmuch tag search. This could result in tagging unexpected messages that were added to the thread after the notmuch-show buffer was created. The patch

Re: [PATCH v2 11/13] emacs: code cleanup in `notmuch-show-operate-all', no functional changes

2012-01-29 Thread Austin Clements
notmuch-show-tag-all, in the first line of the commit message. As in the previous patch, if the previous patch comes earlier in the series, notmuch-show-tag-all could be written this way initially. Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: Use `notmuch-show-mapc' function instead of a

Re: [PATCH v2 13/13] NEWS: document Emacs UI tagging operations changes

2012-01-29 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: --- NEWS | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 2acdce5..dc3acc4 100644 --- a/NEWS +++ b/NEWS @@ -39,6 +39,24 @@ Reply to sender and search modes, 'r' has been bound to

Re: [PATCH v2 13/13] NEWS: document Emacs UI tagging operations changes

2012-01-29 Thread Dmitry Kurochkin
On Mon, 30 Jan 2012 00:04:02 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: --- NEWS | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 2acdce5..dc3acc4 100644 --- a/NEWS +++

[PATCH v3 04/12] emacs: make + and - tagging operations in notmuch-show more flexible

2012-01-29 Thread Dmitry Kurochkin
Before the change, + and - tagging operations in notmuch-show view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function, which allows to enter multiple tags with + and - prefixes. So after the change, + and - bindings in notmuch-show view

[PATCH v2 2/2] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

2012-01-29 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-stash-mlarchive-link-alist): New defcustom of type `alist' (key = name, value = URI), containing Mailing List Archive URI's for searching by Message-Id. (notmuch-show-stash-mlarchive-link-default): New defcustom, default MLA to use when

Re: [RFC] Re: [PATCH] emacs: Add `notmuch-show-stash-gmane' and `notmuch-show-stash-gmane-and-go'.

2012-01-29 Thread Pieter Praet
On Fri, 27 Jan 2012 20:36:40 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Fri, 27 Jan 2012 09:42:23 +0100, Pieter Praet pie...@praet.org wrote: On Thu, 26 Jan 2012 14:40:26 +, David Edmondson d...@dme.org wrote: In general, I like this. - I think that the stash