[PATCH 5/7] cli: Make notmuch-show respect excludes.

2012-01-30 Thread Austin Clements
Quoth Mark Walters on Jan 29 at 6:39 pm: > This adds the excludes to notmuch-show.c. We do not exclude when only > a single message (or part) is requested. notmuch-show will output the > exclude information when either text or json format is requested. As > this changes the output from

[PATCH 4/7] lib: Add the exclude flag to notmuch_query_search_threads

2012-01-30 Thread Austin Clements
Quoth Mark Walters on Jan 29 at 6:39 pm: > Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to > notmuch_query_search_threads. Implemented by inspecting the tags > directly in _notmuch_thread_create/_thread_add_message rather than as > a Xapian query for speed reasons. > --- > lib/notmuch-private.h |

[PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Dmitry Kurochkin
Hi Allan. I did not look at the patch, but there is a typo in the patch title: s/examle/example/. Regards, Dmitry

[PATCH 3/7] lib: Make notmuch_query_search_messages set the exclude flag

2012-01-30 Thread Austin Clements
Quoth Mark Walters on Jan 29 at 6:39 pm: > Add a flag NOTMUCH_MESSAGE_FLAG_EXCLUDED which is set by > notmuch_query_search_messages for excluded messages. Also add an > option omit_excluded_messages to the search that we do not want the > excludes at all. > > This exclude flag will be added to

Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

2012-01-30 Thread Gregor Zattler
Hi Mark, * Mark Walters [30. Jan. 2012]: > On Mon, 30 Jan 2012 20:04:25 +0100, Gregor Zattler > wrote: >> * Pieter Praet [30. Jan. 2012]: >>> On Mon, 30 Jan 2012 00:42:14 +0100, Gregor Zattler >>> wrote: * Pieter Praet [26. Jan. 2012]: > Here's another couple of threads squashed

[PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-30 Thread David Bremner
On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet wrote: > Less code, same results, without sacrificing readability. > > --- Sorry, it conflicts with Jamie's patches that I just pushed. d

[PATCH] moved _config_(get|set)_list () functions earlyer in the file

2012-01-30 Thread David Bremner
On Mon, 30 Jan 2012 12:31:25 +0200, Tomi Ollila wrote: > Moved static functions _config_get_list () and _config_set_list () > closer to the beginning of file so that their definition is known > (without adding forward declarations) in upcoming changes. > --- pushed, d

[no subject]

2012-01-30 Thread David Bremner
On Tue, 24 Jan 2012 16:06:15 -0800, Jameson Graef Rollins wrote: > Final v3 rework of this patch series: > pushed. d

[PATCH 1/7] cli: add --do-not-exclude option to count and search.

2012-01-30 Thread Austin Clements
Quoth Mark Walters on Jan 29 at 6:39 pm: > This option turns off the exclusion so all matching messages are > returned. We do not need to add this to show as notmuch-show does not > (yet) exclude. > --- > notmuch-count.c | 12 > notmuch-search.c | 12 > 2 files

Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

2012-01-30 Thread Mark Walters
On Mon, 30 Jan 2012 20:04:25 +0100, Gregor Zattler wrote: > Hi Pieter, > * Pieter Praet [30. Jan. 2012]: > > On Mon, 30 Jan 2012 00:42:14 +0100, Gregor Zattler > > wrote: > >> * Pieter Praet [26. Jan. 2012]: > >>> On Thu, 26 Jan 2012 13:44:50 +0100, Gregor Zattler > >>> wrote: > |>

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-01-30 Thread Jameson Graef Rollins
lication/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/1ae8b73b/attachment-0001.pgp>

[PATCH 5/5] emacs: Retain the state of the buffer during `notmuch-show-refresh-view'.

2012-01-30 Thread Mark Walters
On Mon, 30 Jan 2012 16:31:04 +, David Edmondson wrote: > Record the state of the buffer during `notmuch-show-refresh-view'. > > In this context, "state" is defined as: > - the open/closed state of each message, > - the current message. This looks great! I have two very minor queries one

Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

2012-01-30 Thread Gregor Zattler
Hi Pieter, * Pieter Praet [30. Jan. 2012]: > On Mon, 30 Jan 2012 00:42:14 +0100, Gregor Zattler > wrote: >> * Pieter Praet [26. Jan. 2012]: >>> On Thu, 26 Jan 2012 13:44:50 +0100, Gregor Zattler >>> wrote: |> [2] grep -I "^Message-Id:" /tmp/thread-I-m-interested-in.mbox |sed -e

[PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines.

2012-01-30 Thread Jani Nikula
/notmuchmail.org/mailman/listinfo/notmuch -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/aba26c57/attachment.html>

[PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

2012-01-30 Thread Tomi Ollila
On Mon, 30 Jan 2012 16:30:59 +, David Edmondson wrote: > v3: > - Add a toggle for line truncation (>). > - Retain the state of a show buffer across a call to refresh (which >includes the various toggles here). Applied and tested -- patches 2-5 works fine -- I currently don't have any

[PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-01-30 Thread Austin Clements
LGTM. Quoth David Edmondson on Jan 30 at 10:16 am: > --- > emacs/notmuch-lib.el |9 + > emacs/notmuch-print.el |8 ++-- > emacs/notmuch-show.el |5 - > emacs/notmuch.el | 21 + > 4 files changed, 28 insertions(+), 15 deletions(-) > >

[PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness.

2012-01-30 Thread Austin Clements
LGTM. One comment that you can take or leave. Quoth David Edmondson on Jan 30 at 10:16 am: > There's no need to call `truncate-string-to-width' twice in this code > path. > --- > emacs/notmuch.el | 22 ++ > 1 files changed, 10 insertions(+), 12 deletions(-) > > diff --git

[PATCH] lib: update notmuch_tags_get example to reflect api change

2012-01-30 Thread Austin Clements
Quoth Allan Wind on Jan 30 at 6:05 pm: > On 2012-01-30 17:42:01, Austin Clements wrote: > > Sorry, I replied to the wrong one. This one LGTM. > > > > (BTW, for future reference, it's helpful if you send later versions in > > reply to the first version so that they're grouped in threads. Sorry

[PATCH] lib: update notmuch_tags_get example to reflect api change

2012-01-30 Thread Allan Wind
On 2012-01-30 17:42:01, Austin Clements wrote: > Sorry, I replied to the wrong one. This one LGTM. > > (BTW, for future reference, it's helpful if you send later versions in > reply to the first version so that they're grouped in threads. Sorry > that the documentation on notmuch's coding

[PATCH] STYLE: Initial draft of coding style document

2012-01-30 Thread Jani Nikula
arg */ > }; > > > [ ... ] > > > Tomi > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/b2596c56/attachment-0001.html>

emacs: more flexible and consistent tagging operations

2012-01-30 Thread Tomi Ollila
Works fine. +1 Tomi

[PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines.

2012-01-30 Thread David Edmondson
le? No, that's "o" for 'output'. :-) -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/f3ca4815/attachment-0001.pgp>

[PATCH] lib: update notmuch_tags_get example to reflect api change

2012-01-30 Thread Austin Clements
Sorry, I replied to the wrong one. This one LGTM. (BTW, for future reference, it's helpful if you send later versions in reply to the first version so that they're grouped in threads. Sorry that the documentation on notmuch's coding conventions is so scattered and lacking. We're working on

[PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Austin Clements
LGTM. On Mon, 30 Jan 2012 09:05:15 -0500, Allan Wind wrote: > The function notmuch_database_find_message_by_filename now requires a > notmuch_message_t and returns a notmuch_status_t. This > change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, > version 0.9.

[PATCH 1/2] emacs: Add tests for quoting of MML tags in replies

2012-01-30 Thread David Bremner
On Sun, 29 Jan 2012 01:07:07 -0500, Aaron Ecay wrote: > The test is broken at this time; the next commit will introduce a fix. > --- Hi Aaron. Applied to master test fails for me as follows (after the second patch is applied as well). In-Reply-To: -Fcc:

[PATCH 2/2] show: Simplify new text formatter code

2012-01-30 Thread Tomi Ollila
On Thu, 26 Jan 2012 01:55:26 -0500, Austin Clements wrote: > This makes the text formatter take advantage of the new code > structure. The previously duplicated header logic is now unified, > several things that we used to compute repeatedly across different > callbacks are now computed once,

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-01-30 Thread David Edmondson
The blank line doesn't really change position, but is now considered to be part of the body rather than part of the headers. This means that it is visible when the body is visible rather than when the headers are visible. --- I'm interested in getting feedback on this. Unless you run with

[PATCH] STYLE: Initial draft of coding style document

2012-01-30 Thread Tomi Ollila
On Fri, 27 Jan 2012 19:46:58 -0400, David Bremner wrote: > From: David Bremner [ ... ] > + > +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8. > + Tabs should be only at the beginning of the line. So, after initial indentation (with tabs) there should not be further tabs?

[PATCH 3/3] emacs: Allow the indentation of content to be toggled.

2012-01-30 Thread David Edmondson
notmuchmail.org/pipermail/notmuch/attachments/20120130/e8ffe7c8/attachment.pgp>

[PATCH 5/5] emacs: Retain the state of the buffer during `notmuch-show-refresh-view'.

2012-01-30 Thread David Edmondson
Record the state of the buffer during `notmuch-show-refresh-view'. In this context, "state" is defined as: - the open/closed state of each message, - the current message. --- emacs/notmuch-show.el | 41 + 1 files changed, 37 insertions(+), 4

[PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines.

2012-01-30 Thread David Edmondson
--- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index a2c4daf..8b07adf 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1114,6 +1114,7 @@ Refreshes the current view, observing

[PATCH 3/5] emacs: Allow the indentation of content to be toggled.

2012-01-30 Thread David Edmondson
Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el

[PATCH 2/5] emacs: Allow `notmuch-show-mode' to display only matching messages.

2012-01-30 Thread David Edmondson
The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1

[PATCH 1/5] emacs: Rework crypto switch toggle.

2012-01-30 Thread David Edmondson
Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour

[PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

2012-01-30 Thread David Edmondson
v3: - Add a toggle for line truncation (>). - Retain the state of a show buffer across a call to refresh (which includes the various toggles here). David Edmondson (5): emacs: Rework crypto switch toggle. emacs: Allow `notmuch-show-mode' to display only matching messages. emacs: Allow

[PATCH 0/4 v3] more care when hiding regions with buttons

2012-01-30 Thread Dmitry Kurochkin
Hi David. Here is my attempt to fix the issue in a cleaner way: id:"1327926286-16680-1-git-send-email-dmitry.kurochkin at gmail.com" Regards, Dmitry

[PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

2012-01-30 Thread Dmitry Kurochkin
`Notmuch-wash-region-to-button' is the function that creates hidden regions with buttons for signatures, citations and original messages. Before the change, it did not work correctly if the to-be-hidden region started at the beginning of a message: the visibility toggle button was hidden as well.

[PATCH 1/2] test: add test for hiding Original Message region at beginning of a message

2012-01-30 Thread Dmitry Kurochkin
The test is currently broken and will be fixed by a subsequent patch. The patch adds a new file for tests of Emacs notmuch-show view. Based on patch by David Edmondson [1]. [1] id:"1327562380-12894-4-git-send-email-dme at dme.org" --- test/emacs-show | 28

[PATCH 0/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

2012-01-30 Thread Dmitry Kurochkin
This patch series is an attempt to fix the issue found by David [1] in a cleaner way. Regards, Dmitry [1] id:"1327503908-17226-1-git-send-email-dme at dme.org"

[PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

2012-01-30 Thread Tomi Ollila
On Mon, 30 Jan 2012 16:24:46 +0400, Dmitry Kurochkin wrote: > `Notmuch-wash-region-to-button' is the function that creates hidden > regions with buttons for signatures, citations and original messages. > Before the change, it did not work correctly if the to-be-hidden > region started at the

[PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Tomi Ollila
On Mon, 30 Jan 2012 09:02:33 -0500, Allan Wind wrote: > The function notmuch_database_find_message_by_filename now requires a > notmuch_message_t and returns a notmuch_status_t. This > change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, > version 0.9. > --- > + * status =

[PATCH 2/2] emacs: new mua mailto: URI handler

2012-01-30 Thread David Edmondson
//notmuchmail.org/pipermail/notmuch/attachments/20120130/ac093d4c/attachment.pgp>

[PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Allan Wind
On 2012-01-30 23:49:36, Dmitry Kurochkin wrote: > I did not look at the patch, but there is a typo in the patch title: > s/examle/example/. Thanks. 4th attempt sent. If that is still good enough then I am giving up. /Allan -- Allan Wind Life Integrity, LLC

[PATCH] lib: update notmuch_tags_get example to reflect api change

2012-01-30 Thread Allan Wind
The function notmuch_database_find_message_by_filename now requires a notmuch_message_t and returns a notmuch_status_t. This change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, version 0.9. --- lib/notmuch.h | 21 +++-- 1 files changed, 11 insertions(+), 10

[PATCH] emacs: More address cleaning.

2012-01-30 Thread David Edmondson
Remove outer single-quotes from the mailbox part. Allow for multiple sets of nested single and double quotes. Add more tests. --- emacs/notmuch-show.el | 24 +--- test/emacs-address-cleaning.el |8 2 files changed, 25 insertions(+), 7 deletions(-)

[PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

2012-01-30 Thread David Edmondson
Good fix, +1 (and for the test). -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/97ae66e6/attachment.pgp>

[PATCH] moved _config_(get|set)_list () functions earlyer in the file

2012-01-30 Thread Tomi Ollila
Moved static functions _config_get_list () and _config_set_list () closer to the beginning of file so that their definition is known (without adding forward declarations) in upcoming changes. --- This addresses Ethan's comments. Thanks. s/_notmuch_/_config_/ and changed 'in further work' to 'in

[PATCH v4] test: emacs: add test for `notmuch-search-operate-all'

2012-01-30 Thread Dmitry Kurochkin
Hi Pieter. On Mon, 30 Jan 2012 08:45:50 +0100, Pieter Praet wrote: > `notmuch-search-operate-all' (bound to "*") adds and removes tags > to/from all messages which match the query used to populate the > current search buffer. > > --- > > Rebased to current master. > > Previous versions

[PATCH 3/3 v2] emacs: Allow the indentation of content to be toggled.

2012-01-30 Thread David Edmondson
Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el

[PATCH 2/3 v2] emacs: Allow `notmuch-show-mode' to display only matching messages.

2012-01-30 Thread David Edmondson
The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1

[PATCH 1/3 v2] emacs: Rework crypto switch toggle.

2012-01-30 Thread David Edmondson
Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour

[PATCH 0/3 v2] reworked crypto toggle, plus a couple of other toggles

2012-01-30 Thread David Edmondson
- Improved default for `notmuch-show-process-crypto' that is less load order dependant. - Pass the _displayed_ depth of the thread to the body-insertion functions, allowing them to properly wrap when the content is not indented. David Edmondson (3): emacs: Rework crypto switch toggle.

[PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

2012-01-30 Thread David Edmondson
oon. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/15174445/attachment.pgp>

[PATCH 2/2] emacs: Quote MML tags in replies

2012-01-30 Thread Tomi Ollila
On Sun, 29 Jan 2012 01:07:08 -0500, Aaron Ecay wrote: > Emacs message-mode uses certain text strings to indicate how to attach > files to outgoing mail. If these are present in the text of an email, > and a user is tricked into replying to the message, the user?s files > could be exposed. > ---

Bug: emacs 23.2 doesn't like ido-completing-read

2012-01-30 Thread Mark Walters
On Mon, 30 Jan 2012 09:39:32 +, David Edmondson wrote: > On Sun, 29 Jan 2012 23:17:55 +, Mark Walters gmail.com> wrote: > > I have been experimenting with notmuch-always-prompt-for-sender on my > > debian stable setup (emacs 23.2.1) and it doesn't like > > ido-completing-read. It goes to

emacs: more flexible and consistent tagging operations

2012-01-30 Thread Austin Clements
The whole series LGTM. Quoth Dmitry Kurochkin on Jan 30 at 9:33 am: > Changes: > > v3: > > * merged 3 `notmuch-show-tag-all'-related patches into one > > * add patch to clean up tagging function argument names > > * fix other comments from Austin's reviews [5,6] > > v2: > > * add patch to

[PATCH 0/2 v2] minor cleanup and improvements

2012-01-30 Thread David Edmondson
ail/notmuch/attachments/20120130/4910934a/attachment.pgp>

[PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-01-30 Thread David Edmondson
--- emacs/notmuch-lib.el |9 + emacs/notmuch-print.el |8 ++-- emacs/notmuch-show.el |5 - emacs/notmuch.el | 21 + 4 files changed, 28 insertions(+), 15 deletions(-) diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index

[PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness.

2012-01-30 Thread David Edmondson
There's no need to call `truncate-string-to-width' twice in this code path. --- emacs/notmuch.el | 22 ++ 1 files changed, 10 insertions(+), 12 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 72f78ed..d4d6904 100644 --- a/emacs/notmuch.el +++

[PATCH] moved _config_(get|set)_list () functions earlyer in the file

2012-01-30 Thread Austin Clements
s/earlyer/earlier/, but unless someone feels strongly about that, I don't think we need another version of this trivial patch. Quoth Tomi Ollila on Jan 30 at 12:31 pm: > Moved static functions _config_get_list () and _config_set_list () > closer to the beginning of file so that their definition

[PATCH] emacs: More address cleaning.

2012-01-30 Thread Austin Clements
loop freaks me out a little, but LGTM. Quoth David Edmondson on Jan 30 at 2:59 pm: > Remove outer single-quotes from the mailbox part. Allow for multiple > sets of nested single and double quotes. > > Add more tests. > --- > emacs/notmuch-show.el | 24 +--- >

[PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-30 Thread Tomi Ollila
On Mon, 30 Jan 2012 08:03:59 +0100, Pieter Praet wrote: > On Sat, 28 Jan 2012 08:41:36 -0400, David Bremner > wrote: > > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet > > wrote: > > > Less code, same results, without sacrificing readability. > > > > > > > This looks OK, although the

[PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Tomi Ollila
On Sun, 29 Jan 2012 10:29:01 -0500, Allan Wind wrote: > The function notmuch_database_find_message_by_filename now requires a > notmuch_message_t and returns a notmuch_status_t. This > change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, > version 0.9. > --- Good, but [ ... ]

[PATCH 3/3] lib: Use talloc to simplify cleanup in notmuch_database_open

2012-01-30 Thread Tomi Ollila
LGTM. all 3. Tomi

[PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

2012-01-30 Thread Jameson Graef Rollins
n't done a code review yet, but so far this seems to work like a charm. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/19eeb3a4/attachment.pgp>

NEWS: add entries for the changes in the python bindings

2012-01-30 Thread Tomi Ollila
On Sun, 29 Jan 2012 18:08:50 +0100, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > This patch series adds a section for the python binding changes to the > NEWS file. LGTM -- although knowing which python 2.x versions works would be nice to know. At least tests pass using python

Bug: emacs 23.2 doesn't like ido-completing-read

2012-01-30 Thread David Edmondson
signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/ebfcfc1b/attachment.pgp>

[PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

2012-01-30 Thread David Edmondson
t;http://notmuchmail.org/pipermail/notmuch/attachments/20120130/7898ab15/attachment.bin> -- next part -- I'm sure that I can figure out either some `defcustom' goop or worse to sort it out so that the initialisation happens correctly. > > `notmuch-crypto-process-mime'

[PATCH 2/2] emacs: new mua mailto: URI handler

2012-01-30 Thread Jameson Graef Rollins
ler: #!/bin/sh emacsclient --eval "(notmuch-mua-mailto \"$@\")" jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/1251566b/attachment.pgp>

[PATCH v3 12/12] NEWS: document Emacs UI tagging operations changes

2012-01-30 Thread Dmitry Kurochkin
--- NEWS | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 2acdce5..7506d68 100644 --- a/NEWS +++ b/NEWS @@ -39,6 +39,24 @@ Reply to sender and search modes, 'r' has been bound to reply to sender, replacing reply to all, which now

[PATCH v3 11/12] emacs: s/tags/tag-changes/ for arguments of tagging functions

2012-01-30 Thread Dmitry Kurochkin
This makes the argument names more consistent and clear. The following functions changed: `notmuch-tag', `notmuch-search-tag-thread', `notmuch-search-tag-region' and `notmuch-search-tag-all'. --- emacs/notmuch.el | 33 + 1 files changed, 17 insertions(+), 16

[PATCH v3 10/12] emacs: accept empty tag list in `notmuch-tag'

2012-01-30 Thread Dmitry Kurochkin
Since `notmuch-tag' is a non-interactive function and hence is meant to be invoked programmatically, it should accept zero tags. Also, the tagging operations (bound to "*", "+", "-") would accept empty input without an error. --- emacs/notmuch.el | 10 +- 1 files changed, 5

[PATCH v3 09/12] emacs: relax tag syntax check in `notmuch-tag' function

2012-01-30 Thread Dmitry Kurochkin
The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with "::". Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not

[PATCH v3 08/12] emacs: separate history for operations which accept single and multiple tags

2012-01-30 Thread Dmitry Kurochkin
Some tag-related operations accept a single tag without prefix (`notmuch-select-tag-with-completion'), others accept multiple tags prefixed with '+' or '-' (`notmuch-read-tag-changes'). Before the change, both functions used a single default minibuffer history. This is inconvenient because you

[PATCH v3 07/12] emacs: add "*" binding for notmuch-show view

2012-01-30 Thread Dmitry Kurochkin
The patch adds `notmuch-show-tag-all' function bound to "*" in notmuch-show view. The function is similar to the `notmuch-search-tag-all' function for the notmuch-search view: it changes tags for all messages in the current thread. --- emacs/notmuch-show.el | 35

[PATCH v3 06/12] emacs: rename `notmuch-search-operate-all' to `notmuch-search-tag-all'

2012-01-30 Thread Dmitry Kurochkin
`Notmuch-search-tag-all' is more clear and consistent with other tagging function names. --- emacs/notmuch.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index ce8bef6..7d06109 100644 --- a/emacs/notmuch.el +++

[PATCH v3 05/12] test: fix emacs tests after tagging operations changes

2012-01-30 Thread Dmitry Kurochkin
After the recent tagging operations changes, functions bound to "+" and "-" in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly. --- test/emacs | 20 ++-- 1 files changed, 10 insertions(+), 10

[PATCH v3 04/12] emacs: make "+" and "-" tagging operations in notmuch-show more flexible

2012-01-30 Thread Dmitry Kurochkin
Before the change, "+" and "-" tagging operations in notmuch-show view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function, which allows to enter multiple tags with "+" and "-" prefixes. So after the change, "+" and "-" bindings in

[PATCH v3 03/12] emacs: make "+" and "-" tagging operations in notmuch-search more flexible

2012-01-30 Thread Dmitry Kurochkin
Before the change, "+" and "-" tagging operations in notmuch-search view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function (renamed `notmuch-select-tags-with-completion'), which allows to enter multiple tags with "+" and "-" prefixes. So

[PATCH v3 02/12] emacs: remove text properties from `notmuch-search-get-tags' result

2012-01-30 Thread Dmitry Kurochkin
--- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 84d7d0a..ff46617 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -577,7 +577,7 @@ the messages that were tagged" (let ((beg (+ (point) 1)))

[PATCH v3 01/12] emacs: move tag format validation to `notmuch-tag' function

2012-01-30 Thread Dmitry Kurochkin
Before the change, tag format validation was done in `notmuch-search-operate-all' function only. The patch moves it down to `notmuch-tag', so that all users of that function get input validation. --- emacs/notmuch.el | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff

emacs: more flexible and consistent tagging operations

2012-01-30 Thread Dmitry Kurochkin
Changes: v3: * merged 3 `notmuch-show-tag-all'-related patches into one * add patch to clean up tagging function argument names * fix other comments from Austin's reviews [5,6] v2: * add patch to remove "No tags given" error from `notmuch-tag' as suggested by Austin in [1] * split patch 3

[PATCH 3/3] emacs: Allow the indentation of content to be toggled.

2012-01-30 Thread David Edmondson
next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/f9715284/attachment.pgp>

[PATCH 2/2] test: remove explicit loading of elisp tests in emacs-address-cleaning

2012-01-30 Thread David Edmondson
Obviously good, +1. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/905e497a/attachment.pgp>

[PATCH 1/2] test: auto load elisp tests file in test_emacs if available

2012-01-30 Thread David Edmondson
Nice idea, +1. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/fff78d13/attachment-0001.pgp>

[PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-30 Thread David Edmondson
--- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/272614fb/attachment.pgp>

[PATCH v2 10/13] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

2012-01-30 Thread Dmitry Kurochkin
On Sun, 29 Jan 2012 23:57:09 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: > > Before the change, `notmuch-show-operate-all' used thread id for > > notmuch-show-tag-all? > ouch > > "notmuch tag" search. This could result in tagging unexpected > > messages that

[PATCH 0/2] Add a fake 'Tags' header

2012-01-30 Thread David Edmondson
non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/e072261c/attachment.pgp>

[PATCH v2 13/13] NEWS: document Emacs UI tagging operations changes

2012-01-30 Thread Dmitry Kurochkin
On Mon, 30 Jan 2012 00:04:02 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: > > --- > > NEWS | 18 ++ > > 1 files changed, 18 insertions(+), 0 deletions(-) > > > > diff --git a/NEWS b/NEWS > > index 2acdce5..dc3acc4 100644 > > --- a/NEWS > > +++

[PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness.

2012-01-30 Thread David Edmondson
ct necessarily a string at this point? Previously this only > ran if the code determined there was a thread at point. No, it's a bug. It's fixed in the third patch, but should be fixed here as well. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/96898fb4/attachment.pgp>

[PATCH v2 03/13] emacs: make "+" and "-" tagging operations in notmuch-search more robust

2012-01-30 Thread Dmitry Kurochkin
On Sun, 29 Jan 2012 23:48:06 -0500, Austin Clements wrote: > Looking good. Just a few small points below. > > Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: > > Before the change, "+" and "-" tagging operations in notmuch-search > > view accepted only a single tag. The patch makes them use the

[PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Allan Wind
The function notmuch_database_find_message_by_filename now requires a notmuch_message_t and returns a notmuch_status_t. This change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, version 0.9. --- lib/notmuch.h | 21 +++-- 1 files changed, 11 insertions(+), 10

[PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Allan Wind
Ignore this one. /Allan -- Allan Wind Life Integrity, LLC

[PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Allan Wind
The function notmuch_database_find_message_by_filename now requires a notmuch_message_t and returns a notmuch_status_t. This change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, version 0.9. --- lib/notmuch.h | 21 +++-- 1 files changed, 11 insertions(+), 10

[PATCH v4] test: emacs: add test for `notmuch-search-operate-all'

2012-01-30 Thread Pieter Praet
`notmuch-search-operate-all' (bound to "*") adds and removes tags to/from all messages which match the query used to populate the current search buffer. --- Rebased to current master. Previous versions (chronologically): - id:"1309450108-2793-1-git-send-email-pieter at praet.org" -

[PATCH v2 2/2] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

2012-01-30 Thread David Edmondson
Looks good. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/02522874/attachment.pgp>

[PATCH v2 1/2] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

2012-01-30 Thread David Edmondson
Looks good. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/692e7b4e/attachment.pgp>

[RFC] Re: [PATCH] emacs: Add `notmuch-show-stash-gmane' and `notmuch-show-stash-gmane-and-go'.

2012-01-30 Thread Pieter Praet
On Fri, 27 Jan 2012 20:36:40 +0400, Dmitry Kurochkin wrote: > On Fri, 27 Jan 2012 09:42:23 +0100, Pieter Praet wrote: > > On Thu, 26 Jan 2012 14:40:26 +, David Edmondson wrote: > > > In general, I like this. > > > > > > - I think that the stash function(s) should take an optional argument

[PATCH v4?] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

2012-01-30 Thread Pieter Praet
On Fri, 27 Jan 2012 09:18:40 +, David Edmondson wrote: > Much nicer :-) > > On Fri, 27 Jan 2012 09:44:26 +0100, Pieter Praet wrote: > > +(defcustom notmuch-show-stash-mlarchive-link-alist > > + '(("Gmane" . "http://mid.gmane.org/;) > > +("MARC" . "http://marc.info/?i=;) > > +("Mail

[PATCH v2 2/2] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

2012-01-30 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-stash-mlarchive-link-alist): New defcustom of type `alist' (key = name, value = URI), containing Mailing List Archive URI's for searching by Message-Id. (notmuch-show-stash-mlarchive-link-default): New defcustom, default MLA to use when

  1   2   >