[PATCH] uncrustify.cfg: comments and more types

2012-02-07 Thread Tomi Ollila
Changes to devel/uncrustify.cfg: * Updated header comment to state this is config file for *notmuch*. * Added comment about the reason of 'type' keyword used. * Added some more custom types woth 'type' keyword. * Have (every) multiline comment lines start with '*'. --- devel/uncrustify.cfg |

[PATCH v2] emacs: call "notmuch tag" only once when archiving a thread

2012-02-07 Thread Jani Nikula
Optimize thread archiving by combining all the -inbox tagging operations to a single "notmuch tag" call. Also skip redisplay of tag changes in current buffer, as it is immediately killed by the archiving functions. For threads in the order of tens or a hundred inbox tagged messages, this gives a

A big thank you for the major tagging speedup

2012-02-07 Thread Florian Friesdorf
-- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120207/516bef31/attachment.pgp>

[PATCH] emacs: Ensure that gnupg output goes at the end of the buffer.

2012-02-07 Thread David Edmondson
When showing the user some details of gnupg output, ensure that those details are shown at the end of the gnupg status buffer ("*notmuch-crypto-gpg-out*"), otherwise it can end up mixed up with earlier output. --- emacs/notmuch-crypto.el |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)

[PATCH] Free the results of scandir()

2012-02-07 Thread Dmitry Kurochkin
On Tue, 7 Feb 2012 05:05:03 -0500, Ethan Glasser-Camp wrote: > From: Ethan Glasser-Camp > > scandir() returns "strings allocated via malloc(3)" which are then > "collected in array namelist which is allocated via > malloc(3)". Currently we just free the array namelist. Instead, free > all the

[PATCH v2] Free the results of scandir()

2012-02-07 Thread Dmitry Kurochkin
Hi Ethan. On Tue, 7 Feb 2012 01:50:05 -0500, Ethan Glasser-Camp wrote: > From: Ethan Glasser-Camp > > scandir() returns "strings allocated via malloc(3)" which are then > "collected in array namelist which is allocated via > malloc(3)". Currently we just free the array namelist. Instead,

[PATCH] Free the results of scandir()

2012-02-07 Thread Tomi Ollila
pe: application/pgp-signature Size: 188 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120207/a7f80825/attachment.pgp>

[PATCH v3 2/2] test: Update test to match previous patch.

2012-02-07 Thread David Edmondson
Indentation now uses tabs where possible. --- ...hread-maildir-storage-with-fourfold-indentation |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation

[PATCH v3 1/2] emacs: Use text properties rather than overlays in `notmuch-show-mode'.

2012-02-07 Thread David Edmondson
Except for where invisibility is involved, replace the use of overlays in `notmuch-show-mode' with text properties, which are more efficient and can be merged together more effectively. --- emacs/notmuch-show.el | 62 +++- emacs/notmuch-wash.el |8

[PATCH v3 0/2] use text properties rather than overlays

2012-02-07 Thread David Edmondson
v3: - Undo mistaken minor edit - no functional change. David Edmondson (2): emacs: Use text properties rather than overlays in `notmuch-show-mode'. test: Update test to match previous patch. emacs/notmuch-show.el | 62 +---

[PATCH v2] Free the results of scandir()

2012-02-07 Thread Jani Nikula
On Tue, 7 Feb 2012 01:50:05 -0500, Ethan Glasser-Camp wrote: > From: Ethan Glasser-Camp > > scandir() returns "strings allocated via malloc(3)" which are then > "collected in array namelist which is allocated via > malloc(3)". Currently we just free the array namelist. Instead, free > all the

[PATCH] Free the results of scandir()

2012-02-07 Thread Ethan Glasser-Camp
On 02/07/2012 05:10 AM, Dmitry Kurochkin wrote: > Please use --subject-prefix='PATCH vN' parameter when sending new > versions of patches. Also, sending new versions as replies to the first > email in the original thread makes it easier to track. Oops! Thanks again. Ethan

[PATCH] Free the results of scandir()

2012-02-07 Thread Ethan Glasser-Camp
From: Ethan Glasser-Camp scandir() returns "strings allocated via malloc(3)" which are then "collected in array namelist which is allocated via malloc(3)". Currently we just free the array namelist. Instead, free all the entries of namelist, and then free namelist. entry

[PATCH v2] Free the results of scandir()

2012-02-07 Thread Ethan Glasser-Camp
From: Ethan Glasser-Camp scandir() returns "strings allocated via malloc(3)" which are then "collected in array namelist which is allocated via malloc(3)". Currently we just free the array namelist. Instead, free all the entries of namelist, and then free namelist. entry

[PATCH] Free the results of scandir()

2012-02-07 Thread Jani Nikula
On Mon, 6 Feb 2012 17:02:49 -0500, Ethan Glasser-Camp wrote: > From: Ethan Glasser-Camp > > scandir() returns "strings allocated via malloc(3)" which are then > "collected in array namelist which is allocated via > malloc(3)". Currently we just free the array namelist. Instead, free > all the

Re: [PATCH v2] Free the results of scandir()

2012-02-07 Thread Jani Nikula
On Tue, 7 Feb 2012 01:50:05 -0500, Ethan Glasser-Camp gla...@cs.rpi.edu wrote: From: Ethan Glasser-Camp et...@betacantrips.com scandir() returns strings allocated via malloc(3) which are then collected in array namelist which is allocated via malloc(3). Currently we just free the array

Re: [PATCH v2] Free the results of scandir()

2012-02-07 Thread Dmitry Kurochkin
Hi Ethan. On Tue, 7 Feb 2012 01:50:05 -0500, Ethan Glasser-Camp gla...@cs.rpi.edu wrote: From: Ethan Glasser-Camp et...@betacantrips.com scandir() returns strings allocated via malloc(3) which are then collected in array namelist which is allocated via malloc(3). Currently we just free

[PATCH v3 0/2] use text properties rather than overlays

2012-02-07 Thread David Edmondson
v3: - Undo mistaken minor edit - no functional change. David Edmondson (2): emacs: Use text properties rather than overlays in `notmuch-show-mode'. test: Update test to match previous patch. emacs/notmuch-show.el | 62 +---

[PATCH v3 1/2] emacs: Use text properties rather than overlays in `notmuch-show-mode'.

2012-02-07 Thread David Edmondson
Except for where invisibility is involved, replace the use of overlays in `notmuch-show-mode' with text properties, which are more efficient and can be merged together more effectively. --- emacs/notmuch-show.el | 62 +++- emacs/notmuch-wash.el |8

[PATCH v3 2/2] test: Update test to match previous patch.

2012-02-07 Thread David Edmondson
Indentation now uses tabs where possible. --- ...hread-maildir-storage-with-fourfold-indentation |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation

[PATCH] Free the results of scandir()

2012-02-07 Thread Ethan Glasser-Camp
From: Ethan Glasser-Camp et...@betacantrips.com scandir() returns strings allocated via malloc(3) which are then collected in array namelist which is allocated via malloc(3). Currently we just free the array namelist. Instead, free all the entries of namelist, and then free namelist. entry only

Re: [PATCH] Free the results of scandir()

2012-02-07 Thread Dmitry Kurochkin
On Tue, 7 Feb 2012 05:05:03 -0500, Ethan Glasser-Camp gla...@cs.rpi.edu wrote: From: Ethan Glasser-Camp et...@betacantrips.com scandir() returns strings allocated via malloc(3) which are then collected in array namelist which is allocated via malloc(3). Currently we just free the array

Re: [PATCH] Free the results of scandir()

2012-02-07 Thread Ethan Glasser-Camp
On 02/07/2012 05:10 AM, Dmitry Kurochkin wrote: Please use --subject-prefix='PATCH vN' parameter when sending new versions of patches. Also, sending new versions as replies to the first email in the original thread makes it easier to track. Oops! Thanks again. Ethan

Re: [PATCH] Free the results of scandir()

2012-02-07 Thread Tomi Ollila
On Tue, 7 Feb 2012 05:05:03 -0500, Ethan Glasser-Camp gla...@cs.rpi.edu wrote: From: Ethan Glasser-Camp et...@betacantrips.com scandir() returns strings allocated via malloc(3) which are then collected in array namelist which is allocated via malloc(3). Currently we just free the array

[PATCH] emacs: Ensure that gnupg output goes at the end of the buffer.

2012-02-07 Thread David Edmondson
When showing the user some details of gnupg output, ensure that those details are shown at the end of the gnupg status buffer (*notmuch-crypto-gpg-out*), otherwise it can end up mixed up with earlier output. --- emacs/notmuch-crypto.el |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)

Re: [PATCH v7 1/8] emacs: Rework crypto switch toggle.

2012-02-07 Thread David Edmondson
On Wed, 8 Feb 2012 00:10:16 -0500, Austin Clements amdra...@mit.edu wrote: Seems reasonable. I'm definitely in favor of erasing buffers instead of killing and recreating them. Two questions below. Thanks for the review. Quoth David Edmondson on Feb 06 at 9:21 am: Re-work the existing