Possible bug in gpg signing replies

: not available Type: application/pgp-signature Size: 489 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120301/3836db07/attachment.pgp>

[PATCH] NEWS: add entry for `notmuch-show-stash-mlarchive-link{, -and-go}'

--- NEWS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 8fb2f24..a739914 100644 --- a/NEWS +++ b/NEWS @@ -80,6 +80,12 @@ Attachment buttons can be used to view or save attachments. button 1 saves the attachment but this is customisable (option

[PATCH 2/2] test: add new test file for mime parsing.

From: David Bremner For now, just tests one message currently causing notmuch to segfault. --- test/mime | 67 + test/notmuch-test |1 + 2 files changed, 68 insertions(+), 0 deletions(-) create mode 100755

[PATCH 1/2] test: utility function to add a pre-generated message to the database.

From: David Bremner For various "nasty" messages, it is easier to ship a message rather than try to generate a message which causes a failure. --- test/test-lib.sh | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh

No subject

Probably both of these patches could use some polishing; Austin asked for a test to help debug the crash I found today.

[Patch v7 13/13] emacs: notmuch.el ignore excluded matches

This is a small change to make notmuch.el ignore excluded matches. In the future it could do something better like add a button for rerunning the search with the excludes (particularly if nothing matches with the excludes) or having them invisible and allowing the visibility to be toggled. ---

[Patch v7 12/13] emacs: show: recognize the exclude flag.

Show mode will recognize the exclude flag by not opening excluding messages by default, and will start at the first matching non-excluded message. If there are no matching non-excluded messages it will go to the first matching (necessarily excluded) message. --- emacs/notmuch-show.el | 36

[Patch v7 11/13] cli: omit excluded messages in results where appropriate.

In all cases of notmuch count/search/show where the results returned cannot reflect the exclude flag return just the matched not-excluded results. If the caller wishes to have all the matched results (i.e., including the excluded ones) they should call with the --no-exclude option. The relevant

[Patch v7 10/13] man: update manpage for notmuch-show --no-exclude option

--- man/man1/notmuch-show.1 |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/man/man1/notmuch-show.1 b/man/man1/notmuch-show.1 index 4c5db94..d75d971 100644 --- a/man/man1/notmuch-show.1 +++ b/man/man1/notmuch-show.1 @@ -128,6 +128,13 @@ multipart/encrypted part will

[Patch v7 09/13] test: update tests to reflect the exclude flag

notmuch show outputs the exclude flag so many tests using notmuch show failed. This commit adds "excluded:0" or "excluded: false" to the expected outputs. After this commit there should be no failing tests. --- test/crypto|9 - test/encoding |2 +- test/json

[Patch v7 08/13] cli: Make notmuch-show respect excludes.

This adds the excludes to notmuch-show.c. We do not exclude when only a single message (or part) is requested. notmuch-show will output the exclude information when either text or json format is requested. As this changes the output from notmuch-show it breaks many tests (in a trivial and expected

[Patch v7 07/13] test: update search test to reflect exclude flag

notmuch-search.c now returns all matching threads even if it the match is a search.tag_excluded message (but with a mark indicating this). Update the test to reflect this. --- test/search |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/test/search b/test/search index

[Patch v7 06/13] lib: Add the exclude flag to notmuch_query_search_threads

Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to notmuch_query_search_threads. Implemented by inspecting the tags directly in _notmuch_thread_create/_thread_add_message rather than as a Xapian query for speed reasons. Note notmuch_thread_get_matched_messages now returns the number of non-excluded

[Patch v7 05/13] lib: Make notmuch_query_search_messages set the exclude flag

Add a flag NOTMUCH_MESSAGE_FLAG_EXCLUDED which is set by notmuch_query_search_messages for excluded messages. Also add an option omit_excluded_messages to the search that we do not want the excludes at all. This exclude flag will be added to notmuch_query_search threads in the next patch. ---

[Patch v7 04/13] lib: Rearrange the exclude code in query.cc

Slightly refactor the exclude code to give the callers access to the exclude query itself. There should be no functional change. --- lib/query.cc | 29 +++-- 1 files changed, 19 insertions(+), 10 deletions(-) diff --git a/lib/query.cc b/lib/query.cc index

[Patch v7 03/13] test: add tests for new cli --no-exclude option

The tests test the new --no-exclude option to search and count. There were no existing tests for the exclude behaviour for count so added these too. --- test/count | 21 + test/search |5 + 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/test/count

[Patch v7 02/13] cli: Add --no-exclude to the man pages for search and count

--- man/man1/notmuch-count.1 |7 +++ man/man1/notmuch-search.1 |7 +++ 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/man/man1/notmuch-count.1 b/man/man1/notmuch-count.1 index 0d0ab5d..805a8ae 100644 --- a/man/man1/notmuch-count.1 +++ b/man/man1/notmuch-count.1

[Patch v7 01/13] cli: add --no-exclude option to count and search.

This option turns off the exclusion so all matching messages are returned. We do not need to add this to notmuch-show as that does not (yet) exclude. --- notmuch-count.c | 17 +++-- notmuch-search.c | 17 +++-- 2 files changed, 22 insertions(+), 12 deletions(-) diff

[Patch v7 00/13] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

This is essentially the same as id:"1330157204-26094-1-git-send-email-markwalters1009 at gmail.com" but has been rebased against master. The changes are to patch 12/13 for notmuch-show.el (which was posted as a followup to the previous series) and to the tests (patch 9/13) which changed in

plans for 0.12

On Sat, 25 Feb 2012 10:27:02 -0400, David Bremner wrote: > > I would like to start a freeze (i.e. merge master to release) for 0.12 > within the next week, say March 1 for an easy to remember date. > > If you have suggestions for things that "should really go in", feel free > to follow up. The

[PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections

On Sat, 18 Feb 2012 23:12:29 +0100, Michal Sojka wrote: > The result is that hello screen shows much faster when some sections are > hidden. > --- > emacs/notmuch-hello.el | 20 ++-- > 1 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/emacs/notmuch-hello.el

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

notmuch-saved-search-sort-function might destructively modify its input (`sort' does that, for instance), so it should not be given notmuch-saved-searches directly. --- emacs/notmuch-hello.el |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el

[PATCH v2 0/1] emacs: Pass a copy to notmuch-saved-search-sort-function

I overlooked that copy-seq is from cl.el. This version uses copy-sequence instead.

[PATCH] Actually close the xapian database in notmuch_database_close

On Thu, Mar 01, 2012 at 07:59:30AM +0100, Justus Winter wrote: > Olly wrote: > >It is hard to say if calling close() is actually useful here from just > >seeing the patch. > > Huh? I provided a test case... I only saw the part of the patch Austin quoted in the mail he cc-ed to me. > Quoting

[PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

Hi Michal. On Thu, 01 Mar 2012 15:57:32 +0100, Michal Sojka wrote: > On Thu, 01 Mar 2012, David Bremner wrote: > > > > Pushed, finally. Thanks for both of your hard work on this. > > Hi, > > is anybody willing to review > id:"1329603149-6047-1-git-send-email-sojkam1 at fel.cvut.cz"? I plan

plans for 0.12

On Thu, 01 Mar 2012 22:21:29 +0100, Pieter Praet wrote: > > Some of the features added/refactored post-0.11.1 don't have any > test coverage yet. Should they, before wrapping up 0.12 ? > (not a rhetorical question, I'm genuinely asking for opinions) > Hi Pieter; My initial answer is probably

[RFC] Smart replying

-- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 489 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120301/b0b10b84/attachment.pgp>

[PATCH] emacs: Mention race condition safety in user visible documentation

On Wed, 29 Feb 2012 22:49:46 -0400, David Bremner wrote: > On Tue, 21 Feb 2012 10:15:08 +0100, Michal Sojka > wrote: > > -- >8 -- > > Subject: [PATCH] emacs: Clarify description of thread manipulating functions > > > > It is not clear whether the term "thread" refers to the thread in the > >

[PATCH v6 1/3] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

On Wed, 29 Feb 2012 08:19:34 -0400, David Bremner wrote: > On Tue, 28 Feb 2012 19:40:04 +0100, Pieter Praet wrote: > > > > Though I couldn't help but notice (it's a curse...) that patch #3 > > seems to have gained an extra space in its commit message subject: > > > > Original

[RFC] Smart replying

--- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 489 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120301/ce4395ba/attachment.pgp>

Internal error on line 296 of mime-node.c

09:06:43 -0500 Size: 2766 URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120301/b09b801a/attachment-0001.eml>

Internal error on line 296 of mime-node.c

Quoth David Bremner on Mar 01 at 5:39 pm: > > In the current master (4fa77d031) I get a sort-of double crash on the > attached message. > > The internal error on line 296 is reached, indicating some kind of bug, > but then the G_OBJECT_TYPE crashes becase parent->part is null. > > The message

[PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

On Thu, 01 Mar 2012, David Bremner wrote: > > Pushed, finally. Thanks for both of your hard work on this. Hi, is anybody willing to review id:"1329603149-6047-1-git-send-email-sojkam1 at fel.cvut.cz"? I'd like to see it merged togetger with these patches as it makes my work with notmuch-hello

[PATCH] emacs: Pass a copy to notmuch-saved-search-sort-function

notmuch-saved-search-sort-function might destructively modify its input (`sort' does that, for instance), so it should not be given notmuch-saved-searches directly. --- emacs/notmuch-hello.el |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el

[PATCH 0/1] emacs: Pass a copy to notmuch-saved-search-sort-function

As Jani discovered, `sort' modifies its input list, leading to deleted saved searches when using notmuch-sort-saved-searches.

[RFC] Smart replying

Dear All, I know that folks recently got done haggling over reply bindings, but there's something I've been using for a little while, and I was curious about whether it's something people would be interested in. Forgive me if this functionality was already discussed and I missed it. The problem

[PATCH 2/2] Spelling fix

Retreive is spelled as r e t r i e v e . --- emacs/notmuch-crypto.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el index e916d66..83e5d37 100644 --- a/emacs/notmuch-crypto.el +++ b/emacs/notmuch-crypto.el @@ -101,7

[PATCH 1/2] emacs: retain show buffer state after retrieving gpg key

After retrieving gpg key retain show buffer state like in all other operations (i.e. no other calls to notmuch-show-refresh-view provides optional reset-state argument). Emacs MUA keeps current message under cursor instead of going first open message(possibly marking it read). ---

[PATCH] emacs: Mention race condition safety in user visible documentation

On Thu, 01 Mar 2012 14:21:26 -0400, David Bremner wrote: > On Thu, 01 Mar 2012 18:13:27 +0100, Pieter Praet wrote: > > Something like this might help save you some time: > > (assuming you'd rather not leave Emacs to apply patches) > > Thanks, I already have a one line git alias ;). > err, in

[PATCH] emacs: Mention race condition safety in user visible documentation

On Thu, 01 Mar 2012 18:13:27 +0100, Pieter Praet wrote: > Something like this might help save you some time: > (assuming you'd rather not leave Emacs to apply patches) Thanks, I already have a one line git alias ;). d

[PATCH] Actually close the xapian database in notmuch_database_close

Quoth Justus Winter on Mar 01 at 7:59 am: > Quoting Austin Clements (2012-02-29 23:17:54) > >Quoth Olly Betts on Feb 29 at 9:19 pm: > >> On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: > >> > Quoth Justus Winter on Feb 29 at 10:19 am: > >> > > Formerly the xapian database object

[PATCH 0/5] Disable search.exclude_tags for 0.12

On Wed, 29 Feb 2012 18:13:04 +, Mark Walters wrote: > As requested by David (Bremner) on irc here is a patch series > disabling the search.exclude_tags feature as a temporary measure for > the 0.12 release. > > There are two options: > > The first is to disable the addition of the new

[alot] howto multiple selections

Hi. Is it possible to select more than one msg in search-mode to retag? Phil

Replacing my name/email with "me" (or similar) in author lists

On Wed, 29 Feb 2012 17:47:46 -0500, Austin Clements wrote: > > On Wed, 29 Feb 2012 10:36:57 -0500, Austin Clements > > wrote: > > > What if the output of search (say, specifically the JSON format) > > > included information on each message in the thread such as the > > > 'message' production

[alot] nottoomuch-addresses.sh config

Sorry, forgot to finish this *caught*: >> should I be creating a key binding to invoke the completion command? >No: this is used when you are prompted for recipients when composing a mail: >Hit `m`, select your account if you have more than one, and when the prompt >says >"To:" you ... use

[RFC PATCH 00/13] Modular message store code

On 02/15/2012 07:56 PM, Mark Walters wrote: > Obviously I have not looked at the patch set in detail yet but I have a > quick question. Since you are allowing more general filenames anyway > couldn't you encode mailstore in filename? Eg > mbox://some-path[:byte-postion], or "imap://server..." > >

[PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

Pushed, finally. Thanks for both of your hard work on this. d

[PATCH v2 2/8] show: Convert JSON format to the new self-recursive style

On Sun, 19 Feb 2012 19:26:24 -0500, Austin Clements wrote: > As before, this is all code movement and a smidgen of glue. This > moves the existing JSON formatter code into one self-recursive > function, but doesn't change any of the logic to take advantage of the > new structure. Pushed the

[PATCH] Actually close the xapian database in notmuch_database_close

Hi :) Olly wrote: >It is hard to say if calling close() is actually useful here from just >seeing the patch. Huh? I provided a test case... Quoting Austin Clements (2012-02-29 23:17:54) >Quoth Olly Betts on Feb 29 at 9:19 pm: >> On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote:

Re: [PATCH 0/5] Disable search.exclude_tags for 0.12

On Wed, 29 Feb 2012 18:13:04 +, Mark Walters markwalters1...@gmail.com wrote: As requested by David (Bremner) on irc here is a patch series disabling the search.exclude_tags feature as a temporary measure for the 0.12 release. There are two options: The first is to disable the

Re: [alot] nottoomuch-addresses.sh config

Sorry, forgot to finish this *caught*: should I be creating a key binding to invoke the completion command? No: this is used when you are prompted for recipients when composing a mail: Hit `m`, select your account if you have more than one, and when the prompt says To: you ... use `tab` to

Re: [PATCH v2 2/8] show: Convert JSON format to the new self-recursive style

On Sun, 19 Feb 2012 19:26:24 -0500, Austin Clements amdra...@mit.edu wrote: As before, this is all code movement and a smidgen of glue. This moves the existing JSON formatter code into one self-recursive function, but doesn't change any of the logic to take advantage of the new structure.

Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

Pushed, finally. Thanks for both of your hard work on this. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/2] emacs: retain show buffer state after retrieving gpg key

After retrieving gpg key retain show buffer state like in all other operations (i.e. no other calls to notmuch-show-refresh-view provides optional reset-state argument). Emacs MUA keeps current message under cursor instead of going first open message(possibly marking it read). ---

[PATCH 2/2] Spelling fix

Retreive is spelled as r e t r i e v e . --- emacs/notmuch-crypto.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el index e916d66..83e5d37 100644 --- a/emacs/notmuch-crypto.el +++ b/emacs/notmuch-crypto.el @@ -101,7

Re: [RFC PATCH 00/13] Modular message store code

On 02/15/2012 07:56 PM, Mark Walters wrote: Obviously I have not looked at the patch set in detail yet but I have a quick question. Since you are allowing more general filenames anyway couldn't you encode mailstore in filename? Eg mbox://some-path[:byte-postion], or imap://server... This would

Re: Replacing my name/email with me (or similar) in author lists

On Wed, 29 Feb 2012 17:47:46 -0500, Austin Clements amdra...@mit.edu wrote: On Wed, 29 Feb 2012 10:36:57 -0500, Austin Clements amdra...@mit.edu wrote: What if the output of search (say, specifically the JSON format) included information on each message in the thread such as the

[PATCH 0/1] emacs: Pass a copy to notmuch-saved-search-sort-function

As Jani discovered, `sort' modifies its input list, leading to deleted saved searches when using notmuch-sort-saved-searches. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] emacs: Pass a copy to notmuch-saved-search-sort-function

notmuch-saved-search-sort-function might destructively modify its input (`sort' does that, for instance), so it should not be given notmuch-saved-searches directly. --- emacs/notmuch-hello.el |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el

Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

On Thu, 01 Mar 2012, David Bremner wrote: Pushed, finally. Thanks for both of your hard work on this. Hi, is anybody willing to review id:1329603149-6047-1-git-send-email-sojk...@fel.cvut.cz? I'd like to see it merged togetger with these patches as it makes my work with notmuch-hello much

Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

Hi Michal. On Thu, 01 Mar 2012 15:57:32 +0100, Michal Sojka sojk...@fel.cvut.cz wrote: On Thu, 01 Mar 2012, David Bremner wrote: Pushed, finally. Thanks for both of your hard work on this. Hi, is anybody willing to review id:1329603149-6047-1-git-send-email-sojk...@fel.cvut.cz? I

[alot] howto multiple selections

Hi. Is it possible to select more than one msg in search-mode to retag? Phil ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v6 1/3] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

On Wed, 29 Feb 2012 08:19:34 -0400, David Bremner da...@tethera.net wrote: On Tue, 28 Feb 2012 19:40:04 +0100, Pieter Praet pie...@praet.org wrote: Though I couldn't help but notice (it's a curse...) that patch #3 seems to have gained an extra space in its commit message subject:

Re: [PATCH] emacs: Mention race condition safety in user visible documentation

On Wed, 29 Feb 2012 22:49:46 -0400, David Bremner da...@tethera.net wrote: On Tue, 21 Feb 2012 10:15:08 +0100, Michal Sojka sojk...@fel.cvut.cz wrote: -- 8 -- Subject: [PATCH] emacs: Clarify description of thread manipulating functions It is not clear whether the term thread refers to

Re: [PATCH] Actually close the xapian database in notmuch_database_close

Quoth Justus Winter on Mar 01 at 7:59 am: Quoting Austin Clements (2012-02-29 23:17:54) Quoth Olly Betts on Feb 29 at 9:19 pm: On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: Quoth Justus Winter on Feb 29 at 10:19 am: Formerly the xapian database object was deleted

Re: [PATCH] emacs: Mention race condition safety in user visible documentation

On Thu, 01 Mar 2012 18:13:27 +0100, Pieter Praet pie...@praet.org wrote: Something like this might help save you some time: (assuming you'd rather not leave Emacs to apply patches) Thanks, I already have a one line git alias ;). d ___ notmuch mailing

Re: [PATCH] emacs: Mention race condition safety in user visible documentation

On Thu, 01 Mar 2012 14:21:26 -0400, David Bremner da...@tethera.net wrote: On Thu, 01 Mar 2012 18:13:27 +0100, Pieter Praet pie...@praet.org wrote: Something like this might help save you some time: (assuming you'd rather not leave Emacs to apply patches) Thanks, I already have a one line

[PATCH v2 0/1] emacs: Pass a copy to notmuch-saved-search-sort-function

I overlooked that copy-seq is from cl.el. This version uses copy-sequence instead. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

notmuch-saved-search-sort-function might destructively modify its input (`sort' does that, for instance), so it should not be given notmuch-saved-searches directly. --- emacs/notmuch-hello.el |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el

[RFC] Smart replying

Dear All, I know that folks recently got done haggling over reply bindings, but there's something I've been using for a little while, and I was curious about whether it's something people would be interested in. Forgive me if this functionality was already discussed and I missed it. The problem

Re: [RFC] Smart replying

On Thu, 01 Mar 2012 15:35:13 -0500, Jesse Rosenthal jrosent...@jhu.edu wrote: Dear All, I know that folks recently got done haggling over reply bindings, but there's something I've been using for a little while, and I was curious about whether it's something people would be interested in.

Re: [RFC] Smart replying

On Thu, 01 Mar 2012 18:02:09 -0300, Nicolás Reynolds fa...@kiwwwi.com.ar wrote: I'll try it, it's been bothering me also on reply-to-list lists :) (There's also C-c C-l but it doesn't work for me) he. https://www.gnu.org/software/emacs/manual/html_mono/message.html#Mailing-Lists

Re: [PATCH] Actually close the xapian database in notmuch_database_close

On Thu, Mar 01, 2012 at 07:59:30AM +0100, Justus Winter wrote: Olly wrote: It is hard to say if calling close() is actually useful here from just seeing the patch. Huh? I provided a test case... I only saw the part of the patch Austin quoted in the mail he cc-ed to me. Quoting Austin

Re: plans for 0.12

On Sat, 25 Feb 2012 10:27:02 -0400, David Bremner da...@tethera.net wrote: I would like to start a freeze (i.e. merge master to release) for 0.12 within the next week, say March 1 for an easy to remember date. If you have suggestions for things that should really go in, feel free to follow

Internal error on line 296 of mime-node.c

In the current master (4fa77d031) I get a sort-of double crash on the attached message. The internal error on line 296 is reached, indicating some kind of bug, but then the G_OBJECT_TYPE crashes becase parent-part is null. The message is probably crap, I created it from another real message

[PATCH] NEWS: add entry for `notmuch-show-stash-mlarchive-link{, -and-go}'

--- NEWS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 8fb2f24..a739914 100644 --- a/NEWS +++ b/NEWS @@ -80,6 +80,12 @@ Attachment buttons can be used to view or save attachments. button 1 saves the attachment but this is customisable (option

Re: Internal error on line 296 of mime-node.c

Quoth David Bremner on Mar 01 at 5:39 pm: In the current master (4fa77d031) I get a sort-of double crash on the attached message. The internal error on line 296 is reached, indicating some kind of bug, but then the G_OBJECT_TYPE crashes becase parent-part is null. The message is

Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections

On Sat, 18 Feb 2012 23:12:29 +0100, Michal Sojka sojk...@fel.cvut.cz wrote: The result is that hello screen shows much faster when some sections are hidden. --- emacs/notmuch-hello.el | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git

[Patch v7 00/13] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

This is essentially the same as id:1330157204-26094-1-git-send-email-markwalters1...@gmail.com but has been rebased against master. The changes are to patch 12/13 for notmuch-show.el (which was posted as a followup to the previous series) and to the tests (patch 9/13) which changed in Austin's

[Patch v7 01/13] cli: add --no-exclude option to count and search.

This option turns off the exclusion so all matching messages are returned. We do not need to add this to notmuch-show as that does not (yet) exclude. --- notmuch-count.c | 17 +++-- notmuch-search.c | 17 +++-- 2 files changed, 22 insertions(+), 12 deletions(-) diff

[Patch v7 03/13] test: add tests for new cli --no-exclude option

The tests test the new --no-exclude option to search and count. There were no existing tests for the exclude behaviour for count so added these too. --- test/count | 21 + test/search |5 + 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/test/count

[Patch v7 05/13] lib: Make notmuch_query_search_messages set the exclude flag

Add a flag NOTMUCH_MESSAGE_FLAG_EXCLUDED which is set by notmuch_query_search_messages for excluded messages. Also add an option omit_excluded_messages to the search that we do not want the excludes at all. This exclude flag will be added to notmuch_query_search threads in the next patch. ---

[Patch v7 06/13] lib: Add the exclude flag to notmuch_query_search_threads

Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to notmuch_query_search_threads. Implemented by inspecting the tags directly in _notmuch_thread_create/_thread_add_message rather than as a Xapian query for speed reasons. Note notmuch_thread_get_matched_messages now returns the number of non-excluded

[Patch v7 07/13] test: update search test to reflect exclude flag

notmuch-search.c now returns all matching threads even if it the match is a search.tag_excluded message (but with a mark indicating this). Update the test to reflect this. --- test/search |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/test/search b/test/search index

[Patch v7 10/13] man: update manpage for notmuch-show --no-exclude option

--- man/man1/notmuch-show.1 |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/man/man1/notmuch-show.1 b/man/man1/notmuch-show.1 index 4c5db94..d75d971 100644 --- a/man/man1/notmuch-show.1 +++ b/man/man1/notmuch-show.1 @@ -128,6 +128,13 @@ multipart/encrypted part will

[Patch v7 11/13] cli: omit excluded messages in results where appropriate.

In all cases of notmuch count/search/show where the results returned cannot reflect the exclude flag return just the matched not-excluded results. If the caller wishes to have all the matched results (i.e., including the excluded ones) they should call with the --no-exclude option. The relevant

[Patch v7 12/13] emacs: show: recognize the exclude flag.

Show mode will recognize the exclude flag by not opening excluding messages by default, and will start at the first matching non-excluded message. If there are no matching non-excluded messages it will go to the first matching (necessarily excluded) message. --- emacs/notmuch-show.el | 36

[Patch v7 09/13] test: update tests to reflect the exclude flag

notmuch show outputs the exclude flag so many tests using notmuch show failed. This commit adds excluded:0 or excluded: false to the expected outputs. After this commit there should be no failing tests. --- test/crypto|9 - test/encoding |2 +- test/json |

[Patch v7 13/13] emacs: notmuch.el ignore excluded matches

This is a small change to make notmuch.el ignore excluded matches. In the future it could do something better like add a button for rerunning the search with the excludes (particularly if nothing matches with the excludes) or having them invisible and allowing the visibility to be toggled. ---

Re: plans for 0.12

On Thu, 01 Mar 2012 22:21:29 +0100, Pieter Praet pie...@praet.org wrote: Some of the features added/refactored post-0.11.1 don't have any test coverage yet. Should they, before wrapping up 0.12 ? (not a rhetorical question, I'm genuinely asking for opinions) Hi Pieter; My initial answer

Re: [PATCH 1/2] test: remove Generate some messages test from raw

Hi David. On Wed, 15 Feb 2012 22:33:51 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi all. Are there any objections to these changes? Otherwise, I would ask David to push it as minor, boring and trivial changes. Since there are no objections, I removed the needs-review

Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections

On Thu, 01 Mar 2012 22:18:04 +, Mark Walters markwalters1...@gmail.com wrote: This looks fine to me and does speed things up when the All tags section is hidden (are there other sections I can hide?) You can define other section that you can then hide, which was the main point of the

Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections

On Fri, 02 Mar 2012 01:34:03 +0100, Daniel Schoepe dan...@schoepe.org wrote: You can define other section that you can then hide, which was the main point of the original patch. The defining other sections thing that is, not that you have more things to hide.. :) pgpOY8At84Uqb.pgp

[no subject]

Probably both of these patches could use some polishing; Austin asked for a test to help debug the crash I found today. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/2] test: utility function to add a pre-generated message to the database.

From: David Bremner brem...@debian.org For various nasty messages, it is easier to ship a message rather than try to generate a message which causes a failure. --- test/test-lib.sh | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh

[PATCH 2/2] test: add new test file for mime parsing.

From: David Bremner brem...@debian.org For now, just tests one message currently causing notmuch to segfault. --- test/mime | 67 + test/notmuch-test |1 + 2 files changed, 68 insertions(+), 0 deletions(-) create mode 100755

Possible bug in gpg signing replies

When using 'mml-secure-sign-pgpmime to sign one part of an email, valid sigs get attached to new emails but not to replies. Instead, when I reply to a message, the signing directive seems to be inserted as plain text and is not processed. Switching to the 'mml-secure-message-sign-pgpmime, which