[PATCH] emacs: keep customizations in groups

2012-03-03 Thread Jani Nikula
Move hello section customization to notmuch-hello group and printing customization to notmuch-show group from the top level customization group. --- emacs/notmuch-hello.el |2 +- emacs/notmuch-print.el |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hell

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-03 Thread Jani Nikula
On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe wrote: > notmuch-saved-search-sort-function might destructively modify its > input (`sort' does that, for instance), so it should not be given > notmuch-saved-searches directly. Hi Daniel, thanks for fixing this. Works for me. Full disclosure:

[PATCH] Fix mml-quoting in responses where pgp-signing is enabled

2012-03-03 Thread Tim Bielawa
(defun notmuch-mua-forward-message () >(message-forward) Works great. Passes unit tests. Definitely a better approach than the original patch. > Notmuch test suite complete. > All 381 tests behaved as expected (2 expected failures). +1 from me (this message replied to and signed using the new patch) -- Tim Bielawa -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 162 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120303/bb4be939/attachment.pgp>

Re: [PATCH] Fix mml-quoting in responses where pgp-signing is enabled

2012-03-03 Thread Tim Bielawa
Great point, I considered that too after I authored the original patch. It's a better approach I think. I'll try and give it a test run later tonight. -Original Message- From: Jani Nikula [j...@nikula.org] Received: Saturday, 03 Mar 2012, 6:36pm To: Tim Bielawa [tbielawa at redhat.com];

[PATCH] Fix mml-quoting in responses where pgp-signing is enabled

2012-03-03 Thread Tim Bielawa
as scrubbed... Name: not available Type: application/pgp-signature Size: 162 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120303/c9f0d7a3/attachment.pgp>

[PATCH 2/2] Use autotools config.sub for --host and --build parsing

2012-03-03 Thread Justus Winter
This introduces a build dependency on autotools, update debian/control accordingly. Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> --- configure | 28 ++-- debian/control |1 + 2 files changed, 7 insertions(+), 22 deletions(-) diff --git a/

[PATCH 1/2] Add GNU as a valid platform

2012-03-03 Thread Justus Winter
Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> --- configure |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 8b85b9d..77203ed 100755 --- a/configure +++ b/configure @@ -362,9 +362,9 @@ elif [ $uname = "SunOS" ] ; then

[rfc] autotools compatibility and Hurd as platform

2012-03-03 Thread Justus Winter
I made two tiny patches to enable notmuch to be built on the Hurd, the first one is straight forward, it just adds GNU as a platform and reuses the settings for Linux. The second one deals with the problem that the value passed as an argument to --build is not a triple but a tuple: % dpkg-archite

Re: [PATCH] Fix mml-quoting in responses where pgp-signing is enabled

2012-03-03 Thread Tim Bielawa
On Sun, 04 Mar 2012 01:36:29 +0200, Jani Nikula wrote: > On Sat, 3 Mar 2012 17:04:22 -0500, Tim Bielawa wrote: > > The addition of mml-quote-region (notmuch-mua.el) in 2c6710e3 breaks > > automatic signing in replies. When replies are mml-quoted and signing > > is enabled by default the "<#part

[PATCH] Fix mml-quoting in responses where pgp-signing is enabled

2012-03-03 Thread Tim Bielawa
The addition of mml-quote-region (notmuch-mua.el) in 2c6710e3 breaks automatic signing in replies. When replies are mml-quoted and signing is enabled by default the "<#part sign=pgpmime>" string will appear on line 1. This will be consumed during the application of the mml-quote-region function and

Re: [PATCH] Fix mml-quoting in responses where pgp-signing is enabled

2012-03-03 Thread Tim Bielawa
Great point, I considered that too after I authored the original patch. It's a better approach I think. I'll try and give it a test run later tonight. -Original Message- From: Jani Nikula [j...@nikula.org] Received: Saturday, 03 Mar 2012, 6:36pm To: Tim Bielawa [tbiel...@redhat.com]; not

Re: [PATCH] Fix mml-quoting in responses where pgp-signing is enabled

2012-03-03 Thread Jani Nikula
On Sat, 3 Mar 2012 17:04:22 -0500, Tim Bielawa wrote: > The addition of mml-quote-region (notmuch-mua.el) in 2c6710e3 breaks > automatic signing in replies. When replies are mml-quoted and signing > is enabled by default the "<#part sign=pgpmime>" string will appear on > line 1. This will be cons

[announce] Bower 0.2

2012-03-03 Thread Peter Wang
Hi, Bower is yet another curses frontend for the Notmuch email system. I wrote it for me, but you might like it, too. https://github.com/wangp/bower Bower 0.2 (2012-03-04) == * Renamed addressbook section to [bower:addressbook]. * Support for configurable search alia

Re: [PATCH] Fix mml-quoting in responses where pgp-signing is enabled

2012-03-03 Thread Tim Bielawa
On Sat, 3 Mar 2012 17:04:22 -0500, Tim Bielawa wrote: > The addition of mml-quote-region (notmuch-mua.el) in 2c6710e3 breaks > automatic signing in replies. When replies are mml-quoted and signing > is enabled by default the "<#part sign=pgpmime>" string will appear on > line 1. This will be cons

Re: [PATCH 5/5] show: Convert raw format to the new self-recursive style

2012-03-03 Thread Jameson Graef Rollins
Hey, Austin. As always, thank you so much for your hard work on this rewrite. It looks like things are definitely moving the right direction. I haven't done a full review of this patch set, and I've been pretty out of the loop on this stuff recently, but I do notice that there are some changes t

[PATCH 5/5] show: Convert raw format to the new self-recursive style

2012-03-03 Thread Jameson Graef Rollins
Hey, Austin. As always, thank you so much for your hard work on this rewrite. It looks like things are definitely moving the right direction. I haven't done a full review of this patch set, and I've been pretty out of the loop on this stuff recently, but I do notice that there are some changes t

[PATCH] Fix mml-quoting in responses where pgp-signing is enabled

2012-03-03 Thread Tim Bielawa
The addition of mml-quote-region (notmuch-mua.el) in 2c6710e3 breaks automatic signing in replies. When replies are mml-quoted and signing is enabled by default the "<#part sign=pgpmime>" string will appear on line 1. This will be consumed during the application of the mml-quote-region function and

[PATCH] emacs: keep customizations in groups

2012-03-03 Thread Jani Nikula
Move hello section customization to notmuch-hello group and printing customization to notmuch-show group from the top level customization group. --- emacs/notmuch-hello.el |2 +- emacs/notmuch-print.el |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hell

[alot] mails tagged 'killed' reappearing

2012-03-03 Thread Philippe LeCavalier
Hi. I can't tell if it's _all_ killed mails but I can say for sure that some tagged mails reappear in the inbox despite them tagged 'killed' and the search mode filter is inbox AND NOT tag:killed. If it's a bug I'll gladly gather more nfo and file it but I don't know how to determine that. Than

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-03 Thread Jani Nikula
On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe wrote: > notmuch-saved-search-sort-function might destructively modify its > input (`sort' does that, for instance), so it should not be given > notmuch-saved-searches directly. Hi Daniel, thanks for fixing this. Works for me. Full disclosure: I

[PATCH 5/5] emacs: make show set --with-excluded

2012-03-03 Thread Mark Walters
Show has to set --with-excluded to deal with cases where it is asked to show a single excluded message. It use JSON so it can easily pass the exclude information to the user. --- emacs/notmuch-show.el |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-show.

[PATCH 4/5] cli: move show to the new --with-excluded naming scheme.

2012-03-03 Thread Mark Walters
This moves show to the --with-excluded naming scheme. When this is set show returns all threads that match including those that only match in an excluded message. When this flag is not set the behaviour depends on whether --entire-threads is set. If it is not set then show only returns the message

[PATCH 3/5] cli: move search to the new --with-excluded naming scheme.

2012-03-03 Thread Mark Walters
This commit replaces the --no-exclude option with a --with-excluded option. The output is identical in all cases except output-summary. In this case they output exactly the same thread lines. They differ in that with the new option the match count (i.e., the x in [x/n] in the output) is the number

[PATCH 2/5] cli: move count to the new --with-excluded naming scheme.

2012-03-03 Thread Mark Walters
Rename the option --no-exclude to --with-excluded. Note that this could be implemented by setting notmuch_query_set_with_excluded_messages but it is simpler not to set the exclude tags in the first place (the two methods give identical output). --- man/man1/notmuch-count.1 |4 ++-- notmuch-cou

[PATCH 1/5] lib: rename (and negate) set_omit_excluded set_with_excluded

2012-03-03 Thread Mark Walters
Rename the function notmuch_query_set_omit_excluded_messages to notmuch_query_set_with_excluded_messages and negate its meaning. Note the suite will not compile currently as the callers of notmuch_query_set_omit_excluded_messages have not been updated yet. --- lib/notmuch.h | 12 +++- l

[PATCH 0/5] Move to --with-excluded approach to excludes

2012-03-03 Thread Mark Walters
This series implements the proposal in id:"87y5riuz7v.fsf at qmul.ac.uk" to move to a consistent --with-excluded approach rather than the previous --no-exclude approach. See the message there and its descendants for discussion. The main user side change is that notmuch-search no longer defaults to

[Patch v7 00/13] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-03-03 Thread Mark Walters
On Sat, 03 Mar 2012 03:42:44 +, Mark Walters wrote: > On Thu, 1 Mar 2012 22:30:32 +, Mark Walters gmail.com> wrote: > > This is essentially the same as > > id:"1330157204-26094-1-git-send-email-markwalters1009 at gmail.com" but > > has been rebased against master. The changes are to pat

[PATCH 0/5] Disable search.exclude_tags for 0.12

2012-03-03 Thread David Bremner
On Wed, 29 Feb 2012 18:13:04 +, Mark Walters wrote: > As requested by David (Bremner) on irc here is a patch series > disabling the search.exclude_tags feature as a temporary measure for > the 0.12 release. > > There are two options: > > The first is to disable the addition of the new searc

[PATCH] Actually close the xapian database in notmuch_database_close

2012-03-03 Thread David Bremner
On Fri, 2 Mar 2012 15:58:39 +0100, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > Formerly the xapian database object was deleted and closed in its > destructor once the object was garbage collected. Explicitly call > close() so that the database and the associated lock is released

[alot] mails tagged 'killed' reappearing

2012-03-03 Thread Philippe LeCavalier
Hi. I can't tell if it's _all_ killed mails but I can say for sure that some tagged mails reappear in the inbox despite them tagged 'killed' and the search mode filter is inbox AND NOT tag:killed. If it's a bug I'll gladly gather more nfo and file it but I don't know how to determine that. Than

[PATCH 0/5] Rewrite mbox and raw show formats

2012-03-03 Thread Tomi Ollila
On Sat, 3 Mar 2012 00:20:20 -0500, Austin Clements wrote: > The show (rewrite) must go on. These are the last two formats in > notmuch show proper; the only remaining format is the reply format. > > One of the ultimate goals of the show rewrite is to make raw actually > work (and probably to sp

[PATCH 2/2] Use autotools config.sub for --host and --build parsing

2012-03-03 Thread Justus Winter
This introduces a build dependency on autotools, update debian/control accordingly. Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de> --- configure | 28 ++-- debian/control |1 + 2 files changed, 7 insertions(+), 22 deletions(-) diff --git a/con

[PATCH 1/2] Add GNU as a valid platform

2012-03-03 Thread Justus Winter
Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de> --- configure |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 8b85b9d..77203ed 100755 --- a/configure +++ b/configure @@ -362,9 +362,9 @@ elif [ $uname = "SunOS" ] ; then

[rfc] autotools compatibility and Hurd as platform

2012-03-03 Thread Justus Winter
I made two tiny patches to enable notmuch to be built on the Hurd, the first one is straight forward, it just adds GNU as a platform and reuses the settings for Linux. The second one deals with the problem that the value passed as an argument to --build is not a triple but a tuple: % dpkg-archite

Re: [PATCH 0/5] Disable search.exclude_tags for 0.12

2012-03-03 Thread David Bremner
On Wed, 29 Feb 2012 18:13:04 +, Mark Walters wrote: > As requested by David (Bremner) on irc here is a patch series > disabling the search.exclude_tags feature as a temporary measure for > the 0.12 release. > > There are two options: > > The first is to disable the addition of the new searc

Re: [PATCH] Actually close the xapian database in notmuch_database_close

2012-03-03 Thread David Bremner
On Fri, 2 Mar 2012 15:58:39 +0100, Justus Winter <4win...@informatik.uni-hamburg.de> wrote: > Formerly the xapian database object was deleted and closed in its > destructor once the object was garbage collected. Explicitly call > close() so that the database and the associated lock is released >

[PATCH 5/5] emacs: make show set --with-excluded

2012-03-03 Thread Mark Walters
Show has to set --with-excluded to deal with cases where it is asked to show a single excluded message. It use JSON so it can easily pass the exclude information to the user. --- emacs/notmuch-show.el |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-show.

[PATCH 4/5] cli: move show to the new --with-excluded naming scheme.

2012-03-03 Thread Mark Walters
This moves show to the --with-excluded naming scheme. When this is set show returns all threads that match including those that only match in an excluded message. When this flag is not set the behaviour depends on whether --entire-threads is set. If it is not set then show only returns the message

[PATCH 3/5] cli: move search to the new --with-excluded naming scheme.

2012-03-03 Thread Mark Walters
This commit replaces the --no-exclude option with a --with-excluded option. The output is identical in all cases except output-summary. In this case they output exactly the same thread lines. They differ in that with the new option the match count (i.e., the x in [x/n] in the output) is the number

[PATCH 2/5] cli: move count to the new --with-excluded naming scheme.

2012-03-03 Thread Mark Walters
Rename the option --no-exclude to --with-excluded. Note that this could be implemented by setting notmuch_query_set_with_excluded_messages but it is simpler not to set the exclude tags in the first place (the two methods give identical output). --- man/man1/notmuch-count.1 |4 ++-- notmuch-cou

[PATCH 1/5] lib: rename (and negate) set_omit_excluded set_with_excluded

2012-03-03 Thread Mark Walters
Rename the function notmuch_query_set_omit_excluded_messages to notmuch_query_set_with_excluded_messages and negate its meaning. Note the suite will not compile currently as the callers of notmuch_query_set_omit_excluded_messages have not been updated yet. --- lib/notmuch.h | 12 +++- l

[PATCH 0/5] Move to --with-excluded approach to excludes

2012-03-03 Thread Mark Walters
This series implements the proposal in id:"87y5riuz7v@qmul.ac.uk" to move to a consistent --with-excluded approach rather than the previous --no-exclude approach. See the message there and its descendants for discussion. The main user side change is that notmuch-search no longer defaults to sh

Re: [Patch v7 00/13] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-03-03 Thread Mark Walters
On Sat, 03 Mar 2012 03:42:44 +, Mark Walters wrote: > On Thu, 1 Mar 2012 22:30:32 +, Mark Walters > wrote: > > This is essentially the same as > > id:"1330157204-26094-1-git-send-email-markwalters1...@gmail.com" but > > has been rebased against master. The changes are to patch 12/13 fo

[Patch v7 00/13] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-03-03 Thread Mark Walters
On Thu, 1 Mar 2012 22:30:32 +, Mark Walters wrote: > This is essentially the same as > id:"1330157204-26094-1-git-send-email-markwalters1009 at gmail.com" but > has been rebased against master. The changes are to patch 12/13 for > notmuch-show.el (which was posted as a followup to the previo

[PATCH 2/2] vim plugin: Implement attachment saving

2012-03-03 Thread Charlie Allom
Ryan Harper writes: > Using the dictionary of attachments in a message we can implement > saving the attachment. Select the current attachment under the cursor > request a new name, but default to the extracted name. > Hi Ryan, can you see why I might be getting these errors on 'S'? here is m

[PATCH 5/5] show: Convert raw format to the new self-recursive style

2012-03-03 Thread Austin Clements
This is fully compatible for root and leaf parts, but drops support for interior parts. Showing interior parts in raw has always been braindead broken, so I don't think anyone will miss this. Tests have been updated to reflect this. The diff looks complicated, but the change is simple. We delet

[PATCH 4/5] show: Move format_part_content_raw with the other new-style formats

2012-03-03 Thread Austin Clements
Just code motion. --- notmuch-show.c | 54 +++--- 1 files changed, 27 insertions(+), 27 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 72c141e..6f6052c 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -475,33 +475,6 @@ format_p

[PATCH 3/5] show: Convert mbox format to new self-recursive style

2012-03-03 Thread Austin Clements
Given the lack of recursion, this is pretty easy. --- notmuch-show.c | 40 ++-- 1 files changed, 18 insertions(+), 22 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index b3a4550..72c141e 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -45,25 +

[PATCH 2/5] show: Move format_message_mbox with the other new-style formats

2012-03-03 Thread Austin Clements
Just code motion. --- notmuch-show.c | 100 1 files changed, 50 insertions(+), 50 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 648f468..b3a4550 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -219,56 +219,6 @@ _is_fr

[PATCH 1/5] show: Allow formatters to return errors

2012-03-03 Thread Austin Clements
Formatter errors are propagated to the exit status of notmuch show. This isn't used by the JSON or text formatters, but it will be useful for the raw format, which is pickier. --- notmuch-client.h |6 ++-- notmuch-show.c | 69 +++-- 2 files

[PATCH 0/5] Rewrite mbox and raw show formats

2012-03-03 Thread Austin Clements
The show (rewrite) must go on. These are the last two formats in notmuch show proper; the only remaining format is the reply format. One of the ultimate goals of the show rewrite is to make raw actually work (and probably to split it into two different formats). This series does not do that; it

Re: [PATCH 0/5] Rewrite mbox and raw show formats

2012-03-03 Thread Tomi Ollila
On Sat, 3 Mar 2012 00:20:20 -0500, Austin Clements wrote: > The show (rewrite) must go on. These are the last two formats in > notmuch show proper; the only remaining format is the reply format. > > One of the ultimate goals of the show rewrite is to make raw actually > work (and probably to sp