[PATCH v4 0/6] Move --no-exclude to --exclude=(true|false|flag)

Mark Walters writes: > This is version 4 of the exclude= patch set. Version 3 was at [1]. > > The only changes relative to version 3 are in the tests. As suggested > by jrollins [2] I have added some systematic count and show tests and > moved all the exclude tests to the file test/excludes. Pus

[PATCH] News for raw format changes

--- NEWS | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index a618a9d..c1704e0 100644 --- a/NEWS +++ b/NEWS @@ -41,6 +41,17 @@ Tag exclusion notmuch config set search.exclude_tags deleted spam +Raw show format changes + + The output of show

[PATCH] Record dependencies during build instead of before

Previously, the makefile created dependency files in a separate, first pass. In particular, include-ing the dependency files would cause make to attempt to rebuild those files using the dependency-generation rules in the makefile. Unfortunately, this approach required obtuse rules and silently de

[PATCH 6/6] show: Remove empty message_set_{start,sep,end} fields

Setting these to NULL is equivalent to the empty string now. --- notmuch-show.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index ef26ad2..7929476 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -26,10 +26,7 @@ format_part_te

[PATCH 5/6] show: Support NULL values for message_set_{start, sep, end}

Many formats don't need these, so it's more convenient if they don't have to set them at all. --- notmuch-show.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 5a71115..ef26ad2 100644 --- a/notmuch-show.c +++ b

[PATCH 4/6] show: Remove unused fields from notmuch_show_format

These fields were only used by old-style formatters. --- notmuch-client.h | 23 --- 1 files changed, 0 insertions(+), 23 deletions(-) diff --git a/notmuch-client.h b/notmuch-client.h index 34155fc..f0fb748 100644 --- a/notmuch-client.h +++ b/notmuch-client.h @@ -70,29 +70,6

[PATCH 3/6] Remove show-message.c

There are no more calls to show_message_body. --- Makefile.local |1 - notmuch-client.h |5 --- show-message.c | 106 -- 3 files changed, 0 insertions(+), 112 deletions(-) delete mode 100644 show-message.c diff --git a/Makefile.loc

[PATCH 2/6] show: Remove support for old-style formatters in show_message

show_message used to have a compatibility path for old-style formatters. This removes that. --- notmuch-show.c | 52 +--- 1 files changed, 13 insertions(+), 39 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 0bf5e21..5a71115 10064

[PATCH 1/6] Sync schemata with current code structure

The schema itself hasn't changed, but many of the references to functions in notmuch-show.c were out of date. --- devel/schemata | 21 +++-- 1 files changed, 7 insertions(+), 14 deletions(-) diff --git a/devel/schemata b/devel/schemata index 728a46f..977cea7 100644 --- a/devel/s

[PATCH 0/6] Finish show rewrite

The long-awaited and oft-belated conclusion of the show rewrite. All of the formatters have been converted to the new style, so this series just rips out unused code and does a little cleanup.

Re: [PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface

On Sun, 08 Apr 2012, Jameson Graef Rollins wrote: > The main change here is to modify argument parsing so as to not force > tag-changes to be a list, and to let notmuch-tag handle prompting the > user when required. doc strings are also updated and cleaned up. > --- > emacs/notmuch-show.el |

Re: [PATCH v4 0/6] Move --no-exclude to --exclude=(true|false|flag)

Mark Walters writes: > This is version 4 of the exclude= patch set. Version 3 was at [1]. > > The only changes relative to version 3 are in the tests. As suggested > by jrollins [2] I have added some systematic count and show tests and > moved all the exclude tests to the file test/excludes. Pus

Why not tags inside messages?

thing like this? I guess not... Thanks D. Odesl?no z tabletu Samsung -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120407/700094c0/attachment.html>

Re: [PATCH v4 0/6] Move --no-exclude to --exclude=(true|false|flag)

On Sat, Apr 07 2012, Mark Walters wrote: > This is version 4 of the exclude= patch set. Version 3 was at [1]. > > The only changes relative to version 3 are in the tests. As suggested > by jrollins [2] I have added some systematic count and show tests and > moved all the exclude tests to the file

[PATCH v4 0/6] Move --no-exclude to --exclude=(true|false|flag)

sts to the file test/excludes. Tested. LGTM. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120407/153f10b8/attachment.pgp>

[PATCH] News for raw format changes

--- NEWS | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index a618a9d..c1704e0 100644 --- a/NEWS +++ b/NEWS @@ -41,6 +41,17 @@ Tag exclusion notmuch config set search.exclude_tags deleted spam +Raw show format changes + + The output of sho

[PATCH v4 0/6] Move --no-exclude to --exclude=(true|false|flag)

LGTM. If for some reason you roll another version, you should update the commit message on the test patch, but that's obviously not enough to hold this series up. Quoth Mark Walters on Apr 07 at 5:10 pm: > This is version 4 of the exclude= patch set. Version 3 was at [1]. > > The only changes r

[PATCH 5/6] show: Support NULL values for message_set_{start, sep, end}

Many formats don't need these, so it's more convenient if they don't have to set them at all. --- notmuch-show.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 5a71115..ef26ad2 100644 --- a/notmuch-show.c +++ b

[PATCH 6/6] show: Remove empty message_set_{start,sep,end} fields

Setting these to NULL is equivalent to the empty string now. --- notmuch-show.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index ef26ad2..7929476 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -26,10 +26,7 @@ format_part_te

[PATCH 3/6] Remove show-message.c

There are no more calls to show_message_body. --- Makefile.local |1 - notmuch-client.h |5 --- show-message.c | 106 -- 3 files changed, 0 insertions(+), 112 deletions(-) delete mode 100644 show-message.c diff --git a/Makefile.loc

[PATCH 2/6] show: Remove support for old-style formatters in show_message

show_message used to have a compatibility path for old-style formatters. This removes that. --- notmuch-show.c | 52 +--- 1 files changed, 13 insertions(+), 39 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 0bf5e21..5a71115 10064

[PATCH 1/6] Sync schemata with current code structure

The schema itself hasn't changed, but many of the references to functions in notmuch-show.c were out of date. --- devel/schemata | 21 +++-- 1 files changed, 7 insertions(+), 14 deletions(-) diff --git a/devel/schemata b/devel/schemata index 728a46f..977cea7 100644 --- a/devel/s

[PATCH 4/6] show: Remove unused fields from notmuch_show_format

These fields were only used by old-style formatters. --- notmuch-client.h | 23 --- 1 files changed, 0 insertions(+), 23 deletions(-) diff --git a/notmuch-client.h b/notmuch-client.h index 34155fc..f0fb748 100644 --- a/notmuch-client.h +++ b/notmuch-client.h @@ -70,29 +70,6

[PATCH 0/6] Finish show rewrite

The long-awaited and oft-belated conclusion of the show rewrite. All of the formatters have been converted to the new style, so this series just rips out unused code and does a little cleanup. ___ notmuch mailing list notmuch@notmuchmail.org http://notm

[PATCH 1/8] emacs: create notmuch-tag.el, and move appropriate functions from notmuch.el

Tagging functions are used in notmuch.el, notmuch-show.el, and notmuch-message.el. There are enough common functions for tagging that it makes sense to put them all in their own library. No code is modified, just moved around. --- emacs/Makefile.local |1 + emacs/notmuch-message.el |

[PATCH 3/8] emacs: have tag-completion return all tags for nil input

Previously the function would fail if the initial input was nil. Now it will return a list of all tags, which obviously makes much more sense. --- emacs/notmuch-tag.el |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el index 5240d

[PATCH 6/8] emacs: eliminate search-tag-thread in favor of just search-tag

notmuch-search-tag-thread is now completely redundant with notmuch-search-tag so we eliminate it to simplify the interface. --- emacs/notmuch.el |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index a03a526..d79a448 100644 --- a/e

[PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface

The main change here is to modify argument parsing so as to not force tag-changes to be a list, and to let notmuch-tag handle prompting the user when required. doc strings are also updated and cleaned up. --- emacs/notmuch-show.el | 26 +++--- 1 files changed, 15 insertions(

emacs tagging cleanup

This is a rework of the series [0]. It addresses some of the comments from Dmitry, and extends the scope to clean up the tagging interface in both search and show mode. [0] id:"154853-25729-1-git-send-email-jroll...@finestructure.net" The goal here is to present a cleaner tagging interface t

[PATCH 5/8] emacs: modify search tag functions to use new notmuch-tag interface

The main change here is to modify argument parsing so as to not force tag-changes to be a list, and to let notmuch-tag handle prompting the user when required. doc strings are also updated and cleaned up. --- emacs/notmuch.el | 36 +--- 1 files changed, 13 insert

[PATCH 2/8] emacs: update tag-completion function

"search-tags" is deprecated, so we move to the more modern and supported "search --output=tags". --- emacs/notmuch-tag.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el index 81b4b00..5240d13 100644 --- a/emacs/notmuch-tag.el +

[PATCH 4/8] emacs: allow notmuch-tag to accept string inputs and prompt for tags

notmuch-tag is extended to accept various formats of the tag changes. In particular, user prompting for tag changes is now incorporated here, so it is common for modes. --- emacs/notmuch-tag.el | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/emacs/notmu

[PATCH 8/8] emacs: eliminate show-tag-message in favor of just show-tag

notmuch-show-tag-message is now completely redundant with notmuch-show-tag so we eliminate it to simplify the interface. --- emacs/notmuch-show.el | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 69bca02..f17

[PATCH 8/8] emacs: eliminate show-tag-message in favor of just show-tag

notmuch-show-tag-message is now completely redundant with notmuch-show-tag so we eliminate it to simplify the interface. --- emacs/notmuch-show.el | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 69bca02..f17

[PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface

The main change here is to modify argument parsing so as to not force tag-changes to be a list, and to let notmuch-tag handle prompting the user when required. doc strings are also updated and cleaned up. --- emacs/notmuch-show.el | 26 +++--- 1 files changed, 15 insertions(

[PATCH 6/8] emacs: eliminate search-tag-thread in favor of just search-tag

notmuch-search-tag-thread is now completely redundant with notmuch-search-tag so we eliminate it to simplify the interface. --- emacs/notmuch.el |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index a03a526..d79a448 100644 --- a/e

[PATCH 5/8] emacs: modify search tag functions to use new notmuch-tag interface

The main change here is to modify argument parsing so as to not force tag-changes to be a list, and to let notmuch-tag handle prompting the user when required. doc strings are also updated and cleaned up. --- emacs/notmuch.el | 36 +--- 1 files changed, 13 insert

[PATCH 4/8] emacs: allow notmuch-tag to accept string inputs and prompt for tags

notmuch-tag is extended to accept various formats of the tag changes. In particular, user prompting for tag changes is now incorporated here, so it is common for modes. --- emacs/notmuch-tag.el | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/emacs/notmu

[PATCH 3/8] emacs: have tag-completion return all tags for nil input

Previously the function would fail if the initial input was nil. Now it will return a list of all tags, which obviously makes much more sense. --- emacs/notmuch-tag.el |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el index 5240d

[PATCH 2/8] emacs: update tag-completion function

"search-tags" is deprecated, so we move to the more modern and supported "search --output=tags". --- emacs/notmuch-tag.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el index 81b4b00..5240d13 100644 --- a/emacs/notmuch-tag.el +

[PATCH 1/8] emacs: create notmuch-tag.el, and move appropriate functions from notmuch.el

Tagging functions are used in notmuch.el, notmuch-show.el, and notmuch-message.el. There are enough common functions for tagging that it makes sense to put them all in their own library. No code is modified, just moved around. --- emacs/Makefile.local |1 + emacs/notmuch-message.el |

emacs tagging cleanup

This is a rework of the series [0]. It addresses some of the comments from Dmitry, and extends the scope to clean up the tagging interface in both search and show mode. [0] id:"154853-25729-1-git-send-email-jrollins at finestructure.net" The goal here is to present a cleaner tagging interfac

[PATCH v4 6/6] emacs: make show set --exclude=false

Show has to set --exclude=false to deal with cases where it is asked to show a single excluded message. It uses JSON so it can easily pass the exclude information to the user. --- emacs/notmuch-show.el |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-show

[PATCH v4 5/6] test: add some exclude tests

Systematically test the exclude options for search. Also move the search existing exclude tests into the new test. There is some overlap between the two sets of tests but many of the existing ones are there because they triggered bugs in the past so I have kept them to ensure coverage. --- test/co

[PATCH v4 4/6] cli: move show to the new --exclude= option naming scheme.

This moves notmuch show to the --exclude=(true|false) naming scheme. When exclude=false show returns all threads that match including those that only match in an excluded message. The excluded messages are flagged. When exclude=true the behaviour depends on whether --entire-thread is set. If it is

[PATCH v4 3/6] cli: move search to the new --exclude= naming scheme.

This commit replaces the --no-exclude option with a --exclude=(true|false|flag) option. The default is to omit the excluded messages. The flag option only makes sense if output=summary (as otherwise there is nowhere to print the flag). In summary output exclude=false and exclude=flag give almost i

[PATCH v4 2/6] cli: move count to the new --exclude=(true|false|flag) naming scheme.

Move the option --no-exclude to the --exclude= scheme. Since there is no way to flag messages only true and false are implemented. Note that, for consistency with other commands, this is implemented as a keyword option rather than a boolean option. --- man/man1/notmuch-count.1 |5 +++-- notmuc

[PATCH v4 1/6] lib: change default for notmuch_query_set_omit_excluded

--- lib/notmuch.h | 23 ++- lib/query.cc | 10 +- 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/lib/notmuch.h b/lib/notmuch.h index babd208..673c423 100644 --- a/lib/notmuch.h +++ b/lib/notmuch.h @@ -449,12 +449,25 @@ typedef enum { const char *

[PATCH v4 0/6] Move --no-exclude to --exclude=(true|false|flag)

This is version 4 of the exclude= patch set. Version 3 was at [1]. The only changes relative to version 3 are in the tests. As suggested by jrollins [2] I have added some systematic count and show tests and moved all the exclude tests to the file test/excludes. Best wishes Mark [1] id:"13337165

Re: [PATCH v4 0/6] Move --no-exclude to --exclude=(true|false|flag)

LGTM. If for some reason you roll another version, you should update the commit message on the test patch, but that's obviously not enough to hold this series up. Quoth Mark Walters on Apr 07 at 5:10 pm: > This is version 4 of the exclude= patch set. Version 3 was at [1]. > > The only changes r

Why not tags inside messages?

On Sat, 07 Apr 2012 18:46:03 +0200, David Belohrad wrote: > Dear all, > > I'd love to use notmuch with offline imap ?to work rather on local > copy of messages, than using remote notmuch, which is slightly slower > due to bandwidth limitation of my vdsl line. There is however > fundamental proble

Why not tags inside messages?

Hi David, On Sat, Apr 7, 2012 at 10:46, David Belohrad wrote: > I'd love to use notmuch with offline imap ?to work rather on local copy of > messages, than using remote notmuch, which is slightly slower due to > bandwidth limitation of my vdsl line. There is however fundamental problem > of synci

Re: Why not tags inside messages?

Hi David, On Sat, Apr 7, 2012 at 10:46, David Belohrad wrote: > I'd love to use notmuch with offline imap  to work rather on local copy of > messages, than using remote notmuch, which is slightly slower due to > bandwidth limitation of my vdsl line. There is however fundamental problem > of synci

Re: Why not tags inside messages?

On Sat, 07 Apr 2012 18:46:03 +0200, David Belohrad wrote: > Dear all, > > I'd love to use notmuch with offline imap  to work rather on local > copy of messages, than using remote notmuch, which is slightly slower > due to bandwidth limitation of my vdsl line. There is however > fundamental proble

Why not tags inside messages?

Dear all, I'd love to use notmuch with offline imap  to work rather on local copy of messages, than using remote notmuch, which is slightly slower due to bandwidth limitation of my vdsl line. There is however fundamental problem of syncing flags between two instances of notmuch. So my question

[PATCH v4 6/6] emacs: make show set --exclude=false

Show has to set --exclude=false to deal with cases where it is asked to show a single excluded message. It uses JSON so it can easily pass the exclude information to the user. --- emacs/notmuch-show.el |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-show

[PATCH v4 5/6] test: add some exclude tests

Systematically test the exclude options for search. Also move the search existing exclude tests into the new test. There is some overlap between the two sets of tests but many of the existing ones are there because they triggered bugs in the past so I have kept them to ensure coverage. --- test/co

[PATCH v4 4/6] cli: move show to the new --exclude= option naming scheme.

This moves notmuch show to the --exclude=(true|false) naming scheme. When exclude=false show returns all threads that match including those that only match in an excluded message. The excluded messages are flagged. When exclude=true the behaviour depends on whether --entire-thread is set. If it is

[PATCH v4 3/6] cli: move search to the new --exclude= naming scheme.

This commit replaces the --no-exclude option with a --exclude=(true|false|flag) option. The default is to omit the excluded messages. The flag option only makes sense if output=summary (as otherwise there is nowhere to print the flag). In summary output exclude=false and exclude=flag give almost i

[PATCH v4 2/6] cli: move count to the new --exclude=(true|false|flag) naming scheme.

Move the option --no-exclude to the --exclude= scheme. Since there is no way to flag messages only true and false are implemented. Note that, for consistency with other commands, this is implemented as a keyword option rather than a boolean option. --- man/man1/notmuch-count.1 |5 +++-- notmuc

[PATCH v4 1/6] lib: change default for notmuch_query_set_omit_excluded

--- lib/notmuch.h | 23 ++- lib/query.cc | 10 +- 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/lib/notmuch.h b/lib/notmuch.h index babd208..673c423 100644 --- a/lib/notmuch.h +++ b/lib/notmuch.h @@ -449,12 +449,25 @@ typedef enum { const char *

[PATCH v4 0/6] Move --no-exclude to --exclude=(true|false|flag)

This is version 4 of the exclude= patch set. Version 3 was at [1]. The only changes relative to version 3 are in the tests. As suggested by jrollins [2] I have added some systematic count and show tests and moved all the exclude tests to the file test/excludes. Best wishes Mark [1] id:"13337165