I must say I don't use these go bindings in anger anymore: this was
mainly a test project for go.
(I am still a happy go user as well as a notmuch one, though, but I
prefer bbdb to notmuch-addrlookup)
-s
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120430/a6285059/attachment.pgp>
Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de>
---
bindings/go/src/notmuch-addrlookup/addrlookup.go | 80 ++--
bindings/go/src/notmuch/notmuch.go | 87 +++---
2 files changed, 85 insertions(+), 82 deletions(-)
diff --git a/bin
Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de>
---
bindings/go/Makefile | 51 ++---
bindings/go/cmds/Makefile | 11 --
bindings/go/pkg/Makefile | 17 ---
3 files changed, 30 insertions(+), 49 deletions(-)
Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de>
---
bindings/go/src/notmuch-addrlookup/addrlookup.go |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/bindings/go/src/notmuch-addrlookup/addrlookup.go
b/bindings/go/src/notmuch-addrlookup/addrlookup.go
Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de>
---
bindings/go/src/notmuch/notmuch.go |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bindings/go/src/notmuch/notmuch.go
b/bindings/go/src/notmuch/notmuch.go
index de9de23..524c956 100644
--- a/bindings
Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de>
---
bindings/go/cmds/notmuch-addrlookup.go | 259 -
bindings/go/pkg/notmuch.go | 1124 --
bindings/go/src/notmuch-addrlookup/addrlookup.go | 259 +
bindings/go/src/notm
Quoting David Bremner (2012-04-30 13:53:47)
> Austin Clements writes:
>
> > The signature of notmuch_database_find_message was changed in 02a30767
> > to report errors and the Go bindings were never updated. This brings
> > the Go bindings in sync with that change and at least makes them
> > com
On Mon, Apr 30, 2012 at 10:50, Michal Sojka wrote:
> json_xs didn't complain, but I've found that notmuch outputs
> ?Failed to verify signed part: Cannot verify multipart/signed part:
> unsupported signature protocol 'application/x-pkcs7-signature'.
> to stderr before the json output and emacs tr
On Mon, Apr 30, 2012 at 10:50, Michal Sojka wrote:
> json_xs didn't complain, but I've found that notmuch outputs
> Failed to verify signed part: Cannot verify multipart/signed part:
> unsupported signature protocol 'application/x-pkcs7-signature'.
> to stderr before the json output and emacs tr
Hi Adam,
Adam Wolfe Gordon writes:
> On Mon, Apr 30, 2012 at 09:00, Michal Sojka wrote:
>> when I try to reply within emacs to a particular message, I get "JSON
>> readtable error". This happens with with the current git master as well
>> as with a version from about a month ago. Is this a known
Hi list,
when I try to reply within emacs to a particular message, I get "JSON
readtable error". This happens with with the current git master as well
as with a version from about a month ago. Is this a known problem or
shall I dig into it and find what wrong?
Thanks,
-Michal
On Sun, Apr 29 2012, David Bremner wrote:
> Tomi Ollila writes:
>
>> Changed all tabs to 8 spaces (M-x untabify over region of the
>> whole file).
>
> All three of these look OK to me. I do wonder whether we should call the
> file NEWS.mdwn or something like that if we intend to enforce markdown
On Mon, Apr 30 2012, David Bremner wrote:
> Vladimir.Marek at oracle.com writes:
>
>> diff --git a/configure b/configure
>> index 71981b7..6870341 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1,4 +1,4 @@
>> -#! /bin/sh
>> +#! /bin/bash
>
> I realize the true story is more complicated than
Justus,
Justus Winter <4win...@informatik.uni-hamburg.de> writes:
> Quoting David Bremner (2012-04-30 13:53:47)
>> Austin Clements writes:
>>
>> > The signature of notmuch_database_find_message was changed in 02a30767
>> > to report errors and the Go bindings were never updated. This brings
>
Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de>
---
bindings/go/src/notmuch-addrlookup/addrlookup.go | 80 ++--
bindings/go/src/notmuch/notmuch.go | 87 +++---
2 files changed, 85 insertions(+), 82 deletions(-)
diff --git a/bindin
Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de>
---
bindings/go/Makefile | 51 ++---
bindings/go/cmds/Makefile | 11 --
bindings/go/pkg/Makefile | 17 ---
3 files changed, 30 insertions(+), 49 deletions(-)
de
Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de>
---
bindings/go/src/notmuch-addrlookup/addrlookup.go |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/bindings/go/src/notmuch-addrlookup/addrlookup.go
b/bindings/go/src/notmuch-addrlookup/addrlookup.go
in
Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de>
---
bindings/go/src/notmuch/notmuch.go |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bindings/go/src/notmuch/notmuch.go
b/bindings/go/src/notmuch/notmuch.go
index de9de23..524c956 100644
--- a/bindings/go
Quoting David Bremner (2012-04-30 13:53:47)
> Austin Clements writes:
>
> > The signature of notmuch_database_find_message was changed in 02a30767
> > to report errors and the Go bindings were never updated. This brings
> > the Go bindings in sync with that change and at least makes them
> > com
---
NEWS | 13 +
1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/NEWS b/NEWS
index a2cd080..0f031f3 100644
--- a/NEWS
+++ b/NEWS
@@ -76,15 +76,20 @@ contrib/ from now on.
Library changes
---
-API changes
-
- The function notmuch_database_close has been
---
bindings/ruby/database.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/bindings/ruby/database.c b/bindings/ruby/database.c
index ba9a139..409d54f 100644
--- a/bindings/ruby/database.c
+++ b/bindings/ruby/database.c
@@ -42,6 +42,8 @@ notmuch_rb_database_ini
---
bindings/python/notmuch/database.py | 29 -
1 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/bindings/python/notmuch/database.py
b/bindings/python/notmuch/database.py
index 268e952..adc0a3f 100644
--- a/bindings/python/notmuch/database.py
+++ b/bi
This requires changing the return types of NewDatabase and
OpenDatabase to follow the standard Go convention for returning
errors.
---
bindings/go/pkg/notmuch.go | 24
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/bindings/go/pkg/notmuch.go b/bindings/
This is the notmuch_database_create equivalent of the previous change.
In this case, there were places where errors were not being propagated
correctly in notmuch_database_create or in calls to it. These have
been fixed, using the new status value.
---
lib/database.cc | 29
It has been a long-standing issue that notmuch_database_open doesn't
return any indication of why it failed. This patch changes its
prototype to return a notmuch_status_t and set an out-argument to the
database itself, like other functions that return both a status and an
object.
In the interest
Relative to v1, this makes notmuch_database_open and
notmuch_database_create gracefully handle a NULL out-argument and adds
documentation of the possible error return values from these two
functions. Patches 3 and on have not changed.
Quoth David Bremner on Apr 30 at 8:39 am:
>
> I have two questions, both of which might have been settled previously.
>
> >
> > -return notmuch;
> > +*database = notmuch;
> > +return status;
> > }
>
> Should we check database is non-NULL here?
Sure, why not. Since one could now
bservation might be faulty memory.
Best regards,
James
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120430/b502b3e4/attachment.pgp>
Hi Adam,
Adam Wolfe Gordon writes:
> On Mon, Apr 30, 2012 at 09:00, Michal Sojka wrote:
>> when I try to reply within emacs to a particular message, I get "JSON
>> readtable error". This happens with with the current git master as well
>> as with a version from about a month ago. Is this a known
---
bindings/ruby/database.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/bindings/ruby/database.c b/bindings/ruby/database.c
index ba9a139..409d54f 100644
--- a/bindings/ruby/database.c
+++ b/bindings/ruby/database.c
@@ -42,6 +42,8 @@ notmuch_rb_database_ini
This is the notmuch_database_create equivalent of the previous change.
In this case, there were places where errors were not being propagated
correctly in notmuch_database_create or in calls to it. These have
been fixed, using the new status value.
---
lib/database.cc | 29
Relative to v1, this makes notmuch_database_open and
notmuch_database_create gracefully handle a NULL out-argument and adds
documentation of the possible error return values from these two
functions. Patches 3 and on have not changed.
___
notmuch mailin
This requires changing the return types of NewDatabase and
OpenDatabase to follow the standard Go convention for returning
errors.
---
bindings/go/pkg/notmuch.go | 24
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/bindings/go/pkg/notmuch.go b/bindings/
It has been a long-standing issue that notmuch_database_open doesn't
return any indication of why it failed. This patch changes its
prototype to return a notmuch_status_t and set an out-argument to the
database itself, like other functions that return both a status and an
object.
In the interest
---
NEWS | 13 +
1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/NEWS b/NEWS
index a2cd080..0f031f3 100644
--- a/NEWS
+++ b/NEWS
@@ -76,15 +76,20 @@ contrib/ from now on.
Library changes
---
-API changes
-
- The function notmuch_database_close has been
---
bindings/python/notmuch/database.py | 29 -
1 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/bindings/python/notmuch/database.py
b/bindings/python/notmuch/database.py
index 268e952..adc0a3f 100644
--- a/bindings/python/notmuch/database.py
+++ b/bi
Quoth David Bremner on Apr 30 at 8:39 am:
>
> I have two questions, both of which might have been settled previously.
>
> >
> > -return notmuch;
> > +*database = notmuch;
> > +return status;
> > }
>
> Should we check database is non-NULL here?
Sure, why not. Since one could now
Hi Michal,
On Mon, Apr 30, 2012 at 09:00, Michal Sojka wrote:
> when I try to reply within emacs to a particular message, I get "JSON
> readtable error". This happens with with the current git master as well
> as with a version from about a month ago. Is this a known problem or
> shall I dig into
Vladimir.Marek at oracle.com writes:
> diff --git a/configure b/configure
> index 71981b7..6870341 100755
> --- a/configure
> +++ b/configure
> @@ -1,4 +1,4 @@
> -#! /bin/sh
> +#! /bin/bash
I realize the true story is more complicated than this, but how do
people feel about specifying bash for co
Austin Clements writes:
> The signature of notmuch_database_find_message was changed in 02a30767
> to report errors and the Go bindings were never updated. This brings
> the Go bindings in sync with that change and at least makes them
> compile with Go r60.3, the last release before Go 1.
I don
I have two questions, both of which might have been settled previously.
>
> -return notmuch;
> +*database = notmuch;
> +return status;
> }
Should we check database is non-NULL here?
> diff --git a/notmuch-count.c b/notmuch-count.c
> index 9c2ad7b..2f98128 100644
> --- a/notmuch-c
It's a JSON parsing error. I don't know if it's a known error, but it's
not one I've seen chatter about on this list. I've gotten it too and
haven't really looked into it. I suspect it is a bug in the Emacs JSON
parsing function. but that I can only support that suspicion with
hunches and slande
Hi Michal,
On Mon, Apr 30, 2012 at 09:00, Michal Sojka wrote:
> when I try to reply within emacs to a particular message, I get "JSON
> readtable error". This happens with with the current git master as well
> as with a version from about a month ago. Is this a known problem or
> shall I dig into
Hi list,
when I try to reply within emacs to a particular message, I get "JSON
readtable error". This happens with with the current git master as well
as with a version from about a month ago. Is this a known problem or
shall I dig into it and find what wrong?
Thanks,
-Michal
On Mon, Apr 30 2012, Mark Walters wrote:
[ ... ]
> ---
> emacs/notmuch-show.el | 21 -
> 1 files changed, 16 insertions(+), 5 deletions(-)
[ ... ]
> - (setq notmuch-search-line-faces '((\"delete\" . (:foreground \"red\"
> + (setq notmuch-search-line-faces '((\"tag:delete\
On Sun, Apr 29 2012, David Bremner wrote:
> Tomi Ollila writes:
>
>> Changed all tabs to 8 spaces (M-x untabify over region of the
>> whole file).
>
> All three of these look OK to me. I do wonder whether we should call the
> file NEWS.mdwn or something like that if we intend to enforce markdown
On Mon, Apr 30 2012, David Bremner wrote:
> vladimir.ma...@oracle.com writes:
>
>> diff --git a/configure b/configure
>> index 71981b7..6870341 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1,4 +1,4 @@
>> -#! /bin/sh
>> +#! /bin/bash
>
> I realize the true story is more complicated than thi
vladimir.ma...@oracle.com writes:
> diff --git a/configure b/configure
> index 71981b7..6870341 100755
> --- a/configure
> +++ b/configure
> @@ -1,4 +1,4 @@
> -#! /bin/sh
> +#! /bin/bash
I realize the true story is more complicated than this, but how do
people feel about specifying bash for confi
Austin Clements writes:
> The signature of notmuch_database_find_message was changed in 02a30767
> to report errors and the Go bindings were never updated. This brings
> the Go bindings in sync with that change and at least makes them
> compile with Go r60.3, the last release before Go 1.
I don
I have two questions, both of which might have been settled previously.
>
> -return notmuch;
> +*database = notmuch;
> +return status;
> }
Should we check database is non-NULL here?
> diff --git a/notmuch-count.c b/notmuch-count.c
> index 9c2ad7b..2f98128 100644
> --- a/notmuch-c
On Mon, 30 Apr 2012, Austin Clements wrote:
> I haven't really looked at this series yet, but I do have a quick
> high-level question. Why use separate customization variables for the
> colors in search and show mode? Wouldn't it make more sense to set
> the colors just once and use them in bot
51 matches
Mail list logo
