[PATCH v2] ruby: extern linkage portability improvement

2012-06-24 Thread Tomi Ollila
Some C compilers are stricter when it comes to (tentative) definition of a variable -- in those compilers introducing variable without 'extern' keyword always allocates new 'storage' to the variable and linking all these modules fails due to duplicate symbols. This is reimplementation of Charlie

[PATCH v2] emacs: add function to toggle display of all multipart/alternative parts

2012-06-24 Thread Mark Walters
On Tue, 19 Jun 2012, Jani Nikula wrote: > Add function notmuch-show-toggle-multipart-alternative to toggle the > value of notmuch-show-all-multipart/alternative-parts variable in the > buffer, and redisplay the thread with either all or preferred > alternative parts expanded. > > A small wrinkle

[PATCH 3/3] new: don't read unchanged directories from disk

2012-06-24 Thread Sascha Silbe
Previously, notmuch new listed all directories on disk, even if they were unchanged from the state recorded in the database. This could take a huge amount of time for large numbers of mails as it would list each individual mail. By iterating over the subdirectories recorded in the database we can

[PATCH 2/3] lib: add support for rewinding a filenames iterator

2012-06-24 Thread Sascha Silbe
This allows the same iterator to be traversed multiple times, instead of destroying and reconstructing it. Signed-off-by: Sascha Silbe --- lib/filenames.c | 11 +++ lib/notmuch.h |8 2 files changed, 19 insertions(+) diff --git a/lib/filenames.c b/lib/filenames.c index

[Patch v8 0/6] Allow JSON to use non-entire thread, and use for elide

2012-06-24 Thread David Bremner
Mark Walters writes: > This is version 8 of this patch series: the previous version is at > id:"1338723972-13063-1-git-send-email-markwalters1009 at gmail.com". The > only change in this version is a rebase so that it applies to master. > > I think this version addresses all comments made in

[PATCH 3/3] test: add test for showing Reply-To headers

2012-06-24 Thread Peter Wang
Test that show --format=text and --format=json now output Reply-To headers when present. --- test/json |4 ++-- test/text |3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/test/json b/test/json index 6439788..0a692ac 100755 --- a/test/json +++ b/test/json @@ -3,9 +3,9

[PATCH 2/3] show: output Reply-To headers

2012-06-24 Thread Peter Wang
Output Reply-To headers when present in a message. These were missing in text and json output formats. --- notmuch-show.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 8247f1d..de63f06 100644 --- a/notmuch-show.c +++

[PATCH 1/3] test: add basic show, search --format=text tests

2012-06-24 Thread Peter Wang
There didn't seem to be these basic tests for --format=text, as there are for --format=json. These are just the tests from the `json' script, with adjusted expected outputs. --- test/notmuch-test |1 + test/text | 55 + 2 files

[PATCH] ruby: extern linkage portability improvement

2012-06-24 Thread David Bremner
Tomi Ollila writes: > > (Hmm, I hope no-one got confused that the trick was mine and not yours :) > > So, the patch you provided in github would be good... > > Tomi > Hi Gang; This ruby portability patch seems to have stalled. What is the current proposal? d

Re: [PATCH v2] emacs: add function to toggle display of all multipart/alternative parts

2012-06-24 Thread Jani Nikula
On Jun 23, 2012 1:34 AM, David Bremner da...@tethera.net wrote: Jani Nikula j...@nikula.org writes: A small wrinkle is that in order to make the variable survive notmuch-show-refresh-view (which is required for expanding/collapsing the parts, but ends up calling kill-all-local-variables

Re: [PATCH] ruby: extern linkage portability improvement

2012-06-24 Thread David Bremner
Tomi Ollila tomi.oll...@iki.fi writes: (Hmm, I hope no-one got confused that the trick was mine and not yours :) So, the patch you provided in github would be good... Tomi Hi Gang; This ruby portability patch seems to have stalled. What is the current proposal? d

[PATCH 0/3] Speed up notmuch new for unchanged directories

2012-06-24 Thread Sascha Silbe
All the time I thought what makes notmuch new so abysmally slow is the stat() for each maildir. But as it continued to be slow even after I moved most mails out of 'new' (into 'new-20120624'), I strace'd notmuch and noticed it listed even unchanged directories, thereby listing and iterating over

[PATCH 3/3] new: don't read unchanged directories from disk

2012-06-24 Thread Sascha Silbe
Previously, notmuch new listed all directories on disk, even if they were unchanged from the state recorded in the database. This could take a huge amount of time for large numbers of mails as it would list each individual mail. By iterating over the subdirectories recorded in the database we can

[PATCH 2/3] lib: add support for rewinding a filenames iterator

2012-06-24 Thread Sascha Silbe
This allows the same iterator to be traversed multiple times, instead of destroying and reconstructing it. Signed-off-by: Sascha Silbe sascha-...@silbe.org --- lib/filenames.c | 11 +++ lib/notmuch.h |8 2 files changed, 19 insertions(+) diff --git a/lib/filenames.c

[PATCH 1/3] lib: fix NULL checks for filenames iterators

2012-06-24 Thread Sascha Silbe
The API documentation (notmuch.h) states that the parameter may be NULL, but the implementation only checked the current element, potentially dereferencing a NULL pointer in the process. Signed-off-by: Sascha Silbe sascha-...@silbe.org --- lib/filenames.c |4 ++-- 1 file changed, 2

Re: [Patch v8 0/6] Allow JSON to use non-entire thread, and use for elide

2012-06-24 Thread David Bremner
Mark Walters markwalters1...@gmail.com writes: This is version 8 of this patch series: the previous version is at id:1338723972-13063-1-git-send-email-markwalters1...@gmail.com. The only change in this version is a rebase so that it applies to master. I think this version addresses all

[PATCH v2] ruby: extern linkage portability improvement

2012-06-24 Thread Tomi Ollila
Some C compilers are stricter when it comes to (tentative) definition of a variable -- in those compilers introducing variable without 'extern' keyword always allocates new 'storage' to the variable and linking all these modules fails due to duplicate symbols. This is reimplementation of Charlie

Re: [PATCH v2] emacs: add function to toggle display of all multipart/alternative parts

2012-06-24 Thread Mark Walters
On Tue, 19 Jun 2012, Jani Nikula j...@nikula.org wrote: Add function notmuch-show-toggle-multipart-alternative to toggle the value of notmuch-show-all-multipart/alternative-parts variable in the buffer, and redisplay the thread with either all or preferred alternative parts expanded. A

[PATCH] manpages: consistent format for NAME section

2012-06-24 Thread Tomi Ollila
The NAME section in manpages generally doesn't start with capital letter (unless the word is 'proper noun') and doesn't end with period. Notmuch manual pages now matches that format. --- See http://notmuchmail.org/manpages/ for reference. man/man1/notmuch-config.1 |2 +-

Re: [PATCH v2] ruby: extern linkage portability improvement

2012-06-24 Thread Ali Polatel
2012/6/24 Tomi Ollila tomi.oll...@iki.fi: Some C compilers are stricter when it comes to (tentative) definition of a variable -- in those compilers introducing variable without 'extern' keyword always allocates new 'storage' to the variable and linking all these modules fails due to duplicate