[PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers'

2012-10-12 Thread Ethan Glasser-Camp
Pieter Praet writes: > * emacs/notmuch-show.el > > (notmuch-show-toggle-headers): > Rename to `notmuch-show-toggle-visibility-headers'. This patch, and its predecessors, all look great to me. The following patches were already marked "stale" (and indeed they don't apply). But it looks

[PATCH v3 2/2] test: Update test to match previous patch.

2012-10-12 Thread Ethan Glasser-Camp
David Edmondson writes: > Indentation now uses tabs where possible. Hi! Just working through the patch queue. This patch is tagged notmuch::moreinfo, although it seems like the rest of the series may have been tagged notmuch::stale or notmuch::pushed. It's a little hard to figure out, because

[PATCH] test: handle filenames that have directories in them

2012-10-12 Thread Ethan Glasser-Camp
Since $TEST_DIRECTORY is an absolute path, any filenames generated with it will be complete paths. Only use the basename to generate suffixes for filenames. Signed-off-by: Ethan Glasser-Camp --- Discovered this while reviewing the patch queue. test/emacs generates filenames using

[PATCH] test: another test wrt ignoring user-specified files and directories

2012-10-12 Thread Ethan Glasser-Camp
From: Pieter Praet Demonstrates that *every* file/directory which matches one of the values in 'new.ignore' will be ignored, independent of its depth/location in the mail store. Signed-off-by: Ethan Glasser-Camp --- This is the trivial modification of Pieter's patch that

[PATCH v2] emacs: Add more processing of displayed headers.

2012-10-12 Thread Ethan Glasser-Camp
Hi! Just going through the patch queue. This is definitely a nice effect, but I'm not sure of the approach. It doesn't indent the message's tags, and it doesn't work when you resize the window. (You can get some very ugly wrapping if you put your mind to it.) Is there no better way to do this

[ANN] notmuch-labeler: Improves notmuch way of displaying labels

2012-10-12 Thread David Bremner
Damien Cassou writes: > > If there is interest, I can help integrate into notmuch itself. > Hi Damien; It seeems like a nice UI enchancement, and people would not have to use it if they didn't like it, so in principle I guess we should work towards integrating it into notmuch upstream. I'm

[notmuch] [PATCH] Calls to notmuch get queued and executed asynchronously.

2012-10-12 Thread David Bremner
Ethan Glasser-Camp writes: > It seems like this patch series is useful for some people, but there are > some design issues yet to be worked out. > > I propose that this thread be tagged notmuch::stale. Go for it, now that you have awesome power to tag things in nmbug. A periodic reminder,

[PATCH 1/2] test: add check for filename argument for test_expect_equal_file

2012-10-12 Thread Ethan Glasser-Camp
Dmitry Kurochkin writes: > Actually, we can do both: check file name for consistent diff order > (from expected to actual) and use file names that the caller provides. Hi! Reviewing the patch queue a little bit here. It seems like this patch ended up getting dropped because the other approach

More ideas about logging.

2012-10-12 Thread Ethan Glasser-Camp
Austin Clements writes: > The trouble with this approach is that the OS doesn't have to flush > logfile to the disk platters in any particular order relative to the > updates to Xapian. So, after someone trips over your plug, you could > come back with Xapian saying you have 500 log entries

Re: More ideas about logging.

2012-10-12 Thread Ethan Glasser-Camp
Austin Clements amdra...@mit.edu writes: The trouble with this approach is that the OS doesn't have to flush logfile to the disk platters in any particular order relative to the updates to Xapian. So, after someone trips over your plug, you could come back with Xapian saying you have 500 log

Re: [notmuch] [PATCH] Calls to notmuch get queued and executed asynchronously.

2012-10-12 Thread David Bremner
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes: It seems like this patch series is useful for some people, but there are some design issues yet to be worked out. I propose that this thread be tagged notmuch::stale. Go for it, now that you have awesome power to tag things in nmbug. A

Re: [ANN] notmuch-labeler: Improves notmuch way of displaying labels

2012-10-12 Thread David Bremner
Damien Cassou damien.cas...@gmail.com writes: If there is interest, I can help integrate into notmuch itself. Hi Damien; It seeems like a nice UI enchancement, and people would not have to use it if they didn't like it, so in principle I guess we should work towards integrating it into

Re: [PATCH 1/2] test: add check for expected filename argument for test_expect_equal_file

2012-10-12 Thread Ethan Glasser-Camp
Dmitry Kurochkin dmitry.kuroch...@gmail.com writes: Actually, we can do both: check file name for consistent diff order (from expected to actual) and use file names that the caller provides. Hi! Reviewing the patch queue a little bit here. It seems like this patch ended up getting dropped

Re: [PATCH v2] emacs: Add more processing of displayed headers.

2012-10-12 Thread Ethan Glasser-Camp
Hi! Just going through the patch queue. This is definitely a nice effect, but I'm not sure of the approach. It doesn't indent the message's tags, and it doesn't work when you resize the window. (You can get some very ugly wrapping if you put your mind to it.) Is there no better way to do this

[PATCH] test: another test wrt ignoring user-specified files and directories

2012-10-12 Thread Ethan Glasser-Camp
From: Pieter Praet pie...@praet.org Demonstrates that *every* file/directory which matches one of the values in 'new.ignore' will be ignored, independent of its depth/location in the mail store. Signed-off-by: Ethan Glasser-Camp et...@betacantrips.com --- This is the trivial modification of

[PATCH] test: handle filenames that have directories in them

2012-10-12 Thread Ethan Glasser-Camp
Since $TEST_DIRECTORY is an absolute path, any filenames generated with it will be complete paths. Only use the basename to generate suffixes for filenames. Signed-off-by: Ethan Glasser-Camp et...@betacantrips.com --- Discovered this while reviewing the patch queue. test/emacs generates filenames

Re: [PATCH v3 2/2] test: Update test to match previous patch.

2012-10-12 Thread Ethan Glasser-Camp
David Edmondson d...@dme.org writes: Indentation now uses tabs where possible. Hi! Just working through the patch queue. This patch is tagged notmuch::moreinfo, although it seems like the rest of the series may have been tagged notmuch::stale or notmuch::pushed. It's a little hard to figure

Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers'

2012-10-12 Thread Ethan Glasser-Camp
Pieter Praet pie...@praet.org writes: * emacs/notmuch-show.el (notmuch-show-toggle-headers): Rename to `notmuch-show-toggle-visibility-headers'. This patch, and its predecessors, all look great to me. The following patches were already marked stale (and indeed they don't apply). But it