[PATCH] test: new: Fix intermittent test failures with --debug

2012-10-21 Thread Jameson Graef Rollins
f times that I've re-run the tests after applying this patch. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/at

[PATCH] lib: fix warnings when building with clang

2012-10-21 Thread Jani Nikula
On Sun, 21 Oct 2012, Ethan Glasser-Camp wrote: > Jani Nikula writes: > >> Building notmuch with CC=clang and CXX=clang++ produces the warnings: >> >> CC -O2 lib/tags.o >> lib/tags.c:43:5: warning: expression result unused [-Wunused-value] >> talloc_steal (tags, list); >>

[PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

2012-10-21 Thread Tomi Ollila
When inserting of email bodypart failes, insert a failure message to the buffer (and continue) instead of halting the insertion of the rest of that email thread in question. --- This is (now real !!!) alternative to id:"1350824336-11060-1-git-send-email-tomi.ollila at iki.fi" This adds error

[PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

2012-10-21 Thread Tomi Ollila
On Sun, Oct 21 2012, Tomi Ollila wrote: > When inserting of email bodypart failes, insert a failure message > to the buffer (and continue) instead of halting the insertion of > the rest of that email thread in question. > --- > > This is alternative to > >

[PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

2012-10-21 Thread Tomi Ollila
When inserting of email bodypart failes, insert a failure message to the buffer (and continue) instead of halting the insertion of the rest of that email thread in question. --- This is alternative to id:"1350824336-11060-1-git-send-email-tomi.ollila at iki.fi" This adds error message string

[PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

2012-10-21 Thread Tomi Ollila
When inserting of email bodypart failes, insert a failure message to the buffer (and continue) instead of halting the insertion of the rest of that email thread in question. --- The failure of inserting bodyparts can be experienced in thread starting with id:"m31ul3qo4w.fsf at quad.robs.office"

[PATCH] emacs: functions to import sender or recipient into BBDB

2012-10-21 Thread Tomi Ollila
On Sun, Oct 21 2012, Jani Nikula wrote: > On Oct 20, 2012 10:35 PM, "Tomi Ollila" wrote: > >> Fine by me. I suggest: >> >> file emacs/notmuch-bbdb.el > > Bikeshedding, but how about the existing notmuch-address.el? Surely bbdb > isn't the only address db, and there's bound to be code to share.

[PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2012-10-21 Thread Tomi Ollila
On Sun, Oct 21 2012, Peter Wang wrote: > On Fri, 19 Oct 2012 01:15:31 -0400, Ethan Glasser-Camp gmail.com> wrote: >> Peter Wang writes: >> >> > Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can >> > cover all four values of search --exclude in the cli. >> >> This series looks good

[PATCH v3] test: conform to content length, encoding fields

2012-10-21 Thread Peter Wang
Update tests to expect content-length and content-transfer-encoding fields in show --format=json output, for leaf parts with omitted body content. --- test/crypto| 30 +- test/json | 4 +++- test/multipart | 9 + 3 files changed, 29 insertions(+), 14

[PATCH v2 3/3] test: conform to content length, encoding fields

2012-10-21 Thread Peter Wang
On Fri, 19 Oct 2012 22:21:46 -0400, Ethan Glasser-Camp wrote: > > diff --git a/test/json b/test/json > > index ac8fa8e..8ce2e8a 100755 > > --- a/test/json > > +++ b/test/json > > @@ -45,7 +45,7 @@ emacs_deliver_message \ > > (insert \"Message-ID: <$id>\n\")" > > output=$(notmuch show

[PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2012-10-21 Thread Peter Wang
On Fri, 19 Oct 2012 01:15:31 -0400, Ethan Glasser-Camp wrote: > Peter Wang writes: > > > Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can > > cover all four values of search --exclude in the cli. > > This series looks good to me. It's a nice clean up and a nice new > feature.

[PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

2012-10-21 Thread Ethan
> This seems like a really good idea generally. I think we should merge this anyhow. Ethan -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20121021/90b9560e/attachment.html>

[PATCH] test: new: Fix intermittent test failures with --debug

2012-10-21 Thread Ethan Glasser-Camp
Although messages are created in a particular order, it seems that when they are created on a tmpfs, they do not always come back in the same order, leading to the same files being ignored but being output in a different order. This causes the test to fail because the outputs being compared are

bug related to ical

2012-10-21 Thread Olivier Berger
Hi. Just in case, Tomi proposed an updated version in Message-ID: <1349333712-18347-1-git-send-email-tomi.ollila at iki.fi> ... but it doesn't seem to fix the issue for me :-/ Hope this helps. Best regards, Tomi Ollila writes: > On Wed, Oct 03 2012, Tomi Ollila wrote: > >> I've got the

[PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2012-10-21 Thread Ethan Glasser-Camp
Peter Wang writes: > Does it help if you add a "sleep 1" before the second generate_message > call, i.e. on line 35? It turns out that this test failure is sporadic (perhaps due to the fact that I'm running on tmpfs) and exists even before this series. Doing "sleep 1" makes it go away, but that

[PATCH v3] test: conform to content length, encoding fields

2012-10-21 Thread Ethan Glasser-Camp
Peter Wang writes: > Update tests to expect content-length and content-transfer-encoding > fields in show --format=json output, for leaf parts with omitted body > content. OK, this whole series looks good to me. Ethan

[PATCH] emacs: functions to import sender or recipient into BBDB

2012-10-21 Thread Jani Nikula
--- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20121021/aa47c6b8/attachment.html>

Re: bug related to ical

2012-10-21 Thread Olivier Berger
Hi. Just in case, Tomi proposed an updated version in Message-ID: 1349333712-18347-1-git-send-email-tomi.oll...@iki.fi ... but it doesn't seem to fix the issue for me :-/ Hope this helps. Best regards, Tomi Ollila tomi.oll...@iki.fi writes: On Wed, Oct 03 2012, Tomi Ollila wrote: I've got

Re: [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2012-10-21 Thread Tomi Ollila
On Sun, Oct 21 2012, Peter Wang wrote: On Fri, 19 Oct 2012 01:15:31 -0400, Ethan Glasser-Camp ethan.glasser.c...@gmail.com wrote: Peter Wang noval...@gmail.com writes: Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can cover all four values of search --exclude in the cli.

Re: [PATCH] emacs: functions to import sender or recipient into BBDB

2012-10-21 Thread Tomi Ollila
On Sun, Oct 21 2012, Jani Nikula wrote: On Oct 20, 2012 10:35 PM, Tomi Ollila tomi.oll...@iki.fi wrote: Fine by me. I suggest: file emacs/notmuch-bbdb.el Bikeshedding, but how about the existing notmuch-address.el? Surely bbdb isn't the only address db, and there's bound to be code to

Re: [PATCH v3] test: conform to content length, encoding fields

2012-10-21 Thread Ethan Glasser-Camp
Peter Wang noval...@gmail.com writes: Update tests to expect content-length and content-transfer-encoding fields in show --format=json output, for leaf parts with omitted body content. OK, this whole series looks good to me. Ethan ___ notmuch

[PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

2012-10-21 Thread Tomi Ollila
When inserting of email bodypart failes, insert a failure message to the buffer (and continue) instead of halting the insertion of the rest of that email thread in question. --- The failure of inserting bodyparts can be experienced in thread starting with id:m31ul3qo4w@quad.robs.office the

Re: [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2012-10-21 Thread Ethan Glasser-Camp
Peter Wang noval...@gmail.com writes: Does it help if you add a sleep 1 before the second generate_message call, i.e. on line 35? It turns out that this test failure is sporadic (perhaps due to the fact that I'm running on tmpfs) and exists even before this series. Doing sleep 1 makes it go

[PATCH] test: new: Fix intermittent test failures with --debug

2012-10-21 Thread Ethan Glasser-Camp
Although messages are created in a particular order, it seems that when they are created on a tmpfs, they do not always come back in the same order, leading to the same files being ignored but being output in a different order. This causes the test to fail because the outputs being compared are

[PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

2012-10-21 Thread Tomi Ollila
When inserting of email bodypart failes, insert a failure message to the buffer (and continue) instead of halting the insertion of the rest of that email thread in question. --- This is alternative to id:1350824336-11060-1-git-send-email-tomi.oll...@iki.fi This adds error message string to the

Re: [PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

2012-10-21 Thread Tomi Ollila
On Sun, Oct 21 2012, Tomi Ollila wrote: When inserting of email bodypart failes, insert a failure message to the buffer (and continue) instead of halting the insertion of the rest of that email thread in question. --- This is alternative to

[PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

2012-10-21 Thread Tomi Ollila
When inserting of email bodypart failes, insert a failure message to the buffer (and continue) instead of halting the insertion of the rest of that email thread in question. --- This is (now real !!!) alternative to id:1350824336-11060-1-git-send-email-tomi.oll...@iki.fi This adds error message

Re: [PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

2012-10-21 Thread Ethan
On Sun, Oct 21, 2012 at 9:35 AM, Tomi Ollila tomi.oll...@iki.fi wrote: When inserting of email bodypart failes, insert a failure message to the buffer (and continue) instead of halting the insertion of the rest of that email thread in question. --- This is (now real !!!) alternative to

Re: [PATCH] lib: fix warnings when building with clang

2012-10-21 Thread Jani Nikula
On Sun, 21 Oct 2012, Ethan Glasser-Camp ethan.glasser.c...@gmail.com wrote: Jani Nikula j...@nikula.org writes: Building notmuch with CC=clang and CXX=clang++ produces the warnings: CC -O2 lib/tags.o lib/tags.c:43:5: warning: expression result unused [-Wunused-value] talloc_steal (tags,

[PATCH v5 1/9] build: drop the -Wswitch-enum warning

2012-10-21 Thread Jani Nikula
-Wswitch-enum is a bit awkward if a switch statement is intended to handle just some of the named codes of an enumeration especially, and leave the rest to the default label. We already have -Wall, which enables -Wswitch by default, and per GCC documentation, The only difference between -Wswitch

[PATCH v5 3/9] test: add new test tool parse-time for date/time parser

2012-10-21 Thread Jani Nikula
Add a smoke testing tool to support testing the date/time parser module directly and independent of the rest of notmuch. Credits to Michal Sojka sojk...@fel.cvut.cz for the stdin parsing idea and consequent massive improvement in testability. --- test/Makefile.local |7 +- test/basic

[PATCH v5 4/9] test: add smoke tests for the date/time parser module

2012-10-21 Thread Jani Nikula
Test the date/time parser module directly, independent of notmuch, using the parse-time test tool. Credits to Michal Sojka sojk...@fel.cvut.cz for writing most of the tests. --- test/notmuch-test |1 + test/parse-time-string | 71 2

[PATCH v5 5/9] build: build parse-time-string as part of the notmuch lib and static cli

2012-10-21 Thread Jani Nikula
--- Makefile.local |2 +- lib/Makefile.local |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.local b/Makefile.local index 7f2d4f1..2b91946 100644 --- a/Makefile.local +++ b/Makefile.local @@ -277,7 +277,7 @@ notmuch_client_srcs = \

[PATCH v5 6/9] lib: add date range query support

2012-10-21 Thread Jani Nikula
Add a custom value range processor to enable date and time searches of the form date:since..until, where since and until are expressions understood by the previously added date/time parser, to restrict the results to messages within a particular time range (based on the Date: header). If since or

[PATCH v5 7/9] test: add tests for date:since..until range queries

2012-10-21 Thread Jani Nikula
A brief initial test set. --- test/notmuch-test |1 + test/search-date | 21 + 2 files changed, 22 insertions(+) create mode 100755 test/search-date diff --git a/test/notmuch-test b/test/notmuch-test index 7eadfdf..9a1b375 100755 --- a/test/notmuch-test +++

[PATCH v5 8/9] man: document the date:since..until range queries

2012-10-21 Thread Jani Nikula
--- man/man7/notmuch-search-terms.7 | 147 +++ 1 file changed, 135 insertions(+), 12 deletions(-) diff --git a/man/man7/notmuch-search-terms.7 b/man/man7/notmuch-search-terms.7 index 17a109e..fbd3ee7 100644 --- a/man/man7/notmuch-search-terms.7 +++

[PATCH v5 9/9] NEWS: date range search support

2012-10-21 Thread Jani Nikula
--- NEWS | 14 ++ 1 file changed, 14 insertions(+) diff --git a/NEWS b/NEWS index 2b50ba3..5f5b726 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,17 @@ +Notmuch 0.15 (-MM-DD) += + +Library changes +--- + +Date range search support + + The `date:`

Bye !

2012-10-21 Thread Xavier Maillard
Hi, After several months of notmuch usage, I feel like it is not really adapted to me or I do not want to adapt. I am going back to my first and beloved simplistic rmail. I just wanted to congratulate all of you for your really appreciated awesome work. Thank you very much and keep up the good

Re: [PATCH] test: new: Fix intermittent test failures with --debug

2012-10-21 Thread Jameson Graef Rollins
On Sun, Oct 21 2012, Ethan Glasser-Camp ethan.glasser.c...@gmail.com wrote: Although messages are created in a particular order, it seems that when they are created on a tmpfs, they do not always come back in the same order, leading to the same files being ignored but being output in a