Austin Clements writes:
> The test designed to exercise Emacs' rendering of HTML emails
> containing images inadvertently assumed w3m was available under Emacs
> 23. The real point of this test was to check that Emacs 24's shr
> renderer didn't crash when given img tags, so use shr if it's
>
Austin Clements writes:
> This is v2 of id:"1351650561-7331-1-git-send-email-amdragon at mit.edu".
> This makes Jani's suggested additions to the regexp and adds support
> for RFC 2392 mid: links, as suggested by Sascha.
This series looks fine to me.
Ethan
Damien Cassou writes:
> +(defun notmuch-tagger-present-tags (tags headerline)
> + "Return a property list which nicely presents all TAGS.
> +
> +If HEADERLINE is non-nil the returned list will be ready for
> +inclusion in the buffer's header-line. HEADERLINE must be nil in
> +all other cases."
Damien Cassou writes:
> 4) distribute the dependency with the rest of notmuch (in a separate
> "fallback-libs/" directory) and load it only when requiring the
> library with the standard load-path does not work. Jonas Bernoulli
> gave me a way to do that:
>
> ,
> | (or (require 'THE-LIB nil
Hi Damien,
On Sat, Nov 10, 2012 at 8:58 AM, Damien Cassou
wrote:
> I recently sent a patch for notmuch emacs that depends on a particular
> library. What is the best way to deal with such dependencies?
First off, what's the library, and what is it used for?
I believe that currently the
The timegm(3) function is a non-standard extension to libc which is
available in GNU libc and on some BSDs. Although SunOS had this
function in its libc, Solaris (unfortunately) removed it. This patch
implements a very simple version of timegm() which is good enough for
parse-time-string.c.
One
Cast the return value of getppid() to "int" from "pid_t" in debugger.c,
since it is being passed to sprintf("%d"), which wants an "int"
argument. On Solaris, "pid_t" is a "long" for 32-bit programs.
---
debugger.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
notmuch-config.c has the only use of the function named "index()" in the
notmuch source. Several other places use the equivalent function
"strchr()"; this patch just fixes notmuch-config.c to use strchr()
instead. (Solaris needs to include to get the prototype for
index(), and notmuch-config.c
The output of "nm" on Solaris is substantially different from that on
Linux, and the current version of gen-version-script is tied to the
Linux "nm" output. This patch separates the parts of "nm" processing
which are dependent on the output format into a couple shell functions,
and makes another
Solaris does not ship a version of the strsep() function. This change
adds a check to "configure" to see whether notmuch needs to provide its
own implementation, and if so, it uses the new version in
"compat/strsep.c" (which was copied from Mutt, and apparently before
that from glibc).
---
Solaris ships a program called "install" in /usr/sbin, which performs a
task that's fairly similar to the GNU and BSD "install" programs but
which uses very different command line arguments. In particular, if it
is invoked without "-c", "-f", or "-n", it will search the target
directory for a
Add a check to "configure" to see whether -Wl,-rpath can be used without
--enable-new-dtags. Solaris needs the former and doesn't know about the
latter.
---
configure |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index 9707f11..c9da667 100755
Add a check to "configure" to see whether -lnsl is needed for programs
that are using gethostbyname(). This change also adds the file
"compat/check_ghbn.c", which configure uses to perform its check.
---
compat/check_ghbn.c |9 +
configure | 17 -
2 files
Add checks to "configure" to see whether _POSIX_PTHREAD_SEMANTICS needs
to be defined to get the right number of arguments in the prototypes for
asctime_r(). Solaris' default implementation conforms to POSIX.1c
Draft 6, rather than the final POSIX.1c spec. The standards-compliant
version can be
Add checks to "configure" to see whether _POSIX_PTHREAD_SEMANTICS needs
to be defined to get the right number of arguments in the prototypes for
getpwuid_r(). Solaris' default implementation conforms to POSIX.1c
Draft 6, rather than the final POSIX.1c spec. The standards-compliant
version can be
Updated based on comments from Tomi Ollila last week:
- Cleaned up the $(INSTALL) changes in vim/Makefile.
- Fixed gen-version-script to be compliant with old "sh" implementation.
Mark Walters writes:
David Bremner writes:
> Mark Walters writes:
>
>> This version changes the `when' to and `if' and adds the fix for the
>> quoting.
>>
>> +(if id
>> + (notmuch-id-to-query id))
> Sorry to be such a pedant about this. Is it obvious to other people that
> (if nil
Damien Cassou damien.cas...@gmail.com writes:
4) distribute the dependency with the rest of notmuch (in a separate
fallback-libs/ directory) and load it only when requiring the
library with the standard load-path does not work. Jonas Bernoulli
gave me a way to do that:
,
| (or (require
Hi Damien,
On Sat, Nov 10, 2012 at 8:58 AM, Damien Cassou damien.cas...@gmail.com wrote:
I recently sent a patch for notmuch emacs that depends on a particular
library. What is the best way to deal with such dependencies?
First off, what's the library, and what is it used for?
I believe that
Damien Cassou damien.cas...@gmail.com writes:
+(defun notmuch-tagger-present-tags (tags optional headerline)
+ Return a property list which nicely presents all TAGS.
+
+If HEADERLINE is non-nil the returned list will be ready for
+inclusion in the buffer's header-line. HEADERLINE must be
Updated based on comments from Tomi Ollila last week:
- Cleaned up the $(INSTALL) changes in vim/Makefile.
- Fixed gen-version-script to be compliant with old sh implementation.
___
notmuch mailing list
notmuch@notmuchmail.org
Add checks to configure to see whether _POSIX_PTHREAD_SEMANTICS needs
to be defined to get the right number of arguments in the prototypes for
asctime_r(). Solaris' default implementation conforms to POSIX.1c
Draft 6, rather than the final POSIX.1c spec. The standards-compliant
version can be
Add checks to configure to see whether _POSIX_PTHREAD_SEMANTICS needs
to be defined to get the right number of arguments in the prototypes for
getpwuid_r(). Solaris' default implementation conforms to POSIX.1c
Draft 6, rather than the final POSIX.1c spec. The standards-compliant
version can be
Add a check to configure to see whether -Wl,-rpath can be used without
--enable-new-dtags. Solaris needs the former and doesn't know about the
latter.
---
configure |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index 9707f11..c9da667 100755
---
notmuch-config.c has the only use of the function named index() in the
notmuch source. Several other places use the equivalent function
strchr(); this patch just fixes notmuch-config.c to use strchr()
instead. (Solaris needs to include strings.h to get the prototype for
index(), and
Add a check to configure to see whether -lnsl is needed for programs
that are using gethostbyname(). This change also adds the file
compat/check_ghbn.c, which configure uses to perform its check.
---
compat/check_ghbn.c |9 +
configure | 17 -
2 files
The output of nm on Solaris is substantially different from that on
Linux, and the current version of gen-version-script is tied to the
Linux nm output. This patch separates the parts of nm processing
which are dependent on the output format into a couple shell functions,
and makes another shell
Solaris ships a program called install in /usr/sbin, which performs a
task that's fairly similar to the GNU and BSD install programs but
which uses very different command line arguments. In particular, if it
is invoked without -c, -f, or -n, it will search the target
directory for a file with the
The timegm(3) function is a non-standard extension to libc which is
available in GNU libc and on some BSDs. Although SunOS had this
function in its libc, Solaris (unfortunately) removed it. This patch
implements a very simple version of timegm() which is good enough for
parse-time-string.c.
One
Solaris does not ship a version of the strsep() function. This change
adds a check to configure to see whether notmuch needs to provide its
own implementation, and if so, it uses the new version in
compat/strsep.c (which was copied from Mutt, and apparently before
that from glibc).
---
Austin Clements amdra...@mit.edu writes:
This is v2 of id:1351650561-7331-1-git-send-email-amdra...@mit.edu.
This makes Jani's suggested additions to the regexp and adds support
for RFC 2392 mid: links, as suggested by Sascha.
This series looks fine to me.
Ethan
Austin Clements amdra...@mit.edu writes:
The test designed to exercise Emacs' rendering of HTML emails
containing images inadvertently assumed w3m was available under Emacs
23. The real point of this test was to check that Emacs 24's shr
renderer didn't crash when given img tags, so use shr
32 matches
Mail list logo
