[PATCH v2 3/3] reply: Use RFC 2822/MIME wholly for text format template

2013-08-15 Thread Austin Clements
Previously, reply's default text format used an odd mix of RFC 2045 MIME encoding for the reply template's body and some made-up RFC 2822-like UTF-8 format for the headers. The intent was to present the headers to the user in a nice, un-encoded format, but this assumed that whatever ultimately

[PATCH v2 2/3] reply: Remove extraneous space from generated References

2013-08-15 Thread Austin Clements
Previously, the References header code seemed to assume notmuch_message_get_header would return NULL if the header was not present, but it actually returns "". As a result of this, it was inserting an unnecessary space when concatenating an empty or missing original references header with the new

[PATCH v2 1/3] reply: Test replying to messages with RFC 2047-encoded headers

2013-08-15 Thread Austin Clements
--- test/reply | 56 1 file changed, 56 insertions(+) diff --git a/test/reply b/test/reply index ee5d361..c877ffe 100755 --- a/test/reply +++ b/test/reply @@ -193,4 +193,60 @@ References: <${gen_msg_id}> On Tue, 05 Jan 2010 15:43:56

[PATCH v2 0/3] Clean up reply's encoding story

2013-08-15 Thread Austin Clements
This is v2 of id:1376332839-22825-1-git-send-email-amdragon at mit.edu. This fixes an unintentional temporary test breakage and two typos in the last patch's commit message. There's no version diff from v1 because the final trees are the same.

[PATCH] test: Make symbol-test depend on libnotmuch.so

2013-08-15 Thread David Bremner
Austin Clements writes: > Without this > $ make -j test > intermittently fails and > $ make clean; make test/symbol-test > always fails (not that anybody would do the latter). pushed, d

[PATCH 3/6] reply: Document the reason for g_mime_filter_headers

2013-08-15 Thread David Bremner
Austin Clements writes: > Given how long it took me to figure out why we pass the reply headers > through g_mime_filter_headers, it's worth a comment. > --- Pushed the first 3 patches in the series. d