[PATCH v3] emacs: wrap current search in parens when filtering

2015-09-06 Thread Uli Scholler
When filtering the current search further with notmuch-search-filter, wrap the current search in parens (if necessary). This fixes unexpected behavior when the current search is complex (like "(tag:this and date:one_week_ago..) or tag:that"). --- emacs/notmuch.el | 20 +++- 1

[PATCH 1/3] cli: add utility routine to print error status.

2015-09-06 Thread David Bremner
No attention to formatting here, initially just focus on getting the relevant strings out of the library. --- Makefile.local | 1 + notmuch-client.h | 9 + status.c | 21 + 3 files changed, 31 insertions(+) create mode 100644 status.c diff --git

[PATCH 2/3] cli/count: update to use notmuch_query_search_messages_st

2015-09-06 Thread David Bremner
This brings back status information that may have been hidden by the great library logging conversion. Note the change of the internal API / return-value for count_files The other count calls to the lib will also get error handling when that API is updated in the lib. --- notmuch-count.c| 22

[PATCH 3/3] cli: convert remainder of CLI to n_q_search_{messages,threads}_st

2015-09-06 Thread David Bremner
I think it would be no real problem to cut and paste the gdb based error message test from count to the other clients modified here, but I'm not currently convinced it's worth the trouble since the code path being tested is almost the the same, and the tests are relatively heavyweight. ---

Re: [PATCH 1/2] test: fix whitespace/indentation in symbol-test

2015-09-06 Thread Tomi Ollila
On Fri, Sep 04 2015, Jani Nikula wrote: > Not of much consequence, but makes it nicer to do further edits. > --- These 2 patches LGTM ! +1! :D > test/symbol-test.cc | 34 ++ > 1 file changed, 18 insertions(+), 16 deletions(-) > > diff --git

Re: [PATCH 2/2] cli: reset db directory mtime upon directory removal

2015-09-06 Thread Tomi Ollila
On Sat, Sep 05 2015, Jani Nikula wrote: > The library does not have a function to remove a directory document > for a path. Usually this doesn't matter except for a slight waste of > space. However, if the same directory gets added to the filesystem > again, the old directory

Re: [PATCH v2] emacs: wrap current search in parens when filtering

2015-09-06 Thread Tomi Ollila
On Sun, Sep 06 2015, David Bremner wrote: > Some pretty fussy comments follow. Probably I could have fixed these in > the time it took to write this message ;). > > Uli Scholler writes: >> + (let ((grouped-query (notmuch-maybe-group-query-string query)) >>