Re: NOTMUCH_STATUS_LAST_STATUS problematic across additive library upgrades

2015-12-08 Thread Daniel Kahn Gillmor
On Tue 2015-12-08 00:22:11 -0500, Carl Worth wrote: > On Mon, Dec 07 2015, Daniel Kahn Gillmor wrote: >> I note that it's exposed in the go bindings -- maybe it shouldn't be >> exposed in any of the bindings that can avoid exposing it? > > Quite likely. It's only there in C because there's no other

Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro

2015-12-08 Thread Tomi Ollila
On Tue, Dec 08 2015, David Bremner wrote: > Tomi Ollila writes: > >> Some compilers (older than gcc 4.5 and clang 2.9) do support >> __attribute__ ((deprecated)) but not >> __attribute__ ((deprecated("message"))). >> >> Check (clang) and know (gcc) which versions support which variants >> and ma

Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro

2015-12-08 Thread David Bremner
Tomi Ollila writes: > Some compilers (older than gcc 4.5 and clang 2.9) do support > __attribute__ ((deprecated)) but not > __attribute__ ((deprecated("message"))). > > Check (clang) and know (gcc) which versions support which variants > and make two definitions of define NOTMUCH_DEPRECATED macro