Re: [PATCH v2 14/14] cli/reply: only pass gmime message to add recipients to reply message

Jani Nikula writes: > The notmuch message is no longer needed. Simplify. LGTM. I guess the comment I asked for in the last patch can be something like "unused parameter will be fixed in the next commit" d ___ notmuch mailing list

Re: [PATCH v2 13/14] cli/reply: pass gmime message to munge detection

Jani Nikula writes: > Improves the accuracy in many ways. Essentially same objections as the last patch If the unused parameter to get_sender is intentional, that probably needs a remark as well ___ notmuch mailing list

Re: [PATCH v2 12/14] cli/reply: pass internet address list to munge detect

Jani Nikula writes: > --- > notmuch-reply.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) The commit message needs a bit more explanation. I think the writer knows this code too well ;). - This changes the arguments of reply_to_header_is

Re: [PATCH v2 11/14] cli/reply: return internet address list from get header funcs

Jani Nikula writes: > Pass in GMimeMessage to simplify To/Cc/Bcc headers. We'll eventually > remove the notmuch message passing altogether, but keep both for now > to not make too big changes at once. Patches 9-11 LGTM. d ___ notmuch

Re: [PATCH v2 01/14] test: add known broken test for reply to message with multiple Cc headers

Jani Nikula writes: > > +test_begin_subtest "Reply to a message with multiple Cc headers" > +test_subtest_known_broken > +cat > "${MAIL_DIR}"/broken_cc < +From: Alice > +To: Daniel Kahn Gillmor > +Cc: Bob >

Re: [PATCH v2 08/14] cli/reply: reduce the reply format abstractions

Jani Nikula writes: > Now that we've made the various reply formats quite similar to each > other, there's no point in keeping the abstractions. They are now > close enough to be put in one function. > > For now, a mime node will be uselessly created for the headers-only > case,

Re: [PATCH v2 06/14] cli/reply: make references header creation easier to follow

Jani Nikula writes: > Just use strdup when original references is not available, instead of > trying to cram everything into a monster asprintf. There should be no > functional changes. > --- > notmuch-reply.c | 13 ++--- > 1 file changed, 6 insertions(+), 7

Re: [PATCH v2 05/14] cli/reply: reorganize create_reply_message()

Jani Nikula writes: > Again, in preparation for later unification, reorganize > create_reply_message() to be more similar to the open coded version in > the headers-only format reply code. Due to "pretty" header ordering, > there should be no change in output. There should be no

Re: [PATCH] emacs: use define-derived-mode for defining modes.

David Bremner writes: > Steven Allen writes: > >> This sets up and runs all the correct hooks and reduces some redundancy. > > pushed to master Thanks! -- Steven Allen ((Do Not Email )) signature.asc Description: PGP

Re: [PATCH] emacs: use define-derived-mode for defining modes.

Steven Allen writes: > This sets up and runs all the correct hooks and reduces some redundancy. pushed to master d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 2/4] emacs: adjust all types of notmuch show buffers

The current notmuch-show-message-adjust logic only adjusts the buffer focused in the current window. Extend it to adjust any kind of buffer, even buffers in a window without focus or in a different frame or even not shown at all. This new logic is very useful to build upon for the auto-refresh

[PATCH 1/4] emacs: reuse buffer when refreshing searches

There's no reason to completely kill a buffer while refreshing its search results because its buffer name is constant between refreshes (based on the search query) and only its contents may change. Reusing the same buffer also makes it possible to do things like refreshing a buffer which is not

[PATCH 0/4] Add refresh all buffers functionality

This patch series adds a function to refresh all buffers, including an option to silently refresh them in the background i.e. to not show the newly refreshed buffer in any window. This is very useful for asynchronously updating all buffers when new mail arrives, using logic similar to the

[PATCH 3/4] emacs: add refresh buffer optional no-display arg

Add an optional no-display arg to the generic buffer refresh function, notmuch-refresh-this-buffer, which works the same way as notmuch-hello mode's notmuch-hello-update no-display arg. The idea is for the generic notmuch-refresh-this-buffer to pass down this arg to the "mode-specific" refresh

[PATCH 4/4] emacs: add refresh all buffers function

This new notmuch-refresh-all-buffers function calls each buffer's major mode specific refresh function using the generic function notmuch-refresh-this-buffer. It is very useful because by passing a non-nil arg to the buffer specific refresh functions it refreshes all notmuch buffers in the

Re: [PATCH] emacs: use define-derived-mode for defining modes.

On Sat, Sep 10 2016, Steven Allen wrote: > [ Unknown signature status ] > > David Bremner writes: >> Steven Allen writes: >> >>> This sets up and runs all the correct hooks and reduces some redundancy. >>> --- >> >> The idea seems

Re: [PATCH v2 04/14] cli/reply: unify reply format functions

On Sat, 10 Sep 2016, David Bremner wrote: > Jani Nikula writes: > >> Prepare for further future unification by making the code similar. The >> only functional change is that errors in mime_node_open() also break >> execution in default reply format. > >>

Re: [PATCH v2 02/14] cli/reply: push notmuch reply format abstraction lower in the stack

On Sat, 10 Sep 2016, David Bremner wrote: > Jani Nikula writes: > >> -if (mime_node_open (ctx, message, &(params->crypto), ) == >> NOTMUCH_STATUS_SUCCESS) { >> -format_part_reply (root); >> -talloc_free (root); >> -} >> +