[PATCH] NEWS: mention message properties API, dump/restore

2016-09-24 Thread David Bremner
--- NEWS | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 0fd6d72..2f15ccd 100644 --- a/NEWS +++ b/NEWS @@ -21,6 +21,16 @@ Support for named queries `query:name` format. The expansion of these queries is stored in the database and

Re: [PATCH v2 0/4] Add refresh all buffers functionality

2016-09-24 Thread Ioan-Adrian Ratiu
On Sat, 24 Sep 2016, David Bremner wrote: > Ioan-Adrian Ratiu writes: > >> On Sat, 24 Sep 2016, Ioan-Adrian Ratiu wrote: >>> Argh, so right after I posted this I found a bug: for every new window >>> in which you open the same notmuch-show

Re: [PATCH v2 0/4] Add refresh all buffers functionality

2016-09-24 Thread David Bremner
Ioan-Adrian Ratiu writes: > On Sat, 24 Sep 2016, Ioan-Adrian Ratiu wrote: >> Argh, so right after I posted this I found a bug: for every new window >> in which you open the same notmuch-show buffer it creates a new buffer. >> >> For example if from

Re: [PATCH v2 0/4] Add refresh all buffers functionality

2016-09-24 Thread Ioan-Adrian Ratiu
On Sat, 24 Sep 2016, Ioan-Adrian Ratiu wrote: > Argh, so right after I posted this I found a bug: for every new window > in which you open the same notmuch-show buffer it creates a new buffer. > > For example if from notmuch-search you open a thread "hello" in multiple > windows,

Re: [PATCH v2 0/4] Add refresh all buffers functionality

2016-09-24 Thread Ioan-Adrian Ratiu
Argh, so right after I posted this I found a bug: for every new window in which you open the same notmuch-show buffer it creates a new buffer. For example if from notmuch-search you open a thread "hello" in multiple windows, each window will show a different "hello<1>" "hello<2>" etc buffer

[PATCH v2 4/4] emacs: notmuch-lib: add refresh all buffers function

2016-09-24 Thread Ioan-Adrian Ratiu
notmuch-refresh-all-buffers calls each buffer's major mode specific refresh function using the generic notmuch-refresh-this-buffer function. It is very useful because by passing a non-nil arg to the buffer specific refresh functions it refreshes all notmuch buffers in the background and this

[PATCH v2 1/4] emacs: reuse buffer when refreshing searches

2016-09-24 Thread Ioan-Adrian Ratiu
There's no reason to completely kill a buffer while refreshing its search results because the buffer name is constant between refreshes (based on the search query), only its contents may change and notmuch search kills all local variables, so it's safe to reuse. Reusing the same buffer also makes

[PATCH v2 3/4] emacs: add refresh buffer optional no-display arg

2016-09-24 Thread Ioan-Adrian Ratiu
Add an optional no-display arg to the generic buffer refresh function, notmuch-refresh-this-buffer, which works the same way as notmuch-hello mode's notmuch-hello-update no-display arg. The idea is for the generic notmuch-refresh-this-buffer to pass down this arg to the "mode-specific" refresh

[PATCH v2 2/4] emacs: notmuch-show: refresh all windows showing a buffer

2016-09-24 Thread Ioan-Adrian Ratiu
This updates all windows displaying a notmuch-show buffer when the buffer refresh function is called. Each window displaying a notmuch-show buffer has its own currently displayed messaged based on the (point) location. Store the state of all displayed windows when refreshing a notmuch-show buffer

[PATCH v2 0/4] Add refresh all buffers functionality

2016-09-24 Thread Ioan-Adrian Ratiu
Changes since v1 (thank you Mark for your feedback): * Major rewrite/simplification of the notmuch-show refresh patch to support simultaneous refreshing multiple windows displaying a buffer * Removed the notmuch-show-message-adjust () patch because it's not needed after the above

[PATCH] test: test-lib.sh: use $BASH instead of ${SHELL-sh} to relaunch

2016-09-24 Thread Tomi Ollila
In case of the test script is to be relaunced under valgrind, or --tee is requested, use the $BASH shell variable to locate the command interpreter. The $SHELL environment variable is not set by bash if it already had non-empty value (e.g. "/bin/zsh"). After this change requesting script relaunch

Re: [PATCH] test/emacs: add broken test for message replying to msg to self

2016-09-24 Thread David Bremner
David Bremner writes: > This is a strange corner case where the removing of the user's address > from the To: header does the wrong thing. If we think it is > worth (eventually) fixing, this test can serve as a reminder. > --- > test/T310-emacs.sh | 24

Re: [PATCH] emacs: tree: make jump close message pane

2016-09-24 Thread David Bremner
Mark Walters writes: > j is in the global notmuch keymap bound to notmuch jump. In tree-mode > it makes sense to close the message pane first (otherwise the new > search runs in the small top pane of tree-mode). pushed, d

Re: [PATCH] lib: add talloc reference from string map iterator to map

2016-09-24 Thread David Bremner
David Bremner writes: > This is needed so that when the map is modified during traversal, and > thus unlinked by the database code, the map is not disposed of until the > iterator is done with it. > --- pushed, d ___ notmuch

Re: [PATCH] test: test-lib.sh: use $BASH instead of ${SHELL-sh} to relaunch

2016-09-24 Thread David Bremner
Tomi Ollila writes: > In case of the test script is to be relaunced under valgrind, or --tee > is requested, use the $BASH shell variable to locate the command > interpreter. The $SHELL variable is re-set by non-interactive shells > so in case the shell uses some other shell

Re: [PATCH] test: test-lib.sh: use $BASH instead of ${SHELL-sh} to relaunch

2016-09-24 Thread David Bremner
Tomi Ollila writes: > In case of the test script is to be relaunced under valgrind, or --tee > is requested, use the $BASH shell variable to locate the command > interpreter. The $SHELL variable is re-set by non-interactive shells > so in case the shell uses some other shell

[PATCH] test: test-lib.sh: use $BASH instead of ${SHELL-sh} to relaunch

2016-09-24 Thread Tomi Ollila
In case of the test script is to be relaunced under valgrind, or --tee is requested, use the $BASH shell variable to locate the command interpreter. The $SHELL variable is re-set by non-interactive shells so in case the shell uses some other shell (e.g. zsh) for interactive use these bash scripts

Re: [PATCH] lib: add talloc reference from string map iterator to map

2016-09-24 Thread Tomi Ollila
On Sat, Sep 24 2016, David Bremner wrote: > Tomi Ollila writes: >> >> I tried to run this under valgrind ( ./T610-message-property.sh --valgrind ) >> but got so noisy output that I could not resolve anything definite >> from it. > > Hmm. On a related

Re: [PATCH] lib: add talloc reference from string map iterator to map

2016-09-24 Thread David Bremner
Tomi Ollila writes: > > I tried to run this under valgrind ( ./T610-message-property.sh --valgrind ) > but got so noisy output that I could not resolve anything definite > from it. Hmm. On a related topic, --valgrind seems broken here: ╭─

Re: [PATCH] lib: add talloc reference from string map iterator to map

2016-09-24 Thread Tomi Ollila
On Fri, Sep 23 2016, David Bremner wrote: > This is needed so that when the map is modified during traversal, and > thus unlinked by the database code, the map is not disposed of until the > iterator is done with it. > --- > > According to my obviously fallible memory, this