plan to migrate notmuch-emacs debian packaging to dh-elpa

2016-11-06 Thread David Bremner
Hi Team; I plan to migrate notmuch-emacs debian packaging to use the tool (that I co-maintain) dh-elpa. This will allow dropping the custom maintainer scripts [1]. It will also make the debian version of notmuch-emacs show up in M-x package-list-packages, and allow us to use the package.el

[PATCH v2 2/2] notmuch-config: replace config reading function

2016-11-06 Thread Ioan-Adrian Ratiu
Config files are currently read using glib's g_key_file_load_from_file function which is very inconvenient because it's limited by design to read only from "regular data files" in a filesystem. Because of this limitation notmuch can't read configs from pipes, fifos, sockets, stdin, etc. Not even

[PATCH v2 1/2] cli: abstract config file reading to a separate function

2016-11-06 Thread Ioan-Adrian Ratiu
From: Jani Nikula Simplify and fix the coding style while at it. --- notmuch-config.c | 65 ++-- 1 file changed, 35 insertions(+), 30 deletions(-) diff --git a/notmuch-config.c b/notmuch-config.c index e5d42a0..bd52790 100644

[PATCH v2 0/2] Refactor config reading to support non-regular files

2016-11-06 Thread Ioan-Adrian Ratiu
Changes since v1 (Based on Jani's feedback): * Incorporated Jani's patch into this series and rebased my changes on top Ioan-Adrian Ratiu (1): notmuch-config: replace config reading function Jani Nikula (1): cli: abstract config file reading to a separate function notmuch-config.c | 94

[Patch v4 2/2] emacs: postpone/resume support

2016-11-06 Thread David Bremner
From: Mark Walters This provides preliminary support for postponing and resuming in the emacs frontend. On postponing it uses notmuch insert to put the message in the notmuch database; resume gets the raw file from notmuch and using the emacs function mime-to-mml

v4 postpone patches

2016-11-06 Thread David Bremner
3 bug fixes compared to v3 - notmuch-draft-save-plaintext=nil case - typo in mark-deleted function - missing notmuch-draft.el in emacs/Makefile.local ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

[Patch v4 1/2] emacs: tree: remove binding for pressing button in message pane

2016-11-06 Thread David Bremner
From: Mark Walters We want to use "e" for editting postponed messages in show, and in tree view, so remove the binding for the function which does (In message pane) Activate BUTTON or button at point --- emacs/notmuch-tree.el | 1 - 1 file changed, 1 deletion(-)

Re: [Patch v3 2/2] emacs: postpone/resume support

2016-11-06 Thread David Bremner
David Bremner writes: > + > +(add-hook 'message-send-hook 'notmuch-draft-mark-draft-deleted) > + One more typo, that actually breaks things (shame on me for not running the test suite). This should be notmuch-draft--mark-deleted d

Re: [Patch v3 2/2] emacs: postpone/resume support

2016-11-06 Thread David Bremner
Mark Walters writes: >> +(defun notmuch-draft--check-encryption-tag () >> + "Query user if there an mml tag that looks like it might indicate >> encryption. >> + >> +Returns t if there is no such tag, or the user confirms they mean >> +it." >> + (save-excursion >> +

Re: [Patch v3 2/2] emacs: postpone/resume support

2016-11-06 Thread Mark Walters
> +(defun notmuch-draft--check-encryption-tag () > + "Query user if there an mml tag that looks like it might indicate > encryption. > + > +Returns t if there is no such tag, or the user confirms they mean > +it." > + (save-excursion > +(message-goto-body) > + (or > + ;; We are

Re: [Patch v3 2/2] emacs: postpone/resume support

2016-11-06 Thread Mark Walters
On Sun, 06 Nov 2016, David Bremner wrote: > From: Mark Walters > > This provides preliminary support for postponing and resuming in the > emacs frontend. On postponing it uses notmuch insert to put the > message in the notmuch database; resume gets

[PATCH] cli: abstract config file reading to a separate function

2016-11-06 Thread Jani Nikula
Simplify and fix the coding style while at it. --- notmuch-config.c | 65 ++-- 1 file changed, 35 insertions(+), 30 deletions(-) diff --git a/notmuch-config.c b/notmuch-config.c index e5d42a0cbfd5..bd527901f7b5 100644 --- a/notmuch-config.c +++

Re: [PATCH] notmuch-config: replace config reading function

2016-11-06 Thread Jani Nikula
> So replace g_key_file_load_from_file with g_key_file_load_from_data which > gives us much more freedom to read configs from multiple sources. I see how your function is a drop-in replacement to g_key_file_load_from_file. However, I really don't like the proliferation of GError here. Please