notmuch release 0.24 now available

2017-03-12 Thread David Bremner
Where to obtain notmuch 0.24 === https://notmuchmail.org/releases/notmuch-0.24.tar.gz Which can be verified with: https://notmuchmail.org/releases/notmuch-0.24.tar.gz.sha256 f7e44cf67630669d3537c4febd7685ca27d62a134e42f9a5db90d5a6ed4c75fc notmuch-0.24.tar.gz

Re: [PATCH 1/3] configure: add ${NOTMUCH_SRCDIR} -- absolute path to notmuch source

2017-03-12 Thread David Bremner
Tomi Ollila writes: > The ${srcdir} -- usually relative path to notmuch source -- works fine > in current ./configure and all makefiles. To have simple access to > notmuch source in tests and out of tree builds holding absolute path to > the source directory is useful.

Re: [PATCH] test: verify test database v1 checksum in more portable way

2017-03-12 Thread David Bremner
Tomi Ollila writes: > Replaced use of sha256 (gnu coreutils binary) with more portable > openssl sha256 execution. > --- > > Works on Linux and also on my FreeBSD KVM environment. There's a tradeoff here. In a minimal GNU/Linux environment coreutils is there but not openssl.

Re: emacs: use epg-gpg-program

2017-03-12 Thread David Bremner
Tomi Ollila writes: > From: John Byrnes > > From: John Byrnes > > Adjusted notmuch-crypto gpg call-process function to respect > the GPG program set by the EasyPG epg-gpg-program variable. > > This is to correct a problem observed

Re: notmuch-0.18 issues [was Re: notmuch-0.16: realpath() compatibility issue; clang visibility problem]

2017-03-12 Thread Thomas Klausner
On Sun, Mar 12, 2017 at 07:24:53PM +0200, Tomi Ollila wrote: > On Sun, Mar 12 2017, David Bremner wrote: > > > Thomas Klausner writes: > > > >> > >> 1. pkgsrc's copy of rst2man is called "rst2man.py". The configure test > >> > > > > Since I see notmuch in

emacs: use epg-gpg-program

2017-03-12 Thread Tomi Ollila
From: John Byrnes From: John Byrnes Adjusted notmuch-crypto gpg call-process function to respect the GPG program set by the EasyPG epg-gpg-program variable. This is to correct a problem observed on NixOS where only gpg2 is installed by default. The

[PATCH] test: verify test database v1 checksum in more portable way

2017-03-12 Thread Tomi Ollila
Replaced use of sha256 (gnu coreutils binary) with more portable openssl sha256 execution. --- Works on Linux and also on my FreeBSD KVM environment. test/T530-upgrade.sh | 6 -- test/test-databases/database-v1.tar.xz.sha256 | 1 - 2 files changed, 4 insertions(+),

Re: [PATCH] configure: change default bash completion location to /usr/share

2017-03-12 Thread Tomi Ollila
On Sun, Mar 12 2017, David Bremner wrote: > At least Fedora and Debian now use > /usr/share/bash-completion/completions now. Apparently > /etc/bash_completion.d will be phased out at some point in the future. > --- LGTM (from keyboard of 20+ year zsh user) Tomi > configure

Re: notmuch-0.18 issues [was Re: notmuch-0.16: realpath() compatibility issue; clang visibility problem]

2017-03-12 Thread Tomi Ollila
On Sun, Mar 12 2017, David Bremner wrote: > Thomas Klausner writes: > >> >> 1. pkgsrc's copy of rst2man is called "rst2man.py". The configure test >> > > Since I see notmuch in pkgsrc for netbsd, I guess things have improved. > I had a quick look at the

[PATCH] configure: change default bash completion location to /usr/share

2017-03-12 Thread David Bremner
At least Fedora and Debian now use /usr/share/bash-completion/completions now. Apparently /etc/bash_completion.d will be phased out at some point in the future. --- configure | 4 ++-- debian/notmuch.install | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: reply to messages with message/rfc822 parts

2017-03-12 Thread David Bremner
Mark Walters writes: > Hello > > I was trying to reply to a message I had forwarded to someone (to update > the information sent in the first message) and came across some strange > behaviour. > > > The initial forward was done using notmuch-emacs: this took the

Re: notmuch-0.18 issues [was Re: notmuch-0.16: realpath() compatibility issue; clang visibility problem]

2017-03-12 Thread David Bremner
Thomas Klausner writes: > > 1. pkgsrc's copy of rst2man is called "rst2man.py". The configure test > for this fails, of course, and there is another place where rst2man is > called directly. I've changed that to rst2man.py locally, but it'd be > good if configure could test for

Re: [PATCH] debian: package ruby bindings

2017-03-12 Thread David Bremner
Felipe Contreras writes: > Signed-off-by: Felipe Contreras > --- > debian/control | 14 ++ > debian/notmuch-ruby.install | 1 + > debian/rules| 9 + > 3 files changed, 24 insertions(+) >

Re: notmuch-0.16: realpath() compatibility issue; clang visibility problem

2017-03-12 Thread David Bremner
Thomas Klausner writes: > Hi! > > I'm currently starting to try out notmuch-0.16 on NetBSD. It went off > to a rocky start, since it segfaulted in the initial config setup. > > Debugging it I found that notmuch uses a glibc extension to realpath, > allowing NULL as second

Re: [RFC PATCH] cli/search: interpret no search terms as synonym for '*'

2017-03-12 Thread David Bremner
David Bremner writes: > This is a bit less typing (and escaping), especially for the > --output=tags case. > --- > > I started merrily on other commands, but I'm not so sure. For example > "git annex metadata" has the feature of interpreting missing file name > as all files

[PATCH] test-databases: use wget or curl to download test databases

2017-03-12 Thread Tomi Ollila
Often Linux systems are shipped with wget(1) by default (and no curl). Many BSDs, macOS, and e.g. some Linux minimal/container images comes with curl(1) (and no wget). Attempting to download with curl if wget is not available increases the likelihood for this to succeed. --- This is an update

[PATCH 2/2] lib: clamp return value of g_mime_utils_header_decode_date to >=0

2017-03-12 Thread David Bremner
For reasons not completely understood at this time, gmime (as of 2.6.22) is returning a date before 1900 on bad date input. Since this confuses some other software, we clamp such dates to 0, i.e. 1970-01-01. --- lib/message.cc | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff

[PATCH 1/2] lib: add known broken test for parsing bad dates.

2017-03-12 Thread David Bremner
This reproduces the symptoms of bug report id:20150422065630.6330.90536@hoothoot --- test/T660-bad-date.sh | 15 +++ 1 file changed, 15 insertions(+) create mode 100755 test/T660-bad-date.sh diff --git a/test/T660-bad-date.sh b/test/T660-bad-date.sh new file mode 100755 index

[PATCH 3/3] fix out of tree tests

2017-03-12 Thread Tomi Ollila
Use $NOTMUCH_SRCDIR/ instead of $TEST_DIRECTORY/../ (in those 2 places) where reference to source directory instead of build directory is required. --- test/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index

[PATCH 1/3] configure: add ${NOTMUCH_SRCDIR} -- absolute path to notmuch source

2017-03-12 Thread Tomi Ollila
The ${srcdir} -- usually relative path to notmuch source -- works fine in current ./configure and all makefiles. To have simple access to notmuch source in tests and out of tree builds holding absolute path to the source directory is useful. --- Fixed version of series starting with

[PATCH 2/3] fix out of tree build

2017-03-12 Thread Tomi Ollila
In addition to use ${srcdir} and deliver ${NOTMUCH_SRCDIR} where needed, source from ruby bindings had to be copied to the out-of-tree target directory -- if the source files in source directory were referenced in build and there were also built object files there, those could have been considered