Re: notmuch-emacs and Emacs26 (master)

2017-04-06 Thread Thomas Hisch
I fixed this by applying the following patch. TBH, I didn't check that everything is still working as expected, but the compilation succeeds. --- emacs/notmuch.el | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index

Re: [PATCH] test: swap order of arguments of test_expect_equal

2017-04-06 Thread David Bremner
Tomi Ollila writes: > On Thu, Apr 06 2017, David Bremner wrote: > >> For some reason (probably inherited from git), the order arguments for >> test_expect_equal was "$output $expected"; this again matters when >> generating diffs. >> --- > > IMO these both

Re: [PATCH] test: swap order of arguments of test_expect_equal

2017-04-06 Thread Tomi Ollila
On Thu, Apr 06 2017, David Bremner wrote: > For some reason (probably inherited from git), the order arguments for > test_expect_equal was "$output $expected"; this again matters when > generating diffs. > --- IMO these both of these should use expected - output argument

notmuch-emacs and Emacs26 (master)

2017-04-06 Thread aaermolov
Hi, in 23.7+ version of notmuch, when building notmuch emacs part against Emacs master, the following error pops up: In toplevel form: emacs/notmuch.el:405:1:Error: Wrong type argument: listp, cl--function-convert The same error reveals in all mentioned versions, ranging only in line numbers.