Re: Strange, incoherent query parsing

2019-08-29 Thread David Bremner
Jorge P. de Morais Neto writes: > Hello, > > Em 2019-08-28T07:08:28-0300, David Bremner escreveu: > >> I don't know about the other cases but here there is an extra closing >> ')', which confuses the query parser. I agree that an error report >> would be nicer, but we don't currently have that

Re: [PATCH v1 2/2] emacs: Bind "u" to jump to the parent message in a thread

2019-08-29 Thread Tomi Ollila
On Thu, Aug 29 2019, David Edmondson wrote: > --- > emacs/notmuch-show.el | 55 +++ > 1 file changed, 55 insertions(+) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 1e3834f2..7c50d2cd 100644 > --- a/emacs/notmuch-show.el > +++

Re: [PATCH v2] configure: fix out of tree build; check unsafe characters in srcdir

2019-08-29 Thread David Bremner
Tomi Ollila writes: > While check for GMime session key extraction support... was made > out of tree build compatible, related (and some unrelated) unsafe > characters are now checked in notmuch source directory path. pushed. Note that while notmuch builds out of tree, the test suite is

Re: [PATCH v2] configure: fix out of tree build; check unsafe characters in srcdir

2019-08-29 Thread David Bremner
Tomi Ollila writes: > To my surprise mkdir 'build dir'; cd 'build dir'; ../notmuch/configure > and then `make` just worked. :D > > I did not dare to run tests -- I'm pretty sure that would fail... > 20-ish tests currently fail looking for json_check_nodes.py But yeah, many other tests explode

[PATCH v1 2/2] emacs: Bind "u" to jump to the parent message in a thread

2019-08-29 Thread David Edmondson
--- emacs/notmuch-show.el | 55 +++ 1 file changed, 55 insertions(+) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 1e3834f2..7c50d2cd 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1173,6 +1173,60 @@ is t, hide the

[PATCH v1 0/2] emacs/show: Add a binding to go up.

2019-08-29 Thread David Edmondson
emacs/show: Add a binding to go up when viewing a thread of messages. The implementation is a bit ropey and perhaps expensive, but it seems to work for me. David Edmondson (2): emacs: Stash the currently shown forest in a buffer local variable emacs: Bind "u" to jump to the parent message

[PATCH v1 1/2] emacs: Stash the currently shown forest in a buffer local variable

2019-08-29 Thread David Edmondson
--- emacs/notmuch-show.el | 4 1 file changed, 4 insertions(+) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index e13ca3d7..1e3834f2 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1165,8 +1165,12 @@ is t, hide the part initially and show the button."

v4 of legacy-display cleanup

2019-08-29 Thread Daniel Kahn Gillmor
This is the fourth revision of the series that cleans up legacy-display protected headers parts so that notmuch users only have to look at one subject line. version 3 can be found at id:20190625014107.12452-1-...@fifthhorseman.net version 2 can be found at

[PATCH v4 4/8] util/crypto: _n_m_crypto_potential_payload: rename "payload" arg to "part"

2019-08-29 Thread Daniel Kahn Gillmor
_notmuch_message_crypto_potential_payload is called on a GMimeObject while walking the MIME tree of a message to determine whether that object is the payload. It doesn't make sense to name the argument "payload" if it might not be the payload, so we rename it to "part" for clarity. This is a

[PATCH v4 3/8] test: avoid showing legacy-display parts

2019-08-29 Thread Daniel Kahn Gillmor
Enigmail generates a "legacy-display" part when it sends encrypted mail with a protected Subject: header. This part is intended to display the Subject for mail user agents that are capable of decryption, but do not know how to deal with embedded protected headers. This part is the first child of

[PATCH v4 5/8] util/crypto: _n_m_crypto_potential_payload returns whether part is the payload

2019-08-29 Thread Daniel Kahn Gillmor
Our _notmuch_message_crypto_potential_payload implementation could only return a failure if bad arguments were passed to it. It is an internal function, so if that happens it's an entirely internal bug for notmuch. It will be more useful for this function to return whether or not the part is in

[PATCH v4 1/8] mime-node: split out _mime_node_set_up_part

2019-08-29 Thread Daniel Kahn Gillmor
This is a code reorganization that should have no functional effect, but will make future changes simpler, because a future commit will reuse the _mime_node_set_up_part functionality without touching _mime_node_create. In the course of splitting out this function, I noticed a comment in the

[PATCH v4 8/8] index: avoid indexing legacy-display parts

2019-08-29 Thread Daniel Kahn Gillmor
When we notice a legacy-display part during indexing, it makes more sense to avoid indexing it as part of the message body. Given that the protected subject will already be indexed, there is no need to index this part at all, so we skip over it. If this happens during indexing, we set a property

[PATCH v4 7/8] cli/{show,reply}: skip over legacy-display parts

2019-08-29 Thread Daniel Kahn Gillmor
Make use of the previous changes to fast-forward past any legacy-display parts during "notmuch show" and "notmuch reply". Signed-off-by: Daniel Kahn Gillmor --- mime-node.c| 11 ++- test/T356-protected-headers.sh | 2 -- 2 files changed, 10 insertions(+), 3

[PATCH v4 2/8] repair: set up codebase for repair functionality

2019-08-29 Thread Daniel Kahn Gillmor
This adds no functionality directly, but is a useful starting point for adding new repair functionality. Signed-off-by: Daniel Kahn Gillmor --- doc/man7/notmuch-properties.rst | 12 lib/notmuch-private.h | 1 + notmuch-client.h| 1 + util/Makefile.local

[PATCH v4 6/8] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display

2019-08-29 Thread Daniel Kahn Gillmor
This is a utility function designed to make it easier to "fast-forward" past a legacy-display part associated with a cryptographic envelope, and show the user the intended message body. The bulk of the ugliness in here is in the test function _notmuch_crypto_payload_has_legacy_display, which

Re: [PATCH v2] configure: fix out of tree build; check unsafe characters in srcdir

2019-08-29 Thread Daniel Kahn Gillmor
On Mon 2019-08-26 20:03:46 +0300, Tomi Ollila wrote: > While check for GMime session key extraction support... was made > out of tree build compatible, related (and some unrelated) unsafe > characters are now checked in notmuch source directory path. LGTM. Thanks, Tomi. > The known unsafe

Re: notmuch-emacs: WISH: command notmuch-show-message-up with key bindung u

2019-08-29 Thread Daniel Kahn Gillmor
On Sun 2019-08-25 12:02:05 +0200, Gregor Zattler wrote: > Dear notmuch developers, when reading a long going discussion > which is deeply threaded, it often would come in handy if it was > possible to jump up to the parent message of the message on is > reading, unfolding this message in