[PATCH 1/2] mime-node: rename decrypted_child to unwrapped_child

When walking the MIME tree, we might need to extract a new MIME object. Thus far, we've only done it when decrypting multipart/encrypted messages, but PKCS#7 (RFC 8551, S/MIME) has several other transformations that warrant a comparable form of unwrapping. Make this member re-usable for PKCS#7

[PATCH 2/2] mime-node: Clean up unwrapped MIME parts correctly.

Avoid a memory leak in the notmuch command line. gmime_multipart_encrypted_decrypt returns a GMimeObject marked by GMime as "transfer full", so we are supposed to clean up after it. When parsing a message, notmuch would leak one GMimeObject part per multipart/encrypted MIME layer. We clean it

Minor cleanup to mime-node.c

This simple 2-patch series is a bit of cleanup that i noticed while completing the work on handling S/MIME messages. It's not strictly part of the S/MIME series, so breaking out this minor cleanup separately should make it easier to review. Regards, --dkg

Weird tagging issue

Hello, I am having a problem with certain messages, in that I remove the tag and it still shows up in search results. e.g. $ notmuch search tag:important [...] thread:aaff 40 mins. ago [37/38(43)] Lucas Liendo, Ricardo Perez; [Bitbucket] Pull request #88: Add webdriver support

Re: [PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify

On Wed, Mar 18 2020, Daniel Kahn Gillmor wrote: > GMIME_ENCRYPT_NONE and GMIME_VERIFY_NONE have the same value, but they > are different enumerated types. So in C, this is a cosmetic change, > but it is technically correct if we only had stricter typing. Change consistent with '@@ node_verify',

[PATCH] emacs: avoid warning about notmuch-show-get-message-id

Without this change, we see the following warning when compiling the elisp: ``` EMACS emacs/notmuch-crypto.elc In end of data: emacs/notmuch-crypto.el:266:1:Warning: the function ‘notmuch-show-get-message-id’ is not known to be defined. ``` Thanks to Örjan Ekeberg and David Edmondson for

Re: notmuch-crypto.el: "‘notmuch-show-get-message-id’ is not known to be defined"

On Wednesday, 2020-03-18 at 10:49:14 +01, Örjan Ekeberg wrote: > Daniel Kahn Gillmor writes: > >> When building the current version of notmuch on debian testing/unstable, >> i see the following warning: >> >> ``` >> EMACS emacs/notmuch-crypto.elc >> >> In end of data: >>

Re: notmuch-crypto.el: "‘notmuch-show-get-message-id’ is not known to be defined"

Daniel Kahn Gillmor writes: > When building the current version of notmuch on debian testing/unstable, > i see the following warning: > > ``` > EMACS emacs/notmuch-crypto.elc > > In end of data: > emacs/notmuch-crypto.el:266:1:Warning: the function > ‘notmuch-show-get-message-id’ is not

[PATCH] configure: Check GMime version properly

Signed-off-by: Daniel Kahn Gillmor --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index c16d18dc..70031d14 100755 --- a/configure +++ b/configure @@ -513,7 +513,7 @@ fi GMIME_MINVER=3.0.3 printf "Checking for GMime development files...

[PATCH] tests/smime: fix typo in README

Signed-off-by: Daniel Kahn Gillmor --- test/smime/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/smime/README b/test/smime/README index 92803c77..46211922 100644 --- a/test/smime/README +++ b/test/smime/README @@ -2,6 +2,6 @@ test.crt: self signed certificated

[PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify

GMIME_ENCRYPT_NONE and GMIME_VERIFY_NONE have the same value, but they are different enumerated types. So in C, this is a cosmetic change, but it is technically correct if we only had stricter typing. Signed-off-by: Daniel Kahn Gillmor --- mime-node.c | 2 +- 1 file changed, 1 insertion(+), 1