Re: [PATCH 1/2] test: known broken test for reindex tag preservation

2020-05-04 Thread David Bremner
Tomi Ollila writes: > On Mon, May 04 2020, David Bremner wrote: > >> In id:1588595993-ner-8.651@TPL520 Franz Fellner reported that tags >> starting with 'attachment' are removed by 'notmuch reindex'. This is >> probably related to the use of STRNCMP_LITERAL in > > Haa, I looked this briefly but

Re: Handle PKCS#7 S/MIME messages

2020-05-04 Thread Daniel Kahn Gillmor
Hi Tomi-- On Sat 2020-05-02 00:15:57 +0300, Tomi Ollila wrote: > I did not see anything suspicious in code, but > > I got these test failures: > > in ubuntu 19.10 native environment, and > > in debian 10 (podman) container running in fedora 31 system > > > T355-smime: Testing S/MIME signature

Re: [PATCH 2/2] lib: replace STRNCMP_LITERAL in __message_remove_indexed_terms

2020-05-04 Thread Franz Fellner
Thank you very much. I confirm that the patch fixes the issue. Regards Franz On Mon May 4 11:00:24 2020, David Bremner wrote: > strncmp looks for a prefix that matches, which is very much not what > we want here. This fixes the bug reported by Franz Fellner in > id:1588595993-ner-8.651@TPL520

Re: [PATCH 1/2] test: known broken test for reindex tag preservation

2020-05-04 Thread Tomi Ollila
On Mon, May 04 2020, David Bremner wrote: > In id:1588595993-ner-8.651@TPL520 Franz Fellner reported that tags > starting with 'attachment' are removed by 'notmuch reindex'. This is > probably related to the use of STRNCMP_LITERAL in Haa, I looked this briefly but failed to see it is

[PATCH 1/2] test: known broken test for reindex tag preservation

2020-05-04 Thread David Bremner
In id:1588595993-ner-8.651@TPL520 Franz Fellner reported that tags starting with 'attachment' are removed by 'notmuch reindex'. This is probably related to the use of STRNCMP_LITERAL in _notmuch_message_remove_indexed_terms. --- test/T700-reindex.sh | 9 + 1 file changed, 9 insertions(+)

[PATCH 2/2] lib: replace STRNCMP_LITERAL in __message_remove_indexed_terms

2020-05-04 Thread David Bremner
strncmp looks for a prefix that matches, which is very much not what we want here. This fixes the bug reported by Franz Fellner in id:1588595993-ner-8.651@TPL520 --- lib/message.cc | 6 +++--- test/T700-reindex.sh | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git

Re: notmuch reindex wipes existing tags

2020-05-04 Thread David Bremner
Franz Fellner writes: > > And it fails. The tag "attachments-extracted" got removed. > Got curious, it seems as soon as the additional tag starts with "attachment" > "notmuch reindex" removes it. > With "extracted-attachments" everything is fine. > Thought it might clash with preserved tags. >

Re: notmuch reindex wipes existing tags

2020-05-04 Thread Franz Fellner
On Mon May 4 07:30:38 2020, David Bremner wrote: > Franz Fellner writes: > > > Ran notmuch reindex. > > And now all custom tags were wiped, especially attachments-extracted. > > I now can't see if the pdf of a certain message was already saved. > > This is 3 years of 5 newspapers a weak. I

Re: notmuch reindex wipes existing tags

2020-05-04 Thread David Bremner
Franz Fellner writes: > Ran notmuch reindex. > And now all custom tags were wiped, especially attachments-extracted. > I now can't see if the pdf of a certain message was already saved. > This is 3 years of 5 newspapers a weak. I must delete the files > and re-extract them. > > I did not expect

Re: waiting tag

2020-05-04 Thread Gregor Zattler
Hi Keegan, * Keegan Carruthers-Smith [2020-05-03; 22:37]: > Chris Tennant writes: >> I would like to have emails that I am waiting on a response for to have a >> special tag that is removed once I get a reply. There are other products >> that do this, but I would much rather do it all from

notmuch reindex wipes existing tags

2020-05-04 Thread Franz Fellner
Hello, I setup notmuch for my dad specifically for mass-extracting pdf newspapers he receives. When the pdf was stored successfully the message gets the tag attachments-extracted added. Today I wanted to go further and make use of afew specifically for mail moving to free up space on the IMAP