[PATCH 2/2] python/notmuch2: add bindings for the database config strings

2020-05-08 Thread Anton Khirnov
--- bindings/python-cffi/notmuch2/_build.py| 17 + bindings/python-cffi/notmuch2/_config.py | 84 ++ bindings/python-cffi/notmuch2/_database.py | 23 ++ 3 files changed, 124 insertions(+) create mode 100644 bindings/python-cffi/notmuch2/_config.py diff --git

[PATCH 1/2] python/notmuch2: do not destroy messages owned by a query

2020-05-08 Thread Anton Khirnov
Any messages retrieved from a query - either directly via search_messages() or indirectly via thread objects - are owned by that query. Retrieving the same message (i.e. corresponding to the same message ID / database object) several times will always yield the same C object. The caller is

[PATCH 1/2 v2] test-lib: mark function variables as local

2020-05-08 Thread Daniel Kahn Gillmor
Several functions in test/test-lib.sh used variable names that are also used outside of those functions (e.g. $output and $expected are used in many of the test scripts), but they are not expected to communicate via those variables. We mark those variables "local" within test-lib.sh so that they

Re: [PATCH 1/2] test-lib: mark function variables as local

2020-05-08 Thread Daniel Kahn Gillmor
On Thu 2020-05-07 10:31:38 +0300, Tomi Ollila wrote: > Good stuff > > robustness comment IMO: > > There is slight difference when writing > > local foo=`false` > > and > > local foo; foo=`false` > > > former does not "fail"; latter does, thanks for pointing this out. On IRC, jindraj

Re: [PATCH] notmuch(1): clarify documentation about --option/value separators

2020-05-08 Thread Daniel Kahn Gillmor
On Thu 2020-05-07 16:40:26 -0700, Carl Worth wrote: > On Thu, May 07 2020, Daniel Kahn Gillmor wrote: >> +separator. Except for boolean options (wihch would be ambiguous), a > > Misspelling of "which". And while I'm here, strictly speaking Boolean is > generally capitalized in English, (being one