[PATCH] Makefile.global: drop -std=gnu99. C11 (or later) compiler required

2020-06-24 Thread Tomi Ollila
Since October 2018 building notmuch has actually required compiler that knows C11. Also this -std=gnu99 was not used in code compiled by configure, so in theory this could have caused problems... ...but no related reports have been sent, perhaps ever. Both gcc and clang has been shipping

Re: [PATCH 1/2] configure: detect 64 bit time_t

2020-06-24 Thread Tomi Ollila
On Wed, Jun 24 2020, David Bremner wrote: > Certain tests involving timestamps > 32bits cannot pass with the > current libnotmuch API. We will avoid this isssue for now by disabling s/isssue/issue/ > those tests on "old" architectures with 32bit time_t. > --- > configure | 33

[PATCH 2/2] test: mark two tests broken on machines with 32 bit time_t

2020-06-24 Thread David Bremner
I haven't traced the code path as exhaustively for the SMIME test, but the expiry date in question is larger then representable in a signed 32 bit integer. --- test/T160-json.sh | 3 +++ test/T355-smime.sh | 3 +++ 2 files changed, 6 insertions(+) diff --git a/test/T160-json.sh

[PATCH 1/2] configure: detect 64 bit time_t

2020-06-24 Thread David Bremner
Certain tests involving timestamps > 32bits cannot pass with the current libnotmuch API. We will avoid this isssue for now by disabling those tests on "old" architectures with 32bit time_t. --- configure | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff

Re: [PATCH] lib: avoid casting gint64 to time_t

2020-06-24 Thread David Bremner
David Bremner writes: > > This is not a complete fix, but at least the timestamp ends up > aparently correct in the database. It looks like there are still > wonky conversions on reading the large timestamp from the database. There is another cast that is harder to avoid:

Re: [PATCH] completion: remove "setup" from the list of possible completions

2020-06-24 Thread Peter Wang
On Mon, 22 Jun 2020 12:22:50 +0200 Lukasz Stelmach wrote: > It was <2020-06-20 sob 12:53>, when Reto wrote: > > On Fri, Jun 19, 2020 at 12:40:49PM +0200, Ɓukasz Stelmach wrote: > >> Having "setup" in the set requires entering three instad of two characters > >> for "search". Since "setup" is