[PATCH] notmuch-show: use correct format specifier for ssize_t

2021-01-24 Thread Đoàn Trần Công Danh
Signed-off-by: Đoàn Trần Công Danh --- I found this after inspecting one of my build today. I'm not sure what is acceptable action. I think using %zd is the right move. But I'm not sure if you prefer to case ssize to long int. notmuch-show.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 37/38] CLI: use configured hook directory

2021-01-24 Thread Tomi Ollila
On Sat, Jan 16 2021, David Bremner wrote: > This enables support for hooks outside the database directory. > It relies strongly on configuration information being usable between > closing the database and destroying it. > --- > hooks.c| 7 +- > notmuch-client.h | 2 +- >

Re: [PATCH 01/38] lib: add _notmuch_string_map_set

2021-01-24 Thread David Bremner
Tomi Ollila writes: > On Sat, Jan 16 2021, David Bremner wrote: > > > First, is this patch series safe to be applied and put into use ? :D At least the backwards compatibility part is pretty well tested. I have been running variations of it for a month or so. > > The style in string-map.c (and

Re: [PATCH 04/38] lib/open: add support for config profiles and default locations

2021-01-24 Thread Tomi Ollila
On Sat, Jan 16 2021, David Bremner wrote: In id:20210116170406.842014-4-da...@tethera.net there is missing space after , gchar **groups,**keys, *val; Here, perhaps s/This commits fills in/Fill in/ (?) > This commit fills in the remainder of the documented functionality for >

Re: [PATCH 01/38] lib: add _notmuch_string_map_set

2021-01-24 Thread Tomi Ollila
On Sat, Jan 16 2021, David Bremner wrote: First, is this patch series safe to be applied and put into use ? :D I've looked this through once. So much stuff hard to figure out if there is something broken. Most of the comments here and other patches are about style (line break), but some