Re: [PATCH] ruby: fix ruby 3.1 warnings

Hello. On Sat, Apr 17, 2021 at 7:20 AM David Bremner wrote: > Thanks for the patch. I have a couple of questions / comments > > - It doesn't apply against current master (5248f55d5f1). Can you rebase > it? Huh? That's precisely the commit I used as a base. It applies cleanly. > - What

[PATCH 13/13] vim: README: sync with upstream

Signed-off-by: Felipe Contreras --- vim/README | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/vim/README b/vim/README index c137bacd..d9a635a2 100644 --- a/vim/README +++ b/vim/README @@ -3,7 +3,7 @@ This is a vim plug-in that provides a fully

[PATCH 12/13] vim: remove backwards compatibility wrappers

Seven years is more than enough. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 50 + 1 file changed, 9 insertions(+), 41 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index e717fb5a..717633c7 100644 --- a/vim/notmuch.vim +++

[PATCH 11/13] vim: syntax: fix message description highlighting

From: Aaron Borden Signed-off-by: Felipe Contreras --- vim/syntax/notmuch-show.vim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vim/syntax/notmuch-show.vim b/vim/syntax/notmuch-show.vim index c3a98b77..de0c43a1 100644 --- a/vim/syntax/notmuch-show.vim +++

[PATCH 10/13] vim: option to add reply quote datetime

From: Aaron Borden By default it's empty so the format doesn't change. Cleanup-by: Felipe Contreras Signed-off-by: Felipe Contreras --- vim/notmuch.txt | 7 +++ vim/notmuch.vim | 12 +++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/vim/notmuch.txt

[PATCH 09/13] vim: option to add email address to reply quote

From: Aaron Borden Cleanup-by: Felipe Contreras Signed-off-by: Felipe Contreras --- vim/notmuch.txt | 6 ++ vim/notmuch.vim | 7 +++ 2 files changed, 13 insertions(+) diff --git a/vim/notmuch.txt b/vim/notmuch.txt index c98f2b53..b658020d 100644 --- a/vim/notmuch.txt +++

[PATCH 08/13] vim: trivial cleanup

Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 8777d412..7a448467 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -641,9 +641,7 @@ ruby << EOF

[PATCH 07/13] vim: use notmuch config command

This simplifies the configuration parsing, is more efficient, and also reverts back to previous logic. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index

[PATCH 06/13] vim: trivial cleanup

Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index dd715828..97167461 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -471,9 +471,8 @@ function! s:NotMuch(...) ruby << EOF

[PATCH 05/13] vim: show first part if no text part is detected

Better something than nothing. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index e2362a2d..dd715828 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -333,7 +333,7 @@ ruby <<

[PATCH 04/13] vim: fix for missing parts

Sometimes Mail incorrectly parses multipart messages. See: https://github.com/mikel/mail/issues/1438 Check for empty parts instead of crashing. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/vim/notmuch.vim

[PATCH 01/13] vim: fix Mail 2.8.0 warning

Passing an unparsed header field to Mail::Field.new is deprecated and will be removed in Mail 2.8.0. Use Mail::Field.parse instead. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index

[PATCH 03/13] vim: doc: minor spelling fix

From: John Gliksberg Signed-off-by: Felipe Contreras --- vim/notmuch.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.txt b/vim/notmuch.txt index 4a038102..c98f2b53 100644 --- a/vim/notmuch.txt +++ b/vim/notmuch.txt @@ -144,7 +144,7 @@ If you want to count

[PATCH 02/13] vim: doc: small fixes

Signed-off-by: Felipe Contreras --- vim/notmuch.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vim/notmuch.txt b/vim/notmuch.txt index 43741022..4a038102 100644 --- a/vim/notmuch.txt +++ b/vim/notmuch.txt @@ -89,7 +89,7 @@ s Send CONFIGURATION

[PATCH 00/13] vim: a bunch of updates from upstream

I finally took some time to update notmuch-vim and include some fixes, as well as pull requests. Here are the transplanted patches. Aaron Borden (3): vim: option to add email address to reply quote vim: option to add reply quote datetime vim: syntax: fix message description highlighting

Re: [PATCH] compat: expose canonicalize_file_name to C++

On Sun, Apr 18 2021, Tomi Ollila wrote: > > not perl, but python3 -c 'import socket; print(socket.getfqdn())' notmuch_passwd_sanitize() { python3 -c ' import os, sys, pwd, socket pw = pwd.getpwuid(os.getuid()) user = pw.pw_name name = pw.pw_gecos.partition(",")[0] fqdn = socket.getfqdn()

Re: [PATCH] compat: expose canonicalize_file_name to C++

On Sun, Apr 18 2021, David Bremner wrote: > Đoàn Trần Công Danh writes: > >> >> Anyway, I see some failure in the testsuite due to: >> - *My* hostname(1) (from coreutils) doesn't understand "-f" Interesting (neither of these use coreutils hostname) $ rpm -q -f =hostname

Re: [PATCH] lib/n_d_index_file: check return value from _n_m_add_filename

David Bremner writes: > Ignoring this return value seems like a bad idea in general, and in > particular it has been hiding one or more bugs related to handling > long directory names. > --- > > This is not a fix for the aforementioned bugs, but it at least makes > clear part of the problem.

Re: [PATCH] test-lib: unset XDG_CONFIG_HOME

Đoàn Trần Công Danh writes: > lib/open.cc:_load_key_file will only open xdg-config files in > $XDG_CONFIG_HOME if it's defined, $HOME/.config will be considered if > and only if XDG_CONFIG_HOME not defined. > > Let's unset said variable before running the test. applied to master. d

Re: v1 deletion patches

David Bremner writes: > This version has a better commit message for 2/2 and portability fixes > (thanks to Tomi) for 1/2. > > It obsoletes the WIP version [1] > > [1]: id:20210414021627.1236560-1-da...@tethera.net Applied to master. d ___ notmuch

Re: [PATCH] compat: expose canonicalize_file_name to C++

Đoàn Trần Công Danh writes: > > Anyway, I see some failure in the testsuite due to: > - *My* hostname(1) (from coreutils) doesn't understand "-f" ah, any suggestions for a portable replacement? I guess some perl one liner might work. > - All emacs tests depend on dtach(1) but the >

Re: [PATCH] compat: expose canonicalize_file_name to C++

On 2021-04-18 10:08:31+0300, Tomi Ollila wrote: > On Sun, Apr 18 2021, Đoàn Trần Công Danh wrote: > > > On 2021-04-17 11:39:59-0300, David Bremner wrote: > >> Đoàn Trần Công Danh writes: > >> > >> > > >> > However, I see that lib/open.cc uses g_key_file_get_value from GLib > >> > already, we

Re: v1 deletion patches

On Fri, Apr 16 2021, David Bremner wrote: > This version has a better commit message for 2/2 and portability fixes > (thanks to Tomi) for 1/2. Looks safe enough to be pushed in. Tomi > > It obsoletes the WIP version [1] > > [1]: id:20210414021627.1236560-1-da...@tethera.net

Re: [PATCH] compat: expose canonicalize_file_name to C++

On Sun, Apr 18 2021, Đoàn Trần Công Danh wrote: > On 2021-04-17 11:39:59-0300, David Bremner wrote: >> Đoàn Trần Công Danh writes: >> >> > >> > However, I see that lib/open.cc uses g_key_file_get_value from GLib >> > already, we may switch to g_canonicalize_file_name then? >> > >> >> Yes that