Re: [PATCH 3/3] test: ruby: simplify basic tests

2021-06-07 Thread Felipe Contreras
On Mon, Jun 7, 2021 at 6:53 PM David Bremner wrote: > > Felipe Contreras writes: > > >> > >> Is this assuming that the sort order in the CLI is the same as in the > >> library / bindings? that seems a bit fragile if so. > > > > Both the CLI and the bindings are using the same libnotmuch library.

Re: [PATCH 3/3] test: ruby: simplify basic tests

2021-06-07 Thread David Bremner
Felipe Contreras writes: >> >> Is this assuming that the sort order in the CLI is the same as in the >> library / bindings? that seems a bit fragile if so. > > Both the CLI and the bindings are using the same libnotmuch library. > If neither of them specify a sort order, the default sort order

Re: [PATCH] test: aggregate-results updates

2021-06-07 Thread David Bremner
Tomi Ollila writes: > > Should such an extremely rare cases happen it should be enough just to > report it so it get noticed (and not add any extra code to handle such > cases any further). One checking the results would probably guess that > if output is as nonsensical as it is something went

Re: [PATCH 1/3] emacs: fix declare-function definitions with related line breaks

2021-06-07 Thread David Bremner
Tomi Ollila writes: > - declare-function notmuch-unthreaded lacked file name > - declare-function notmuch-search had differently named last arg > - note: check-declare-directory did not complain about that > - declare-function notmuch-search-show-thread without nil > - some functions declared

Re: [PATCH] test: add known broken test for indexing RFC822 group names

2021-06-07 Thread David Bremner
David Bremner writes: > Austin Clements diagnosed this indexing problem in [1]. > > [1]: id:20130711215207.gr2...@mit.edu Applied to master. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to

Re: [PATCH 1/2] make _alloc_notmuch static

2021-06-07 Thread David Bremner
Tomi Ollila writes: > > could also add static to _maybe_load_config_from_database() > in the same file (open.cc) and to > _notmuch_message_remove_indexed_terms() in message.cc applied to master, with all 3 made static d ___ notmuch mailing list --

Re: [PATCH] emacs: drop setting mail-user-agent, and document how to set it

2021-06-07 Thread David Bremner
David Bremner writes: > After some discussion [1], I decided it is better to make notmuch users > who rely on this behaviour customize mail-user-agent. This is > consistent with the behaviour of other emacs mail packages. > > [1]: id:87k0nuhfrk@toryanderson.com Applied to master. I (still)

Re: [PATCH] emacs: remap send-message and send-message-and-exit

2021-06-07 Thread Tomi Ollila
On Fri, Jun 04 2021, e...@edef.eu wrote: >> > (defvar notmuch-message-mode-map >> >(let ((map (make-sparse-keymap))) >> > -(define-key map (kbd "C-c C-c") #'notmuch-mua-send-and-exit) >> > -(define-key map (kbd "C-c C-s") #'notmuch-mua-send) >> > +(define-key map [remap

Re: [PATCH] emacs: drop setting mail-user-agent, and document how to set it

2021-06-07 Thread Tomi Ollila
On Fri, Jun 04 2021, David Bremner wrote: > After some discussion [1], I decided it is better to make notmuch users > who rely on this behaviour customize mail-user-agent. This is > consistent with the behaviour of other emacs mail packages. LGTM. Tomi > > [1]:

Re: [PATCH] test: aggregate-results updates

2021-06-07 Thread Tomi Ollila
On Sat, Jun 05 2021, David Bremner wrote: > Tomi Ollila writes: >> >> testing all changed branches is somewhat hard; I did by adding >> sleep 20 and file what effective removed created results files; >> another change was to change 'total' to 'toxtal' in test_done, >> then I run (at least) the

Re: [PATCH 2/2] emacs: Prefer email address over User ID when showing valid signature

2021-06-07 Thread Daniel Kahn Gillmor
On Mon 2021-06-07 13:07:12 +0100, David Edmondson wrote: > Could this not be something like: > > (when (or email userid) > (setq label (concat "Good signature by: " (or email userid))) > ... > ) > > ? Sounds reasonable to me. If you want to offer a revised patch for this, i'd definitely

Re: [PATCH 2/2] emacs: Prefer email address over User ID when showing valid signature

2021-06-07 Thread David Edmondson
On Wednesday, 2021-05-26 at 21:44:59 -04, Daniel Kahn Gillmor wrote: > Most concrete verification steps are likely only taken on the e-mail > address in the first place, and e-mail addresses render more > intelligibly than arbitrary User IDs in the first place. > > Signed-off-by: Daniel Kahn

Re: How to recover from this permanent fatal error?

2021-06-07 Thread Felipe Contreras
Olly Betts wrote: > On Sun, Jun 06, 2021 at 07:48:39AM -0500, Felipe Contreras wrote: > > On Sun, Jun 6, 2021 at 5:08 AM Olly Betts wrote: > > > > > You could try commenting out the body of GlassTable::set_overwritten() > > > in xapian-core/backends/glass/glass_table.cc so it keeps going instead